summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)AuthorFilesLines
2021-12-11Fix typosAndrea Gelmini1-1/+1
Change-Id: I8e6db5dfb5285e45f862fadf09ecb4142be6e075 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126659 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2021-12-10Generally determine Rdb content from gb_*_set_componentfile callsStephan Bergmann3-3/+3
...instead of by listing the content somewhat redundantly in the Rdb_*.mk files, to avoid duplication of logic for components that are only built conditionally (and thus should only be included conditionally in the corresponding Rdb). To achieve that, add an "rdb" parameter to gb_ComponentTarget_ComponentTarget (and to the gb_*_set_componentfile macros that internally call gb_ComponentTarget_ComponentTarget), which is used to make the appropriate gb_Rdb_add_component call internally from within gb_ComponentTarget_ComponentTarget. (As a special case, gb_CppunitTest_set_componentfile shall not call gb_Rdb_add_component, as that has already been done by the corresponding gb_Library_set_componentfile call, so allow the gb_ComponentTarget_ComponentTarget "rdb" parameter to be empty to support that special case.) Most Rdb_*.mk files are thus mostly empty now. One exception is i18npool/Rdb_saxparser.mk, which duplicates some of the Rdb_services content as needed during the build in CustomTarget_i18npool/localedata. 1c9a40299d328c78c035ca63ccdf22c5c669a03b "gbuild: create services.rdb from built components" had already tried to do something similar (in addition to other things) under a new --enable-services-rdb-from-build option. However, that approach had four drawbacks that this approach here addresses (and which thus partly reverts 1c9a40299d328c78c035ca63ccdf22c5c669a03b): 1 Rdb_services shall not contain the component files of all libraries that are built. While that commit filtered out the component files that go into Rdb_ure/services (ure/Rdb_ure.mk), it failed to filter out the component files that go into others like Rdb_postgresql-sdbc (connectivity/Rdb_postgresql-sdbc.mk). 2 The code added by that commit to Makefile.gbuild codified the knowledge that there is an Rdb_services, which is brittle. 3 The code added by that commit to solenv/gbuild/Rdb.mk codified the knowledge (for gb_Rdb__URECOMPONENTS) that there is an Rdb_ure/services, which is brittle. 4 Introducing an --enable-services-rdb-from-build option needlessly provided two different ways how the content of Rdb_services is assembled. The changes done here would leave --enable-services-rdb-from-build as a misnomer, as it no longer controls how Rdb_services is assembled. I thus renamed it to --enable-customtarget-components, as that is apparently what it still does now. Change-Id: Ia5e8df4b640146c77421fcec6daa11a9cd260265 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-30loplugin:stringviewStephan Bergmann1-2/+2
Change-Id: I941fc246211968f14654a9ee3540d2ed9bf13221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126113 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-11-25remove unused defines and convert some to OUStringLiteralNoel Grandin1-1/+0
Also remove the associated links.txt entries Change-Id: I5028fab2feb828875a0b772418fc29cbdfe4ce72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125773 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-25Related: tdf#145842 fix a crash after deleting an entryCaolán McNamara1-1/+0
delete an entry in remote files dialog and go one level up and crash, ownership of the SvtContentEntry is not with the entry, but belongs to mpImpl->maEntries Change-Id: I4a052ada1fd4f5e8142ac4396877b15ac49149b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125792 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-24tdf#145842 canceling remote file delete makes file disappear from treeviewCaolán McNamara1-2/+7
we remove the selected entries from the treeview, so the user cancel's the deletion of an entry we should unselect it from the candidates to remove. Change-Id: Ieb2258960fc647ad15d8f315a18454a0dae8a420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-24loplugin:stringliteraldefine in formual,fpickerNoel Grandin3-24/+24
Change-Id: I663a31ff6b207f43dd6f1c8240a341845b9e20b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125764 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-11-23tdf#145769 fpicker: RemoteFilesDialog: don't use FStatHelperMichael Stahl2-4/+24
FStatHelper doesn't use an XCommandEnvironment and is thus unsuitable for remote access as it can't even authenticate with the password container; it should only be used for local access. Due to this problem, the ContentIsDocument() would always return a hard-coded "true" value from the webdav UCP, causing a spurious dialog that an existing file would be overwritten in Save Remote. (regression from 67fa088be7db1df661188ef4bab490a76fb06b85) Change-Id: Ibe667f2012e261b84d4c69c84fdd499b7276e64b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125666 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-11-12Fix (mis-)uses of temporary O[U]StringLiteralStephan Bergmann1-1/+2
...as sub-expressions of ternary operators, which happened to keep compiling after 4b9e440c51be3e40326bc90c33ae69885bfb51e4 "Turn OStringLiteral into a consteval'ed, static-refcound rtl_String" and e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString" because both branches are of the same type O[U]StringLiteral<N>, and which didn't cause any issues because no dangling pointers to those temporary objects escaped the surrounding full expressions. This was found with an experimental build with VS 2022 with --enable-latest-c++, which would support HAVE_CPP_CONSTEVAL after some linking fix in the configure.ac detection code (which is forthcoming in a later commit) and flagged all these uses in ternary operators as error C7595 "call to immediate function is not a constant expression". That error looks bogus (and it also caused a false > sd/source/ui/unoidl/unoobj.cxx(742): error C7595: 'Color::Color': call to immediate function is not a constant expression so HAVE_CPP_CONSTEVAL will need to remain undefined for VS 2022 until that compiler bug is fixed), but it nicely found all these cases that should arguably be cleaned up. Change-Id: I81de94e8af5a6c50e5fe7dfa1a4b253e0c2a68f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-31uniformly allow focus into GtkToolbarCaolán McNamara1-1/+1
Change-Id: I110daf882d9196cf7552e43a157ba4ae73fd670b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31gtk[3 vs 4]: remove can-focus from GtkToolButtonCaolán McNamara1-1/+0
so tab-cycling inside sidebar panel toolbars works as wanted It needs to be false for gtk3 and true for gtk4, leaving it unspecified gets a desired working default. Change-Id: I34869d5dcffc814f62ec2b717108f90c395a067b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-31Unused TOOLBOXBUTTON_DEFAULT_LOCATION in fpickerJulien Nabet2-2/+0
Change-Id: I6da38e7585a2e607e407e5f829b64fc5498d04d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124506 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-31Typo: TOOLBOXBUTOON->TOOLBOXBUTTON in fpickerJulien Nabet3-8/+8
Change-Id: I7110afbdd554b180c368894b9aa6b3b79a8fb2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124498 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-30Prepare for removal of non-const operator[] from Sequence in fpickerMike Kaganski6-38/+37
Change-Id: I918b785082b89833839fc0a7eeb7cb36a91f897a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124369 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-27Add support for macOS SDK 12.0Stephan Bergmann1-0/+4
...and for now just silence all the new deprecation warnings Change-Id: Ic6e04f4bade91a823872cd4e453c41ee1950bd77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124275 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-27Remove line that has been commented out since 2008Tor Lillqvist1-1/+0
Change-Id: I4dc8b6c4e324a0b2ec2d3dba25cc322e0fbefa6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124263 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-27There is nothing deprecated about these calls as far as I seeTor Lillqvist1-6/+0
Must have been some misunderstanding, or temporary mistake in the 10.9 SDK? Change-Id: I19d86c7a0e752676b317423361a18d2b156f0d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124259 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2021-10-21Use NSModalResponseOK instead of deprecated NSFileHandlingPanelOKButtonTor Lillqvist1-4/+1
NSFileHandlingPanelOKButton is defined as NSModalResponseOK in NSSavePanel.h: NSFileHandlingPanelOKButton API_DEPRECATED_WITH_REPLACEMENT("NSModalResponseOK", macos(10.0,10.13)) = NSModalResponseOK, For some reason, when as a test I just removed the SAL_WNODEPRECATED_DECLARATIONS_PUSH and _POP lines, I still did not get any depreation warning about NSFileHandlingPanelOKButton. I wonder if there is some problem in latest Xcode or in our build system that means we don't get any deprecation warnings at all any more on macOS. Change-Id: Ia61dd9f800eb7d251508dbd491a9c48c8e6118f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123964 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-21Bin dead codeTor Lillqvist11-198/+8
Change-Id: I2098172d065a195a15b7fd81a34dab25b1f38e57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123956 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-20add suggested-action to some buttonsCaolán McNamara2-0/+6
Change-Id: Iacb477c17f1c8ac68b331705796e56b4c92292cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-19Related: tdf#145169 make double-click call same handler as ok buttonCaolán McNamara1-1/+1
so that the user is asked to confirm an overwrite of a file Change-Id: I1340fb33559b68c28fc91e272f05e122f8c519ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123806 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-10-19tdf#145216 remote open/save dialog: icon view shows nothingCaolán McNamara1-0/+2
since... commit b004a1bd7bf3885613d52aba70dea79766eae639 Date: Sat Nov 23 19:14:45 2019 +0000 Resolves: tdf#128940 use a normal MenuButton Change-Id: I7ba6424a2a4892e2d6bc5552105a3b1e37d21a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123798 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Related: tdf#145169 change to selected dir on remote "save"Caolán McNamara2-24/+21
if a dir is selected then try to change to that dir when save is clicked instead of saving using that as basename, which is consistent with standard fpicker. don't change the contents of the Entry, leave it alone. Change-Id: Id19fbf0f3ef2b8220059a1fa166b7783feb8d57d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123755 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Resolves: tdf#145169 only position treeview cursor at the first entryCaolán McNamara1-4/+4
when the view is filled, don't actually select the entry. With these single selection trees the default is to select when the cursor is positioned, so move the unselect to after the cursor positioning to achieve this. Now nothing is considered "selected" in the view unless the user explicitly does that so the contents of the entry are used by default on save/load because nothing is selected in the treeview unless the user does that. Change-Id: I2a740616205bab35614f85f62e8240cd11df90ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123754 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18tdf#145169 have one button per responseCaolán McNamara2-22/+5
not two sharing the same response, so the other buttons response handler is not a candidate to be called on pressing return which is the circumstance which causes the dialog to return even after cancel was selected in its child dialog warning about overwrite Change-Id: I09eb0ea5e94c89ce0860be362e1c7632887e7a4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123753 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18tdf#145169 for IsDocument/IsFolder I think we want no interactionCaolán McNamara2-53/+4
rather than installing something to sometimes disable interaction I think we just want to not have any interaction here at all Change-Id: Ic775f0cd88f796db873d2980bb40043caac498bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123750 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Related: tdf#145169 unwanted dialogs on sftp save to remote to a new documentCaolán McNamara1-1/+5
which is similar to: commit f12e483589888f87843026ceff5ae3c1e615ca02 Date: Mon Feb 1 16:04:49 2016 +0100 Fix tdf#97500 Reinstate missing file error dialog on WebDAV this all looks a bit dubious, but make a safely backportable change first Change-Id: Ia6dbaacf7024d05083c336135a80b5acf607dfc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123749 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18help button in built-in file dialog didn't workCaolán McNamara1-0/+3
Change-Id: Ib37c713b926e1836bfb15dc0bb440b2e7bfc9f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123739 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18Related: tdf#145169 use INetURLObject::getName and removeSegmentCaolán McNamara1-34/+22
to get the name and link for each part of the path otherwise for sftp:// clicking on the "Root" doesn't work for me Change-Id: If6f0ac8f105afd8be2d264b54f76a3d8f345ad75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123735 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-16Simplify vector initialization in fpickerJulien Nabet1-2/+1
Change-Id: If75810cb09e13d5d9b9490b20a0a99b1745e17be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123687 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-28gives names to all the Idles and TasksNoel Grandin3-2/+3
enforce it by making the constructor parameter non-default. Change-Id: I321543e4dcf15ea0a43ad8cce91d2f8dc22df6ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122766 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-01clang-tidy:readability-redundant-member-initNoel Grandin2-3/+1
Change-Id: I67edbea77b12940ac807ccbadfd74b250902809d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-23Resolves: tdf#143993 don't change FolderPicker to FilePicker if init calledCaolán McNamara1-1/+6
make SIMPLE continue to map to E_CREATE_OPEN_DIALOG for a file dialog but map to E_CREATE_FOLDER_PICKER for a folder dialog Change-Id: I37b0cc318a06b1b16fae3c3dd99def4322f771f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-10Missing includeStephan Bergmann1-0/+4
(for std::unique_ptr, with recent libstdc++ 12 trunk) Change-Id: I61b7823dd740ea7cdfe0d7403a50ac73b24d1c4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120229 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-07create comphelper::OMultiTypeInterfaceContainerHelper2 and use itNoel Grandin2-4/+4
based on OInterfaceContainerHelper2 which is considerably faster than the original OInterfaceContainerHelper Change-Id: I9c8b6d0e5382018824bf7188a26343703abf2d51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120161 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-07no need to use UNO_QUERY hereNoel Grandin1-1/+2
Change-Id: I1bfe8238d7c08f27d2b21f9fe79712aba045c812 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120152 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-05Pass context and resource string down to boost::locale separatelyNoel Grandin5-15/+12
because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Change-Id: Ia36047209368ca53431178c2e8723a18cfe8260a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-02convert #defines to OUStringLiteralNoel Grandin1-1/+1
mostly by doing $ git grep -l '#define.*\"' -- *.cxx | xargs perl -pi -e 's/^#define\s+(\w+)\s+(\".*\")/constexpr OUStringLiteral \1 = u\2;/g' Change-Id: Idface893449b0ef2a3c5254865a300585d752fbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119669 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-28loplugin:indentation improve checks for brace alignmentNoel Grandin1-1/+1
Change-Id: I333100fda7e181f68f36b03279b3fbb8cb768310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117615 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-17use string_view in the Translate APINoel Grandin1-1/+4
Change-Id: I0bb0ea9d39ed623928060ffd3f2e2bc36ba33209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117272 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-11Simplify Sequence/vector initializationsJulien Nabet1-3/+1
Change-Id: Ib02e25b4600666185cf0f8d0cc8d5c64186789c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-10-Werror,-Wunused-but-set-variable (Clang 13 trunk)Stephan Bergmann1-2/+0
...ever since the code block's introduction in 14bc62ad0d9e0179f4178d2913ebba7abf99755e "INTEGRATION: CWS aquafilepicker02_DEV300" Change-Id: Id4cda7ed087b350361b0207034fc31819d65efad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116992 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-06-08Simplify Sequences initializations (desktop/e*/filter/forms/formula/fpicker)Julien Nabet1-3/+1
includes removing of unused TOKEN_SEP Change-Id: Ic72d9d94bd8d07232699ee4d948f3b203d524491 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116833 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-06-02no need to allocate these on the heapNoel Grandin1-4/+4
Change-Id: Ie11353c8711e970cc20059227d8283c79e4b126d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116586 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-21add Toggleable as a separate thing to a ButtonCaolán McNamara3-6/+6
and inherit ToggleButton from both it and Button Change-Id: If0e500aca8d0ffa087cb5e2bfc1786372fbff4eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115921 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-20use toggle instead of click for CheckButtonCaolán McNamara2-13/+12
Change-Id: I7196581a8b7c307d531f6995e1c24db746afdb26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-27loplugin:moveoptNoel Grandin1-2/+1
An attempt that did not find anything convincing enough to finish it up and make it permanently active. So just leave it in /store for now. Change-Id: I1750e177655a4a510da100f880ba81bf762be277 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114742 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27use string_view in INetURLObject::decodeNoel Grandin1-1/+1
Change-Id: I10e04970ceac33c9c3fbfd0182dd2140e06cb80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-27loplugin:staticmethods (clang-cl)Stephan Bergmann1-38/+28
Change-Id: Ib096abfeea6cefb5df562cf75448ef38e432344c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114695 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-04-27-Werror,-Wnon-virtual-dtor (clang-cl)Stephan Bergmann1-1/+1
(1c1226709c6be39c5462f5e6e1262ca630b30b34 "tdf#106282 Change Windows File Dialog to run on the main thread" had changed it to non-virtual, but for no apparent reason) Change-Id: I12dc3a46c5d9aad5e43471b97c9ab45ff9f309ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114693 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-02 09:18:57 +0000