summaryrefslogtreecommitdiff
path: root/fpicker
AgeCommit message (Collapse)AuthorFilesLines
2014-12-18fpicker: Use appropriate OUString functions on string constantsStephan Bergmann1-8/+5
Change-Id: I9be920ec3d9da211daeabe872b02361a0500054a
2014-12-17fdo#39440 reduce scope of local variablesMichael Weghorn1-11/+5
This addresses some cppcheck warnings. Change-Id: I1d037e87c69b1a7de019f1abf1f729bf7e28d762 Reviewed-on: https://gerrit.libreoffice.org/13494 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-12-15fpicker: Use appropriate OUString functions on string constantsStephan Bergmann1-1/+1
Change-Id: Icbb91dbfcce1f16f77e8238cbb86ff9eba2d5784
2014-12-12fdo#37814: SHCreateItemFromParsingName doesn't like LO's file URLsStephan Bergmann1-13/+25
...but apparently wants pathnames instead, cf. the other use of it in WinSalInstance::AddToRecentDocumentList (vcl/win/source/app/salinst.cxx). Change-Id: Iaa64ff82915f7cbfee55b4389387b226f7adc919
2014-12-09loplugin:cstylecastStephan Bergmann1-1/+1
Change-Id: If35fa5d97cec6c167bb0841da1e6819e5a4caf13
2014-12-04Older Mac apparently need a reinterpret_cast hereStephan Bergmann1-1/+1
Change-Id: I58ff0ae2e2410ff50f0faffabab5cdc0e4471433
2014-12-04fpicker (Mac): loplugin:cstylecastStephan Bergmann2-2/+2
Change-Id: I52687481a3d1203e72224c172edefd4a0a280688
2014-12-01fdo#84938: replace EVENT_ constants with enumTobias Madl1-2/+2
Change-Id: I8275832d8dae43b374bddd48520d11592e9a6a1f Reviewed-on: https://gerrit.libreoffice.org/13134 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-26Silence Mac OS X 10.9/10.10 deprecations for nowStephan Bergmann2-0/+8
Change-Id: Ie63ed8f6f66a7641ad872f93d76efb962333cec9
2014-11-25fdo#85347 Make file picker modal againAdolfo Jayme Barrientos1-0/+1
Change-Id: I0e26b9e13e69ed49e7bbbc7f2ac0b04941ee1da7 Reviewed-on: https://gerrit.libreoffice.org/12974 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-11-18cppuhelper: clean up public headers with include-what-you-useMichael Stahl5-2/+5
Change-Id: I41ba46831f24b2960a1fe982b74a2b623e682e0b
2014-11-17sal: clean up public headers with include-what-you-useMichael Stahl6-2/+6
Sadly cannot forward declare "struct {...} TimeValue;". rtl/(u)?string.hxx still include sal/log.hxx but removing osl/diagnose.h was painful enough for now... Change-Id: Id41e17f3870c4f24c53ce7b11f2c40a3d14d1f05
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2-2/+2
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-12Fix common typos. No automatic tools. Handmade…Andrea Gelmini1-1/+1
Change-Id: I1ab4e23b0539f8d39974787f226e57a21f96e959 Reviewed-on: https://gerrit.libreoffice.org/12164 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-11-05fdo#38835 strip out OUString globalsNoel Grandin1-2/+2
they are largely unnecessary these days, since our OUString infrastructure gained optimised handling for static char constants. Change-Id: I07f73484f82d0582252cb4324d4107c998432c37
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin7-7/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-16MAC_OS_X_VERSION_MIN_REQUIRED is always >= 1080 nowTor Lillqvist1-2/+2
Change-Id: I40d03ab9acb67ab72b9047017452f069ce88fd4b
2014-10-16MAC_OS_X_VERSION_MAX_ALLOWED is always >= 1080 nowTor Lillqvist4-57/+0
Change-Id: Ieae67cbf917cdf4bca2b0d6c1697eddc6137dbe2
2014-10-08back out more wrong and confusing tools::Time comment changesEike Rathke1-1/+1
Apparently fc04f76336fdf8c96e35382cdeb497e2f939705c used some sed script to change all ... Change-Id: Ie609bd02a2c5d70109fc6185cf4440480f29d8f5
2014-10-02fpicker (Windows): std::auto_ptr -> std::unique_ptrStephan Bergmann10-15/+15
Change-Id: Id373c3ed6e483a501e07146812ff04353eafcc32
2014-10-01fdo#82577: Handle TimeNoel Grandin1-1/+1
Put the TOOLS Time class in the tools namespace. Avoids clash with the X11 Time typedef. Change-Id: Iac57d5aef35e81ace1ee0d5e6d76cb278f8ad866 Reviewed-on: https://gerrit.libreoffice.org/11684 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-23fdo#82577: Handle WindowNoel Grandin15-31/+31
Put the VCL Window class in the vcl namespace. Avoids clash with the X11 Window typedef. Change-Id: Ib1beb7ab4ad75562a42aeb252732a073d25eff1a
2014-09-22fdo#84086 Fix assorted use-after-free bugsMatthew J. Francis1-2/+4
Change-Id: Iec004fffdb0afbe27bd69f379db90f6d904a8a65 Reviewed-on: https://gerrit.libreoffice.org/11553 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-09-15loplugin:salboolStephan Bergmann4-29/+29
Change-Id: Id2d9e8bf20b196d3a107802ac07ffb1ef61dfc60
2014-09-12fpicker: sal_Bool -> boolStephan Bergmann4-11/+11
Change-Id: Iaf55e2106900be0319c96861b07abea24075bbbe
2014-09-10Typo: (N|n)ormaly->(N|n)ormallyJulien Nabet1-2/+2
Change-Id: I96d081f394b0b62d99ec1034bf5e99da9aedd9d9
2014-08-25oops, forgot to include osl/thread.hMichael Stahl1-0/+1
Change-Id: Iaef9e9356c7a75215a868bb7dbcaa25d1fb19e01
2014-08-25set names on the Win32-only threadsMichael Stahl4-0/+10
Nice to see what weird threads are running. Change-Id: Ic9888aa3260d0aeb5858cde5415571ab23c75484
2014-08-23fdo#82577: Handle KeyCodeTor Lillqvist1-1/+1
Put the VCL KeyCode class in the vcl namespace. Avoids clash with the X11 KeyCode typedef. Change-Id: I624c9d937f7c5f5986d313b6c5f060bd8bb7e028
2014-08-18ErrorBox->MessageDialogCaolán McNamara1-4/+4
Change-Id: I57d4e43460e40d3aff54873280eddbb18c12446b
2014-08-13warning C4505: unreferenced local function has been removedThomas Arnhold1-23/+0
Change-Id: I4a96bc7156e0d4369bf3bfe599529df9f12ab318
2014-08-13warning C4189: local variable is initialized but not referencedThomas Arnhold1-0/+4
Change-Id: Ibe6ee8225da0090656fbec3ce2253b2c42ddff78
2014-08-13warning C4189: local variable is initialized but not referencedThomas Arnhold1-3/+0
Change-Id: I941898ecbd8f3c73d39878390cdcb89119a3bbaf
2014-08-09remove obsolete commentThomas Arnhold1-2/+0
Change-Id: I6b3466e5dd8ce6b3814037382c865af1e50a025c
2014-08-01typo: more then -> more thanTakeshi Abe1-1/+1
Change-Id: I2e477d66f25bde7256938ccb1f95ab26add24922
2014-07-26WaE: convenience initializer should not invoke an initializer on 'super'Tor Lillqvist2-17/+1
New warning from Clang 6. So get rid of the initWithOUString initializer completely, it is called only from stringWithOUString anyway. Change-Id: I510101bfe1e6ac52f8f5a1d8a061082b3875419f
2014-07-22callcatcher: update unused codeCaolán McNamara2-10/+0
Change-Id: I1dd1b40d807c7c9d9b145aca9f69a67d786ec5ff
2014-07-21win32 fpicker: correctly set the default file nameAurimas Fišeras1-10/+9
Correctly set the default file name in win2k+ See fdo#74295 for more details. Change-Id: I30117a8e1e50b157fee96f4777b0c3f11630165c Reviewed-on: https://gerrit.libreoffice.org/10430 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-07-21Revert "Cleaning: remove use of old edt1 from dlg.h (Windows)"Aurimas Fišeras1-5/+11
This commit introduced fdo#74295. This reverts commit e9fd9c25269abe171e5f693a8c70b33ab5a01c85. Change-Id: I884c25aee137819810bdbc76ad85f2b580b2d626 Reviewed-on: https://gerrit.libreoffice.org/10429 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2014-07-11-Wdeprecated-declarations: first deprecated in OS X 10.10rbuj2-0/+16
fpicker/source/aqua/SalAquaFilePicker.mm:220:14: warning: 'NSOKButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseOK instead [-Wdeprecated-declarations] fpicker/source/aqua/SalAquaFilePicker.mm:225:14: warning: 'NSCancelButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseCancel instead [-Wdeprecated-declarations] fpicker/source/aqua/SalAquaFolderPicker.mm:114:10: warning: 'NSOKButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseOK instead [-Wdeprecated-declarations] fpicker/source/aqua/SalAquaFolderPicker.mm:119:10: warning: 'NSCancelButton' is deprecated: first deprecated in OS X 10.10 - Use NSModalResponseCancel instead [-Wdeprecated-declarations] Change-Id: Ib497903e4df868867cc56e2eade7bb2572f0902a Reviewed-on: https://gerrit.libreoffice.org/10115 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-07-10use SimpleReferenceObject in fpicker moduleNoel Grandin3-25/+4
to replace hand-rolled version Change-Id: I0c1cbf6b0e70106f4ecc5b579e09acc17045a44e
2014-07-02fix crash when m_aType is '*'Caolán McNamara1-1/+1
Change-Id: If2c4ca98814a58b785cd2670eac1e522e70464fd
2014-07-01loplugin:stringconcatStephan Bergmann1-7/+7
Change-Id: Ibf410eb1b8be81505b8e778aadf916a26ba39468
2014-07-01coverity#703963 Unchecked return valueNorbert Thiebaud1-8/+6
also avoid pointless double Guard Change-Id: Ie7707fc3baf46f9363fdef6213df098123183ab9
2014-06-30Dead codeStephan Bergmann2-67/+0
Change-Id: I50b13e27501dfd885e3ed99215d18166d5112bf7
2014-06-30-Werror,-Wunused-macrosStephan Bergmann1-2/+0
Change-Id: I04b79678a488d6dd954a339f678d56f978249b32
2014-06-30tweak helpids nowCaolán McNamara1-1/+2
Change-Id: I2ab7255f634d626cf34ec9f1dcb19d5f24db1c09
2014-06-30rework resize into a custom widgetCaolán McNamara4-69/+73
so that the order of resizing will happen in the right sequence to work correctly every time Change-Id: I1adffe276db3fb80eb34ca74c2ceb51a6ee28526