summaryrefslogtreecommitdiff
path: root/forms
AgeCommit message (Collapse)AuthorFilesLines
2023-12-31cid#707862 Uninitialized pointer fieldCaolán McNamara1-1/+2
returned since commit 04c3ef3c7224644b7e54ff215343391cef77f7b5 Date: Sat Dec 30 15:08:30 2023 +0200 ImgProdLockBytes is unnecessary Change-Id: Iabd3cf1f64b87b8ffb8c73702ef138cf7b7d64a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-31Replace "size() != 0 with !empty()" (forms)Julien Nabet1-1/+1
Change-Id: I855c4868334c8890b00e78caa67bfc9c9c9ebd80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161485 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-31Remove duplicated includeAndrea Gelmini1-1/+0
Change-Id: I64436766ca0274e0877c861db3ffdb9d87f5e12a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161462 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-30no need to use SvLockBytes in OImageControlModelNoel Grandin1-11/+3
we already have other, simpler facilities for wrapping streams Change-Id: Ic6f88821e089951999395507bc84e68ea339d9de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161444 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-30ImgProdLockBytes is unnecessaryNoel Grandin2-136/+17
we already have facilities for doing this kind of wrapping (removes another instance of SvLockBytes) Change-Id: Ie3546efe06580f9492d8f6ddbc1a2e904036465a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161443 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-30no need to use SvLockBytes in formsNoel Grandin1-3/+3
Change-Id: Ide586997d504e0fbdb72aa1db77c49ba3d6007c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161437 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-20cid#1545612 COPY_INSTEAD_OF_MOVECaolán McNamara1-2/+1
and cid#1545605 COPY_INSTEAD_OF_MOVE cid#1545587 COPY_INSTEAD_OF_MOVE Change-Id: Iafb1d81dbacfefe70fbddd84b29e827dc137ef07 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07simplify and modernise ScopedBitmapAccessNoel Grandin1-6/+5
(*) Make all of it use a "Scoped" paradigm (*) pass by value, no need to allocate on heap (*) make all of the construction go via the *Access constructors, instead of it being some via the constructors and some via the Acquire*Access methods. (*) take the Bitmap& by const& in the constructor, so we can avoid doing const_cast in random places. Change-Id: Ie03a9145c0965980ee8df9a89b8714a425e18f74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-04cid#1545597 Using invalid iteratorJulien Nabet1-1/+1
and : cid#1545537 Using invalid iterator cid#1545508 Using invalid iterator cid#1545494 Using invalid iterator cid#1545478 Using invalid iterator cid#1545427 Using invalid iterator cid#1545420 Using invalid iterator cid#1545400 Using invalid iterator cid#1545300 Using invalid iterator cid#1545258 Using invalid iterator cid#1545257 Using invalid iterator cid#1545200 Using invalid iterator cid#1545183 Using invalid iterator Change-Id: Ibf3a41902f34286967195c5c3b22e337a4b06809 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160322 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-11-23loplugin:fieldcast in BindingNoel Grandin3-50/+41
Change-Id: Ia4bb341dba0c853b53c42a36fcb472e5948f1708 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159839 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-23Extended loplugin:ostr: Rewrite some O[U]StringLiteral -> O[U]StringStephan Bergmann5-386/+386
...in include files. This is a mix of automatic rewriting in include files and manual fixups (mostly addressing loplugin:redundantfcast) in source files that include those. Change-Id: I1f3cc1e67b9cabd2e9d61a4d9e9a01e587ea35cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158337 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-19Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: formsStephan Bergmann3-5/+5
Change-Id: Ifab0f06a776a9c505508781018300c7ce5d46436 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-14Use exception ctors, instead of setting members laterMike Kaganski2-7/+2
Avoids overwriting source location in message Change-Id: Ia0290c7dd1ab3ea1357712a27ecab75c7b583dd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157893 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-12Make NC_ constexpr-friendlyStephan Bergmann1-1/+1
...by moving the char8_t -> char reinterpret_cast out of any potential constexpr paths into a new TranslateId::getId. And demonstrate constexpr'ability by making the aCategories var in OApplicationIconControl::Fill (dbaccess/source/ui/app/AppIconControl.cxx) constexpr. (And there might be more such cases that could now be made constexpr.) Change-Id: I0b4e3292faf8f6b901f9b9e934e1aa6bf0f583ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157862 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-07loplugin:ostr: automatic rewriteStephan Bergmann1-2/+2
Change-Id: I2d09b2b83e1b50493ec88d0b2c323a83c0c86395 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157647 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2023-10-05Replace useless lcl_throwIllegalArgumentException function (forms)Julien Nabet1-14/+5
Change-Id: Icad8c36ef91edd12da8cc533e3ce24c0000a8a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157590 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-25Convert internal vcl bitmap formats transparency->alpha (II)Noel Grandin1-2/+2
(Second attempt at landing this) Image formats and graphics APIs use alpha, not transparency, so change our internal formats and data structures to work directly with alpha, so we don't need to modify data before we push it to graphics APIs. Add a couple of new Color constants to make the intention of the vcl code clearer. Notes (*) On macOS, tweaking the logic in CreateWithSalBitmapAndMask to more accurately reflect the requirements of the CGImageCreateWithMask function seems to fix some tests. (*) The vcl code does not properly support gradients with transparency. So the previous code was wrong, and this change is going to result in slightly different wrongness. Change-Id: I9e21c2e98d88ecfdc5f75db13bd1ffff7c38db98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114168 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-24sw, forms: some hacks to nerf time-fields so convwatch works betterMichael Stahl1-2/+5
This is useful for PDF-based layout-comparison regression testing where date/time fields were updated upon PDF export and create lots of false positives. Hopefully these can be eliminated this way, at least from text documents. To test: Download https://bugs.documentfoundation.org/attachment.cgi?id=48452 from tdf#38703 and export it with: STABLE_FIELDS_HACK=1 instdir/program/swriter --convert-to pdf DeleteStackSample.odt The date and time fields are now reset to 30/12/1899 00:00:00 Change-Id: Ic89111615074adb50f16a605f920f9a89c437dfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/24442 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-07-05loplugin:finalclassesNoel Grandin1-1/+1
Change-Id: I62b094a3bd9a4f630cebdf538c04391e2920ff2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-04loplugin:unusedvarsglobalNoel Grandin1-2/+0
Change-Id: Ia86c8bd0bdc85c375eb3837ba97f9e171d9dac6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153974 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-06-26new loplugin:constexprliteralNoel Grandin1-2/+2
OUStringLiteral should be declared constexpr, to enforce that it is initialised at compile-time and not runtime. This seems to make a different at least on Visual Studio Change-Id: I1698f5fa22ddb480347c2f4d444530c2e0e88d92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153499 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-25use more TypedWhichId in editengNoel Grandin2-4/+4
Change-Id: I2eb2b50ef7002e23221c985ab3218617b3832aa7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152203 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-19XML forms: remove duplicate addEventListener DOMAttrModified with capture trueJulien Nabet1-2/+0
since commit b2a54aa2e4d215edc30cfecc397eeb3eeff1e5bc Author: Vladimir Glazounov <vg@openoffice.org> Date: Wed Mar 23 10:34:34 2005 +0000 Change-Id: I8f511d1efa0e2ee713d1e7c145cc60f4945aa8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151983 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-18tdf#155123: XML Form: Deleting parts of user defined data type impossibleJulien Nabet1-2/+2
2 parts: 1) in extensions/source/propctrlr/standardcontrol.cxx if value retrieved from the field is 0, let's return an empty Any var. 2) forms/source/xforms/datatypes.cxx Allow to select 0 in the spinbox for String and URI ("hyperlink") datatypes to be homogeneous Change-Id: Ife9a94c279e8651623112c0bf8a64555cb9c556c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151740 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-17tdf#154628: XML Form Document: Sending data with GET fires very oftenJulien Nabet1-4/+0
See rationale here: https://bugs.documentfoundation.org/show_bug.cgi?id=154628#c5 Change-Id: I26556baceec8823d2c3bed382d51731d18bd2ccd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151852 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-05-14tdf#155121: XML Form Document: better take into account "not required"Julien Nabet1-1/+8
Change-Id: Ibebdbc52f2bd7d09ec7aa5f072efef364249a291 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151733 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-05-08tdf#152974 revert change to ORichTextModel::getPropertyDefaultByHandleCaolán McNamara1-3/+7
properties that match the default are not exported, so we're basically stuck with what is in there for compatibility with older versions, so revert commit ca46afebb7dc0ec4375e995fa90edccbed6c2530 Date: Tue Oct 4 16:22:51 2022 +0100 default to 'flat' instead of '3D Look' for form controls and set m_nBorder to the desired new default in the ctor but leave getPropertyDefaultByHandle as it always was Change-Id: Ia862fc6851248fc9b16b3b4c505fdaf6fdb4b2ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-07use AlphaMask for variables when calling GetAlphaMaskNoel Grandin1-2/+2
Right now this doesn't make any difference, since Bitmap is the superclass of AlphaMask. But when I switch to using alpha instead of transparency, passing AlphaMask around is going to mean something different to passing plain Bitmap around. Change-Id: Ic1541e5f0a3b97331793cd23e23115faa7f382b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151463 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-05-05Resolves: tdf#154337 allow submitting to file: if user agreesCaolán McNamara3-7/+32
continue to allow submitting to http[s]: without further interaction. Don't allow for other protocols, except for file: where the user has to agree via dialog prompt. Change-Id: Ia915f4f33d5dba621971ce69a156c339da933b55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151418 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-05-03Related tdf#154769: XML Form add limits of length value for some datatypeJulien Nabet1-0/+15
length value for: - year:4 - month and day:2 change ISO8601parseDate in unotools to return false when month or day length > 2 Change-Id: I807a8a784c8924750ae2c821de4be667e514e91f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151238 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-26Related tdf#154769: XML forms add anyURI/hyperlink datatypeJulien Nabet3-1/+158
See https://www.w3.org/TR/xmlschema11-2/#anyURI Since I copied-paste string datatype + add check url, I thought about deriving from string datatype but seeing https://www.w3.org/TR/2012/REC-xmlschema11-2-20120405/datatypes.html#built-in-datatypes anyURI doesn't derive from string TODO: contrary to "string" which uses "preserve" for "whitespace" "anyURI" uses "collapse" There's WhiteSpaceTreatment notion in datatypes.cxx and m_nWST associated, WhiteSpaceTreatment::Preserve seems to be the default but when searching about it, it's seems not used. Change-Id: Ifc2dc06072e40b9be168c2f40a9506fe7d267ce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150822 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-04-25Add script to find unused using declarationsGabor Kelemen1-2/+0
As a complementer to clang-tidy-12 --checks="-*,misc-unused-using-decls" Pros: - simple, fast! - finds some more unused declarations, somehow - works on non-linux specific parts of the code - clang-tidy (for me) trips on files with external headers, this does not Change-Id: If2db989114ac5c2841ed2e89ff7bd7a9e419f567 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150612 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-04-21Fix some getImplementationNameStephan Bergmann2-9/+17
...to match the corresponding .component entries Change-Id: I4c2a838b7a88e3d21e230310c1a4057b427a7c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150756 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-21tdf#116451: XML Form: adding 2 values of decimal-fields gives wrong resultJulien Nabet2-2/+2
Since, depending of the localization decimal separator may be ",", replace "," by "." before calling ::rtl::math::stringToDouble Change-Id: I461f3bdf83019d066735e10b3b6b6784e006bc7f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150750 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2023-04-20Run clang-tidy with misc-unused-using-decls on modules [d-o]*Gabor Kelemen5-6/+0
To remove unneeded using declarations. Via the simple script: for i in $(find $dirname -name "*cxx" -o -name "*hxx" ); do clang-tidy-12 --checks="-*,misc-unused-using-decls" "$i"; done Change-Id: Idd8aa3d3cfec456c4babb65e89af712051b4deb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150609 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-04-20Related tdf#154769: XML form, detect misformed year/month/dayJulien Nabet1-10/+68
From https://www.w3.org/TR/xforms20/ "Data Binding Restrictions: Binds only the following list of datatypes, or datatypes derived by restriction from those in the list: xsd:duration, xsd:date, xsd:time, xsd:dateTime, xsd:gYearMonth, xsd:gYear, xsd:gMonthDay, xsd:gDay, xsd:gMonth, xsd:float, xsd:double, and xsd:decimal. " gYear: a number between 0 and 10000 From https://www.w3.org/TR/xmlschema11-2/#gYear + https://www.w3.org/TR/xmlschema11-2/#partial-implementation: "All ·minimally conforming· processors must support nonnegative ·year· values less than 10000" -> we could accept more but if other use this minimal requirement, they may wrongly consider LO as buggy here gMonth: a number between 1 and 12, not some string like 'May' (see https://www.w3.org/TR/xmlschema11-2/#gMonth) gDay: a number between 1 and 31, https://www.w3.org/TR/xmlschema11-2/#gDay The first test in lcl_getValueyear is due to the fact that a failing conversion with "o3tl::toInt32" also returns 0. So the goal is to consider this obvious case first. Change-Id: Ifd8106b55419093a0223cff6a0afb9ccd3aa5efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-19Related tdf#154769: XML form, detect misformed date/datetime/timeJulien Nabet2-5/+30
Change-Id: Ied859703f906ef97c70be4518974ca6a0e482573 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150582 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-04-18Some missing XServiceInfo implementationsStephan Bergmann2-0/+20
Change-Id: I1cf871b40f9f4020147dac0456ebeed3de0438e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150533 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-04-14tdf#154734: XML Form doc: all binded fields will be shown as fields...Julien Nabet1-1/+1
with wrong content - except fields, which have wrong content Regression of 14cfff500e93f0d6cbf8412065feea85c01ea81d (at 2021-08-05) Pass context and resource string down to boost::locale separately because this is often on a hot path, and we can avoid the splitting and joining of strings like this. Before the commit, it was: return ( _validate( sValue ) == nullptr ); _validate methods return "TranslateId" variable which contain the reason why validity is wrong so if this variable contains no reason it means everything is OK. so just replace: return bool(_validate( sValue )); by: return bool(!_validate( sValue )); Change-Id: I76373d0825f86f9072217c96757252b6a891ecc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150433 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-04-10Related: tdf#154684 Make this string more specificAdolfo Jayme Barrientos1-1/+1
Change-Id: Id28083f1549c752555068dc715131c38f09adb23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150180 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-04-10tdf#154658: XML Form Document: Fields doesnt calculate any moreJulien Nabet1-0/+33
Regression from 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 author Julien Nabet <serval2412@yahoo.fr> 2021-11-07 15:40:37 +0100 committer Julien Nabet <serval2412@yahoo.fr> 2021-11-07 21:58:53 +0100 commit 73334560b2dd2d60ac58d2cc2b1a5295490b03e1 (patch) tree b5bc4f69dd8ed455c78ea05ab1c5e2f3c25b909e parent 6be03ac71e0d4927612b4a57ead3d0b245c29c77 (diff) Replace some macros in forms part 16 A big thank you to Raal for having spotted this! Change-Id: Ib6f1878897b16b43df287702f82835824c1f766d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150174 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-03-25loplugin:stringadd in editeng..frameworkNoel Grandin4-18/+12
after my patch to merge the bufferadd loplugin into stringadd Change-Id: Ieac16a01fde6467a2f6fe47864069304a3c44e47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-17elide some temporary OUStringsNoel Grandin1-1/+1
where we are calling append(OUString::createFromAscii( and we can rather call appendAscii Change-Id: I2366b518fe6d8d2484b00bb831cb79fb49bc0293 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149043 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-13make more use of OUStringBuffer::append(OUStringConcat)Noel Grandin1-4/+2
where we can avoid constructing temporary OUStrings Change-Id: I0eacd68a8d1b450894c2ea769055f16886b78ad0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148780 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-06no need to allocate these separatelyNoel Grandin4-18/+17
they are all one or two words in size Change-Id: Idc76cb87d1dae7ef245f327dc4afebaf71190f6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27osl::Mutex->std::mutex in CProgressHandlerHelperNoel Grandin1-6/+4
Change-Id: I86ddf381e0d52fe50739d5378ea36059a4d1e521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147863 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27osl::Mutex->std::mutex in frm::OComponentEventThreadNoel Grandin2-6/+9
Change-Id: I419a96fce0d5dbdd438dda32217ced39ba598446 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147864 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-22BaseMutex->std::mutex in ListenerMultiplexerBaseNoel Grandin1-6/+2
Change-Id: Icd565c83ca3b4afb1a846a637b7943b0498487e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147457 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-01-19cid#1520418 Unchecked dynamic_castCaolán McNamara2-3/+3
and cid#1520419 Unchecked dynamic_cast cid#1520420 Unchecked dynamic_cast Change-Id: Ia5ef238677bd5eadcdb7fc3fcf982d8a1507133c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145768 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-01-18cleanup commit for SubmissionNoel Grandin4-14/+4
The following commit missed some stuff: commit fc41f4d58c7c0e60025c1b43127ef1b3c87fa1ac Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sat Jan 14 12:41:58 2023 +0200 XUnoTunnel->dynamic_cast in Submission Change-Id: Ic27a813e360ae39227cd68213d2899ab64f0dee5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/145688 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>