summaryrefslogtreecommitdiff
path: root/editeng
AgeCommit message (Collapse)AuthorFilesLines
2016-04-02cleanup: remove unused Reference.h(xx) includesJochen Nitschke2-2/+0
and unused using-declarations from Reference.h Change-Id: I297a7ae6044fa329d245ecf08fd5c4cb930f5b19 Reviewed-on: https://gerrit.libreoffice.org/23735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-03-31tdf#97525 vcl: make DeletionListener internalJochen Nitschke1-1/+0
move include/vcl/impdel.hxx to vcl/inc/ include impdel.hxx in salframe.hxx remove vcl/impdel.hxx includes in pch add missing <list> includes Change-Id: Id146363b2e20ce0238542929c26a83efb1e8c4bd Reviewed-on: https://gerrit.libreoffice.org/23664 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-31use SAL_N_ELEMENTS more widelyNoel Grandin1-1/+1
found using git grep -n 'sizeof.*/.*sizeof.*[0]' Change-Id: Icd4a6cc1ca8ec8ebd68e1701a02789c74cf0eb2a
2016-03-29Avoid reserved identifiersStephan Bergmann3-18/+18
Change-Id: I759939aa74570be63f5d41814c22aad1851d65c4 Reviewed-on: https://gerrit.libreoffice.org/23587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-23loplugin:constantparam in editengNoel Grandin7-197/+47
Change-Id: I50ee4a0a3403cbed2aa8cdd6daaa951c9d0dad37
2016-03-18loplugin:constantfunction in editengNoel Grandin15-42/+33
Change-Id: I8f8414b4867d3248e6d836ed8037de4da41b97f1 Reviewed-on: https://gerrit.libreoffice.org/23331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-15loplugin:constantparamNoel Grandin2-5/+3
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-10coverity#1355507 uninitialized scalar fieldCaolán McNamara5-17/+17
I think commit b2fb84499e1f75735e8fd90bc2eece3fed9af5f6 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 7 14:19:22 2016 +0200 loplugin:write only fields wrong wrong and took out this param along with the unused nIndex beside it Change-Id: Idc34e03b5d59d4b0017fff456b79c807fda2535f
2016-03-10loplugin:constantparam in editengNoel Grandin7-29/+18
Change-Id: I078061c502c09bccf515151d3a5bdcd1176e64fb
2016-03-09remove unused NOT_POOLABLE enum valueNoel Grandin1-55/+55
and simplify the resulting SfxItemInfo field down to a single bool Change-Id: I73e24e83d39afc7660ac85872ba96bc790713cb2 Reviewed-on: https://gerrit.libreoffice.org/23058 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:write only fieldsNoel Grandin6-24/+22
Change-Id: Ia0fb487c5590e096659b81f76c4dc543e184c59c
2016-03-07improve defaultparams lopluginNoel Grandin1-1/+1
to catch calling params with defaults like "= OUSString()" Change-Id: Iad060e318ed492c22f8be44e326174fe6d28fff9 Reviewed-on: https://gerrit.libreoffice.org/22932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-07loplugin:unuseddefaultparam in editengNoel Grandin6-22/+20
Change-Id: Ifd86b0f6cca5d5d30daeee1c087c0124f2f18f3c Reviewed-on: https://gerrit.libreoffice.org/22899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-06bIsExpanding is unusedCaolán McNamara1-3/+0
Change-Id: I187ca7dc0e9e1a99e82145f4bcdce6abaac68278
2016-03-06coverity#1355252 Uninitialized pointer fieldCaolán McNamara1-11/+13
Change-Id: I34c5565adcfd3fd39f9b03967e5c4272767a58ea
2016-03-03editeng: fix -Werror=unused-but-set-variableMiklos Vajna1-2/+0
Change-Id: I14364bc833c97dbb5dfe323c65282f69ba7e393f
2016-03-03loplugin:unuseddefaultparams in editengNoel Grandin18-118/+72
Change-Id: I1dc0ba262c06bd69cf92aae20b344fe23f460f55
2016-02-24let SvxSearchItem use SearchOptions2Eike Rathke1-2/+2
And all those places that interface to SvxSearchItem. Change-Id: I08915824a596cd0f247a89f44e4684cd22b98082
2016-02-23new loplugin: commaoperatorNoel Grandin4-11/+21
Change-Id: I03f24e61f696b7619855e3c7010aa0d874e5a4ff
2016-02-19editeng: remove never read mpLibreOfficeKitCallbackMiklos Vajna4-12/+6
As all callback invocations happen with SdrModel's callback pointer. Change-Id: I0111040c501b7927332f88cc4797b8ebab2bc57a
2016-02-18Fix SdrModel::libreOfficeKitCallback() vs ImpEditView duplicationMiklos Vajna1-14/+2
It's better if ImpEditView doesn't have a copy of the event types which should be ignored during searching. Change-Id: I9044b9a6af4e3f8e5bf75973e1f975fb45ec72cf
2016-02-17Fix missing iterator include on MSVC 14.0David Ostrovsky1-0/+2
Change-Id: I55de612aef52038fd9979426950d4ae4131ca586 Reviewed-on: https://gerrit.libreoffice.org/22448 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock1-1/+1
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92
2016-02-10Simplify codeStephan Bergmann2-17/+3
Change-Id: I2ac0564a5a6714111abdcff48edff070d75892b7
2016-02-09Use rtl::Reference<CppType> instead of HardCppRef<UnoType,CppType>Stephan Bergmann2-14/+15
Change-Id: I089b5caca5e05726105f78aeb00db1869d0a17f4
2016-02-09Remove excess newlinesChris Sherlock44-532/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-09Formatting changes across all modulesChris Sherlock2-138/+66
+ Removed comment cruft + Tab formatting in number of files + Some commented out code removed + Tab characters replaced with spaces + Newline cleanup in quite a few files + Tweak header guard #endifs Change-Id: I3208ff2f047da890edcc49b73389aca22442f5fc Reviewed-on: https://gerrit.libreoffice.org/22221 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-08loplugin:unusedmethodsNoel Grandin2-18/+10
using an idea from dtardon: <dtardon> noelgrandin, hi. could you try to run the unusedmethods clang plugin with "make build-nocheck"? that would catch functions that are only used in tests. e.g., i just removed the whole o3tl::range class, which has not been used in many years, but htere was a test for it... <noelgrandin> dtardon, interesting idea! Sure, I can do that. Change-Id: I5653953a426a2186a1e43017212d87ffce520387 Reviewed-on: https://gerrit.libreoffice.org/22041 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-05interface to new XTextSearch2 with SearchOptions2, tdf#72196Eike Rathke1-1/+1
Places that had utl::TextSearch::UpgradeToSearchOptions2() introduced are worth an inspection if the new SearchAlgorithms2::WILDCARD search should be supported or at least use SearchOptions2 instead of SearchOptions to eliminate the small performance penalty that conversion involves. Change-Id: I565f73af2b551ae9ad0f488e672823dc6c5c1109
2016-02-04vcl: take into account the font width is the average font widthChris Sherlock10-29/+29
I'm changing the Font class function names: - SetSize -> SetFontSize - GetSize -> GetFontSize - SetHeight -> SetFontHeight - GetHeight -> GetFontHeight - SetWidth -> SetAverageFontWidth - GetWidth -> GetAverageFontWidth That's because it really makes no sense to say that there is a single constant font width because obviously proportional fonts don't have one - the best we can do is an average font width, which is what folks like Microsoft sort of do already. On a fixed font, the average is still accurate, for obvious reasons :-) I'm also not a fan of GetSize/SetSize as I find it a might too generic. Change-Id: Ib80a604ba62d6883fd6cbc7994da763976be5c70 Reviewed-on: https://gerrit.libreoffice.org/22069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-04tdf#94269 Replace "n" prefix for bool variables with "b"Chris Sherlock1-1/+1
Change-Id: I8999dc2701010424ea4d2504e99ed429030d7d4e
2016-02-02Related: tdf#97375 a cut doesn't refresh the editviewCaolán McNamara1-4/+5
but a delete does. The diff from delete to cut is the EnterBlockNotifications/LeaveBlockNotifications calls so try that Change-Id: I10147043d6fe358bf2f4f4bd6877210b86cbbd1f
2016-02-02Resolves: tdf#97375 use Invalidate in all modesCaolán McNamara1-6/+1
makes the crash/hangs go away Change-Id: I91a4391190ec7aa0ffa5e41a8c1eb86b4bb9c484
2016-02-02boost::hash->std::hashNoel Grandin1-1/+0
Change-Id: If4d1e4071995f07212fad958b0226d5824d168f8 Reviewed-on: https://gerrit.libreoffice.org/21989 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-01boost::cref->std::crefNoel Grandin2-4/+3
Change-Id: I2a4d2052c48f35d69cea2aed2e98079ad8d98a02 Reviewed-on: https://gerrit.libreoffice.org/21982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31OSL_THIS_FUNC is a rip-off of BOOST_CURRENT_FUNCTION so we can use thatCaolán McNamara1-1/+0
as a direct drop in I guess Change-Id: I3add63f1459f4e659019bd6db54da2f5431958ce Reviewed-on: https://gerrit.libreoffice.org/21941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-01-31unnecessary use of OUString constructorNoel Grandin1-1/+1
Change-Id: Idd31b0a53c8318af69bbcd32f6798721ec8eb8e1 Reviewed-on: https://gerrit.libreoffice.org/21945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-31tools: rename FontUnderline to FontLineStyleChris Sherlock11-91/+91
Change-Id: I4750ad8569a1003b2f8c29052f3e25003ee433ca Reviewed-on: https://gerrit.libreoffice.org/21892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-29vcl: add text alignment functions to ImplFont and FontAttributesChris Sherlock3-6/+6
ImplFont and FontAttributes now have GetAlignment and SetAlignment, and I have renamed Font::GetAlign to Font::GetAlignment, and Font::SetAlign to Font::SetAlignment. See commit description in 8bfccd3a71d911b6d ("vcl: Create accessor and mutator for font scaling in FontMetric") for reasoning behind patch. Unit test added to vcl/qa/cppunit/font.cxx to test text alignment. Change-Id: I6272c84fc9416c90616d957d1897eba9469fe7ba Reviewed-on: https://gerrit.libreoffice.org/21876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-22new loplugin sfxpoolitemNoel Grandin1-0/+8
generates a warning about subclasses that add members but do not override operator==() Change-Id: If6df1a2cbd115f17bcca22f9b7995181dcf55c03 Reviewed-on: https://gerrit.libreoffice.org/20468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-22Further uninitialized SvxNumberFormat::mbNumAdjustChanged fixingStephan Bergmann1-1/+1
The uninitialized read during CppunitTest_sd_html_export_tests mentioned in d90a20833a815362c344b82fc16b4bbcff0ebf07 "Missing initialization of SvxNumberFormat::mbNumAdjustChanged" is rather caused by the SvxNumberFormat copy ctor callling the SvxNumberFormat copy assignment op, which calls SvxNumberFormat::SetNumberingType before assigning mbNumAdjustChanged. What is probably wanted here is to simply copy the nNumType member without doing the eNumAdjust adjustments anyway. But a rather brittle design, that. Change-Id: Ic587687038f1ea71173461412350e6b2dee13aa4
2016-01-22TypoKhaled Hosny1-1/+2
Change-Id: Ib4c474cab050cdef003dc5e611e8a9bc1fb46e86
2016-01-22Missing initialization of SvxNumberFormat::mbNumAdjustChangedStephan Bergmann1-1/+2
introduced in 6517141b6233c5f9667031bc92f66109fddf5b76 "tdf#42788: FORMATTING - Numbering/ordered list," causing a read of the uninitialized value in CppunitTest_sd_html_export_tests. Change-Id: I7955593999e3a2bedca815ee447d96c1b997a358
2016-01-22editeng: ImpEditView::mbTiledRendering is never readMiklos Vajna4-18/+0
Change-Id: Ie8e33d075f0cedbb9f7148717c4318f4494ed419
2016-01-21tdf#42788: FORMATTING - Numbering/ordered listNusaiba Al-Kindi1-0/+21
I changed the default numbering alignment of the Roman(upper/ lower) numbers list to the right instead of left with out any changes in the default alignment of other numbring type lists. In addition, numbering alignment can be changed by the user and any new list created will not be affected by the user choice (using the default settings for the new list). Change-Id: I7a6b7fb31bf40e26910e90538cd336e767f4c056 Reviewed-on: https://gerrit.libreoffice.org/21439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-01-21vcl: rename Font::GetFamily to Font::GetFamilyTypeChris Sherlock10-16/+16
Change-Id: Ie427a43bd126dcdd89c6f66582736e67130f2254 Reviewed-on: https://gerrit.libreoffice.org/21633 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-20loplugin:unusedmethodsNoel Grandin2-32/+0
Change-Id: Ib2dc804f55d1a96ae01f2cf31b7d55956040a72e Reviewed-on: https://gerrit.libreoffice.org/21603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18basebmp now only used from vcl/headless codeCaolán McNamara1-3/+0
Change-Id: I068d404431d3565f6ad5741edbd3693225824a4d
2016-01-18loplugin: unused return valuesNoel Grandin6-23/+6
Change-Id: I9c61a46c57894bc63a57740206c0bcb4a16553af Reviewed-on: https://gerrit.libreoffice.org/21571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-01-18drawmodes header goneCaolán McNamara1-1/+0
Change-Id: Ia1b9ad96dbe41bebc5c2819385950a6d2980608b
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-28 05:18:29 +0000