Age | Commit message (Collapse) | Author | Files | Lines |
|
...as requested at
<https://github.com/flathub/org.libreoffice.LibreOffice/issues/213> "Can Skia be
reenabled in the Flatpak build?" and implemented on Flathub for now with
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/372d036e9113b6080780669ad44fc11a172356ed>
"Re-enable Skia". (This partially reverts
9d88f11de57bcbeb29fa6f1299d5d0867c1a75a4 "Flatpak: Upgrade to 21.08 runtime,
disable Skia".)
Change-Id: I50039d431fd3e6ba4c0d859d71e42e744433806b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148054
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
gcc from devtoolset-11 would complain about
svx/source/tbxctrls/layctrl.cxx: aText = u"\u202D" + aText;
See also https://gcc.gnu.org/pipermail/gcc-patches/2021-November/585777.html
Change-Id: I040371673dd8d5e023092c53791e9b666bace7a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147511
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Reverts parts of d552b4a549d614a03aa9328e017dec27bd3ff41e and
97e2e73e87479a742b798f362eda4baafb89497c.
Instead of patching HarfBuzz, lets make use of the already mmap’ed file
we use with FreeType.
Change-Id: Ia81222118162a30cadb8c988bc477ad3ce36166d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147410
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since:
commit d552b4a549d614a03aa9328e017dec27bd3ff41e
Date: Tue Sep 20 16:07:14 2022 +0300
Enable opening of downloaded fonts only in ForKit in Online
which silently disabled that from working for harfbuzz and graphite,
but just for Linux.
Change-Id: I13a67e3ad53a8d4c1833df19dd9f96b0b7366774
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147316
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
NDK 24 dropped support for API versions < 19,
quoting [1]:
> * Jelly Bean (APIs 16, 17, and 18) is no longer supported. The minimum OS
> supported by the NDK is KitKat (API level 19).
Therefore, use API level 19 for these (and unknown) NDKs unless
anything greater has explicitly been specified using the
`--with-android-api-level=<VERSION>` autogen switch
(or is default for the architecture, s. above).
Update the Jenkins config to use NDK 25 for the Android
builds as discussed in the ESC meeting on 2023-01-26 [2].
[1] https://developer.android.com/ndk/downloads/revision_history
[2] https://lists.freedesktop.org/archives/libreoffice/2023-January/089878.html
Change-Id: Ib8e65f433ee89ff1bc12432722570bf8f9f7ed85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146135
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Relevant announcement from revision history for NDK 23 [1]:
> * GNU binutils, excluding the GNU Assembler (GAS), has been removed. GAS
> will be removed in the next release. If you are building with
> -fno-integrated-as, file bugs if anything is preventing you from
> removing that flag.
Therefore, switch from uses of GNU binutils to the
corresponding LLVM tools instead.
NDK 20.x doesn't provide `llvm-ranlib` yet, so bump the minimum
version to 21.x.
Also drop the previous uses of `ANDROID_BINUTILS_PREBUILT_ROOT`,
which appear to no longer be relevant by now.
commit 4082a18406c18af7b4fcef7bd501c3679c3be56b
Date: Wed Nov 22 23:08:06 2017 +0100
android: use unified headers and llvm-c++ STL (x86) with NDK 16
gnustl (and others) are to be removed in future versions of the ndk
also bump gradle and build-tools to current versions along with it
arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix
that later
that introduced one of those uses mentions issues on ARM, but building
and running the app at least on my 32-bit ARM device (Samsung Galaxy S4 I9505,
LineageOS 17.1/Android 10) didn't show any issues in a quick test
with this change in place.
Update the Jenkins config to switch from the now no longer
supported NDK 20.1.5948944 to 23.2.8568313 for which building and
running the app has been tested on devices for all of the four
supported architectures with upcoming change
Change-Id I9ea714255faf29d50bb5f8e206f13495637da867
"android: Require NDK 23 and use default linker lld" in place
on top, s. that one's commit message for more details.
Note however that the NDK version will be further updated to use
NDK 25 in upcoming change
Change-Id Ib8e65f433ee89ff1bc12432722570bf8f9f7ed85
("android: Support NDK 24.x and 25.x, use NDK 25 for Jenkins").
[1] https://developer.android.com/ndk/downloads/revision_history
[2] https://lists.freedesktop.org/archives/libreoffice/2023-January/089878.html
Change-Id: I7645f8025d42f0fa384b5bceb31bb4b1c0a44cb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146118
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Otherwise we get the slightly mysterious "Can't select gen VCL plugin,
if --without-x is used!" error from configure.ac.
Change-Id: I3ffda8f7306ff48a619052df25186f0989370d95
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143707
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
The resulting config_host.mk from running autogen.sh with just
--with-distro=LibreOfficeWASM32 is identical, so this should be safe.
Change-Id: I68ab81ba4e48c18d135a824c6158d725eb3f94da
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143395
Tested-by: Jenkins
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I1588bd8c1ea844bfe997941554f0b8ed2cf21909
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141532
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
For now, just comment out those lines that don't match the configury
options here in master.
Change-Id: I38819e54e2f4ff3851c167603a1084072ef62700
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141756
Tested-by: Tor Lillqvist <tml@collabora.com>
Reviewed-by: Tor Lillqvist <tml@collabora.com>
|
|
Change-Id: I04511d12b1c6e500790448343320944eeb97a142
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138519
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
This commit reverts 3749d9af3745c0eaff7239e379578e4e2af89e9d
which removes the dependency on the external library cuckoo
Without using cuckoo the same file in tdf#130795 takes
real 0m4,892s
user 0m5,298s
sys 0m0,449s
With it, it takes
real 0m4,914s
user 0m5,276s
sys 0m0,444s
pretty much the same time
Change-Id: I4cc9000ac5bf26de22bb9835283ae8d5b3230196
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138435
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: I8ff0dd5314027e136782c236faebddd1077b180d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135830
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I48ffef665514378740b4146e2368f65930f74270
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134502
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Do not bundle LanguageTool which is at a 10 year old version (1.7)
while upstream has a lot of new releases (now at version 5.5.x)
It is not bundled by any downstream distributions
so it makes no much sense to keep it integrated here.
Change-Id: Icd2ef151b1b8d0252ffa3db0caaba576f2783fa9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133356
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
It is not bundled by any downstream distributions
so it makes no much sense to keep it integrated here.
Change-Id: I80180e53e050b8b3cd1b173ef01b51e8d706f295
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133355
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
e.g., <https://ci.libreoffice.org/job/gerrit_linux_gcc_release/114702/> on tb91
apparently picked up --enable-dconf and --enable-python=system (and failed, for
unclear reasons), while a corresponding
<https://ci.libreoffice.org/job/gerrit_linux_gcc_release/114728/> on tb89 didn't
(and succeeded)
Change-Id: I9ddd66ff7f1c6595a6cce65365f1cb0a07b6d67e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132216
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
|
|
Change-Id: I28ba6fd50d2c97bcdb1f9b56eb416f01813bd175
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/132131
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
It had originally been added with e754d0931ca75403647cc16100edd98e7e5ceadb
"Remove CXXFLAGS_CXX11 from Clang plugin compilation", so "if
COMPILER_PLUGINS_CXX is not set, simply default it to g++ instead of trying to
construct an acceptable CLANGCXX value from CXX (which would be Clang). (The
problem with using Clang without CXXFLAGS_CXX11 is that Clang, unlike GCC,
typically defaults to C++03, but building compilerplugins requires C++11 at
least. That would cause e.g. the Gerrit/Jenkins linux_clang_dbgutil_64 builds
to fail---but which also needs COMPILER_PLUGINS_CXX to be explicitly set to 'g++
-std=c++11' as GCC on those machines is still 4.8.5 defaulting to C++03." But
that should no longer be an issue with contemporary Clang, which defaults to >=
C++11 for quite a while now.
On the other hand, when trying to update the Clang used by
<https://ci.libreoffice.org/job/gerrit_linux_clang_dbgutil/> from 5.0.2 to
12.0.1, and adding
> export COMPILER_PLUGINS_CXX="ccache $LODE_HOME"/opt_private/gcc-7.3.0/bin/g++
to
<https://git.libreoffice.org/lode/+/refs/heads/master/bin/linux_clang_dbgutil_64.env>
(where this setting arguably belongs, rather than in
distro-configs/Jenkins/linux_clang_dbgutil_64, anyway), which is needed
because that version of Clang (and thus loplugin built against it)
cannot be built with the baseline CentOS 7 GCC 4.8.5, that setting of
COMPILER_PLUGINS_CXX got overriden by the one in
distro-configs/Jenkins/linux_clang_dbgutil_64, and configure failed due to
> configure:21069: checking clang/Basic/SourceLocation.h usability
> configure:21069: ccache g++ -std=c++11 -c -I/home/tdf/sberg/lode/opt_private/clang-llvmorg-12.0.1/include -std=c++14 -fno-exceptions -fno-rtti -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/\
> tdf/sberg/lode/packages/llvm-llvmorg-12.0.1.src/clang/include -I/home/tdf/sberg/lode/opt_private/clang-llvmorg-12.0.1/include -std=c++14 -fno-exceptions -fno-rtti -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_L\
> IMIT_MACROS -I/home/tdf/sberg/lode/packages/llvm-llvmorg-12.0.1.src/clang/include conftest.cpp >&5
> g++: error: unrecognized command line option '-std=c++14'
> g++: error: unrecognized command line option '-std=c++14'
> configure:21069: $? = 1
Change-Id: Ic33b116090f648ef645febb4fbb28ceb6a2a7cae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129692
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Doesn't include VCLplug flags and it should work with gtk3 too.
But normally you want to use:
--disable-gtk3
--enable-qt5
Change-Id: Ifea5e5b1e63633ff1fa709cdeb49afdb43fa0e8b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128588
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I17ddc43c37d806f267f4ca57bb02227bd053d2cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128397
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Currently mergelibs errors just fails the later callgrind build,
not early in Gerrit.
Change-Id: I165f99fa819ea3d88b76089a5a0967731570d42a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127426
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: Ic50f10d60879eee0eb0bc0194f7d08b58c58266b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127608
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This way we can get rid of the pre-generated locale data and the
special fuzzers target, which invokes a full gbuild make for
every prereqisite, always parsing the whole tree, taking ages.
This also reverts:
- commit d0780b21cfe235c4446adf649eb690f9c1771dd5 ("fix oss-fuzz
build") by adding epubgen and revenge dependencies.
- commit ff25d6a123beb42476bf42d189b3033a86835b2a ("ofz#41602 fix
more build failure"), which shouldn't happen anymore since
commit d47628f287f4377394c4ff488c433bfe254b6abe ("don't want to
link to system static libs for DISABLE_DYNLOADING")
Change-Id: I3aed9ec62da507254b42e4e7470bae1097b4bc8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127031
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
So I thought I could come up with a rich MediaItem and can get
rid of all the GUI elements. But all the still needed features
require a MediaWindow. Probably not for real, but there are
multiple levels of createPlayer (some static) in MediaWindow
and priv::MediaWindowImpl.
Untangling this will require more time, so just return to the old
--disable-gui state with actually keeping all the GUI elements.
Regression from commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31
("Fix --disable-avmedia for DESKTOP build")...
Change-Id: I2b04459003d474cd3abf8b086f2f20f17274a7ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127226
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
... by expanding libo_CHECK_SYSTEM_MODULE with yet an other
parameter to optionally disable the feature completely and
adding the matching AC_ARG_ENABLE.
As a result, --disable-cmis becomes --disable-libcmis.
Also adds more documentation to m4/libo_externals.m4.
And use simpler help strings, now hopefully correctly escaped.
Change-Id: I8ac67145721d8518cca6f6867bc05738a87ed77a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126771
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Remove code in ucb/source/ucp/webdav-neon, and now unused external
neon.
The --with-webdav=no option is retained for now.
Change-Id: I4ce429587e3991fa82009da2f8e4a068abe36435
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126839
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
...than ae36ee4f3aa544e53e2edad93d6d79160b27bc9d "Work around use-after-poison"
for
> ==1922539==ERROR: AddressSanitizer: use-after-poison on address
> 0x61d00190fab0 at pc 0x00000026aaa9 bp 0x7f422ee84b80 sp
> 0x7f422ee84348 WRITE of size 192 at 0x61d00190fab0 thread T44 #0 in
> memset at
> ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:800:3
> (instdir/program/soffice.bin +0x26aaa8) #1 at <null>
> (/lib64/libnsspem.so +0x15f3d) #2 at <null> (/lib64/libnsspem.so
> +0x16185) #3 at <null> (/lib64/libnsspem.so +0x8a9b) #4 at <null>
> (/lib64/libnsspem.so +0xe13b) #5 in secmod_ModuleInit at
> workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
> (instdir/program/libnss3.so +0x4ad372) #6 in secmod_LoadPKCS11Module
> at workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:544:10
> (instdir/program/libnss3.so +0x4b1fca) #7 in SECMOD_LoadModule at
> workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:1946:10
> (instdir/program/libnss3.so +0x50de92) #8 in SECMOD_LoadUserModule
> at workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:2042:28
> (instdir/program/libnss3.so +0x50e9a9) #9 in nss_load_module at
> workdir/UnpackedTarball/curl/lib/vtls/nss.c:1310:12
> (instdir/program/libcurl.so.4 +0x4fdd25) #10 in nss_setup_connect at
> workdir/UnpackedTarball/curl/lib/vtls/nss.c:1894:12
> (instdir/program/libcurl.so.4 +0x4eeffb) #11 in nss_connect_common
> at workdir/UnpackedTarball/curl/lib/vtls/nss.c:2235:14
> (instdir/program/libcurl.so.4 +0x4ee237) #12 in
> nss_connect_nonblocking at
> workdir/UnpackedTarball/curl/lib/vtls/nss.c:2291:10
> (instdir/program/libcurl.so.4 +0x4ebe4a) #13 in
> Curl_ssl_connect_nonblocking at
> workdir/UnpackedTarball/curl/lib/vtls/vtls.c:361:12
> (instdir/program/libcurl.so.4 +0x514039) #14 in https_connecting at
> workdir/UnpackedTarball/curl/lib/http.c:1591:12
> (instdir/program/libcurl.so.4 +0x2f29ce) #15 in Curl_http_connect at
> workdir/UnpackedTarball/curl/lib/http.c:1517:14
> (instdir/program/libcurl.so.4 +0x2f23d5) #16 in protocol_connect at
> workdir/UnpackedTarball/curl/lib/multi.c:1696:16
> (instdir/program/libcurl.so.4 +0x3b8620) #17 in multi_runsingle at
> workdir/UnpackedTarball/curl/lib/multi.c:1997:16
> (instdir/program/libcurl.so.4 +0x3a2232) #18 in curl_multi_perform
> at workdir/UnpackedTarball/curl/lib/multi.c:2568:14
> (instdir/program/libcurl.so.4 +0x39dc5c) #19 in
> http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession&,
> http_dav_ucp::CurlUri const&, curl_slist*,
> com::sun::star::uno::Reference<com::sun::star::io::XOutputStream>
> const*, com::sun::star::uno::Sequence<signed char> const*,
> std::pair<std::__debug::vector<rtl::OUString,
> std::allocator<rtl::OUString> > const&, http_dav_ucp::DAVResource&>
> const*, (anonymous namespace)::ResponseHeaders&) at
> ucb/source/ucp/webdav-curl/CurlSession.cxx:880:14
> (instdir/program/../program/libucpdav1.so +0x5aad30) 0x61d00190fab0
> is located 48 bytes inside of 2048-byte region
> [0x61d00190fa80,0x61d001910280) allocated by thread T44 here: #0 in
> malloc at
> ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_malloc_linux.cpp:69:3
> (instdir/program/soffice.bin +0x2d3c7e) #1 in PR_Malloc at
> workdir/UnpackedTarball/nss/nspr/out/pr/src/malloc/../../../../pr/src/malloc/prmem.c:448:55
> (instdir/program/libnspr4.so +0x123629) #2 in PL_ArenaAllocate at
> workdir/UnpackedTarball/nss/nspr/out/lib/ds/../../../lib/ds/plarena.c:134:27
> (instdir/program/libplds4.so +0x9a32) #3 at <null>
> (/lib64/libnsspem.so +0x15f77)
during UITest_sw_options:
That --with-system-nss workaround for <https://ci.libreoffice.org/job/lo_ubsan/>
had caused CppunitTest_desktop_lib to start to fail there, presumably "caused by
--with-system-nss on the CentOS7 baseline", see the mail thread starting at
<https://lists.freedesktop.org/archives/libreoffice/2021-December/088136.html>
"Re: [global-libreoffice-ci] UBSAN Linux Build - Build # 2217 - Still Failing!"
And while I had initially not been able to reproduce the use-after-poison during
UITest_sw_options with my local ASan+UBSan build (on Fedora 35), I now found out
that that was just because my machine happened to not have an nsspem library
installed in the system (the nss-pem RPM on Fedora). With that system library
installed, my local build failed UITest_sw_options in the same way as the
Jenkins tinderbox.
Which lead me to the idea of avoiding the whole mess by avoiding that CUrl loads
the (apparently optional) nsspem library in ASan builds altogether. (Another
approach might have been to disable the __asan_poison_memory_region
functionality in workdir/UnpackedTarball/nss/nspr/lib/ds/plarena.h, but the
chosen approach nicely makes us less dependent on accidental differences in
build-time execution environments, at least for ASan builds.)
Change-Id: I8fd2ff255771622f26ad666ca78a6d9ded0af2d7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126451
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
we don't care about that tool
Change-Id: Ifc0910a77177e504a35fcf35efad92d6ede63507
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126365
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since...
commit f9e79a91f15e10ededad0f103c4ffe0ca38fcb31
Date: Tue May 18 01:11:41 2021 +0200
Fix --disable-avmedia for DESKTOP build
Change-Id: I31404c1a4c2ba71fb47388d87b59ecbee87ff603
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126324
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
can't use the internal Executable_lockfile because it needs itself to
link
Change-Id: I51e3a910bedc038bb6776cd67d16ea706fbc071f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126285
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
> ==21930==ERROR: AddressSanitizer: use-after-poison on address 0x61d001aa0eb0 at pc 0x0000004398b4 bp 0x2ada81952e60 sp 0x2ada81952610
> WRITE of size 192 at 0x61d001aa0eb0 thread T42 (utl::Moderator)
> #0 0x4398b3 in __interceptor_memset.part.43 /home/tdf/lode/packages/llvm-llvmorg-9.0.1.src/compiler-rt/lib/asan/../sanitizer_common/sanitizer_common_interceptors.inc:773
> #1 0x2ada82e404ae (/lib64/libnsspem.so+0x154ae)
> #2 0x2ada82e405bf (/lib64/libnsspem.so+0x155bf)
> #3 0x2ada82e331b7 (/lib64/libnsspem.so+0x81b7)
> #4 0x2ada82e386c1 (/lib64/libnsspem.so+0xd6c1)
> #5 0x2ad58dccdafc in secmod_ModuleInit /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:244:11
> #6 0x2ad58dcd3027 in secmod_LoadPKCS11Module /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11load.c:544:10
> #7 0x2ad58dd37e20 in SECMOD_LoadModule /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:1946:10
> #8 0x2ad58dd389b9 in SECMOD_LoadUserModule /workdir/UnpackedTarball/nss/nss/lib/pk11wrap/pk11pars.c:2042:28
> #9 0x2ad54cea71b1 in nss_load_module /workdir/UnpackedTarball/curl/lib/vtls/nss.c:1310:12
> #10 0x2ad54ce969ae in nss_setup_connect /workdir/UnpackedTarball/curl/lib/vtls/nss.c:1894:12
> #11 0x2ad54ce95a5a in nss_connect_common /workdir/UnpackedTarball/curl/lib/vtls/nss.c:2235:14
> #12 0x2ad54ce9320a in nss_connect_nonblocking /workdir/UnpackedTarball/curl/lib/vtls/nss.c:2291:10
> #13 0x2ad54cebfa5a in Curl_ssl_connect_nonblocking /workdir/UnpackedTarball/curl/lib/vtls/vtls.c:361:12
> #14 0x2ad54cc6929e in https_connecting /workdir/UnpackedTarball/curl/lib/http.c:1591:12
> #15 0x2ad54cc68c74 in Curl_http_connect /workdir/UnpackedTarball/curl/lib/http.c:1517:14
> #16 0x2ad54cd42aac in protocol_connect /workdir/UnpackedTarball/curl/lib/multi.c:1696:16
> #17 0x2ad54cd2a3dc in multi_runsingle /workdir/UnpackedTarball/curl/lib/multi.c:1997:16
> #18 0x2ad54cd25704 in curl_multi_perform /workdir/UnpackedTarball/curl/lib/multi.c:2568:14
> #19 0x2ada803a8d54 in http_dav_ucp::CurlProcessor::ProcessRequestImpl(http_dav_ucp::CurlSession&, http_dav_ucp::CurlUri const&, curl_slist*, com::sun::star::uno::Reference<com::sun::star::io::XOutputStream> const*, com::sun::star::uno::Reference<com::sun::star::io::XInputStream> const*, std::pair<std::__debug::vector<rtl::OUString, std::allocator<rtl::OUString> > const&, http_dav_ucp::DAVResource&> const*, (anonymous namespace)::ResponseHeaders&) /ucb/source/ucp/webdav-curl/CurlSession.cxx:918:14
during UITest_sw_options (<https://ci.libreoffice.org/job/lo_ubsan/2210/>) after
bdef11f5337ecc87556a92693f6b7b5e200eb29e "configure: default to
--with-webdav=curl", apparently caused by a mixture of external/nss built with
ASan and system /lib64/libnsspem.so not build with ASan. (And this commit may
become obsolete with <https://gerrit.libreoffice.org/c/core/+/120388>
"configure: default to --with-system-nss on Linux".)
(The last time that use-after-poison in /lib64/libnsspem.so hit
<https://ci.libreoffice.org/job/lo_ubsan/>, I could work around it with
db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download
https files".)
Change-Id: Ic5ed4e60a577a65c71084e97b3fb3afd03266bb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125912
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...to 214fa233338c09156c67f85818b6a2ea6b3235bd "add
with-system-abseil/with-system-openjpeg for pdfium"
Change-Id: I5956b2710e3c3aa02285224e9d5799ef2da91270
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125885
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...for 3749d9af3745c0eaff7239e379578e4e2af89e9d "tdf#130795 use concurrent
hashmap in SharedStringPool"
Change-Id: I1f8d224cc412ff3e8ad819b018aea6cc1829faca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125884
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
It's the "more debug" option that each developer ideally should
use unless binary compatibility is wanted. Jenkins builds done
with these settings are reportedly not published, so this is
just tinderbox builds, and there's it's better to verify
the extra dbgutil stuff too.
Change-Id: Ia2f86ff9394e155b247a6e5e1583d0681399b99b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125381
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
LTO should now work properly at least on these platforms, and it's
a couple percent better performance at the cost of build time.
Change-Id: I0b6103161616b730fa32a7dd3b244219dda030fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123585
Tested-by: Jenkins
Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
|
|
which requires dropping ---disable-database-connectivity
Change-Id: I5b3a2027916a3cf844cefd90629c3fe918ead31e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122591
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
build without it and see what warnings there might be
Change-Id: I54b4d0c784631d26f634c63157563203bc37f1b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121864
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
For whatever reason, building Skia against the 21.08 SDK would fail with
> /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp: In function ‘void {anonymous}::colrv1_draw_paint(SkCanvas*, const FT_Color*, FT_Face, FT_COLR_Paint)’:
> /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:668:14: error: ‘FT_COLR_PAINTFORMAT_TRANSFORMED’ was not declared in this scope; did you mean ‘FT_COLR_PAINTFORMAT_TRANSFORM’?
> 668 | case FT_COLR_PAINTFORMAT_TRANSFORMED: {
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | FT_COLR_PAINTFORMAT_TRANSFORM
> /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:669:60: error: ‘union FT_COLR_Paint_::<unnamed>’ has no member named ‘transformed’; did you mean ‘transform’?
> 669 | SkMatrix transform = ToSkMatrix(colrv1_paint.u.transformed.affine);
> | ^~~~~~~~~~~
> | transform
> /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp: In function ‘bool {anonymous}::colrv1_traverse_paint(SkCanvas*, const FT_Color*, FT_Face, FT_OpaquePaint)’:
> /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:763:14: error: ‘FT_COLR_PAINTFORMAT_TRANSFORMED’ was not declared in this scope; did you mean ‘FT_COLR_PAINTFORMAT_TRANSFORM’?
> 763 | case FT_COLR_PAINTFORMAT_TRANSFORMED:
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> | FT_COLR_PAINTFORMAT_TRANSFORM
> /run/build/libreoffice/workdir/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.cpp:768:74: error: ‘union FT_COLR_Paint_::<unnamed>’ has no member named ‘transformed’; did you mean ‘transform’?
> 768 | colrv1_traverse_paint(canvas, palette, face, paint.u.transformed.paint);
> | ^~~~~~~~~~~
> | transform
> make[1]: *** [/run/build/libreoffice/solenv/gbuild/LinkTarget.mk:347: /run/build/libreoffice/workdir/GenCxxObject/UnpackedTarball/skia/src/ports/SkFontHost_FreeType_common.o] Error 1
But including Skia in the Linux flatpak isn't too useful anyway (and just
happened to be on by default): First, it is disabled by default on Linux, cf.
UseSkia in officecfg/registry/data/org/openoffice/Office/Common.xcu. And
second, on Linux it can only be enabled for SAL_USE_VCLPLUGIN=gen, but not for
the gtk3 plugin that the flatpak normally uses, cf.
OfaViewTabPage::UpdateSkiaStatus in cui/source/options/optgdlg.cxx.
Change-Id: Ifdc9c23676280caf19db0e9f09df15aaa21eef5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121705
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
so we get good stacktraces when something goes wrong
Change-Id: I1e0832b3ab0bdbbf1a76533c37fbb0a8060a0166
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121266
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8a3845ae0b811a43830c7bb166cc2092b7e163b1
|
|
dependencies need to be built with the msan flags so undo the
--with-system .a usage now that trying to squeeze into the 12 hour build
window isn't critical because the afl 6-8 hour build+check is disabled
Change-Id: I3729d37e0f028c5efe62ce5d66ea6fe636d3d0c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120788
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Idf4aa5f8d76afb3f0842830c2c874a10241ecc3d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120528
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1dd2c49bfc5577a8502eb42721f3ef9b08f8fdb0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120485
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I2d0fcf28aa8d2fe937f850a2a54125073a6913d4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120423
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
for these special targets now where we want to avoid building ucpp
Change-Id: I9ffa6f4148e8b5cafd7d34df4f2e18ec6f6c75c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120413
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I12e44bf2dbeebc0d18e48a22831099c3dad7b12d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120402
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ie78fa4442ec2d9b33e85d378f2df16f9f1696dd7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120227
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I67c1c00fa716242336bbad1dd3df079e277ea776
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120126
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
though its already implicitly disabled
Change-Id: Ia896ee187cae9e7bae6569559f5ceb824c8c86ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120167
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|