summaryrefslogtreecommitdiff
path: root/desktop
AgeCommit message (Collapse)AuthorFilesLines
2020-03-12comparison operators should be constNoel Grandin1-1/+1
Change-Id: Ifa76e004128223460945d58d1c59c4e23db0f108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90370 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-03-06lok: calc formula bar tunnelingMarco Cecchetti1-1/+3
Change-Id: I92026098222e04a163796225a048c6d7dc1b37c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89857 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2020-03-05android hunspell: Disable for Android ViewerMichael Weghorn1-1/+1
Since hunspell/extension support does not work for the Fennec-based Android Viewer, only enable the feature for the LibreOffice-Online-based Android app, not Android Viewer. This amends commits 4f9531c81d4190090ede4d657acdd4b7628462d0 ("android hunspell: Turn on the hunspell build on Android...", 2020-02-06) and 99e143cb771446b592e0d9e52bb16563e114b69a ("android hunspell: Don't explicitly disable extensions on Android.", 2020-02-07) to prevent Android Viewer from crashing whenever trying to open a document. Change-Id: Ib35fb35baf542a66b77ce2eed902e68adfec7349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90021 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-03-01lok: Create Text boxes directlyMuhammet Kara1-0/+4
Change-Id: I281d4648d0e91f74d6f0f5880945d8e7e8659efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89344 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89709 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-27desktop: soffice --print-to-file generates PDF but names it ".ps"Michael Stahl1-1/+1
Both on Linux and Windows a PDF is generated. Change-Id: I076b57c34a87c17d34eb34f2ea87c6fd5fe590f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89645 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-02-27Drop checking for user extensions w/ the same ID on every synchronizationKatarina Behrens1-27/+0
the question in 2012 was, is this still necessary? It slows down every warm start so let's assume it is not, remove it and see what happens Change-Id: Ia185fd18433d4145c0f33df8d7f60ba734f8504a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85609 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-26Revert "jsdialog: Refresh dialog after action"Tamás Zolnai1-18/+1
This change makes some cypress tests to fail, the mobile wizard does not open or opens with an empty content. It seems it causes an issue when mobile wizard is opened/closed subsequently. One test case does not make this visible, but it needs to run more test cases subsequently. This reverts commit 0a35eafca9f74d2858bd3323d74d64813fa9107a. Change-Id: Iccb6bb3d77270340ac9b36a68cae749098ddaa3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89502 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2020-02-25Fix currency symbol selection in Calc on mobileTomaž Vajngerl3-17/+25
In LOK we use one language identifier for both - UI language and the locale used. This is a problem when we determine that we a language for UI is not available and fall-back to the default "en-US" langauge, which also changes the locale. This introduces a separate variable that stores the language tag for the locale independently to the language. Another problem is that in some cases we don't reset the staticly initialized data, when the new document is loaded, which is on the other hand used to define which currency symbol is used as SYSTEM locale. That can in some cases select the wrong currency symbol even when we changed the locale to something else. This fix introduces a reset function, which is triggered on every document load. Change-Id: I55c7f467600a832895f94346f8bf11a6ef6a1e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89320 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89343 Tested-by: Jenkins
2020-02-25jsdialog: Refresh dialog after actionSzymon Kłos1-1/+18
Change-Id: I83e5750f91789fcd01ba41cab616c5e768492bc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89369 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-02-24tdf#95845: Use CommandInfoProvider to receive UNO command labelsPelin Kuran1-39/+3
Change-Id: Id8fb7304ca5f8cc8c5b94504fb891b56769a57c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88756 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-24workaround GCC 9.2.1 -Og -Werror=maybe-uninitializedMichael Stahl1-2/+3
vcl/unx/generic/gdi/salbmp.cxx:727:32: error: ‘pixmapHandle’ may be used uninitialized in this function [-Werror=maybe-uninitialized] vcl/unx/gtk3/gtk3gtkinst.cxx:7336:16: error: ‘eRet’ may be used uninitialized in this function [-Werror=maybe-uninitialized] etc. One looks like it might occur in practice. Change-Id: I09af7d36b134b31cb7bd8047b5c73f4a49c9d9b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89351 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-22tdf#127205 split Desktop::terminate processJan-Marek Glogowski2-0/+9
Trying to somehow keep stuff correctly alive, truned out to be rather futile. Originally I tried the same way Caolan did in the attached patch to tdf#88985, when he finally settled on adding a special terminate listener. But this is not enough to handle in-process scripted extensions, like Java, Python or even Basic macros themself. So this separates the module shutdown and SfxApplication cleanup from the rest of the terminate call. Change-Id: Ice59816080c922a17511b68afe59348a662600c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88835 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-02-21Drop o3tl::optional wrapperStephan Bergmann31-93/+90
...now that macOS builds are guaranteed to have std::optional since 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". The change is done mostly mechanically with > for i in $(git grep -Fl optional); do > sed -i -e 's:<o3tl/optional\.hxx>\|\"o3tl/optional\.hxx\":<optional>:' \ > -e 's/\<o3tl::optional\>/std::optional/g' \ > -e 's/\<o3tl::make_optional\>/std::make_optional/g' "$i" > done > for i in $(git grep -Flw o3tl::nullopt); do > sed -i -e 's/\<o3tl::nullopt\>/std::nullopt/g' "$i" > done (though that causes some of the resulting #include <optional> to appear at different places relative to other includes than if they had been added manually), plus a few manual modifications: * adapt bin/find-unneeded-includes * adapt desktop/IwyuFilter_desktop.yaml * remove include/o3tl/optional.hxx * quote resulting "<"/">" as "&lt;"/"&gt;" in officecfg/registry/cppheader.xsl * and then solenv/clang-format/reformat-formatted-files Change-Id: I68833d9f7945e57aa2bc703349cbc5a56b342273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89165 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-20macOS Xcode ld is known to always support -platform_version nowStephan Bergmann1-1/+1
...after 358146bbbd1b9775c12770fb5e497b6ec5adfc51 "Bump macOS build baseline to Xcode 11.3 and macOS 10.14.4". This effectively reverts b7fd89100d8653dc73955780358fe31d38b68ebf "tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_version". Change-Id: Ib79563babe3cc948556d5369b0f6b6a8d208cab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89160 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-16Remove useless access modifier from the Updater classMuhammet Kara1-1/+0
Change-Id: I1353634e9e5e65dd080daf7304d5e8a16bc77e4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88808 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-16GBUILD_TRACE, support for finding out where the build time is spentLuboš Luňák1-0/+2
See instructions in solenv/gbuild/Trace.mk . This generates a file than can be viewed e.g. in the Chromium tracing view. Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-16clang-format c*,d*,e* with under 5-percent lines of changeMuhammet Kara3-6/+2
Files which could become clang-format conformant with under 5-percent lines of change relative to the total count of lines in the file are found by using bin/find-clang-format.py, and fixed with /opt/lo/bin/clang-format -i <path-of-the-file> There will be follow-up patches to fix all 'under-5-percent' files. Change-Id: I06087a1385ca9da6a28d36ea4c0d2e40bdbf8f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88774 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-16MAC_OS_X_VERSION_MIN_REQUIRED_DOTS is the same as MACOSX_DEPLOYMENT_TARGETStephan Bergmann1-2/+1
Change-Id: I3a725e4681c11f503dae57436b05b5a80ff2979c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88764 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_versionStephan Bergmann1-5/+7
...according to <https://github.com/llvm/llvm-project/commit/ 25ce33a6e4f3b13732c0f851e68390dc2acb9123> "[driver][darwin] Pass -platform_version flag to the linker instead of the -<platform>_version_min flag": "In Xcode 11, ld added a new flag called -platform_version [...] This patch adopts the new -platform_version flag in Clang, and starts using it by default, unless a linker version < 520 is passed to the driver." So detect new HAVE_MACOS_LD_PLATFORMVERSION and adapt 645fe53be0dc36535dba0ed684e21ca4cda80d70 "tdf#122218: Hack to avoid blurry text with macOS SDK 10.15" accordingly. (This also changes the passed -platform_verion sdk value from 0.0 to 0.0.0, for cosmetic consistency with the default Clang behavior cited above. Also, after f67e5ef9a5c71f3b35b1c67eb72794e44cc15410 "Drop broken filter-out of -bind_at_load for Executable_soffice_bin on macOS" got included in the meantime, the surrounding ifeq in desktop/Executable_soffice_bin.mk can be combined now.) Change-Id: Ie1ddf2d618e2f1232c6b4e17ce17665851f3bd38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88717 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14Drop broken filter-out of -bind_at_load for Executable_soffice_bin on macOSStephan Bergmann1-4/+0
We generally use -bind_at_load ("Sets a bit in the mach header of the resulting binary which tells dyld to bind all symbols when the binary is loaded, rather than lazily." according to Xcode 11.3.1 ld(1) man page) since 4c9c1957cfc7c9de3def35dab4dcd07e76992ddd "INTEGRATION: CWS geordi2q01: #i18350#: join changes from CWS ooo11rc3" (lacking any explanation; later carried over into solenv/gbuild/platform/macosx.mk). And we filtered out -bind_at_load for Executable_soffice_bin (and others, back then, which have become irrelevant by now) with 13be934b43266d3df966ce40c00316401cea7a90 "INTEGRATION: CWS geordi2q14: #111934#: merge CWS ooo111fix2" (again, lacking any explanation). However, the latter was effectively broken when 6df9c479f58ea94141a3a43eb7fd6fb4d1fd5c8b "gbuildize desktop" rewrote it in desktop/Executable_soffice.bin.mk as $(eval $(call gb_Executable_set_ldflags,\ $(filter-out -bind_at_load,$$(LDFLAGS)) \ )) lacking an "soffice_bin," at the end of the first line. Given that the soffice executable is apparently built with -bind_at_load ever since 2011, without causing any issues, lets assume that filtering it out is no longer necessary (if it ever was), and drop that. (Maybe it was once necessary for some reason when the file system layout of OOo/ LO executables and dynamic libraries was different. But today, the soffice executable finds its dependent libraries, sal and sofficeapp, via @executable_path just fine.) Change-Id: Ifa379237cce4fa6d5ea0e2c1f1d84263f9007c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14tdf#122218: Hack to avoid blurry text with macOS SDK 10.15Stephan Bergmann1-0/+7
...by setting the LC_VERSION_MIN_MACOSX load command's sdk value to n/a in the soffice executable. See <https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c167> for how this helps, even though I have no idea why it helps. (Adding that -platform_version linker option appears to generate warnings like > ld: warning: passed two min versions (10.13.0, 10.13) for platform macOS. Using 10.13. but which are probably harmless.) Change-Id: I043498c7ff2d148d4a7e1e0e9d46241b638f2eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-13factor out dialog hacksCaolán McNamara1-13/+9
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12Allow boolean valued statechange messages for...Dennis Francis1-1/+4
object align commands : ObjectAlignLeft [SID_OBJECT_ALIGN_LEFT] ObjectAlignRight [SID_OBJECT_ALIGN_RIGHT] AlignCenter [SID_OBJECT_ALIGN_CENTER] What is pending is to set correct align state items for Impress in DrawViewShell::GetMenuStateSel(). For doing that we need to store the object align state somewhere when we execute SID_OBJECT_ALIGN_* in DrawViewShell::FuTemporary(). For Writer the align state information was already available in frame-format-manager object. Change-Id: I86fcf59cfc66af98097611277201ecaa3b8c22cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88077 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88452 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12lok: Add LOK_CALLBACK_STATE_CHANGED for uno:OrientationMuhammet Kara1-1/+2
Change-Id: Iab3aaf742bdb9fc4b9c5875fee7d769fa0581eeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87370 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88451 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin2-2/+1
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-10android hunspell: Hardcode the ReferenceOOoMajorMinor for version check.Jan Holesovsky1-0/+5
From some reason it fails to be read from the versionrc; and I'm not really eager to debug why... Without this, only the dictionaries that do not mention the OpenOffice.org-minimal-version are registered; which would be just 2 of them. Change-Id: I9fe0bc138eadbdcbe5e0d8231e7e90ef268163bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88219 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88366 Tested-by: Jenkins
2020-02-10android hunspell: Turn on the hunspell build on Android...Jan Holesovsky1-0/+8
...and try to register it for use - it's a bundled extension. The attempt to use the Android's native spell checking failed because the combination of gboard + google's spell checker makes every word in the app appear as if spelled correctly. I haven't found any easy way around that, so let's use hunspell instead; but for that, we need to make the bundled extensions work on Android. Change-Id: If6563e497f1d3085c26eda571567242b2c1f6181 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88217 Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88364 Tested-by: Jenkins
2020-02-08Fix typoAndrea Gelmini1-1/+1
Change-Id: If83a1a5cc7b6170579f852e735d0a94bdff2d9d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88252 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-07merge OpenGLZone and OpenCLZone into one generic codeLuboš Luňák2-2/+2
To be used also by Skia code to detect problems with Vulkan drivers. The watchdog does not handle OpenCL because neither did the original code, but also because OpenCLZone::hardDisable() called from it would deadlock on SolarMutex for some reason. Change-Id: I483d8cb0b11a4e1e65c564f4e4c29ab68843ff71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88008 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-06lok: calc: formula input bar: set text selection as requested by clientMarco Cecchetti2-1/+33
Change-Id: If04ed3c1637249329530a73d20df9b9296d1004e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88089 Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> Tested-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit 01f0d42f5ca9fb0e6e45b7bfcf51cb33c1a27bec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88117 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-05tdf#130080 soffice.sh: Avoid exporting empty LC_ALLMichael Weghorn1-2/+6
The previous way of doing LO_SAVE_LC_ALL="$LC_ALL" LC_ALL=C export LC_ALL # ... (call some tools,...) LC_ALL="$LO_SAVE_LC_ALL" resulted in the LC_ALL environment variable explicity being set to an empty string in case it was not set at all previously. For some reason, an LC_ALL explicitly set to an empty string (other than an unset LC_ALL) makes the system ICU on various Linux distributions assume an "US-ASCII" encoding, even if the locale is otherwise configured to be a UTF-8 one. Since the corresponding detection from ICU is used in the KF5/Qt stack, that resulted in the Plasma-native file picker assuming an ASCII-encoding, and thus having problems with files containing non-ASCII characters. To avoid this, don't export LC_ALL if unset or set to an empty string. A big thanks to frinring on IRC #kde-devel for the analysis of why the Plasma-native file picker is affected by LC_ALL being set to an empty string! I could also reproduce that the following sample program run with 'LC_ALL=' on KDE Neon Developer edition printed "US-ASCII" when using the system ICU, while it printed "UTF-8" when using a self-built ICU as of current master (commit d6b88d49e3be7096baf3828776c2b482a8ed1780) instead, but did not further investigate why: #include <unicode/ucnv.h> #include <iostream> int main() { std::cout << ucnv_getDefaultName(); } Change-Id: Idee88f200b6edecdb2633ed6e6fa70b370ffcf0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88003 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-02-04tdf#117331 Merge jurt and unoil into ridlSamuel Mehrbrodt5-12/+5
jurt.jar and unoil.jar are kept as effectively empty jars, each with a Class-Path: ridl.jar in their meta-inf/manifest.mf, so that 3rd-party code loading them (with or without also loading ridl.jar) will still have access to their content. Conceptually, the UNOIDL entities in unoil.jar (corresponding to module offapi) are not part of the URE, but are now made available by URE's ridl.jar. This should probably not cause problems in practice. At least for now, we seal exactly those packages in ridl.jar that were originally sealed in jurt.jar. Ideally, all of ridl.jar could be sealed now, but that would be mildly incompatible, as it would prevent 3rd-party code from introducing additional UNOIDL entities in the relevant namespaces (even if that is something we do not want 3rd-party code to do anyway). However, some JunitTest_jurt_* define classes in those sealed packages. In the past they got away with that by using gb_JunitTest_use_jar_classset,*,jurt. Instead they now need to gb_JunitTest_use_jar_classset,*,ridl and drop the gb_JunitTest_use_jar,*,ridl. But the former only makes available the classes that are specified in ridljar/Jar_ridl.mk with gb_Jar_add_sourcefiles, not the UNOIDL entities specified via gb_Jar_add_packagedirs. But the tests need the udkapi UNOIDL entities, so introduce gb_JunitTest_add_classpath to let the tests get them explicitly. (Curiously, JunitTest_jurt_uno and JnitTest_jurt_util use gb_JunitTest_use_jar_classset,*,jurt but don't seem to acutally need it; lets leave that for a follow-up clean up.) As a follow-up clean up, relevant files could be moved from jurt/ to ridljar/. Change-Id: I836f4e7bb47fb41f1306e3f223da90dba988eb9a Co-authored-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-04Log what UNO command we failed to dispatchTor Lillqvist1-1/+1
Change-Id: I79ed68a1e271d44f8afd2858c979a66691233fc7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87688 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit f92e4bed51de1625bc8fba2d7a432420db6841d0)
2020-02-03tdf#129917 Use temp user profile when installing shared extensionsSamuel Mehrbrodt3-8/+16
Change-Id: I62dd163758e6348a62fc8a0b25150a62f282de90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86543 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-01make update_pch also consider files in <module>/src/**/incLuboš Luňák4-69/+34
With --enable-pch=full there's not much difference between a "public" header in <module>/inc and a private one in <module>/src/somewhere/inc . And since the script searches recursively, this apparently helps to find even more headers for lower pch levels. Change-Id: I8483d0aa5b4fea5a59107c20a8aa5f1ef694af0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87799 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-31clang-tidy modernize-concat-nested-namespaceNoel Grandin15-15/+15
Change-Id: Iab35a8b85b3ba1df791c774f40b037f9420a071a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-29desktop: document what doc_iniUnoCommands() doesMiklos Vajna1-0/+6
Change-Id: I961e563d92c6fdb783942de4b295d5d8b1bf2db3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87701 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2020-01-28Dispose configmgr at the end of unopkgStephan Bergmann1-0/+6
...so that the configmgr::Components::WriteThread (configmgr/source/components.cxx) is joined well before exit. (This should solve the issue discussed at <https://gerrit.libreoffice.org/c/core/+/86543/3/ configmgr/source/writemodfile.cxx#564>, "tdf#129917 Use temp user profile when installing shared extensions".) Change-Id: I79004c2e7f839d80eda23eed2a1c5e8e660a58df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87592 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-28remove some unused local varsNoel Grandin1-2/+1
found by my new aggressive unused var plugin. these are unused return values from function calls Change-Id: I3359c583f535828f192cb833762dfedc008d82f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87439 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-25tdf#130137 Replace remaining uses of WNT define checks with _WIN32A_GAN4-7/+7
Change-Id: If95f1ea5a81de62eb4f725e5fcb30ccb8530062a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87372 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-24Fix iOS build after 3381e35ec2b567f0b85cce6192df11d0be9cdbe2Tor Lillqvist1-0/+6
Change-Id: I2b24d8850ea55b87e556c4faf77d61ad17f246db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87342 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-01-24desktop: fix Android buildMiklos Vajna1-0/+3
See <https://tinderbox.libreoffice.org/cgi-bin/gunzip.cgi?tree=MASTER&brief-log=1579871401.18121>. Change-Id: I5b5de185d22adb1c7ca6144f3fb4d083e7731402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87340 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-24tdf#42949 Fix IWYU warnings in desktop/Gabor Kelemen112-474/+158
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: If72377cb352be71050a5b0a471bbe3b02d9c0f74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87117 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-24loplugin:makeshared in cui..desktopNoel Grandin4-11/+11
Change-Id: I45b7381f665a749b86302be07fa095a30842428f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87277 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-23Logger should be initialized with local contextMike Kaganski1-4/+4
... otherwise its output will go to connected soffice, and will not reach the unopkg console, e.g. trying to execute unopkg add wrong_extension_name while an instance of soffice is running. Change-Id: Ic0b0c48f9b3e8be084e0fdd1838cb0614da6817e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87248 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23List more possible executable names returned by osl_getExecutableFileMike Kaganski1-21/+10
Change-Id: I2266b04ec0aabe60ba55a40b71aa7832bcf53bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87245 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23Use crt functions for IO in unopkg on WindowsMike Kaganski3-42/+12
Since https://gerrit.libreoffice.org/c/core/+/87210, the workaround using WinAPI is not needed anymore, so this unifies Windows behavior with other platforms. Change-Id: I0fa46b6b98a03a7e4d2fd1347b05c15b8f142607 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87221 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-23Make unopkg.com proper launcher for unopkg.bin on WindowsMike Kaganski10-597/+151
... like implemented in 506173a7f42f34821238a63f3f8c7362c9fae9d9 for soffice.bin. Previously unopkg.com prepared some communication pipes, and launched unopkg.exe, which in turn launched unopkg.bin (both GUI subsystem apps), and when the latter sent output to console, it was redirected to the pipes, and finally sent to console by unopkg.com (details in dropped desktop/win32/source/guistdio/guistdio.inc). The implementation made it impossible to use standard console output function from c/c++ standard libraries; WinAPI had to be used. Special API had been implemented for that: dp_misc::writeConsole*, and still part of output was garbled. Commit 015e9f780bc133788f79868bb7fb0b1d4e81f5f3 tried to workaround that, effectively making loghandler unusable outside of unopkg. This change makes unopkg.com a console subsystem clone of unopkg.exe, and unopkg.bin is now also console application. This allows to cleanup and unify its output in a follow-up commit. Change-Id: I3b299e09f8a11a72883b06442b0e95131ffaac5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87210 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-21unopkg: Improve error message displaySamuel Mehrbrodt1-4/+4
Change-Id: Ic842a3be82094557efde6cc22b11b6567c2ad85b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86519 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-16clang-tidy modernize-concat-nested-namespace in dbaccess..desktopNoel Grandin22-114/+40
Change-Id: I35a3d422fe020a08f6c2678097252334a3951f7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86848 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-27 07:31:42 +0000