summaryrefslogtreecommitdiff
path: root/desktop/inc
AgeCommit message (Collapse)AuthorFilesLines
2018-08-28Fix typo in codeAndrea Gelmini1-2/+2
To complete commit: e9fa088735bfbd34bc81f1925438691f746db070 It passed "make check" on Linux Change-Id: I2772b1ac5d4024bb11f3e09e24afc566b7091fb8 Reviewed-on: https://gerrit.libreoffice.org/59693 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-06-20lok: Unit test for jsonToPropertyValuesVector.Jan Holesovsky1-0/+6
Change-Id: I3e0623cc68838c650edbd03cc89bf3fcb8098ff8 Reviewed-on: https://gerrit.libreoffice.org/56149 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-04-19tdf#95843: Wait for fire_glxtest_process also in --headless modeStephan Bergmann1-0/+1
Discussed with mmeeks on IRC that fire_glxtest_process is probably called as early as possible so that its reuslt is ready by the time it is needed in the non-headless case. So best fix for headless is probably to just wait for the sub-process at an opportune point, instead of redesigning the whole mess so that fire_glxtest_process would only be called once its result is actually needed. Change-Id: I4ea9c9d54b83c9695a3b72317e68fed0c410da0e Reviewed-on: https://gerrit.libreoffice.org/53154 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-03lok: Make the bundled dictionaries work.Tamás Zolnai1-1/+1
Create the user directory temporary in the temp directory and use that to load the dictionaries (bundled extensions). Co-author; Jan Holesovsky <kendy@collabora.com> Change-Id: I5c7c824b68571048ce870fd5218cb47a333f3ad8 Reviewed-on: https://gerrit.libreoffice.org/49495 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-03-20drop unnecessary includesCaolán McNamara1-1/+0
Change-Id: I1a817d5575bbd57ecaa874a27158b9218e4210cc Reviewed-on: https://gerrit.libreoffice.org/51603 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-14Allow lok to re-set temporary paths on second init.Michael Meeks1-0/+2
Change-Id: I40cd0538b573c2d090f56424e1110b938981a878 Reviewed-on: https://gerrit.libreoffice.org/51292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-02delete colordata.hxxNoel Grandin1-1/+0
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann1-1/+1
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-23loplugin:includeform: desktopStephan Bergmann1-1/+1
Change-Id: I2dacb21cd0c9618dadb49912e0f09c9ab576f9b0
2017-10-22oss-fuzz: drop our own afl related hackeryCaolán McNamara1-5/+0
Change-Id: Ia6a498c07fffd1790ad433287ef4d1cf82085887 Reviewed-on: https://gerrit.libreoffice.org/43695 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22Fresh run of bin/update_pch.shMike Kaganski4-22/+49
Change-Id: I69d4157aaf6570cecd51ea59df20556914942e06 Reviewed-on: https://gerrit.libreoffice.org/42565 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-08-01move resmgr to unotoolsCaolán McNamara3-6/+4
and the vast majority of translations is to the ui language so default ctor with that arg and now drop OModuleResourceClient Change-Id: I3b85a560ffdfe5f019c2271ac56a5fe4a361522b
2017-07-21migrate to boost::gettextCaolán McNamara7-169/+209
* all .ui files go from <interface> to <interface domain="MODULE"> e.g. vcl * all .src files go away and the english source strings folded into the .hrc as NC_("context", "source string") * ResMgr is dropped in favour of std::locale imbued by boost::locale::generator pointed at matching MODULE .mo files * UIConfig translations are folded into the module .mo, so e.g. UIConfig_cui goes from l10n target to normal one, so the res/lang.zips of UI files go away * translation via Translation::get(hrc-define-key, imbued-std::locale) * python can now be translated with its inbuilt gettext support (we keep the name strings.hrc there to keep finding the .hrc file uniform) so magic numbers can go away there * java and starbasic components can be translated via the pre-existing css.resource.StringResourceWithLocation mechanism * en-US res files go away, their strings are now the .hrc keys in the source code * remaining .res files are replaced by .mo files * in .res/.ui-lang-zip files, the old scheme missing translations of strings results in inserting the english original so something can be found, now the standard fallback of using the english original from the source key is used, so partial translations shrink dramatically in size * extract .hrc strings with hrcex which backs onto xgettext -C --add-comments --keyword=NC_:1c,2 --from-code=UTF-8 --no-wrap * extract .ui strings with uiex which backs onto xgettext --add-comments --no-wrap * qtz for gettext translations is generated at runtime as ascii-ified crc32 of content + "|" + msgid * [API CHANGE] remove deprecated binary .res resouce loader related uno apis com::sun::star::resource::OfficeResourceLoader com::sun::star::resource::XResourceBundleLoader com::sun::star::resource::XResourceBundle when translating strings via uno apis com.sun.star.resource.StringResourceWithLocation can continue to be used Change-Id: Ia2594a2672b7301d9c3421fdf31b6cfe7f3f8d0a
2017-07-19loplugin:constparams in desktopNoel Grandin1-1/+1
Change-Id: Idba3acbd1e6ad5e1ce1cae9f80f764906ab8b143 Reviewed-on: https://gerrit.libreoffice.org/40157 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-15emfplus: create a wmf/emf/emf+ primitive based importerArmin Le Grand1-1/+1
First steps to organize an importer that can read/interpret wmf/emf/emf+ and deliver a primitive representation for the content by parsing it. Use the same mechanisms as already applied for Svg, so to reuse abilities to keep original binary data to allow save again and embedding in files and have an implemented replacement bitmap based representation. For this, unify the used helper classes to handle more than just Svg. For 1st try, add test code and static bool switches Change-Id: I6e0a82943541d811a8f8d65a84115569fcd8cee7
2017-06-18remove unused osl/mutex.hxx includesJochen Nitschke1-1/+0
Change-Id: I3b50e45fdb99e9cd8bfda07356ee3ddb4dd0f8bb Reviewed-on: https://gerrit.libreoffice.org/38905 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-06-15use more SAL_N_ELEMENTS part 3Noel Grandin1-2/+0
Change-Id: I82e366fefd2e31928b99840fe76649cc3521e623 Reviewed-on: https://gerrit.libreoffice.org/38789 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-06-12cleanup unused css/frame/* includesJochen Nitschke1-1/+0
Change-Id: I173a29fd1ee889127369d2bc2fce8e010b89ca65 Reviewed-on: https://gerrit.libreoffice.org/38633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-26tdf#36019: Dynamically enable/disable extension removal via GUIMuhammet Kara1-0/+1
Now extension removal via the Extension Manager dialog can be dynamically enabled/disabled from the expert configurations. This doesn't affect the unopkg commands. Change-Id: I2b718d48977ca18cc3d808e98cf7804d4a47dcff Reviewed-on: https://gerrit.libreoffice.org/37990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-05-24tdf#36019: Dynamically enable/disable extension installation via GUIMuhammet Kara1-0/+1
Now extension installation via the Extension Manager dialog can be dynamically enabled/disabled from the expert configurations. This also affects the installation by double-clicking the extension file in the file manager, but doesn't affect the unopkg commands. Change-Id: I70c2c83c2458115b366c7fdcc06f72e11df4726b Reviewed-on: https://gerrit.libreoffice.org/36688 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2017-05-19make string translation loading more uniformCaolán McNamara1-6/+3
change various ResId classes that use conversion operator to OUString to functions that return a OUString drop various defines drop unnecessary toString calls Change-Id: Ibeccdf2b91a46a2ed5b4b74e6024e301a023bc92 Reviewed-on: https://gerrit.libreoffice.org/37817 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-19improve update checker and update downloader codeMarkus Mohrhard1-0/+3
2017-04-30untranslated strings are just stringsCaolán McNamara1-0/+17
Change-Id: Ic7247a6d0e702572ca304bb048bfabfafcbf7505
2017-04-25remove desktop bitmaps from .src filesCaolán McNamara2-6/+21
Change-Id: I32aefdf3407434564ed7efe2f6785a17c69199f2 Reviewed-on: https://gerrit.libreoffice.org/36956 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-25errinf.hxx moved out of tools and into vcl moduleChris Sherlock1-1/+1
ErrorInfo has a hard depency on VCL, yet is in the tools package. It is more appropriate to have it reside in the VCL module. Change-Id: Ica54a46c3a7f86cf0331ed7245234bea69c05650 Reviewed-on: https://gerrit.libreoffice.org/36839 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-20loplugin:unusedmethodsNoel Grandin1-1/+0
Change-Id: Ib7a9b1b0802ca751da258065e89b412b090bb672 Reviewed-on: https://gerrit.libreoffice.org/36718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-29Fix typosAndrea Gelmini1-1/+1
Change-Id: I379c3f8ca971e6180744fb7270dde9164ebcec1a Reviewed-on: https://gerrit.libreoffice.org/35814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-28Fix typosAndrea Gelmini1-1/+1
Change-Id: Ibef75de246fb31884153437fe8c05e299fe5962f Reviewed-on: https://gerrit.libreoffice.org/35782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-03-24lok: Allow setting of the language during load.Jan Holesovsky1-0/+5
Change-Id: I9dbb62950e639376c26122ceb9fcec2982b3ca82
2017-03-03Remove redundant 'inline' keywordStephan Bergmann1-1/+1
...from function definitions occurring within class definitions. Done with a rewriting Clang plugin (to be pushed later). Change-Id: I9c6f2818a57ccdb361548895a7743107cbacdff8 Reviewed-on: https://gerrit.libreoffice.org/34874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-31Revert "Lok: support for batch API calls"Jan Holesovsky1-4/+0
This was for the moment removed from the online.git, so let's disable the API bits too before it shows this is really necessary. Reverts also: Revert "Lok: unittest batch API" Change-Id: I7bf3fe62d1e73b6f233992d51f587868a78f4bec
2017-01-23Lok: support for batch API callsAshod Nakashian1-0/+4
Mouse and keyboard operations typically come in batches, and often each results in tile invalidations and/or layout modifications. Processing each input event on its own, then processing the resulting output event is very costly and unecessary when we know there is more of the same. The new API adds support for batching such related input events by disabling the output events generated by Core until the batch is done. The client can then process the resulting events, which will be compressed and deduplicated. Change-Id: Id381dab807186d010021a8778ee440074a739920 Reviewed-on: https://gerrit.libreoffice.org/33402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-01-18d*: load BitmapEx resources instead of Image onesCaolán McNamara1-4/+4
Change-Id: Ibf741af5e5043fae6139a19cec3d244dee06f225
2017-01-18XPackageTypeInfo::getIcon is uselessCaolán McNamara1-9/+0
nothing in LibreOffice calls it, and anything external would get a resource id which is useless to anything except LibreOffice internals Change-Id: I9d6d91a047da64dc98b556ae46fc86d84cf774f4
2017-01-02tdf#95416 Get rid of #include ../foo/bar.hxx style includesGaurav Dhingra1-2/+2
Change-Id: I9b05c261faebd3e0e5d65ca524a4379c1d5918f1 Reviewed-on: https://gerrit.libreoffice.org/32419 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-12-21tdf#95416 Fix an include for 2 files in unopkgHuzaifa Iftikhar2-0/+142
Change-Id: Id1fa09b6db6c90cd727182133e5f9f39383aa5e5 Reviewed-on: https://gerrit.libreoffice.org/32255 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-20tdf#95416 Fix an include for desktop directoryHuzaifa Iftikhar1-0/+164
Change-Id: I04a2181b05f2b15a55db306f49b47855db7753db Reviewed-on: https://gerrit.libreoffice.org/32204 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2016-11-09loplugin:expandablemethods in dbaccessNoel Grandin2-10/+1
Change-Id: I6087a3eff46926646ac1637615a0af30b38956a4 Reviewed-on: https://gerrit.libreoffice.org/30712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-06drop unused STD_MASKCOLOR definesCaolán McNamara1-3/+0
Change-Id: I9e6d499788467e5215464cf8f5146721b847909c
2016-10-05Remove _TYPED suffix from tools/link.hxx macrosStephan Bergmann1-4/+4
...which was introduced with 3ead3ad52f9bb2f9d1d6cf8dfc73a0a25e6778ed "Gradually typed Link" to distinguish the new, typed versions from the old, untyped ones, but is no longer necessary since 382eb1a23c390154619c385414bdbe6f6e461173 "remove untyped Link<>" removed the old versions. Change-Id: I494025df486a16a45861fcd8192dfe0275b1103c
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann2-2/+2
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-10LOK: new callback dropping implementationMarco Cecchetti1-0/+5
Now view callbacks have their own collection of last states where the key is made up by both the view id and the callback type. Callback dropping based on the last state is no more handled on queueing but on flushing, since what really matters is the last performed callback (for each callback type). Anyway in order to not modify the order of callbacks, that could be changed when an already queued callback is superseeded, dropping still occurs on queuing too, just by looking for the last queued callback of the same type. The result is a substantial reduction of redundant callbacks and fix the following problem in loleaflet: when there are more views for a speadsheet and cell cursors for two view are placed on the same cell, a continuos swapping between the two cell cursors can occur. That was due to a sequence of "EMPTY" and coordinates messages or cell cursor and cell view cursor messages which were sent in an alternating way. Change-Id: I79e14d11d4e8590aff715181e3410ad88c4e6175 Reviewed-on: https://gerrit.libreoffice.org/28783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-09-10LOK: tidy up `CallbackFlushHandler::queue`, improved cell view cursorMarco Cecchetti1-2/+4
Rewritten the switch statement in `CallbackFlushHandler::queue`: - Now, the new callback data is emplaced after removing all states overridden by the new one. - View callbacks are checked not only for the same type but even for the same view id: that allowed to fix the following issue: starting from the 3rd view for a spreadsheet it could occur that only the cell cursor of the previous last view was displayed in the new view. Change-Id: I2b63526deb4dca39e3a1f430443ebc5d0f61938d Reviewed-on: https://gerrit.libreoffice.org/28782 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2016-08-31LOK: queue-up events while processing client callsAshod Nakashian1-2/+11
To prevent feedback effects and improve performance, we now queue up events fired during the processing of a client call on the LOK API. This has the advantage of giving us a chance to compress redundant events and to combine others (where possible) into fewer ones. Change-Id: I2f6ea12c5d85205e6495cb130f6a6262534b6bb2 Reviewed-on: https://gerrit.libreoffice.org/28311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-07-12desktop: validate OpenCL drivers before use.Michael Meeks1-0/+1
OpenCL validation needs to happen before drivers are used in anger. This should isolate any crashes, and/or mis-behavior to We use app version, CL driver version and file time-stamp to trigger re-testing the device. If anything fails: hard disable OpenCL. We use an opencl validation sheet (cl-test.ods) and install it. It is a minimal CL set - it requires a very short formula group length, and combines several CL functions into few formulae to test more. The sheet structure, in particular the manual squaring / SQRT is necessary to stick within the default CL subset, and ensure that formulae are CL enabled from the root of the dependency tree up. Change-Id: I18682dbdf9a8ba9c16d52bad4447e9acce97f0a3 Reviewed-on: https://gerrit.libreoffice.org/27131 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-06-16sw lok: move filtering of callbacks during paint to desktopMiklos Vajna1-1/+2
This will be important when in the per-view case SwViewShell::libreOfficeKitCallback() won't be called anymore; as pointed out by online.git's TileCacheTests::testSimpleCombine() test. Change-Id: Ie68f8c51facdba127763df660e9220f820805ecc Reviewed-on: https://gerrit.libreoffice.org/26372 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09desktop lok: implement per-view CallbackFlushHandlerMiklos Vajna1-1/+1
With this, per-view cursor callbacks work again, as they did after commit 32f419fee5f9df4facb7a9b3ec910471d2a20247 (sw: implement per-view LOK_CALLBACK_CURSOR_VISIBLE, 2015-09-18). Change-Id: Ic589276f99164a1a8d46f7a029d1a59ab6e971f3 Reviewed-on: https://gerrit.libreoffice.org/26102 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-06-09desktop lok: move CallbackFlushHandler impl details out of headerMiklos Vajna1-191/+10
To reduce the amount of rebuilt code when changing something there. Change-Id: I8f3c18c29d5c08d70910ee2b204cafb99d6b4011 Reviewed-on: https://gerrit.libreoffice.org/26088 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-29bccu#1781: Impress/Comments - selection not updated on deleteAshod Nakashian1-1/+3
Change-Id: I694d76785fcf6ec9c158c34cbe07f4d1f2c7a41d Reviewed-on: https://gerrit.libreoffice.org/25219 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b95e4e8681c9cefb4e1d4177192164e041baf9d9) Reviewed-on: https://gerrit.libreoffice.org/25428 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: don't filter cursor visibility during paintingAshod Nakashian1-1/+2
Change-Id: Ia44ffe08dc8f46e0d10a73db374a283eb032f771 Reviewed-on: https://gerrit.libreoffice.org/25120 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f805637353e4463d5b64f1b010bb580e191bd3aa) Reviewed-on: https://gerrit.libreoffice.org/25427 Tested-by: Jenkins <ci@libreoffice.org>