summaryrefslogtreecommitdiff
path: root/dbaccess
AgeCommit message (Collapse)AuthorFilesLines
2013-03-01coverity#705107: use of invalid iteratorMarkus Mohrhard1-1/+1
Change-Id: I2f36090f7d1b009466a973f3795c668f001063c2
2013-02-28regenerate pchPeter Foley1-0/+1
Change-Id: I130bfbeaf8723f0f9ee38051c8acf32cb7f5ba85
2013-02-28remove all d.lstMichael Stahl1-0/+0
Change-Id: Icba4218c5f9fe89d183d25ea82a8eae52881f885
2013-02-28fdo#61203 initialise m_aComposedTableName *before* trying to use itLionel Elie Mamane2-2/+4
Change-Id: Ie7a19bdfe9e7bc729a62191362ce0779d73385a0
2013-02-28fdo#38838, String to OUString in module dbaccess/source/sdbtools/connectionGergő Mocsi2-21/+21
Replaced String to OUString, plus deleted deprecated macro RTL_CONSTASCII_USTRINGPARAM Change-Id: I4464644df8c42692aed7cb078b5f77c482e615f4 Reviewed-on: https://gerrit.libreoffice.org/2380 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-28fdo#39468: Translate German commentsDavid Verrier1-21/+21
Change-Id: I29619fab12ae22bda6a8f325eece63d777b0470b Reviewed-on: https://gerrit.libreoffice.org/2468 Reviewed-by: Michael Meeks <michael.meeks@suse.com> Tested-by: Michael Meeks <michael.meeks@suse.com>
2013-02-27janitorial: simplify test expression without semantics changeLionel Elie Mamane1-1/+1
The "sComposerFilter != m_sRowSetFilter" could not influence the result. Proof. The right hand-side of the || is evaluated only when m_sRowSetFilter.isEmpty() So the only case where the removed test could have an influence is when m_sRowSetFilter.isEmpty(). However, the right hand-side of the && is evaluated only when !sComposerFilter.isEmpty(). We have m_sRowSetFilter.isEmpty() and !sComposerFilter.isEmpty(). In particular, (sComposerFilter != m_sRowSetFilter) is true. Qed. Change-Id: I1484d78cf2d7a5e8ca44f382eb7c440c84d8c10e
2013-02-27fdo#51976 make "refetch one row" query easier to optimiseLionel Elie Mamane4-62/+134
Instead of playing tricks with parameters that when filled in force a part of the WHERE clause to have not influence, actually use several different statements and hardcode in each the kind of test to be done Change-Id: I93e1978f0420bc627a02291f209c788b9b4f2e96
2013-02-27janitorial: save one objectLionel Elie Mamane1-3/+1
Change-Id: I52b7d8204bb2d34639dea544833318fe86a5ddcf
2013-02-27janitorialLionel Elie Mamane1-9/+9
- more const qualifiers - remove unnecessary cast - don't hardcode magic number (length of hardcoded string) Change-Id: Id8165ec556c913213b5be22c731b78f6b325f22c
2013-02-27spelling in commentsLionel Elie Mamane1-3/+3
Change-Id: I3a7df167a91dd6ef845d16d5e6cf46ff5a82d455
2013-02-26fdo#38838 Replaced some use of (Xub)String with OUString.Jean-Noël Rouvignac4-27/+12
Change-Id: I5a8f2d1a5762c20d21d31b04778a9e2cac8df9cb Reviewed-on: https://gerrit.libreoffice.org/2364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-26Translated German comments and some messages into EnglishDavid Verrier1-61/+60
Change-Id: I2d92db30bacc52d487df2a0a118b430bc3425f69 Reviewed-on: https://gerrit.libreoffice.org/2427 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-26String::SearchAndReplaceAllAscii() corresponds to OUString::replaceAll()Tor Lillqvist1-5/+5
The code originally used the former methods, so now when it has been changed to use OUStrings instead, it should use the latter. (I don't know if it is significant in the presumably quite specific use cases here.) Change-Id: I83cc7c602f376784054f479668171ccfa7f478f7
2013-02-26WaE: ignoring return valueTor Lillqvist1-5/+5
Change-Id: Ib445acdb01808cf5d05cd29973b568956d717e61
2013-02-26German comment translated to EnglishDavid Verrier1-1/+1
Change-Id: I8f4686e89a068a4392cff013de31f429be88e2b9 Reviewed-on: https://gerrit.libreoffice.org/2423 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-26fdo#38838, String to OUString in dbaccess/source/ext/macromigrationAuthor: Gergő Mocsi14-76/+76
String to OUString applied in dbaccess/source/ext/macromigration module. Also, RTL_CONSTASCII_USTRINGPARAM is removed from files, plus ::rtl::OUString replaced by OUString. Change-Id: I31673c7d812992dbac675a5d7da5bf379c402a9c Reviewed-on: https://gerrit.libreoffice.org/2379 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-26fix WaEDavid Ostrovsky1-1/+1
Change-Id: I1bbac4de97866695bf73e25977af8306014325fc
2013-02-25Database: Add Limit in Query Desing ViewZolnai Tamás12-4/+472
Levels of implementation - Add a new toolbar item to ui (designobjectbar.xml) - Make a control for this element( LimitBox: derived from NumericBox) - Make an own controller for this control (LimitBoxController) and register it - Add new feature to the general\central controller (OQueryController) and construct a communication channel between the two controller - Modify the view switching (SQL<->Design) methods to use\set limit value (QueryDesignView.cxx) Conflicts: dbaccess/source/ui/querydesign/QueryDesignView.cxx Change-Id: I0eb09d1d40cfdb9b8a2a57ab8911faca91d5e690 Reviewed-on: https://gerrit.libreoffice.org/1994 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2013-02-25remove some trivial duplicatesThomas Arnhold1-1/+0
Change-Id: Ie736cb6d5ff7f4d1998338f4a3a3a3b0a67c79ad
2013-02-25RTL_CONSTASCII_USTRINGPARAM and ::rtl:: removalsKrisztian Pinter21-487/+453
Conflicts: cui/source/options/optgdlg.cxx cui/source/options/webconninfo.cxx dbaccess/source/ui/app/AppController.cxx Change-Id: I2abfad91318e8be8c0f77909cbd76825cdca9b85 Reviewed-on: https://gerrit.libreoffice.org/2350 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-25remove duplicate lineThomas Arnhold1-1/+0
This came in with 3ecdcbaee0a906bc0d1700f60a4d360f4f51291c and is apparently wrong. Change-Id: Ic048d20c728aca2f8c97a90ede74d77e51b16e1c
2013-02-25fdo#38838,::rtl::OUString_to_OUStringelixir1-185/+185
Change-Id: I7c9ebd01c16ff066008e53de865560ad78215bab Reviewed-on: https://gerrit.libreoffice.org/2330 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-25loplugin: unused variablesThomas Arnhold20-61/+0
Change-Id: I46a748bf2c54d15c0f5718901197f3b4c34b82bf
2013-02-25loplugin: unused variableThomas Arnhold2-6/+4
First parameter is unused since fb98c33c688ef479a64f9838abd63f617fd4b589 Change-Id: Iff9ff51227c5244950830febf2cdcf78e1de4d29
2013-02-24fdo#38838 searched, replaced and removed String::CreateFromInt32().Jean-Noël Rouvignac9-16/+16
I ran the following code replace: s/(Uni|Xub)?String\s*::\s*CreateFromInt32/OUString::number/ And finally removed String::CreateFromInt32(). Change-Id: I53b26a59c68511ae09f0ee82cfade210d0de3fa5 Reviewed-on: https://gerrit.libreoffice.org/2279 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-02-23Fix typo recieved/receivedJulien Nabet1-1/+1
Change-Id: I0c838f5c06ff26149113a9bbab970d314758c648
2013-02-23Fix typo seperated/separatedJulien Nabet1-1/+1
Change-Id: I133423de994b1befe246b6c921802428a3528202
2013-02-23Fix typo "teh" -> "the"Julien Nabet2-2/+2
Change-Id: Iacfeb4a0c2bff254e5bcc8d58582994cd0f3993a
2013-02-22fix strings more in 1da3af5f1eb6a32fd0ab10da7cf2f8ddb298a3a1Michael Stahl1-12/+14
Change-Id: I7d4cf698721fcf972bf35babb6d53369719eed18
2013-02-22fix string conversion 1da3af5f1eb6a32fd0ab10da7cf2f8ddb298a3a1Michael Stahl1-3/+4
Change-Id: I18f80b5fd6aa11ed78fe2b1bee3cb9f843cf203e
2013-02-22[Uu]sefull -> [Uu]sefulJulien Nabet1-1/+1
Change-Id: I5dad83789ff9b6815561208679a5e19821041e1f
2013-02-22unused local variableAndras Timar1-1/+0
Change-Id: I8d8019b6947c1f989d897389379f2b6bb396cfbb
2013-02-22fdo#38838, ::rtl::OUString, String to OUStringGergő Mocsi18-575/+568
I have cleared out String and ::rtl::OUString calls in module dbaccess/source/core/misc. It was mainly file dbaccess/source/core/misc/dnstypes.cxx , and it's usages. There are still some calls in dbaccess for this class(ODnsTypeCollection), that needs refactoring (eg. in file DbAdminImpl.cxx, method "String ODbDataSourceAdministrationHelper::getConnectionURL() const"). Remaining calls will be my next task (in module dbaccess). I also clear out deprecated macro RTL_CONSTASCII_USTRINGPARAM every time I find one. The class I've mentioned above (ODnsTypeCollector) is OK. Change-Id: Ia0f3bb8cc649d1ecf8decc093f8a1a20ee23c33c Reviewed-on: https://gerrit.libreoffice.org/2289 Reviewed-by: Andras Timar <atimar@suse.com> Tested-by: Andras Timar <atimar@suse.com>
2013-02-22s/the the/the/Tor Lillqvist10-10/+10
Change-Id: Iadacffaad832c6ff06757e8567e24f929f24a4c3
2013-02-22s/whith/with/Tor Lillqvist1-3/+3
Change-Id: I23da81c182ad30faf871d98e55820295418207d0
2013-02-21Fix type unkown -> unknownJulien Nabet1-1/+1
Change-Id: I8d55d5ae5ae38ae2b252859b5400e36301f19ef0
2013-02-21generic integers to enumsLuboš Luňák1-1/+2
Change-Id: Ic43283b9e1666c0f2162e277dc79fc6f992ef616
2013-02-19fdo#38838, ::rtl::OUString to OUString, String to OUStringGergő Mocsi3-110/+105
::rtl::OUString was replaced to OUString and all occurences of String was replaced to OUString in dbaccess/source/core/api Change-Id: I9771708408e04dcebe18f49a75c83036740f0ca2 Reviewed-on: https://gerrit.libreoffice.org/2239 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-02-13update pch headers, broken by 1aaf9a9Luboš Luňák1-0/+2
2013-02-12fdo#46808, convert xmloff module code to use XComponentContextNoel Grandin4-10/+21
with lots of repurcussions in other modules Change-Id: I6982671eecc701b06cf85d93533e1fe618044fea
2013-02-11fdo#46808, convert io::TextOutputStream service to new-styleNoel Grandin1-12/+6
Change-Id: I12af47afc21c2b646197893a77698f4e0818f94f
2013-02-11fdo#46808, convert io::TextInputStream service to new styleNoel Grandin1-8/+8
Change-Id: Ida4abdd6587399aa8ade88af672bcb23ab7ea0f1
2013-02-11fdo#46808, Use service constructor for awt::DialogProviderNoel Grandin1-8/+5
Change-Id: I5d0a3e66afeadafa6d53ff0a255d036b7e3d528d
2013-02-11fdo#46808, Adapt document::XML*BasicExporter UNO services to new styleNoel Grandin2-8/+17
The services are document::XMLBasicExporter document::XMLOasisBasicExporter Change-Id: Ifd93e5735cae94d34904d79769cdb3edf587fe43
2013-02-11fdo#46808, Adapt java::JavaVirtualMachine UNO service to new styleNoel Grandin7-18/+17
Change-Id: Ib0329b9cdc4290ce98c4182e8466c1b44b408341
2013-02-07Fix busted multi-repeated column in evolution database viewCaolán McNamara1-0/+12
In the evolution address book where we have real column names of e.g. first_name, second_name and city. On parsing via OSQLParseTreeIterator::appendColumns that creates some labels using those real names but the evo XResultSet gives them proper labels of First Name, Second Name and City the munge means that here we have e.g. just "City" as a label because it matches, while the others don't The symptoms are to load the evolocal.odb and of the 128 columns column 5 is repeated until 128 This is all a horrible confusing mess. It seems safest to catch the mismatch of column counts and throw away the partial list and force a generate of a full list. Change-Id: I1d6e2a282bdd43acac63c366eb2a9d029aa17878
2013-02-06remove obsolete hidother.src filesAndras Timar1-387/+0
Change-Id: Ieb30afd81d16d184e0276ce7699b848f26a00013
2013-02-05ORowSetValue: clean up sign/unsigned union memberDavid Ostrovsky1-2/+2
Also switch BOOLEAN constructor from sal_Bool to bool. old/new signed/unsigned storage situation: ------------------------------------------------------- SQL type | signed | unsigned old | unsigned new ------------------------------------------------------- TINYINT | sal_Int8 | sal_Int16 | sal_uInt8 SMALLINT | sal_Int16 | sal_Int32 | sal_uInt16 INTEGER | sal_Int32 | sal_Int64 | sal_uInt32 BIGINT | sal_Int64 | pValue (String*) | sal_uInt64 ------------------------------------------------------- When sticking an UNSIGNED TINYINT into an Any, silently promote it to UNSIGNED SMALLINT (that is sal_uInt16), else Any would take it as a sal_Bool and normalise to sal_True (1) or sal_False (0). When constructing an ORowSetValue from a sal_Bool, silently keep it as an unsigned 8 bit integer (that is understand it as a sal_uInt8). This will work in most cases, since when asked back for a bool or sal_Bool, we'll give back the right value. Only code looking at the type tag could possibly make a "wrong" decision. The main (hopefully only?) path through which this would happen is through an implementation of XParameters::setBoolean XRowUpdate::updateBoolean that would use its sal_Bool argument to construct an ORowSetValue. So make sure each implementation constructs a proper BOOLEAN so as not to get confused. For authorship/copyright purposes, this patch is a cooperation between Lionel Elie Mamane <lionel@mamane.lu> and David Ostrovsky <david@ostrovsky.org> Change-Id: I3f1f08716127147f077bff4edb6ec558b1b09e09
2013-02-04use OUString(Buffer) in class EditChr. Rossmanith5-15/+15
replaced Len() with isEmpty() where appropriate Change-Id: I5a5847d6055f376fd5f86079aa1736541d790fff Reviewed-on: https://gerrit.libreoffice.org/1892 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>