summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2019-09-27cid#1453996 Unchecked return valueCaolán McNamara1-4/+3
Change-Id: I0b5010aec8ad941d662e851833923a8b6b0a383d Reviewed-on: https://gerrit.libreoffice.org/79672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Deduplicate O(U)StringNumber definitions; add toAsciiUpperCaseMike Kaganski1-3/+3
Change-Id: I00e7ce62940907b5f4efc2b7f23f355c3e43ed6b Reviewed-on: https://gerrit.libreoffice.org/79686 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-09-27cid#1453994 Uninitialized pointer fieldCaolán McNamara1-8/+0
Change-Id: Ife94e1e8861f108cd6db54694232c7686f47dc6e Reviewed-on: https://gerrit.libreoffice.org/79671 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-27Fix Typo SvxMenuConfigPage -> SvxConfigPageStephan Bergmann1-1/+1
...introduced with ccb2b0078f07194befa61f1e3fd88e53ff236871 "weld SvxMenuConfigPage/SvxToolbarConfigPage", causing -fsanitize=dynamic-type- mismatch during UITest_writer_demo: > include/tools/link.hxx:163:10: runtime error: downcast of address 0x613000204b40 which does not point to an object of type 'SvxMenuConfigPage' > 0x613000204b40: note: object is of type 'SvxConfigPage' > 83 01 00 4e b0 a1 bb 2e f6 7f 00 00 20 c4 56 00 e0 60 00 00 50 f8 a4 00 40 60 00 00 e8 49 38 00 > ^~~~~~~~~~~~~~~~~~~~~~~ > vptr for 'SvxConfigPage' > #0 in SvxMenuConfigPage* tools::detail::castTo<SvxMenuConfigPage*, SvxConfigPage*>(SvxConfigPage*) at include/tools/link.hxx:163:10 > #1 in SvxConfigPage::SvxConfigPage(weld::Container*, weld::DialogController*, SfxItemSet const&) at cui/source/customize/cfg.cxx:997:41 [...] Change-Id: Ie36ebabd3075cade590cc504fb06b5319b346dcf Reviewed-on: https://gerrit.libreoffice.org/79666 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27cid#1453993 Unchecked return valueCaolán McNamara1-1/+3
Change-Id: Ie30e1b40b8867246c793294b7b34b38a86f9ad01 Reviewed-on: https://gerrit.libreoffice.org/79670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26TODO rename to GetFrameWeldCaolán McNamara29-111/+111
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180 Reviewed-on: https://gerrit.libreoffice.org/79560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26drop unnecessary includes and update pchCaolán McNamara1-2/+0
Change-Id: Id7fa7d5b95c32fdc738a18208eb95eaec102d937 Reviewed-on: https://gerrit.libreoffice.org/79523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26now drop TabPageParent intermediateCaolán McNamara116-572/+565
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara115-1016/+425
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-25SmartArt Edit UI: remove nodeGrzegorz Araminowicz3-2/+33
Removes data node from data model including associated presentation nodes, transition nodes and all connections between them (child-parent and presentation-of). It still doesn't update order of remaining connections after removal, so empty entries can happen. Additional step is needed or using better data structures. Change-Id: I96e0752b6ec5a19ae8e972dbd421314e6c442b53 Reviewed-on: https://gerrit.libreoffice.org/79279 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-09-24copy to clipboard without intermediate vcl::WindowCaolán McNamara1-1/+1
Change-Id: I36d26e583e08ef66564e232b54fa00a468a280c6 Reviewed-on: https://gerrit.libreoffice.org/79453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24get environment RTL mode without vcl::WindowCaolán McNamara1-1/+2
Change-Id: Iec6ffe6e5012b6853b4190f3172cbb9b0d0cc913 Reviewed-on: https://gerrit.libreoffice.org/79451 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24use GetDefDialogParent as an arbitrary parent for temp widgetCaolán McNamara1-1/+2
Change-Id: I7226481c7d501c88ac937760ba464b1b11260f7e Reviewed-on: https://gerrit.libreoffice.org/79452 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24set correct parentCaolán McNamara5-12/+13
Change-Id: I133cccc72896021c38f90efa3f9819fd5410d836 Reviewed-on: https://gerrit.libreoffice.org/79419 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24getDrawPreviewOptimalSize can take an OutputDevice argCaolán McNamara4-4/+4
Change-Id: Ifb36166b153858ca7e32974e9b297e583b66c256 Reviewed-on: https://gerrit.libreoffice.org/79444 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24should use the controller hereCaolán McNamara4-5/+5
Change-Id: Ic6a97c0032521bf7099ba1ef9a1ab196d50e0894 Reviewed-on: https://gerrit.libreoffice.org/79445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24now guaranteed to have a controller and not a vcl::DialogCaolán McNamara1-3/+0
Change-Id: Ic8ba0234d4b2e13d59d743e6f03a229756484131 Reviewed-on: https://gerrit.libreoffice.org/79442 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24LogicToLogic is a static memberCaolán McNamara2-7/+7
Change-Id: If87f2c6d89c14a92f7222ed040696186583c73e2 Reviewed-on: https://gerrit.libreoffice.org/79443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24support O(U)String::number() for fast string concatenationLuboš Luňák1-3/+3
When I did the fast string concatenation, I didn't add any support for number(), which simply returned a O(U)String, and so it did the extra allocation/deallocation, although that could be avoided. In order to support this, number() now returns a special temporary return type, similarly to O(U)StringConcat, which allows delaying the concatenation the same way. Also similarly, the change of the return type in some cases requires explicit cast to the actual string type. Usage of OString::getStr() is so extensive in the codebase that I actually added it to the helper class, after that it's only relatively few cases. Change-Id: Iba6e158010e1e458089698c426803052b6f46031 Reviewed-on: https://gerrit.libreoffice.org/78873 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-24replace LogicToPixel uses in SfxTabPagesCaolán McNamara1-2/+4
Change-Id: Ic1a132113b343d7253533763df5f3371d3b672e4 Reviewed-on: https://gerrit.libreoffice.org/79446 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24remove SvxLineEndDefTabPage::ResizeCaolán McNamara2-8/+0
Change-Id: I70128f34ab1ab56ec4f99a5533606bd1d49561c8 Reviewed-on: https://gerrit.libreoffice.org/79439 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24get text colour without vcl::WindowCaolán McNamara1-1/+3
Change-Id: Ib1a9d438de9a310cf101aeda37f36a791b86ec76 Reviewed-on: https://gerrit.libreoffice.org/79438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24approximate_char_width -> get_approximate_digit_widthCaolán McNamara1-1/+1
Change-Id: Ic78d4d9ec6a7604085903b347a7a06926ab8d983 Reviewed-on: https://gerrit.libreoffice.org/79437 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24options dialog has a controller nowCaolán McNamara2-2/+2
Change-Id: I34b486ba54c361401327dbe8fcee007da4ca72c1 Reviewed-on: https://gerrit.libreoffice.org/79426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-24unused aControlSize variableCaolán McNamara1-3/+0
Change-Id: I59b8bb107ac40c15a027426ece916d0b6713407b Reviewed-on: https://gerrit.libreoffice.org/79425 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23Resolves: tdf#127683 options dialog has a controller nowCaolán McNamara1-2/+2
Change-Id: I1143bb27f524960e44aa2cdb76f063a9b93d42be Reviewed-on: https://gerrit.libreoffice.org/79415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23config dialog uses a controller nowCaolán McNamara1-1/+1
Change-Id: I3751a2c08c88638a9843da658b829abf1ffef14c Reviewed-on: https://gerrit.libreoffice.org/79408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23drop strange use of Help::ShowBalloonCaolán McNamara1-2/+0
Change-Id: I90406d02d31f1e89e31a5c9d938d42eeb112ee25 Reviewed-on: https://gerrit.libreoffice.org/79407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23set correct parentCaolán McNamara2-2/+2
Change-Id: I1fc03238a68bcc42e0e43f3305baeb4407791eca Reviewed-on: https://gerrit.libreoffice.org/79409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23replace LogicToPixel uses in SfxTabPagesCaolán McNamara2-9/+11
Change-Id: Ic2ea87bd5bcb8ccee58818b638e70a561fc8f95b Reviewed-on: https://gerrit.libreoffice.org/79410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23ofz#17613 fix buildCaolán McNamara1-3/+1
Change-Id: Ie8463af051b46dcd24b1642c583cc48f4359beea Reviewed-on: https://gerrit.libreoffice.org/79395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23do not require $(SRCDIR) in every gb_Library_set_precompiled_headerLuboš Luňák1-1/+1
Change-Id: I7b3a22584bb2e4d501f509ffcd80929feed23a4c Reviewed-on: https://gerrit.libreoffice.org/79360 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-23should use DialogController hereCaolán McNamara2-6/+3
Change-Id: Ie0ad42e98d574d15172c6ed3a58714c3f87593cd Reviewed-on: https://gerrit.libreoffice.org/79355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-23Resolves tdf#127400 - Allow to show tip of the day againHeiko Tietze3-18/+20
* UNO command TipOfTheDay and slot SID_TIPOFTHEDAY introduced and added to help menus * Tip ID introduced to keep the current tip over the day * Tip ID updates after 24h * Randomization of tips replaced by sequential order * Tip ID added to the dialog title Change-Id: I69b72b80d6d6afa25a1c4f01fa05bc60b5741db8 Reviewed-on: https://gerrit.libreoffice.org/78693 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-21set wait on the dialog, not the page parentCaolán McNamara1-2/+1
Change-Id: If782e774fee91a427d4bda575b2f404fd636f534 Reviewed-on: https://gerrit.libreoffice.org/79319 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-21tdf#126527 Fix widow and orphan lines being added to searchJim Raykowski1-2/+2
Change-Id: I36d627b64fab3d42f7cf583e6f639745527b1b7f Reviewed-on: https://gerrit.libreoffice.org/79265 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-09-20weld OfaTreeOptionsDialogCaolán McNamara15-490/+408
including ability to host a vcl::Window based XWindow hierarchy inside a native widget, e.g. the dictionary extensions have option pages Change-Id: I17d933bac12679e10164214a9045b677291a6557 Reviewed-on: https://gerrit.libreoffice.org/79070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld Application Colors pageCaolán McNamara7-674/+900
Change-Id: Ib074afdb9cf57decb435bb6ec3867af5989019ef Reviewed-on: https://gerrit.libreoffice.org/79225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20tdf#109158 improve sorting when loading large autocorrect fileNoel Grandin1-7/+9
reduces time from 2.0s to 1.7s reduce work by (*) reserving some arrays (*) pre-sorting with a cheaper comparator (*) don't copy when returning result, just return a const& (*) flattening the data-structures to reduce pointer-chasing Change-Id: I972bd7ffdbf2121c2d38c24aca9618ca708e920c Reviewed-on: https://gerrit.libreoffice.org/79119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-19use an explicit id for the default currencyCaolán McNamara1-3/+5
Change-Id: I437966b55226805d6de83b17221318eb1f0279b8 Reviewed-on: https://gerrit.libreoffice.org/79116 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18fix some incorrect column idsCaolán McNamara3-8/+10
Change-Id: I17575fb6b24e5e09791dbd3f15c6cda662fefe65 Reviewed-on: https://gerrit.libreoffice.org/79087 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-18cui: infinite loop in SentenceEditWindow_Impl::MarkNextError()Michael Stahl1-2/+2
Looks like previously the aCursor never moved backwards so try to ensure the same for nCursor. (regression from 5261417cbb3051b812164838d19c0f748573df45) Change-Id: I7d2f04bbc6d1274ec4feff57927494f2eb5d665c Reviewed-on: https://gerrit.libreoffice.org/79071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-18column should be CairoSurfaceCaolán McNamara1-3/+3
Change-Id: Iaccc60edbb5729121b8258416a17345df2475f50 Reviewed-on: https://gerrit.libreoffice.org/79082 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17move GetStandardText to stdtext.hxxCaolán McNamara3-9/+9
Change-Id: Iaf9b5107cf88390f62d5ca94bf985c77bcb8b7ad Reviewed-on: https://gerrit.libreoffice.org/79048 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-17weld DirectSQLDialogCaolán McNamara2-21/+0
Change-Id: I8f97068bb38a1fb888d60251f8f25506044c8451 Reviewed-on: https://gerrit.libreoffice.org/78970 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-13Revert "Resolves tdf#127317 - Make text of tips of the day selectable"Heiko Tietze1-1/+0
Selectable text makes the GtkLabel unwrap; revert is needed until the control works properly This reverts commit 54a3044ebd7f946235ba1d0a8af11ad94872afb7. Change-Id: I7b63e0e29a22f3feddac99ac42735a1880a9b1c2 Reviewed-on: https://gerrit.libreoffice.org/78864 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-13Resolves tdf#127436 - Display issues of TotD on macOSHeiko Tietze1-0/+2
Dialog resizing blocked Change-Id: Ie61880d2d08adabf64a60e97a9bf00c02247f1ce Reviewed-on: https://gerrit.libreoffice.org/78761 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-09-13add missing model to treeviewCaolán McNamara1-5/+38
Change-Id: Idf268ea30da1b80d9418419b2336979685d7cf8c Reviewed-on: https://gerrit.libreoffice.org/78858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-07Fix typosAndrea Gelmini1-3/+3
Change-Id: Ia6760e685e7f38458a8c78e6304d06d0e7222805 Reviewed-on: https://gerrit.libreoffice.org/78740 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-09-06use unique_ptr in DoConvertToPolyObjNoel Grandin1-6/+6
Change-Id: Ia7f9ff4d8f7b9834b6634e5c126bd65014dacf19 Reviewed-on: https://gerrit.libreoffice.org/78684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-11 21:36:23 +0000