summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2018-03-05weld InputDialogCaolán McNamara1-5/+5
Change-Id: I821dcea904cad7cc6f9394bccf6560624d23729b Reviewed-on: https://gerrit.libreoffice.org/50756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-04weld Security Options DialogCaolán McNamara5-106/+105
Change-Id: I0975ce9e096283d060ba5486aedc0d6cb3086f9d Reviewed-on: https://gerrit.libreoffice.org/50747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-04weld SvxNameDialogCaolán McNamara16-103/+114
Change-Id: Iac7bdf9c998e611b56473a685aee276a56adf996 Reviewed-on: https://gerrit.libreoffice.org/50702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-03Translate German variable namesJohnny_M2-31/+31
Akt -> Current in tabstpge Change-Id: I36c8b772f4bc5d1aa6df4b759d1afabfe116e13a Reviewed-on: https://gerrit.libreoffice.org/50669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-02weld split cells dialogCaolán McNamara5-73/+58
Change-Id: I726c6d84807ab3efba509058eed554fe4c0ffced Reviewed-on: https://gerrit.libreoffice.org/50636 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-02use more Color in HexColorControlNoel Grandin2-14/+9
Change-Id: I889fa9f2a8711e95f24336718e35d11d0945dec1 Reviewed-on: https://gerrit.libreoffice.org/50573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-02delete colordata.hxxNoel Grandin1-1/+0
move what we still need into color.hxx Change-Id: Ied7e31eb16468aa334c666b1499a6262f16a6350 Reviewed-on: https://gerrit.libreoffice.org/50561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01weld insert row/column dialogCaolán McNamara5-44/+31
Change-Id: Ib035e4ea18e65558e6b7cd7d7ebb643f68241ead Reviewed-on: https://gerrit.libreoffice.org/50594 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01tdf#115994: Extensions' option pages need fixed pref. sizeKatarina Behrens1-2/+10
as they are fixed size .xdl-based dialogs mostly But because of tdf#115015 calculate this preferred size as approx. 14 text edits + some padding to make sure crypto settings will fit the allocated space Change-Id: If31c4944e0909b281da5e8266ba1d1001b7c5309 Reviewed-on: https://gerrit.libreoffice.org/50474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-01give ok, cancel, help buttons those namesCaolán McNamara2-8/+8
So they can be used to sort the buttons into native ordering (eventually). Give them the gtk response ids, so they can be used by native gtk3 dialog loading (eventually) Change-Id: Ide49649b8ea6a2e0c003d23c3a88f0cb06822b05 Reviewed-on: https://gerrit.libreoffice.org/50535 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-01make Color::GetRGBColor return Color instead of ColorDataNoel Grandin1-1/+1
Change-Id: I532959a7103c3857510f26ecce2f942d676a233b Reviewed-on: https://gerrit.libreoffice.org/50487 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-01drop old tools/gen methods in accessibility..formulaNoel Grandin2-6/+8
Change-Id: I075e29173945200854f2ef8e420867871659766a Reviewed-on: https://gerrit.libreoffice.org/50446 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-28Fix assert(mpDialogImpl->get_response(pButton) == RET_OK) etc.Stephan Bergmann1-2/+2
...in Dialog::add_button (vcl/source/window/dialog.cxx:1338) during CppunitTest_cui_dialogs_test4 (part of `make screenshot`) Change-Id: I960c6e83ece088bc67888f265f90c663d8408adb Reviewed-on: https://gerrit.libreoffice.org/50518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28Fix assert(mpDialogImpl->get_response(pButton) == RET_HELP)Stephan Bergmann1-1/+1
...in Dialog::add_button (vcl/source/window/dialog.cxx:1344) during CppunitTest_cui_dialogs_test2 (part of `make screenshot`) Change-Id: I5dee49415421df9c7f476fadc5486636ca2af881 Reviewed-on: https://gerrit.libreoffice.org/50517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28Missing dependenciesStephan Bergmann3-0/+12
Change-Id: I1d153b9962cfe3b280831644c8d989ab8b515d3e
2018-02-28Drop unnecessary HIDs from Hyperlink dialogGabor Kelemen6-17/+0
The defaults from ui files will do just fine Change-Id: Idd0f3b2f171386142971e7b285abaf869e42717f Reviewed-on: https://gerrit.libreoffice.org/50379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28Use for-range loops in cuiJulien Nabet25-349/+230
Change-Id: I82cbea6d221ec0fd0e0d4620bdda698f2bed520e Reviewed-on: https://gerrit.libreoffice.org/50472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-28Translate German comments and debug stringsJohnny_M1-1/+1
Change-Id: Ie2da785cb674e21f042caa5e6d461e3489036003 Reviewed-on: https://gerrit.libreoffice.org/50467 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-28sneaky uppercase OK,CANCEL,HELP responsesCaolán McNamara1-4/+4
Change-Id: I02324d31822c37daa1e5e1b8c87aa597def58957 Reviewed-on: https://gerrit.libreoffice.org/50437 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28convert COL_ constants to be of type ColorNoel Grandin3-9/+9
Change-Id: I0e25c8950ac26b851ff42f71e1471fcbe4770d48 Reviewed-on: https://gerrit.libreoffice.org/50373 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27remove unused vclunohelper.hxx includesJochen Nitschke3-3/+0
Change-Id: I68178379e5493d0e738861a4dce5aa6e4b58cd22 Reviewed-on: https://gerrit.libreoffice.org/50393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27Fix assert(mpDialogImpl->get_response(pButton) == RET_HELP)Stephan Bergmann1-1/+1
...in Dialog::add_button (vcl/source/window/dialog.cxx:1348) during CppunitTest_cui_dialogs_test (part of `make screenshot`) Change-Id: Ie5b8e301b99350a19f6de7de6496a9b315b633ee Reviewed-on: https://gerrit.libreoffice.org/50415 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27tdf#116043 fix customize dialog icons going awayJim Raykowski1-1/+1
Change-Id: Id4022092765c085efcd71627a1dd8290f7441e74 Reviewed-on: https://gerrit.libreoffice.org/50407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-02-27replace Color(COL_*) with COL_*Noel Grandin11-21/+21
using git grep -lwP "Color\s*\(\s*(COL_\w+)\s*\)" | xargs perl -pi -e "s/Color\s*\(\s*(COL_\w+)\s*\)//g" and then some manual fixup where the resulting expression no longer compiled Change-Id: I0e268d78611c3be40bba9f60ecfdc087a36c0df4 Reviewed-on: https://gerrit.libreoffice.org/50372 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-27convert various MessBox to weld::MessageDialogCaolán McNamara2-64/+40
Change-Id: I4d2d0393c753114aeb9bb7e646dfdc810f6caa38 Reviewed-on: https://gerrit.libreoffice.org/50398 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-27tdf#1155015: Make sure checkbox text really wrapsKatarina Behrens1-0/+1
for :wrap property to be effective, a reasonable height request is needed so the text is not forced into single line again Change-Id: I3bfe459b4894cad1682d03a8ef77f0c54690bf4d Reviewed-on: https://gerrit.libreoffice.org/50394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-27convert remaining WarningBox to weld::MessageDialogCaolán McNamara43-48/+15
Change-Id: I7e3c156a6ad47ac232636ae274280c1cb7556d4a
2018-02-27Remove duplicated includesAndrea Gelmini1-1/+0
Change-Id: I8caee48fa9a08d6ee8c5c084468634dcd2a5fbf6 Reviewed-on: https://gerrit.libreoffice.org/50383 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-26split out GetStandardWarningBoxImageCaolán McNamara2-3/+3
Change-Id: I2c8315c7223adac2d7e0e2aa403db0f865bdc48e Reviewed-on: https://gerrit.libreoffice.org/50377 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-26Removed duplicated includesAndrea Gelmini1-1/+0
Change-Id: Ib93cb76a3b667ca96e228d0b59da9f9849850081 Reviewed-on: https://gerrit.libreoffice.org/50330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-26convert remaining ErrorBox to weld::MessageDialogCaolán McNamara6-26/+50
and convert remaining QueryBox to weld::MessageDialog Change-Id: Ifb4c316dee8eabf57c4940c44e29c65a2781aa6c
2018-02-26use less TRGB_COLORDATANoel Grandin1-1/+1
part of removing ColorData Change-Id: Id2d5843762227559f97cfb5eb61c01c888a0601e Reviewed-on: https://gerrit.libreoffice.org/50347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26use less RGB_COLORDATANoel Grandin2-7/+7
part of removing ColorData Change-Id: If31b5b88545529863377e9a178f45f4516bf6cbb Reviewed-on: https://gerrit.libreoffice.org/50345 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26tdf#116020: use actual whichIds in dialogs for character propertiesMike Kaganski4-13/+32
... instead of converting back and forth between character-specific whichIds and generic. This eliminates creating duplicate properties in the set passed to dialog. A temporary GrabBag entry "DialogUseCharAttr" is used to indicate that dialogs should use character-specific Ids. This simplifies and unifies preparation of the set for different dialogs. Change-Id: I41b982ff05d54b0dfc283c07aef806f51c87209c Reviewed-on: https://gerrit.libreoffice.org/50339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-26loplugin:oncevar extend to tools/gen.hxx typesNoel Grandin3-6/+3
Change-Id: I5c75875da44334569c02e2ff039b33c38397a0a2 Reviewed-on: https://gerrit.libreoffice.org/50283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-26ColorData->Color in variousNoel Grandin3-20/+20
Change-Id: I22018b6a535224316d93bfd621771248b873a218 Reviewed-on: https://gerrit.libreoffice.org/50167 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-25convert remaining InfoBox to weld::MessageDialogCaolán McNamara7-13/+24
Change-Id: I91d828e38d96264cf4a76f30940942556b8f78d8 Reviewed-on: https://gerrit.libreoffice.org/50205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-25convert all help responses to gtk's -11Caolán McNamara83-221/+221
and ok responses to gtk's -5 and cancel responses to gtk's -6 and close responses to gtk's -7 and yes responses to gtk's -8 and no responses to gtk's -9 Change-Id: Ia1a261a3a711ed9f5d8c0b0c639897c3064bb08c Reviewed-on: https://gerrit.libreoffice.org/50206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-23tdf#115938: Properly detect shadow size control's changed stateMike Kaganski1-1/+6
This change makes sure that only if the shadow size edit box' text is changed, it is converted to the size in twips. It sets wrapper's default value on each SetControlValue, to return proper initial size when the size text wasn't modified. Also both ExampleSet and OutSet in SfxTabDialog's Reset handler are processed to set relevant items back to initial value; otherwise, as the restored item (marked as unchanged) will be absent in tab's result set, it would not modify the old items in the two, and they would keep previous modified values. Change-Id: Ie4362811968c6e6cbe0f9229bd3c9b29462f5704 Reviewed-on: https://gerrit.libreoffice.org/50196 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-22weld native message dialogsCaolán McNamara39-253/+247
just the straight-forward MessageDialog cases first a) remove border_width from message dialog .ui so as to take the default border width b) retain 12 as default message dialog border for vcl widget case c) remove layour_style from message dialog button boxes so as to take the default mode (a no-op for vcl widget case) d) use gtk response ids (vcl builder will converts to vcl ones) Change-Id: I7de281093a1b64f92f71ca11e7cbba42bb658154 Reviewed-on: https://gerrit.libreoffice.org/50143 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-22Move include/sfx2/notebookbar/NotebookbarContextControl.hxx to include/vcl/Stephan Bergmann1-1/+1
...as it is included from other include/vcl/*.hxx files. (And moving it there helps the heuristic in an upcoming improvement of loplugin:dyncastvisibility.) Change-Id: I15e061fbaba8e82235afb5b312f7b38f26eec900 Reviewed-on: https://gerrit.libreoffice.org/50123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-21tdf#115015: make crypto settings better fit allocated spaceKatarina Behrens3-6/+19
Oh dear how much do I dislike fixed size dialogs. Everytime they are enlarged to fit new content (esp. gtk3 is rather space-greedy there) someone starts to whine the dialog is now too large Doing what e6d7d7375221 does is not really an option, since there are some 30+ tabpages to try and test for optimal size here. Change-Id: I3ffb2d794f76781eb62186093b928289593585cf Reviewed-on: https://gerrit.libreoffice.org/50032 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-21tdf#115892: properly get the box' saved valueMike Kaganski1-8/+2
Previously textual value like "10,5 pt" was converted to int as simply 10 (multiplied by 10, it became 100), which compared as different from unchanged value of 105. This made the fractional values to be treated as always changed. This patch uses the same code to convert saved value as is used for current edit box value. Change-Id: I09a84a6bf33b17e0192b79b31af21ef14d7e9c63 Reviewed-on: https://gerrit.libreoffice.org/50066 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-20drop Color::SetColor(ColorData) in favour of operator=Noel Grandin3-6/+6
first stage of getting rid of ColorData Change-Id: I5e4e95eb958722814c43c8d1ebfef17ad18c29ec Reviewed-on: https://gerrit.libreoffice.org/49997 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19cui: remove dead codeChris Sherlock1-15/+0
Change-Id: I3f27d1b502512a5603110445da7b0c50a5339198 Reviewed-on: https://gerrit.libreoffice.org/47486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-19use std::array in createHistorical8x8FromArrayNoel Grandin1-3/+3
to make the assumption about the size of the array obvious in the code. Change-Id: I7ebe0b037e3be38f7e33c0160742f829288bb474 Reviewed-on: https://gerrit.libreoffice.org/49938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-19use VirtualDevice in createHistorical8x8FromArrayNoel Grandin1-3/+3
part of making BitmapWriteAccess an internal detail of vcl/ Change-Id: I8b3aa2fdd3c26db0e48b228640cd31b0bd31543c Reviewed-on: https://gerrit.libreoffice.org/49937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-16Revert "loplugin:changetoolsgen in canvas..cui" and reapplyNoel Grandin12-53/+53
because I (a) forgot to insert parentheses which changes the meaning of some expressions and (b) I now use the AdjustFoo calls when changing unary operations, which reads much better This reverts commit f841dada1a5018897cce29ccf972da33ece4738c. Change-Id: Iff19e1fc99812c086b0a39b71a3f67b98e2f9c8f Reviewed-on: https://gerrit.libreoffice.org/49841 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14loplugin:changetoolsgen in canvas..cuiNoel Grandin22-116/+116
Change-Id: I4e320055a3dbe4159c2aa2714e1ee98182e1e80a Reviewed-on: https://gerrit.libreoffice.org/49642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-10lokdialog: Handle dialog items' invalidation in generalTamás Zolnai1-20/+0
Change-Id: Ib7b178fe97964bc5fd6ac173a143ba8ba089e237 Reviewed-on: https://gerrit.libreoffice.org/49240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>