summaryrefslogtreecommitdiff
path: root/cui
AgeCommit message (Collapse)AuthorFilesLines
2018-06-15weld SvxStdParagraphTabPageCaolán McNamara3-387/+374
Change-Id: I02b0f2e4f049b407a3ac0c7f304cbcd0cc652749 Reviewed-on: https://gerrit.libreoffice.org/55827 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxParaAlignTabPageCaolán McNamara3-260/+204
Change-Id: I843b264d44266213e91b7e75bf35e4f6cf41dd88 Reviewed-on: https://gerrit.libreoffice.org/55809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxExtParagraphTabPageCaolán McNamara3-398/+363
Change-Id: I6836bc659f28ebae35ed0ca33ffd9425212c3622 Reviewed-on: https://gerrit.libreoffice.org/55791 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxAsianTabPageCaolán McNamara2-56/+30
Change-Id: Ib1e229a9780dd0959ce847a2d4c15eab7fb92c33 Reviewed-on: https://gerrit.libreoffice.org/55781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-14weld SvxCharTwoLinesPageCaolán McNamara3-117/+153
Change-Id: I54a8963cd8b12f5fd51bf6b3bb791a4a15fbd13d Reviewed-on: https://gerrit.libreoffice.org/55766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-13weld SvxCharPositionPageCaolán McNamara3-282/+345
Change-Id: I2084702798e5b01eae5905dc54ad8413e6d5fae6 Reviewed-on: https://gerrit.libreoffice.org/55765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-12weld SvxTransparenceTabPageCaolán McNamara3-269/+310
Change-Id: If8c8a6cf74664f9acd360d877c57e8dd9de2f2b5 Reviewed-on: https://gerrit.libreoffice.org/55694 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-05tdf#117866 cui: avoid deadlock in personalization dialogMiklos Vajna2-4/+8
The deadlock happened as the main thread wanted to join SearchAndParseThread (while owning the solar mutex), but SearchAndParseThread wanted to take the solar mutex to import a graphic. Fix the deadlock by checking for the termination flag earlier, so we don't take any new mutexes if termination was requested already. (cherry picked from commit 766c85a4f67f5d50645340e31cebd5956998c6fc) Related: tdf#117866 cui: use std::atomic for thread termination flag (cherry picked from commit f4ac7b5a084a7cf483bb89a2fa411f9df70df4d0) Change-Id: Idddaadadc693610d9f31a14300b22aff8d452756 Reviewed-on: https://gerrit.libreoffice.org/55334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-06-04weld SwSectionFootnoteEndTabPageCaolán McNamara1-81/+0
Change-Id: Ib4246a2f90780a005e79e2d071b43a5629a3242c Reviewed-on: https://gerrit.libreoffice.org/55216 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit cd08397eedbe347784a3ac569481a17a8391e7b2) Reviewed-on: https://gerrit.libreoffice.org/55236
2018-05-31Fix conditionSamuel Mehrbrodt1-1/+1
Change-Id: I977eae208bd12886d25679d4c75308d51245766a Reviewed-on: https://gerrit.libreoffice.org/55057 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 29f0c9d344bfe2e09727fd9b9aa88e8c7bf361e2) Reviewed-on: https://gerrit.libreoffice.org/55067 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-29these spinbuttons should be focusableCaolán McNamara3-15/+14
Change-Id: I5af98ef0815f91b8c615441299eb43d602ebf57b Reviewed-on: https://gerrit.libreoffice.org/55026 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxTransformTabDialogCaolán McNamara5-102/+207
Change-Id: Ib6dabd04e3f834b61363d5a620de7f0219a1e644 Reviewed-on: https://gerrit.libreoffice.org/55018 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29fix pow by digitsCaolán McNamara1-0/+4
Change-Id: I715b85fa1c1e3f6c391c742f861e3791a505a570 Reviewed-on: https://gerrit.libreoffice.org/55013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxSwPosSizeTabPageCaolán McNamara3-477/+430
Change-Id: I51c83ec801884a07f7920309535a58b55171b0be Reviewed-on: https://gerrit.libreoffice.org/54979 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxAngleTabPageCaolán McNamara4-119/+142
Change-Id: I03bd0a6a0805d549570ce44030a0f58ca2b98d05 Reviewed-on: https://gerrit.libreoffice.org/54987 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxSlantTabPageCaolán McNamara3-104/+101
Change-Id: Ib3b1bf1fa434c63b66f388a1f1815787b642fb88 Reviewed-on: https://gerrit.libreoffice.org/54967 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxPositionSizeTabPageCaolán McNamara3-344/+310
Change-Id: Ic642d6ab2470a14b3a1d83284407fc690d5eba88 Reviewed-on: https://gerrit.libreoffice.org/54975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28fix up position of anchor widgetCaolán McNamara1-3/+1
Change-Id: I35823a4c84f6134bf9b005fb1ab6df12d716d14e Reviewed-on: https://gerrit.libreoffice.org/54942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:unusedfieldsNoel Grandin1-1/+1
Change-Id: I625b73152c0c277c6e0ce3e24e4704094fc4e8ff Reviewed-on: https://gerrit.libreoffice.org/54822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 96d7c67d98527b1ccc1cfba3ca817238e582d63b) Reviewed-on: https://gerrit.libreoffice.org/54943 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:passstuffbyrefNoel Grandin3-4/+4
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit ff3bdde2527123fc9e011ff0d93e958174632186) Reviewed-on: https://gerrit.libreoffice.org/54914 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24rework custom widget welding to enable inheritenceCaolán McNamara5-275/+305
Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103 Reviewed-on: https://gerrit.libreoffice.org/54681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24Remove unnecessary includeMuhammet Kara2-2/+0
Change-Id: I660bc8efd441e9fc5b6f83f69dc632a26add193b Reviewed-on: https://gerrit.libreoffice.org/54712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-05-23tdf#104086 cui: enable OpenGL when ignoring its blacklistMiklos Vajna2-0/+10
"Ignore OpenGL blacklist" is called "force OpenGL" in the code, so it make sense that OpenGLHelper::isVCLOpenGLEnabled() returns true in that case. But the UI suggested that enabling ignore doesn't enable OpenGL itself. Fix this by auto-checking the parent UI widget when enabling the blacklist. Change-Id: I16bec69aebd645858260850f15ea8e687566fd0e Reviewed-on: https://gerrit.libreoffice.org/54720 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-22Related tdf#83877 Select certificate ok button label doesn't matchSamuel Mehrbrodt1-1/+1
Change the button to "Select" instead of sign when we only want to select a certificate. Change-Id: Ifa896e502c8680497d71912ddd1058ab0b71542b Reviewed-on: https://gerrit.libreoffice.org/52823 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Don't try to sign when no certificate is selectedSamuel Mehrbrodt1-0/+1
Change-Id: I30f8f5970538db25ae678dc5b32afb292fd3983a Reviewed-on: https://gerrit.libreoffice.org/54652 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#83877 Use Signer comments as signature descriptionSamuel Mehrbrodt1-1/+1
Change-Id: Ia9f18addeee9cf86989c873419113ddbd07c219f Reviewed-on: https://gerrit.libreoffice.org/54551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22tdf#83877 Add valid/invalid images to signaturesSamuel Mehrbrodt2-40/+40
Change-Id: I958c1bad2f32383ebaaeb7d42c761f0d1dfefc35 Reviewed-on: https://gerrit.libreoffice.org/54513 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-22Place help button on the left of signature dialogOlivier Hallot1-10/+14
Change-Id: Ic78646b7540d2eaf176b3b6c57b0225793b866bd Reviewed-on: https://gerrit.libreoffice.org/54597 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-20coverity#1435684 deliberate 'Constant' variable guards dead codeCaolán McNamara1-1/+1
Change-Id: I0a5b36ad781bfc76295e91131bdc073dac0d6ea2 Reviewed-on: https://gerrit.libreoffice.org/54585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-19Fix typosAndrea Gelmini1-1/+1
Change-Id: Ie0c9f168759a625d78668cd57838b208fbc9dc56 Reviewed-on: https://gerrit.libreoffice.org/54458 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-18Refactor SfxObjectShell sign methodsSamuel Mehrbrodt1-1/+1
for signature line signing Change-Id: Iac4f3a248af53bdbf159e6e8d656e1dcbc3aacbf Reviewed-on: https://gerrit.libreoffice.org/54473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-18tdf#83877 Write SignatureLineId to ODF & OOXML signaturesSamuel Mehrbrodt1-1/+1
Change-Id: I483a3b7895cdcb10ef9d6dacf167ed0f8db7e723 Reviewed-on: https://gerrit.libreoffice.org/54432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-17loplugin:unusedfields in cuiNoel Grandin27-76/+29
Change-Id: If92e31342f587b5e0e9fc7efd85fdcb48f3043c7 Reviewed-on: https://gerrit.libreoffice.org/54457 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-17'/' appearing in java classpath listCaolán McNamara1-7/+10
regression from... commit 2f6b3fb0f30cd03e5ac60805a922711bdcab77f9 Date: Wed Apr 25 18:21:46 2018 +0200 Avoid comphelper::string::getTokenCount() Change-Id: I5bbfa38d8cceb56fe03282c89039ab30cf108204 Reviewed-on: https://gerrit.libreoffice.org/54422 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17weld SvxJavaClassPathDlgCaolán McNamara3-116/+125
Change-Id: I3938a05d96cb1fc171611e54fa34f780ba569268
2018-05-17set parents for MasterPasswordCreateDialog and MasterPasswordDialogCaolán McNamara2-7/+23
Change-Id: I7e58597b2a47db1be5588432d372256785258de5 Reviewed-on: https://gerrit.libreoffice.org/54459 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17weld SvxJavaParameterDlgCaolán McNamara3-142/+153
Change-Id: Ibcd19071aae42e07d9411d9c4ac4fbbb566aec45 Reviewed-on: https://gerrit.libreoffice.org/54441 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17weld AssignComponentDialogCaolán McNamara3-33/+31
Change-Id: I09fac24b81248bc27128d9142487301d4dc8ea6a Reviewed-on: https://gerrit.libreoffice.org/54440 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17weld SvxNewToolbarDialogCaolán McNamara4-46/+31
Change-Id: I9ce16b4a72037db491a0919e117d664ccd554153 Reviewed-on: https://gerrit.libreoffice.org/54439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-17weld SvxMainMenuOrganizerDialogCaolán McNamara4-183/+123
Change-Id: I157dc8054e3bd0055cc52f7c9a80066026b7033d Reviewed-on: https://gerrit.libreoffice.org/54424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-15Sign Signature LineSamuel Mehrbrodt1-29/+48
This adds a new context menu entry "Sign Signature Line" to signature lines. You can directly sign the document from there. Still missing is the updating of the graphic to reflect the valid/invalid signature state. Change-Id: Ib8bc8c57f9d5370a10e379f86f9e41e57c715e3f Reviewed-on: https://gerrit.libreoffice.org/53778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-14weld GalleryIdDialogCaolán McNamara5-81/+83
Change-Id: I214afef7668eaf5082683f1c77b08aa0c5107619 Reviewed-on: https://gerrit.libreoffice.org/54317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld TitleDialogCaolán McNamara5-70/+75
Change-Id: I009da829e2b866844e67f976582e2a9d99bd22c0 Reviewed-on: https://gerrit.libreoffice.org/54316 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-14weld FmInputRecordNoDialogCaolán McNamara5-75/+73
Change-Id: I87f3dc3a576e30fe50871c14a67a5b777c21d3ba Reviewed-on: https://gerrit.libreoffice.org/54308 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-12make Bitmap/BitmapEx constructors explicitNoel Grandin2-3/+3
and add BitmapEx::operator=(Bitmap const &) Image::Image(Bitmap const &) to lessen the fallout Change-Id: Iff5fab88d167a7be739c370c9933d36c297bc61c Reviewed-on: https://gerrit.libreoffice.org/54162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-12coverity#1430087 Division by zeroCaolán McNamara1-1/+1
Change-Id: Ie29773a3f0a3fcadd633f09e6355b801945933c2 Reviewed-on: https://gerrit.libreoffice.org/54140 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-11loplugin:datamembershadow in SvxMacroTabPage_Noel Grandin1-1/+1
Change-Id: I8cd1a4fef6bd0966620692c316a40ea47dd14d7d Reviewed-on: https://gerrit.libreoffice.org/54105 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-10move Java from config_features to already existing config_javaRene Engelhard2-2/+2
Change-Id: I085fab2bcdc5910d1386fc20768fe7063ce3e28e Reviewed-on: https://gerrit.libreoffice.org/54071 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-05-09vcl: get rid of Bitmap{Ex}::Filter() and Animation::Filter()Chris Sherlock1-18/+18
Change-Id: I510d7b286df732712aa9206b0a7c7910af34c83f Reviewed-on: https://gerrit.libreoffice.org/53206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-08tdf#114549:entering hex/dec code should change char samplehimajin1000002-17/+26
by checking has_focus() for m_xHexCodeText and m_xDecimalCodeText. Also,CharHighlightHdl and SearchCharHighlightHdl now look alike. Also add case for missing glyph for entered hex/dec code. Change-Id: I32c782ac09756462f11b209afa12183d5ae7ac1f Reviewed-on: https://gerrit.libreoffice.org/51616 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>