summaryrefslogtreecommitdiff
path: root/comphelper
AgeCommit message (Collapse)AuthorFilesLines
2016-12-23tdf#70998 Change word "Graphic(s)" to "Image(s)"Huzaifa Iftikhar1-1/+1
There was an error in the previous patch inside the file embeddedobjectcontainer.cxx This is fixed in this patch. Change-Id: I01c9e254e58e1683a8e6e9a0bcff3c4663bf32e0 Reviewed-on: https://gerrit.libreoffice.org/32353 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2016-12-23loplugin:unusedmethodsNoel Grandin1-14/+0
Change-Id: Ife4c8d948ffa116f044d43903de9485e43cfcae5 Reviewed-on: https://gerrit.libreoffice.org/32336 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-15teach sallogareas plugin to catch inconsistenciesNoel Grandin1-1/+1
Change-Id: I8bcea5ffc74d48148bea78da8c17744e288c069a Reviewed-on: https://gerrit.libreoffice.org/32004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin2-6/+2
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12comphelper: cleanup class NameContainer.Arnaud Versini1-7/+2
Remove useless class NameContainerImpl. Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c Reviewed-on: https://gerrit.libreoffice.org/31830 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-08convert OSL_ENSURE to assert in AccessibleEventNotifierNoel Grandin2-2/+2
and fix the places that trigger it Change-Id: I97a04cff25ab5aa1d42c79a971d15ba742bf384e Reviewed-on: https://gerrit.libreoffice.org/31760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-07This is presumably not meant to be exportedStephan Bergmann1-1/+1
Change-Id: Id11393c44ddd217d3def259ea5a8df9f8bb27711
2016-12-07tdf#88206 replace cppu::WeakImplHelper* miscJochen Nitschke2-4/+4
also edited two examples in canvas comments Change-Id: Iac82b462168f869f995c33bb2c639f3dbe09cbd5 Reviewed-on: https://gerrit.libreoffice.org/31715 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-06SafeModeDialog: Add option to reset bundled extension registrationSamuel Mehrbrodt1-20/+44
Change-Id: Ic83ada7cc76142852643cefa60b4fc9286e0756a Reviewed-on: https://gerrit.libreoffice.org/31694 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-06SafeModeDialog: Rename to match realitySamuel Mehrbrodt1-5/+5
This doesn't remove shared&bundled extensions, but resets the registration database from shared extensions. Change-Id: I9f198fc7b771fd3bd31547008fd8d006a6d1b5d5 Reviewed-on: https://gerrit.libreoffice.org/31693 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-05convert DecodeMechanism to scoped enumNoel Grandin1-1/+1
Change-Id: I5c56634b1bca8e37fa73d02d2428645301b6c547
2016-12-01tdf#104126 - comphelper thread-pool, use reliable std::condition_variable.Michael Meeks1-147/+119
The existing osl::Condition is an API and reliability disaster area. Change-Id: I3be84e1c6a83e58c43c40c9c8720790d923a6694 Reviewed-on: https://gerrit.libreoffice.org/31163 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2016-12-01Fix race in ThreadTaskTagStephan Bergmann1-8/+10
Assume T0 calls ThreadPool::pushTask twice, then ThreadPool::waitUntilDone: T0 calls ThreadTaskTag::onTaskPushed: mnTasksWorking = 1, maTasksComplete.reset T1 runs the 1st task to completion and calls ThreadTaskTag::onTaskWorkerDone: mnTasksWorking = 0; suspended... T0 calls ThreadTaskTag::onTaskPushed: mnTaskWorking = 1, maTasksComplete.reset T1 continues in the call to ThreadTaskTag::onTaskWorkerDone: ..., maTasksComplete.set T0 calls ThreadTaskTag::waitUntilDone and immediately returns T2 only now starts to run the 2nd task Change-Id: Ic29101a4791fca2a1a4d54b559f10ff706e8a20d
2016-11-29Rewrite some (trivial) assignments inside if/while conditions: comphelperStephan Bergmann1-6/+3
Change-Id: I8361f62199f45dbced45e5d4a4d5eeddf1c42d67
2016-11-28loplugin:unnecessaryoverride (dtors) in comphelperStephan Bergmann7-37/+0
Change-Id: I13ebc4efa7f8bd0d3732ed65e397c710ae65d14e
2016-11-21Delete the "Any-to-Any" template specializations for LIBO_INTERNAL_ONLYStephan Bergmann1-1/+1
i.e., css::uno::Any function template specializations Any::has<Any>() const Any::get(Any const &) const operator >>=(Any const &, Any &) operator <<=(Any &, Any const &) that don't make much sense (the first is always true, the rest can be replaced with operator =, which additionally supports move semantics). For 3rd-party compatibility, do this only for LIBO_INTERNAL_ONLY, however. However, some generic template code did benefit from operator >>= working also for Any, so make up for that with a new (LIBO_INTERNAL_ONLY, given that operator >>= still covers if fine for !LIBO_INTERNAL_ONLY) fromAny, complementing the existing toAny. Change-Id: I8b1b5f803f0b909808159916366d53c948206a88 Reviewed-on: https://gerrit.libreoffice.org/30022 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-11-10loplugin:expandablemethods in comphelper..cppuhelperNoel Grandin4-29/+19
Change-Id: I9d5487af4729bd3ee4f6450092e4b77f74a12e6d Reviewed-on: https://gerrit.libreoffice.org/30717 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-09comphelper: also bump PDBKDF2 count for password-to-modifyMichael Stahl1-3/+3
The password-to-modify misfeature does not actually provide any security, but it may induce users to re-use passwords, so at least make it harder to crack the passwords. Change-Id: I0adf0e8e11b222fc469013e17a2695bd7122ad01
2016-11-09make comphelper::containerToSequence a little smarterNoel Grandin1-1/+1
So we don't have to specify the source and destination type as often. Change-Id: Id9e286417a1cb246d163cbc3c536b231a4a92624 Reviewed-on: https://gerrit.libreoffice.org/30700 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-08loplugin:unnecessaryvirtual in comphelper..formsNoel Grandin2-4/+4
Change-Id: Iabe292e68cb84b97f207061347ed6a30309dc9fd Reviewed-on: https://gerrit.libreoffice.org/30679 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-03SafeModeDialog: Allow to create zip file from profileSamuel Mehrbrodt1-0/+5
Change-Id: I4296d1cf5058be359ffed46745673cf26eba3375 Reviewed-on: https://gerrit.libreoffice.org/30479 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01SafeModeDialog: Add link to user profileSamuel Mehrbrodt1-0/+5
Change-Id: I0096b3d7db51e28eb58c7209109c30b73b382478 Reviewed-on: https://gerrit.libreoffice.org/30448 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01safemode: Add option to disable H/W accelerationSamuel Mehrbrodt1-1/+80
Change-Id: Ic6751717c14d317b5a4bc64c4fd1cf2b2f5efabf Reviewed-on: https://gerrit.libreoffice.org/30112 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-11-01Omit the default comparatorTakeshi Abe1-2/+1
Change-Id: Idea8ea8dab6a86d7be6394aef1cf7f25b75009e0 Reviewed-on: https://gerrit.libreoffice.org/30319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-10-26coverity#1374269 Uncaught exceptionCaolán McNamara1-1/+1
Change-Id: Ib3a876ea6463396784062bd53bfedff177818498
2016-10-23Fix typosAndrea Gelmini1-1/+1
Change-Id: Ib7b17f85c7b6a1937c3f6e1617ceec58074643b4 Reviewed-on: https://gerrit.libreoffice.org/30040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-10-22Typos in commentsJulien Nabet1-3/+3
Change-Id: I6450d3862a67c2a9275a569a8ee3c29262124409 Reviewed-on: https://gerrit.libreoffice.org/30162 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-10-21profilesafe: Make sure no recursive saving happensArmin Le Grand1-0/+4
Change-Id: Idd57a948fcaaf23614ca1a92051a50b86e4bb0c5 Reviewed-on: https://gerrit.libreoffice.org/30145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-21profilesafe: Added more specific optionsArmin Le Grand1-38/+122
For Extensions there is the possibility to not only decide enable/disable state for User ones, but also to deinstall user or all extensions, added these options to the dialog and the functionality. Also unified customization name schema to have just one source of strings to avoid errors in the future. Small fix in tryPop_extensionInfo Change-Id: I39acbe9a052ffd4cb78b496f24e5b583136c565a Reviewed-on: https://gerrit.libreoffice.org/30100 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-21loplugin:expandablemethodds in include/basic..comphelperNoel Grandin1-2/+2
Change-Id: I1aa9c12e8839325a9fd98530abc89a3d586ff62e Reviewed-on: https://gerrit.libreoffice.org/30120 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-10-21coverity#1374089: Unchecked return valueThorsten Behrens1-1/+1
Change-Id: Ied4e80db512000471b5aa215beeef1277121fe12
2016-10-20Blind fix for "error: chosen constructor is explicit in copy-initialization"Stephan Bergmann1-1/+1
...on linux_clang_dbgutil_64 build Change-Id: I00022749ce12df459ce22333593daa2eb6503fd7
2016-10-20Fix odd compilation error with Clang 3.8.0Tor Lillqvist1-1/+1
Fix "default initialization of an object of const type 'const ExtensionInfoEntryVector' (aka 'const vector<(anonymous namespace)::ExtensionInfoEntry>') without a user-provided default constructor". Change-Id: I97013ed4660459a3f4c1b8b5b7cc302ba3ff914d
2016-10-19profilesafe: added xml read/modify to restoreArmin Le Grand1-200/+363
To be able to restore the last saved state of enabled/disabled extensions it is necessary in SafeMode to get and set that states without XExtensionManager, so the configuration xml files have to be accessed. Added this change Change-Id: I00fe5795598427e7c08be0d3dd54bef68d038e24 Reviewed-on: https://gerrit.libreoffice.org/30062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-19coverity#1373663 Untrusted loop boundCaolán McNamara1-8/+8
Change-Id: Iabad14f8fc35656015b98693dd327a41aeaf63c7
2016-10-19profilesafe: Deeper integration with SafeModeArmin Le Grand1-95/+339
Added deeper integration by saving at SaveMode content of user dir completely to a user/SafeMode dir, including the whole stack of pack files. Repair happens in that safe directory, so that the user dir is resetted to default when re-started in SafeMode. All changes (including complete deletion) are played back to the user config at first restart with disabled SafeMode Change-Id: I5114c7d5d04582be62090707bc9b97afa55fc1f1 Reviewed-on: https://gerrit.libreoffice.org/30003 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-19replace <<= with assign for <<= with rhs AnyJochen Nitschke1-1/+1
queryAggregation and queryInterface return Any Change-Id: Ib8e3e742bd66f7419cad583988b247bb628f7b4a Reviewed-on: https://gerrit.libreoffice.org/29912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2016-10-16clang-cl loplugin: comphelperStephan Bergmann1-1/+1
Change-Id: Icde27eeeb21e9049630028e81af10edc1ba8ae04 Reviewed-on: https://gerrit.libreoffice.org/29876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-10-14profilesafe: Adapted to UIArmin Le Grand1-20/+241
Adaptions to UI, added more modes what the user can do in SafeMode. Adapted locations to write pack information and added places where to enter SafeMode. Implemented basically all five possible user choices Change-Id: Ic5324a8f77ab434309e840949c3803e65a75c538 Reviewed-on: https://gerrit.libreoffice.org/29785 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-14coverity#1373663 consider backupfilehelper byte twiddling as untaintedCaolán McNamara1-1/+8
Change-Id: I13f7c3df20b3c9f81a9519b4bb84f556a8f4db7e
2016-10-13profilesafe: extended to three modesArmin Le Grand1-95/+545
Saving configuration is now extended to three basic modes, from just saving registrymodifiications to adding user-defined config stuff to saving all information in the user profile, additionally configuration information for Extensions is saved. Added configuration entries for this and tested saving/restoring. Change-Id: I79b09c37617803bf656826f76a7e3db79cda49ac Reviewed-on: https://gerrit.libreoffice.org/29770 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-12profilesafe: Multiple adaptionsArmin Le Grand1-118/+648
Added own directory in User config to where the saved content is written and taken from, adapted to also handle ExtensionConfiguration, changed point for creating backups of configuration to doShutdown, create no configuration when a restart is triggered (untested configuration) Change-Id: Id7a96195b765842c31cacf81cc08d2965a205281 Reviewed-on: https://gerrit.libreoffice.org/29729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2016-10-12Missing includeStephan Bergmann1-0/+1
Change-Id: I5abde663d639278bcc8374da6b5772b58a9b7a75
2016-10-11profilesafe: Add values for SecureUserConfigfeature/profilesafemodeArmin Le Grand1-15/+11
Added default values for SecureUserConfig values to soffice.ini/rc which enable the mechanism, enable by default and set a maximum of three backups file in packed form. Added more handy flag for easy decision to add compressed/uncompressed. Change-Id: I5a624c09fec4e4278314e13fc5f693ac085d5e61
2016-10-11profilesafe: Added zip deflate/inflateArmin Le Grand2-77/+337
Stack of files can now deflate/inflate using zip library, unfortunately have to use direct due to Deflater/Inflater not being available, had to add linking against zip.lib. Checked compressed and uncompressed creation/usage of backup stack. Also warnings and clang errors corrected. Change-Id: Ieb059baeea323bb48ec5b1cf6b8df09da97cfb93
2016-10-11profilesafe: Collect copies in single *.pack fileArmin Le Grand1-138/+576
Enhanced helper classes for BackupFileHelper to allow writing a stack of rescued last valid configuration files to a single file package. Added configuration values for enabling this and defining the number of entries, added max entry limitation. Using FileSize and CRC32 now to dectect if config file did change. To make this work I added sorting to writing the configuration so that with no change the same configuration file is written. Use std::vector for better mem performance for sorting, defined static const for buffer size of manipulation, prepare inflate/deflate usages. Fixes to setPos, warnings Change-Id: Ib286e2a3f25b0085a1e3ae4f50c9ff1ff3a5dcf5
2016-10-11profilesafe: Enhancements to BackupFileHelperArmin Le Grand1-0/+11
Added helper class to allow easy creation/deployment of backups of a file. It works like a 'stack' of backups, supports easy add/remove/delete of last entry (LIFO). Added some work top allow opening dialogs in DeInit under linux. Change-Id: Idacec97ec2f097af9bd22a8a67b410c7677d17f1
2016-10-11profilesafe: Initial creation of BackupFileHelperArmin Le Grand2-0/+231
Added helper class to allow easy creation/deployment of backups of a file (here: registrymodifications). It works like a 'stack' of backups, supports easy push/pop of backed-up versions. Change-Id: Ie19e1209534f23a3dbd6106a5ca13b24b8fefe4d
2016-10-04comphelper: move setTiledPainting() from SfxViewShellMiklos Vajna1-0/+12
And make it a static one. The primary point of that member function is to prevent invalidations during paint, and since multiple views are allowed, it wasn't extended to filter out invalidations from all views, not just from the current one. (Same goes for other callback types.) Change-Id: I23e6b2c2ff94227f2b72c481148b2d8279ae2905
2016-09-29LOK: conditionally include part number in invalidation payloadMiklos Vajna1-5/+5
Since desktop/ code queues, compresses and only emits callbacks on idle, it's possible that two invalidations are in the queue, and there was a setPart() call between them. In this case it's impossible to tell what part the invalidation was sent for. Fix this by conditionally including the part number in the invalidation payload. It's off by default, a new feature flag is added to request this behavior. gtktiledviewer enables this feature flag by default, though just to show the part number in the debug output. Android doesn't enable it. Change-Id: I73e6def848c0eb61d64e71026002c7a0e750aab4