summaryrefslogtreecommitdiff
path: root/codemaker
AgeCommit message (Collapse)AuthorFilesLines
2016-02-11[API CHANGE] add operator==/!= to UNO structsNoel Grandin1-0/+63
this is useful now that we are storing UNO structs in std::vector Change-Id: Ic558bcd669bd2b3cdf9eb8393269eb906ac52369 Reviewed-on: https://gerrit.libreoffice.org/22257 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-09convert to range-based for loops in codemaker/Noel Grandin9-558/+359
Change-Id: Ifa521f34a8d9565bb61743c4a996bcba37e95ec2
2016-02-09rename dumpHFile to dumpHdlFileNoel Grandin1-7/+7
since we create .hdl files, not .h files Change-Id: I0faf0eda459c5353c9ebf1417fd65a17748dc591
2016-02-09rename dumpHxxFile to dumpHppFileNoel Grandin1-20/+20
since we generate .hpp files, not .hxx files Change-Id: I694364c9b0e7c78777201a031435c40b10cfd1ed
2016-02-09Remove excess newlinesChris Sherlock3-3/+0
A ridiculously fast way of doing this is: for i in $(pcregrep -l -M -r --include='.*[hc]xx$' \ --exclude-dir=workdir --exclude-dir=instdir '^ {3,}' .) do perl -0777 -i -pe 's/^ {3,}/ /gm' $i done Change-Id: Iebb93eccbee9e4fc5c4380474ba595858a27ac2c Reviewed-on: https://gerrit.libreoffice.org/22224 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-01-10Fix typosAndrea Gelmini1-1/+1
Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2015-12-01Reduce space needed for string literalsStephan Bergmann1-22/+16
...as had been done in 68ba6ddef50ec4aa92f55fa610c84c9f0d134e67 "codemaker: Allow compiler to share these generated strings" and 2188a7ac2eb37aee89f8f305bdf99db9b05b20bf "Reduce the amount of strings in the release builds," and then undone in 759eb79d886b70c7e7ab86b48e63d1b627b7dc44 "give useful details in non-debug mode too" Change-Id: Ic888d6c47449da3b3a084f863a7e0526f201a967
2015-11-27give useful details in non-debug mode tooCaolán McNamara1-4/+2
Change-Id: I5a3be096ad4417735254abb387b21029e636f5b8
2015-11-26mark UNO structs as SAL_WARN_UNUSED, where possibleNoel Grandin1-2/+63
Change-Id: Ie3de518f60c9f1313c68df54dbdc1fb2804f1f0d
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann10-118/+118
Change-Id: Ic33cbe3feed8aec9f7578aea2cbd809169d9b8c8
2015-11-06coverity#1338267 Uncaught exceptionCaolán McNamara1-0/+4
Change-Id: Id886abbafe7501e17eaae5b2ebf0bd065745c1ad
2015-11-06coverity#1338254 Uncaught exceptionCaolán McNamara1-1/+5
Change-Id: Ie7cf971b3d0c67f33a1b82ff12a8e25506bf0cd0
2015-11-02tdf#94269: Replace "n" prefix for bool variables with "b"Benjamin Ni5-63/+63
Change-Id: I178545792c7354a362658ac7ef8b1d4cf0865797 Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-10-30UNO: no need to use OUString constructor when calling createInstanceNoel Grandin1-4/+4
Change-Id: I37da28539b94706574116d0fff5f008aabfb5526 Reviewed-on: https://gerrit.libreoffice.org/19682 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-10-20loplugin:defaultparamsStephan Bergmann1-2/+2
Change-Id: I3d9d96d1ce91471b7c0e73df848a4893152cd637
2015-10-12Replace "SAL_OVERRIDE" with "override" in LIBO_INTERNAL_ONLY codeStephan Bergmann3-52/+52
Change-Id: I2ea407acd763ef2d7dae2d3b8f32525523ac8274
2015-10-12Replace "SAL_DELETED_FUNCTION" with "= delete" in LIBO_INTERNAL_ONLY codeStephan Bergmann2-6/+6
Change-Id: I328ac7a95ccc87732efae48b567a0556865928f3
2015-08-11new loplugin: defaultparamsNoel Grandin1-1/+1
find places where we do not need to be passing a parameter to a function, because that function has a default value which matches the value we are passing. Change-Id: I04d1fd6275204dd4925e6563282464f461123632
2015-07-24loplugin:unusedmethodsNoel Grandin2-18/+0
Change-Id: If5090c330e12d6e537766bf4a9be0a2360381a7a Reviewed-on: https://gerrit.libreoffice.org/17312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-06-08cppcheck: noExplicitConstructorCaolán McNamara1-1/+1
Change-Id: Ie2ae923ad4c1a66e779711de6ff05328ef144dac
2015-04-01Deprecate getCppuType et al in favor of cppu::UnoTypeStephan Bergmann1-7/+7
...which doesn't suffer from the sal_uInt16 vs. sal_Unicode ambiguity. Change-Id: I4de265145e720615652e88b6a68e03903ad8cba2
2015-03-27loplugin:staticfunctionNoel Grandin1-1/+1
Change-Id: Id796b799f8e2fcc3eae98d43800c5e31fec27fef
2015-03-26const_cast: convert some C-style casts and remove some redundant onesStephan Bergmann1-1/+1
Change-Id: I3f5293be44ba87122de639f75ca477af827a1c51
2015-02-07loplugin:deletedspecialStephan Bergmann2-6/+6
Change-Id: Ice7788ebcfbc638ec21a824c4267757218c14478
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara1-3/+2
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-01-22SAL_DLLPUBLIC_RTTI for proper RTTI visibility for LLVMStephan Bergmann1-4/+4
The Itanium C++ ABI mandates that for a unique (complete) C++ type a single unique symbol for the type's RTTI name is used across a process's dynamic objects (so type equivalence can be determined via pointer comparison on the RTTI names). GCC nowadays deviates from that, using strcmp to determine equivalence, so it is resilient to RTTI names being bound locally within dynamic objects (which has performance benefits, but also makes it impossible to have unrelated types that happen to have the same name "encapsulated" in individual dynamic objects--- whether or not that would violate the ODR would be open to interpretation of how dynamic objects fit into the C++ Standard). LLVM sticks to the Itanium ABI, which becomes notable in at least two places: For one, libc++abi's __dynamic_cast uses strict checking. It still has a _LIBCXX_DYNAMIC_FALLBACK for now that additionally uses strcmp checking and syslogs visibility violations. Mac OS X uses libc++abi with _LIBCXX_DYNAMIC_FALLBACK enabled, and running LO routinely logs dynamic_cast errors to the Console there. For another, RTTI-based UBSan checks unconditionally only use strict checking (cf. isDerivedFromAtOffset in lib/ubsan/ubsan_type_hash.cc). This causes false positives from Clang -fsanitize=function and -fsanitize=vptr even on Linux not using libc++abi. Therefore, introduce SAL_DLLPUBLIC_RTTI to mark types for which RTTI needs to have default visibility under the Itanium/LLVM semantics. There is unfortunately no way to mark only the (implicitly generated) RTTI symbols for default visibility, but at least with the cases where SAL_DLLPUBLIC_RTTI is used for now that is no real problem---any class type marked SAL_DLLPUBLIC_RTTI only has inline (covered by -fvisibility-inlines-hidden) or undefined pure virtual functions. It appears that even the vtables of those classes remain hidden, at least with Mach-O on Mac OS X. (That also means there is no need for a SAL_DLLPRIVATE_RTTI marker analoguous to the---also superfluous in retrospect--- CPPU_GCC_DLLPRIVATE one.) Nevertheless, the number of exported symbols of course increases when SAL_DLLPUBLIC_RTTI is "active." For a full-blown --enable-dbgutil build on Mac OS X, find instdir/LibreOffice.app/Contents -name \*.dylib\* -exec nm -gU {} \; \ wc -l increased from 125541 to 139239. For Linux, an option might be to "activate" SAL_DLLPUBLIC_RTTI only for __clang__ plus !ENABLE_RUNTIME_OPTIMIZATIONS. The set of types marked SAL_DLLPUBLIC_RTTI with this patch (wholesale cppumaker- generated UNO enum, struct, and interface types; plus some IEmbeddedHelper and IUndoManager) is chosen so that a full "make check" on Mac OS X no longer syslogs any dynamic_cast errors to the Console. Change-Id: I42fa6ec01c2503ec24bcd9c0518abb112afa3235
2014-12-27coverity#1019332 Unchecked dynamic_castCaolán McNamara1-7/+6
Change-Id: I280928da005b8cdd94c8bf33eb5aaa86a5ea2fcd
2014-12-27coverity#1019331 Unchecked dynamic_castCaolán McNamara1-7/+6
Change-Id: I902fdbcfd171e93ac57b5021269d2279610b4b0d
2014-12-27coverity#1019327 Unchecked dynamic_castCaolán McNamara1-5/+4
Change-Id: Ibc5a1478d196681cbc124886924eebf065bbdb11
2014-12-27coverity#1019325 Unchecked dynamic_castCaolán McNamara1-0/+3
Change-Id: Ic1607eea119a7321f65b0a0145a263a03406ed6d
2014-12-10Fix generation of com.sun.star.uno.[Runtime]Exception classesStephan Bergmann1-5/+9
Change-Id: If9bd4d906906e0e6cd7c5bb61f8a67a163218395
2014-12-08protected -> privateStephan Bergmann1-8/+4
Change-Id: I807b31eaa0b0cd68e0ca018b6df4269c1aab5763
2014-11-18cppumaker: only include rtl/instance.hxx and mutex.hxx when necessaryMichael Stahl1-4/+22
Change-Id: Ib21a3cfe4b02e421f8848a6e2cca4e2a1c04adb9
2014-11-18More iwyu suggested headers removalRiccardo Magliocchetti2-2/+0
Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Signed-off-by: Stephan Bergmann <sbergman@redhat.com>, undid one remove that was detrimental to loplugin:unreffun Change-Id: I18d8252084d828f94ef7a954e1dbfb45743d7970
2014-11-14fdo#86023 - O[U]String needs a 'clear' methodBrij Mohan Lal Srivastava2-2/+2
Added clear() method to OString and OUString class, Updated appropriate call-sites. Change-Id: I0ba97fa6dc7af3e31b605953089a4e8e9c3e61ac Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2014-11-06Revert "use the new OUString::fromUtf8 method"Stephan Bergmann1-1/+1
This reverts commit 05050cdb23de586870bf479a9df5ced06828d498, not all places that use e.g. OStringToOUString to convert potential UTF-8 are guaranteed to fulfil the prerequisites necessary to use fromUtf8 (and some places like e.g. in codemaker are happy with the best-effort effect of OStringToOUString's OSTRING_TO_OUSTRING_CVTFLAGS).
2014-11-06use the new OUString::fromUtf8 methodNoel Grandin1-1/+1
Change-Id: I771004b7ccab3344a67e827e45bc34c22ffa5f77
2014-10-31Removed duplicated includesAndrea Gelmini1-7/+6
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin1-1/+0
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-24coverity#441989 Uncaught exceptionCaolán McNamara1-5/+4
Change-Id: I579bfc6f4a57aea49e2b023917d0dbd7c3db6c88
2014-10-24coverity#441732 Uncaught exceptionCaolán McNamara1-5/+4
Change-Id: Icd11b81566fec7ce4855cd4e54ff3a3d9862d354
2014-10-07coverity#1242375 Don't call fscanf without specifiersCaolán McNamara2-2/+2
Change-Id: I58082770ca79da9c4d235b5ea0dc79c688c7498b
2014-09-30codemaker: std::auto_ptr -> std::unique_ptrStephan Bergmann2-61/+21
Change-Id: I205c0908254f13970315f8e159997a5ec2f96ed3
2014-09-25java: when rethrowing exceptions, store the original causeNoel Grandin1-8/+129
so that we get a nice complete stacktrace when it hits the final handler Change-Id: Iec4fcc15a2a25c55f591b5e069dce3d010197a90
2014-08-20java: avoid unnecessary comparisons in boolean expressionsNoel Grandin1-6/+6
i.e. stuff like "x == true" Change-Id: Ib82a4a30e736df392405332fa197b588482cffcf
2014-08-19java: use 'Integer.valueOf' instead of 'new Integer'Noel Grandin1-2/+2
Change-Id: Ia8befb8d69914ce971174fc5f2ffc0e2f506a940
2014-07-26coverity#1019323 Unchecked dynamic_castCaolán McNamara1-1/+1
Change-Id: I3d8b598e86339fdd51af48e62393550821b6278d
2014-07-25coverity#1219788 Unchecked dynamic_castCaolán McNamara1-0/+3
Change-Id: I1bedfb601320bc27adc0d0d72fcb8b3c5dfe73ff
2014-07-01New loplugin:stringconcatStephan Bergmann1-4/+3
Change-Id: Id7c517fb37bc28797c45fc0dde83e866f2aa4aac
2014-06-24new compilerplugin returnbyrefNoel Grandin2-7/+7
Find places where we are returning a pointer to something, where we can be returning a reference. e.g. class A { struct X x; public X* getX() { return &x; } } which can be: public X& getX() { return x; } Change-Id: I796fd23fd36a18aedf6e36bc28f8fab4f518c6c7
generated by cgit v1.2.3 (git 2.39.1) at 2024-12-04 05:47:37 +0000