Age | Commit message (Collapse) | Author | Files | Lines |
|
Build target was kept for backward compat in 'rework the default make
target', so lets retire it after 1.5 years.
Use 'make build' instead (which is since the default target anyway).
Change-Id: I93d5237dce2abf2536a4d847d79d33d5b6d6cec9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126362
Tested-by: Jenkins
Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
|
|
Use uuid.uuid5 with a custom URL to generate stable GUIDs. This avoids
glitches in IDE when re-opening the solution after its re-generation
makes some previously opened files to show duplicate entries in IDE's
tabbed UI.
Also drop the UniqueIdentifier elements from .vcxproj.filters files,
which are optional and only used in VS automation [1], so are useless
with randomly-generated GUIDs.
[1] https://docs.microsoft.com/en-us/cpp/build/reference/vcxproj-filters-files
Change-Id: I91dae730286b3187a6ceffcb9ae3afc2b479f4d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124594
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This makes the solution more manageable - one can collapse unneeded
categories.
And put LibreOffice.natvis to Utility folder, to move it to bottom.
Change-Id: I869faaf5756c65e6812b58627acd03bf816dea2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124588
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This allows to define the mapping once, and avoid modification in
multiple places each time a new VS version support is added
Change-Id: I93de4c9d78c3f67a0a2e157007e9d13b6f557937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123163
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Do not require the IDE version in vs*-ide-integration. Instead, use
VCVER environment variable, that is set in configure, to obtain
the toolset for the VCPROJ files. When introducing support for new
VS version, the 'VisualStudioIntegrationGenerator.retrieve_toolset'
method needs to be updated synchronously to list the toolset.
This simplifies the make command to
make vs-ide-integration
TODO: also set the toolset in configure, to simplify the code here,
and also in places like external/python3/ExternalProject_python3.mk
(see commit c156a8c708f74dd31e1ef024edc578c3915619cb).
Change-Id: I95960029a933be2cab96898eee6be6ca6bc5794a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123162
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
VS2017 is not supported since 24973523ba59087185d434396fd614e73d72107f.
Change-Id: I1a2af1eb8c9216eaed87d5454def2176728f719b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123161
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
With the previous modifications to Qt Creator IDE integration,
this makes 'make qtcreator-ide-integration' work when run from
a separate build dir, and allows to use multiple build dirs for
the same source dir in parallel, each with its own set of
Qt Creator files referring to the specific build in their
build and run settings.
Change-Id: I5d85d0d280be5e5edca15760bcccfc793e1e4b2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111553
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
... as a preparation to make this work
for the srcdir != builddir case as well.
Change-Id: I87507b9866f97cdbdf848c6b187b3b8f17262b6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111552
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Create a new method 'get_file_path' which basically
does what 'get_header_extension' and 'get_source_extension'
did, but already concatenates the extension to the
input; call that one and rename other methods accordingly.
While at it, let 'get_source_extension' search for files
in srcdir instead of builddir, as another step in making
generation of qtcreator-ide-integration work properly for
the case where srcdir != builddir.
Change-Id: I1e34bfdb726192b4af21e9003205fa551545ae31
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111551
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
They are overwritten when written with the new content
anyway, since opened with file mode 'w+', i.e. they're
truncated first.
This also simplifies handling the case where srcdir != builddir,
for which support will be added in a subsequent step.
Change-Id: I1dd3386cdf0b97a6299357d6c12ed2d7b6365eae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111550
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I2fe51ab0cdfca5c94bd520ed7f9096bc7c8f6fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111549
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
The variable is used outside of the try block
further down. While that works with how Python handles
variable scopes (and there is no exception before the
assignment happens), moving the variable outside makes
the context/scope clearer.
Change-Id: Iecfd0477ffb4515cf58736ee138fc8ca7273967f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111548
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Generating *.pro.user files is not ideal; they're
supposed to hold user-specific settings for a project,
and thus also to persist manual changes made by the user
after initial import of the project.
Generate *.pro.shared files instead which are
meant to be used to share project settings. [1]
This just changes the file name of the generated
file for now, but leaves the content the same.
The result for the initial loading of the project from
a '*.pro' file is basically still the same from a user
perspective:
A new kit 'Replacement for "Desktop"' is generated on
the fly which contains the build and run settings
specified in the corresponding '*.pro.shared' file.
By using the '*.pro.shared' files, user-specific settings
made after initial import will no longer
be overwritten by running 'make qtcreator-ide-integration'
again, since the '*.pro.user' files are left as they are.
The '*.pro.shared' files generated here still contain
information specific to the local setup (like file paths).
For some more background on LO's Qt Creator IDE integration,
s. dev mailing list thread "Added some information about
Qt Creator IDE integration to the wiki" [2].
[1] https://doc.qt.io/qtcreator/creator-sharing-project-settings.html
[2] https://lists.freedesktop.org/archives/libreoffice/2021-February/thread.html#86800
Change-Id: Ia187bcbffe5297a1cdf6bfeaaabf7867003195e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111474
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
At least with current Qt Creator 4.14, no proper
names were shown for the build configurations in
the project's "Build" settings, but just integers.
Using the config key 'ProjectExplorer.ProjectConfiguration.DisplayName'
instead of 'ProjectExplorer.ProjectConfiguration.DefaultDisplayName'
in the *.user.pro file makes this work as intended, and "01-Global Build"
(and others) shows up as the name for the top-level 'lo.pro' project
and "1-Build vcl" for 'vcl.pro', etc.
Along with the two previous qtcreator-related commits,
this should generally (re)implement an easy way to
run unit tests etc. directly from the Qt Creator IDE
without having to set that up manually, which cloph
mentioned as missing in his FOSDEM talk today
("Using IDEs for LibreOffice development", [1]).
To use this, select the corresponding build configuration
by clicking on the "screen" icon on the bottom left,
then build the project (Ctrl+B or left-click on the
"hammer" icon on the bottom left).
I didn't check whether the single targets are still up
to date.
[1] https://fosdem.org/2021/schedule/event/lo_ideforlodevelopment/
Change-Id: I9965829db319a8b26f5ad82d3ffa723a28da7910
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110536
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Fix indentation and drop some extra empty lines that are
automatically removed once the project is loaded in
Qt Creator and then closed anyway.
This will make it a little easier to compare what the initially
generated file looks like compared to the one as it is written
after (implicitly or explicitly) carrying out the configuration
in Qt Creator after loading the project.
Change-Id: I52173162efe635e6fb3e7f889c42ed67271c05b1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110535
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Use the 'lib' instead of the 'app' template for the
qmake files in the subdirectories, which avoids
automatically creating a useless run configuration
for each subdirectory pointing to a non-existent
execuatable, like '<BUILDDIR>/accessibility/accessibility'
etc.
With this in place, I just get a single "Custom Executable"
run configuration running 'instdir/program/soffice.bin'
when opening the newly generated 'lo.pro' in Qt Creator 4.14.
Change-Id: I69a7f1b56b02849b217bf66f110d9ee1f61125ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110534
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Exception ignored in: <_io.FileIO name='compile_commands.json' mode='wb' closefd=True>
ResourceWarning: unclosed file <_io.TextIOWrapper name='compile_commands.json' mode='w' encoding='UTF-8'>
Change-Id: I2ab4275a9b7897f5cd9e88b20a1eea4c68fe0d1f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102907
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
According to [1]:
> Changed in version 3.6: Unrecognized escape sequences produce a DeprecationWarning.
> In a future Python version they will be a SyntaxWarning and eventually a SyntaxError.
[1] https://docs.python.org/3/reference/lexical_analysis.html#string-and-bytes-literals
Change-Id: Ia4f79f17ccb121f423f35b1e1306d5ae285e8762
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98321
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... so `TK_DLL_NAME=\"tklo.dll\"` becomes `TK_DLL_NAME="tklo.dll"`
Change-Id: I0e14ded85be387a342e1979aa3f120727178351d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98319
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
.. instead of source dir. This allows to have ide integration files
in proper directory when using out-of-the-tree build directory.
Change-Id: I0d3be02b3ee27e499d9d223b0a521e4688885a1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87502
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Icb4e879025278291270d908bb53178250c8e7007
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87192
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... in particular to have a deterministic order and see
more easily what relevant effects changes to the
gbuild-to-ide script have while testing those.
Change-Id: I4583a8ca5a779d1d1e8aa6db7bb0295abd6154ee
Reviewed-on: https://gerrit.libreoffice.org/80653
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
This makes code-completion, clang checks, navigation etc.
work in files related to those as well.
Change-Id: Ie0b7d75f2ed953228d74ae070056327bff7ff2a2
Reviewed-on: https://gerrit.libreoffice.org/80652
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Recursivley walk the include directories located
inside the current module's directory, since includes
are basically paths relative to the include directories
and can refer to files in subdirectories of the include
path, like e.g.
#include <extended/AccessibleBrowseBoxBase.hxx>
in 'accessibility/source/extended/AccessibleBrowseBoxBase.cxx'.
This way, such header files are added to the .pro files
and are thus e.g. shown in Qt Creator's project view
and can be found by using 'a <FILEANME>' in the Locator.
Change-Id: Id74f971b2ffee82203f74a4d444c41166c671920
Reviewed-on: https://gerrit.libreoffice.org/75628
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Absolute paths in files created by GbuildToJson
in Cygwin environment are Windows paths
(like "C:/....'), while relative paths in the Python
program executed in Cygwin are treated as Unix paths
('/cygdrive/c/....') which caused wrong relative paths to
be generated by the call to 'os.relpath'. It would walk up to
the root of the Windows path and then walk down the tree in the
Unix file system path again.
This converts the paths to absolute Windows paths first to avoid
this issue.
Change-Id: I2e3e6926e312d64aa18067933a5903ac7ad5d31a
Reviewed-on: https://gerrit.libreoffice.org/75114
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I14b7ebb3521f9a23fcf4c3ff907408327f189f29
Reviewed-on: https://gerrit.libreoffice.org/74138
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
If the '-std=' compiler flag is set in CXXFLAGS,
take that over into the .pro files used by
Qt Creator.
This makes ClangCodeModel use the correct std version,
and e.g. know about 'std::string_view' if '-std=gnu++2a'
(or anything else indicating C++17 or higher is supported)
is used and thus avoids unnecessary errors/warnings from
being displayed.
Use a list, so other flags can easily be added later.
(It currently doesn't seem reasonable to me to just pass all
cxxflags though, since .pro files are currently only generated
per top-level module, while C++ flags can differ between
different targets in the same module).
Change-Id: Id3f3e2b9ba77e5220a17fd4796937c816979959a
Reviewed-on: https://gerrit.libreoffice.org/73677
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Adding AdditionalOptions to nmake project settings allows IntelliSense
to know about used compiler switches; specifically, passing std switch
(currently -std:c++17) defines _MSVC_LANG macro [1] to proper value to
avoid false IntelliSense errors (e.g., for string_view).
[1] https://docs.microsoft.com/en-us/cpp/preprocessor/predefined-macros
Change-Id: I90309e6bf2a87257a0c81b1406e678af962eb587
Reviewed-on: https://gerrit.libreoffice.org/67805
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I70613baada4f82e5e56f9a21547733c3a6907b53
Reviewed-on: https://gerrit.libreoffice.org/66908
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Take system includes ('-isystem') into account
when generating the '*.pro' files for Qt Creator
using the 'qtcreator-ide-integration' make target.
Without this, Qt Creator is unable to find the
corresponding included files.
This also makes Qt Creator's ClangCodeModel
able to properly process files and display
actual problems, rather than always showing
a multitude of errors due to missing includes
while parsing the source/header files.
Change-Id: Ie513341e1074ceab9304ae9df73fac9a79329db8
Reviewed-on: https://gerrit.libreoffice.org/65129
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I69e4d471c806159d6748016a79f041c01b40b888
Reviewed-on: https://gerrit.libreoffice.org/64430
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
This allows to avoid the "(Visual Studio 2015)" labels next to project
names in Solution Explorer; and also avoid multiple warnilgs like
project-name.vcxproj : warning : The build tools for Visual Studio
2015 (v140) cannot be found. Install Visual Studio 2015 (v140) to
build using the Visual Studio 2015 (v140) build tools.
in IDE's Output pane in case VS2015 is absent locally.
Change-Id: I53b68ac810cbf2a31667c35dd549310e7209e010
Reviewed-on: https://gerrit.libreoffice.org/59797
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Fixes the problem that e.g. this code:
OUString str;
str += "";
is marked as a compile error, when clang would still work with c++11,
but the tree is configured for gnu++17.
Change-Id: Id60c0cf4b8c693b534f16ba813cf01a4bad7e560
Reviewed-on: https://gerrit.libreoffice.org/59746
Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
Tested-by: Jenkins
|
|
Change-Id: I4a17cfb567f5ebec8bb416b9aa4d58763ff36c36
|
|
It turns out that VS IDE's "Peek definition" (and other functions that
navigate to sources) fail if the short ("DOS") path to the file is given
in project's includes: see issue at
https://developercommunity.visualstudio.com/content/problem/139659/vc-peek-definition-fails-to-navigate-to-windows-ki.html
This patch converts the include paths to full Windows paths, to avoid the
problem. Also, since IDE starts working correctly with this change, this
patch removes inclusion of "inherited" paths "$(IncludePath)", which are
the paths added by Visual Studio itself. Since we do specify all include
paths explicitly, that is not required, and avoids confusion.
Change-Id: Ide2d948f8c7b050b02f550342144fede4fcafb82
Reviewed-on: https://gerrit.libreoffice.org/53731
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Avoids VS warnings:
> smoketest\Library_smoketest.vcxproj.filters : warning : Unable to
> read the filters file "Library_smoketest.vcxproj.filters". Please
> unload the project "Library_smoketest.vcxproj" to be able to edit it.
> The required attribute "Include" is empty or missing from the element
> <Filter>.
Change-Id: I0f02e837823a5e7a0355fd0f895f00c63a5df6fc
Reviewed-on: https://gerrit.libreoffice.org/51684
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
It is more likely that soffice.bit should be debugged, not soffice.exe
stub. This allows to start debug session from VisualStudio, and debug
startup code.
Change-Id: Iab4615c67aeb25b811ecc71f6ae48aa9b40c45dc
Reviewed-on: https://gerrit.libreoffice.org/48025
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Since commit ecbaf980625a9e7b06abe91c7c70e78f6ad469a7 (-I$(dir $(3)) in
gb_CObject__command_pattern is no longer needed, 2017-11-01).
Change-Id: I9d6b7436f7b6e865d37e358adb9cf075e4e51bff
|
|
Moved gbuild-to-ideNS to gbuild-to-ide (NS was the original)
Removed gbuild-to-ideNS from Makefile.in
the original gbuild-to-ide was split off to gbuild-to-ideNS, in order
not to disturb the production environment while playing with new ide
generation.
Work on a new IDE generator have been stopped for a half year, so time
to clean up.
The work on a new Xcode generator continues offline (for now), and are
part of the iOS development.
Change-Id: Ia67355df21c6aec592d792ffa7c904a568eff961
|
|
Before this, -D_WIN32_WINNT=0x0601 used to land to VS project simply
as _WIN32_WINNT (without value).
Change-Id: I68ebdc24c3181c5d9e046280756e4cefee3de46c
Reviewed-on: https://gerrit.libreoffice.org/43928
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Previously, defines string like this:
-DDBG_UTIL -DNOMINMAX -D_DLL -UNOMINMAX
would produce this defines list:
DBG_UTIL;NOMINMAX;_DLL -UNOMINMAX
where last "define" is incorrect; proper list should be
DBG_UTIL;_DLL
so that the undef'ed element would be properly eliminated from the
result. This patch takes care of this.
Change-Id: Ia66a1d6d0a6e0bbfd0022b22285b005609871336
Reviewed-on: https://gerrit.libreoffice.org/43923
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
See https://msdn.microsoft.com/en-us/library/jj620914
Change-Id: Ibd18f1c36c46ea47c897542f35e3ea2a8bc0a8ac
Reviewed-on: https://gerrit.libreoffice.org/39510
Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
Tested-by: Jenkins <ci@libreoffice.org>
|
|
Too old to build master.
Change-Id: I01636c9ae26ddb3954dcfdd1977551c0f115a81b
|
|
change for cicle to generate only one .vcxproj and .filter pr module
Change-Id: I93f2279e368e11ef5b9d442c6dcdfa4bf39bd6c2
Reviewed-on: https://gerrit.libreoffice.org/35075
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>
|
|
this patch fix some problem in the class testVS2013Ide:
fix some tag xml bad generated, i test the project pocheck
and it compiles.
Change-Id: I5a4e3e71286a486e03ecbe936fb848e589ff71c9
Reviewed-on: https://gerrit.libreoffice.org/34739
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>
|
|
this patch add a PropertySheet.props in the windows directory
in this file can put the enviroment variables
for vs2013.
i add in the gbuildparser a variable _jsonsrcdir that
contains the SRCDIR path that it can found in the json file.
with this file we can use enviroment variables of LO.
e.g.: $(SRCDIR), $(BUILDDIR) etc...
in the VS2013 ide.
Change-Id: Ie3158fd31fe247833115d445553f613dcd1a3b1d
Reviewed-on: https://gerrit.libreoffice.org/34749
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@libreoffice.org>
|
|
double ".ccx" for each source files in the .filters in the
testVS2013Ide.
this patch fix that.
Change-Id: Ic06800c260800f72254038e30119db40fe048037
Reviewed-on: https://gerrit.libreoffice.org/33892
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
this function generates a vcxproj, for the reverse engineering
i generate a vcxproj from VS2013 that:
-the compiler works good
i do the code that generates it
the code miss that the link to lib that i left commented
Change-Id: If98eb5645c9e1060a55701abf5b96db85eca6ce5
Reviewed-on: https://gerrit.libreoffice.org/33893
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|
|
In order to compile correct this flag is needed and
it is not exported in the json files
Change-Id: Ib8f0b882f2d59ed467a9198c148263e2882c60b3
|
|
the path in gbuildparse changed, so this patch re-adapt this
2 IDE integration
Change-Id: I5f7a679b8b12eac6f44030a33713ff19327b9d1a
Reviewed-on: https://gerrit.libreoffice.org/33815
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: jan iversen <jani@documentfoundation.org>
|