summaryrefslogtreecommitdiff
path: root/basic/source
AgeCommit message (Collapse)AuthorFilesLines
2014-02-14fix crash when importing unsupported macro content, related fdo#59374Markus Mohrhard1-0/+6
Change-Id: I960c8174454074fd9ddb27fb17244d782c4cb24c Reviewed-on: https://gerrit.libreoffice.org/8038 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-01-21Resolves: fdo#73771 Non-standard behaviour for Function MidJulien Nabet1-1/+2
Change-Id: I90be516235228574dc219447a0eef3a34f83bee2 Reviewed-on: https://gerrit.libreoffice.org/7539 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ff48f28f71609b0ab4e6b8bc79818f765e48fddd)
2014-01-16Environment variables can contain >127 charactersAndras Timar1-1/+1
Change-Id: Iaeb690429d835ab2e6c13a8890a1b27b9405796a Reviewed-on: https://gerrit.libreoffice.org/7476 Reviewed-by: Fridrich Strba <fridrich@documentfoundation.org> Tested-by: Fridrich Strba <fridrich@documentfoundation.org>
2013-12-02Resolves: #i74854# fix buttons in MsgBox with info iconHerbert Dürr1-1/+1
Patch by: hanya.runo@gmail.com Found by: ooo@catcons.co.uk Tested by: hdu@apache.org (cherry picked from commit 02cc651a1b45cbfbdab0aca6b57bff7bdf9e4f2c) Conflicts: basic/source/runtime/methods.cxx vcl/inc/vcl/msgbox.hxx Change-Id: I1656263e189f1a6cfa58436741bfa74ae0e6fffa (cherry picked from commit 3a437baee23d45ab64d557fed75e2e1b14aa5541)
2013-11-19remove unnecessary use of OUString constructor when assigningNoel Grandin1-2/+2
change code like aStr = OUString("xxxx"); to aStr = "xxxx"; Change-Id: Ib981a5cc735677ec5dba76ef9279a107d22e99d4
2013-11-14SAL_WARN_UNUSED com::sun::star::uno::AnyStephan Bergmann1-1/+0
Change-Id: I9058044d13f696e07667dce706f6c311af6dbea0
2013-11-14remove unnecessary sal_Unicode casts in various placesNoel Grandin2-7/+7
Change-Id: Ibf04062ca86ed866202d748c3b62a210d30ed6ec
2013-11-11basic: include <> for external includesNorbert Thiebaud19-46/+46
Change-Id: I4715bbe853d60ef15f20a4d2441c688003ca568e
2013-11-11SAL_WARN_UNUSED INetURLObjectStephan Bergmann1-1/+0
Change-Id: Ia9af3b76c2a2ac654b02c1502aa2d0c2c987fbf2
2013-11-11convert OUString compareToAscii == 0 to equalsAsciiNoel Grandin1-1/+1
Convert code like aStr.compareToAscii("XXX") == 0 to aStr.equalsAscii("XXX") which is both easier to read and faster. Change-Id: I448abf58f2fa0e7715dba53f8e8825ca0587c83f
2013-11-11remove unnecessary use of OUString constructor in BASIC moduleNoel Grandin8-38/+38
Change-Id: Iee86ce9200285647d5031cb2f89266a52704dd44
2013-11-01add limits.h for rhel-6 buildCaolán McNamara1-1/+2
Change-Id: I9d355be54eb4072044ad660296375fca8d0fa831
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin1-1/+1
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-28fixincludeguards.sh: basicThomas Arnhold33-69/+69
Change-Id: Id797a8969e42876092da347d8e1bba6195b697dc
2013-10-28windows: warning 4355 is disabled globally in com_MSC_defs.mkThomas Arnhold1-5/+0
So there is no need to do this locally, too. Change-Id: I0fa1d0cd3e077ba0985848a9d2cbb061b123e8ad
2013-10-23clean up places accessing the NULL at the of an OUStringNoel Grandin2-9/+13
There were only a couple of real bugs fixed, but we're a little bit safer now. This also fixes the assert and the comment in OUString::operator[] about this. Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist7-9/+9
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara1-1/+1
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28
2013-10-21fdo#68849 add some header guardsThomas Arnhold2-0/+10
Change-Id: I9d25a58f22095689eccc0ac444c163d1e9bee69f Reviewed-on: https://gerrit.libreoffice.org/6364 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-10-17The getSupportedServiceNames implementations will already take careStephan Bergmann1-1/+0
Change-Id: I0c7ae8e0393f069259b943e04368e874abdf8386
2013-10-17fdo#54938: Adapt svtools and comphelper module ...Marcos Paulo de Souza1-12/+2
to use cppu::supportsService and other pieces. Change-Id: I16893b3d31a8055acd214ff23d01e63d38fe0826 Signed-off-by: Stephan Bergmann <sbergman@redhat.com>
2013-10-15clean up SbiScanner::NextSym() a little, fdo#70319 follow-upEike Rathke1-38/+58
Number recognition was suboptimal and didn't properly resync scan positions after having detected an error. Change-Id: I278fdaaf17ed40560785deaaad0e3412a249d90a
2013-10-15Defer OUString -> OString conversionStephan Bergmann3-20/+15
...to avoid converting back OString -> OUString in SbiIoSystem::WriteCon. Change-Id: I17024891d0babaa589f2c65f1123f1905c4338bb
2013-10-12Nothing Unix-specific about <stdlib.h>Tor Lillqvist1-2/+0
Although unsure whether this source file actually uses anything declared in <stdlib.h>... Change-Id: Ibb5dfe5d0de1576a37a5f2c9cffcd9b850602b14
2013-10-12Test WNT instead of the vague UNXTor Lillqvist2-16/+9
Change-Id: Icacdae592f05bcdcf50223d607976d687e182c96
2013-10-12We already have SAL_CALL that means __cdecl on WindowsTor Lillqvist1-8/+1
Not that there should be any need to use it here; it is the default anyway. Also the extern "C" is bogus here as far as I know; that affects only the external name of the function, and that a function is passed to bsearch() doesn't set any requirements on the external name of it. It could be a static function with no global symbol name. But oh well. Change-Id: Ia264bf2f952fd6f38aa36a25a084383d4d3f1bdc
2013-10-12Bin two unused functionsTor Lillqvist1-10/+0
Change-Id: I8362bfa0152f84a425ea3d461653d45c07816b92
2013-10-11CID#1103740 uninitialized valueCaolán McNamara1-1/+1
Change-Id: I2d10104277d8ad0781e3dd088d51d62fa759fe57
2013-10-10little String to OUString + documentationThomas Arnhold1-1/+1
Change-Id: I982e44150fd2909da0571409f16051d79377d7a3 Reviewed-on: https://gerrit.libreoffice.org/6192 Reviewed-by: Thomas Arnhold <thomas@arnhold.org> Tested-by: Thomas Arnhold <thomas@arnhold.org>
2013-10-09Improve ErrorCodeIOException messagesStephan Bergmann1-4/+11
...and clean up some includes. Change-Id: Ia5843cd38f967722d7173a6c87fba26064e3ffd6
2013-10-07CID#708773 unused pointer valueCaolán McNamara1-3/+3
Change-Id: Ib394a444882f5ffa1e0c5e833d59f4e4985479df
2013-10-07CID#707648 uninitialized memberCaolán McNamara1-0/+1
Change-Id: Ib8371710dd6c856b143782ca9c18f4ee76798f0e
2013-10-07CID#707646 uninitialized member variablesCaolán McNamara1-2/+6
also CID#707647 Change-Id: I9962bd2417119944a243d8a92711866548248e36
2013-10-07CID#707643 uninitialized membersCaolán McNamara1-1/+6
Change-Id: I23386c780bf484652a518d907d7dc0cc3c910040
2013-10-07CID#738564 uninitialized memberCaolán McNamara1-0/+1
Change-Id: I35a4d3d412b1848fe3ef8aed600471fc1c8a61d2
2013-10-07CID#707638 uninitialized membersCaolán McNamara1-1/+3
Change-Id: Ic0757e544e42f7ca07cddec379d2d647822d9923
2013-10-07CID#707636 uninitialized membersCaolán McNamara1-1/+3
Change-Id: I7eba8ac0f676a2a16dc12ed423356539aec7148b
2013-10-07CID#738563 uninitialized memberCaolán McNamara1-1/+5
Change-Id: I5413099beb3b30f92b58f973fa4bb03f29e7f5c3
2013-10-07sal_Bool to boolTakeshi Abe4-30/+30
Change-Id: Ie8e35c4342db6e2dc35fca33cee7b4d71cfcb732
2013-10-04'ist' -> 'is' here and there.Jan Holesovsky1-1/+1
Change-Id: I0a463c38214b95582db2c7b3979367255426c14e
2013-10-03unused StringHashCodeCaolán McNamara1-8/+0
Change-Id: I72b882292f62c4a2b4999fa3e553db3c617e03f4
2013-10-02sal_Bool to boolTakeshi Abe8-67/+67
Change-Id: I16ddbcf100e21d6c05fccbe24faca2932a605902
2013-09-25Related: fdo#38838 remove UniString::EqualsIgnoreCaseAsciiCaolán McNamara1-3/+3
Change-Id: Ib5c3a2daa4a48bc286b14fa2cebb3306ea0012bc
2013-09-17convert BASIC from String to OUStringNoel Grandin5-23/+23
Change-Id: I4b046e4c460305acad29862341092af948639215
2013-09-12CID#736166 unlikely out of boundsCaolán McNamara2-2/+6
Change-Id: I8a0f97be1723766df9f8fe287417365febf54966
2013-09-12CID#707499 check for 0 nDimsCaolán McNamara1-1/+1
Change-Id: I828339695db1b1880d7e884f8bf26911d04b8508
2013-09-11Easier conversion between Basic Date and UNO Date/TimeLionel Elie Mamane9-27/+235
Utility functions to convert between Basic Date type and the representations of Date and Time in UNO, namely: - com.sun.star.util.Date - com.sun.star.util.Time - com.sun.star.util.DateTime Name of new functions: - CDateToUnoDate - CDateFromUnoDate - CDateToUnoTime - CDateFromUnoTime - CDateToUnoDateTime - CDateFromUnoDateTime Change-Id: I2b971df20df1c0351d071023e042169b548894f1 Reviewed-on: https://gerrit.libreoffice.org/5897 Reviewed-by: Noel Power <noel.power@suse.com> Tested-by: Noel Power <noel.power@suse.com>
2013-09-10janitorial: c++-style castLionel Elie Mamane1-1/+1
Change-Id: I746eff36778e30e36b975e24c70712301c3c71cb
2013-09-04WaE: use number() instead of valueOf()Tor Lillqvist2-2/+2
Change-Id: Ic45dc030f76531d202a12e227130d11d3d1de805
2013-09-03WaE: C4101: 'ex' : unreferenced local variableTor Lillqvist1-1/+1
Change-Id: If56eaa48c176138cd1b74da2f7f0aa71e3845894