summaryrefslogtreecommitdiff
path: root/android
AgeCommit message (Collapse)AuthorFilesLines
2023-12-30android-viewer translated using WeblateWeblate1-0/+63
Hungarian currently translated at 50.8% (60 of 118 strings) Change-Id: I827a786aca47cb057e3c822d04aba13906ebef2d Added translation for android-viewer using Weblate (Hungarian) Change-Id: Ic660281a13f5b4a1ad0d0bd35618038d143c1994 Co-authored-by: Gábor Kelemen <kelemeng@gnome.hu> Co-authored-by: Weblate <noreply@documentfoundation.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hu/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161304 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-25android-viewer translated using WeblateWeblate9-5/+253
Dutch currently translated at 100.0% (118 of 118 strings) Change-Id: I59c75900254b4124ff7dc8397a943908404e0a5c android-viewer translated using Weblate Italian currently translated at 35.5% (42 of 118 strings) Change-Id: I73561c67beafbeeee4896d7b2301d1b3970eb030 android-viewer translated using Weblate Asturian currently translated at 100.0% (118 of 118 strings) Change-Id: I83e753b66c856b4fa39cba5bf1de1e44616b1cba android-viewer translated using Weblate Basque currently translated at 100.0% (118 of 118 strings) Change-Id: I6e956873841380aabd1351dbbd07f3466ba28275 android-viewer translated using Weblate French currently translated at 100.0% (118 of 118 strings) Change-Id: I1af1d53bd1daaab3bd0404d8fe75b92e5923b9e2 android-viewer translated using Weblate Punjabi currently translated at 95.7% (113 of 118 strings) Change-Id: I7582795194c21cc6c954884bd4612e9cefc01308 android-viewer translated using Weblate Galician currently translated at 100.0% (118 of 118 strings) Change-Id: Ica6acf55e43ec98648b021b9f38871aedf2581fa android-viewer translated using Weblate Turkish currently translated at 100.0% (118 of 118 strings) Change-Id: If8639fcaf3b5b0447c0b00f5fe85ed55d0bb7cad android-viewer translated using Weblate German currently translated at 100.0% (118 of 118 strings) Change-Id: I0c5795094434899569e18ae6d87c4bed2e10ea01 Co-authored-by: A S Alam <amanpreet.alam@gmail.com> Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Aitor Salaberria <trslbrr@gmail.com> Co-authored-by: Ayhan YALÇINSOY <ayhanyalcinsoy@gmail.com> Co-authored-by: Christian Kühl <kuehl.christian@googlemail.com> Co-authored-by: Elisabetta Manuele <calembour@hotmail.it> Co-authored-by: Xosé <xosecalvo@gmail.com> Co-authored-by: kees538 <kees538@gmail.com> Co-authored-by: sophie <gautier.sophie@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/nl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/161274 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2023-12-19Added translation for android-viewer using Weblate (Indonesian)Weblate9-4/+490
Change-Id: I55e7159ff10e7bb0ee32651a8f23f2f3a4e1282c android-viewer translated using Weblate Asturian currently translated at 100.0% (118 of 118 strings) Change-Id: Ica863fed7663f5f5c17820a4010262101fcc358c android-viewer translated using Weblate Nepali currently translated at 16.9% (20 of 118 strings) Change-Id: Ifc64ae37b7faa5bad89f70178565595630993420 android-viewer translated using Weblate Greek currently translated at 100.0% (118 of 118 strings) Change-Id: Icb257e6a5cfd38de5a27425f69294e059796e596 android-viewer translated using Weblate Ukrainian currently translated at 100.0% (118 of 118 strings) Change-Id: Iddf1e095b789f2a324fbc614d57b98ab3df8ed0e android-viewer translated using Weblate Asturian currently translated at 100.0% (118 of 118 strings) Change-Id: I318be3807e77e190d857f1d9edd25fc9d7a60c0a android-viewer translated using Weblate Asturian currently translated at 100.0% (118 of 118 strings) Change-Id: If8105733d78073254da1ccd16817581d53ab55b8 android-viewer translated using Weblate Chinese (Traditional) currently translated at 100.0% (118 of 118 strings) Change-Id: I7ef697098031684e32aed137b2ac6bd844ed94fb Added translation for android-viewer using Weblate (Nepali) Change-Id: I2d68cb2696827a6cd6e2ad634873857344c8ac9f android-viewer translated using Weblate Greek currently translated at 57.6% (68 of 118 strings) Change-Id: Ic029d631692c1f47a9d7eeda13ce6ac38a59c3b8 android-viewer translated using Weblate Greek currently translated at 56.7% (67 of 118 strings) Change-Id: Id3456928ecb1a9aab0c27e77fbe49a02540fd8c4 android-viewer translated using Weblate Asturian currently translated at 58.4% (69 of 118 strings) Change-Id: Ibaf90837a1f25d070f9dd8ac183fbca6c26e85c4 android-viewer translated using Weblate Italian currently translated at 11.8% (14 of 118 strings) Change-Id: I64eb0e5cbf5a6ab050c6ef18a1adae68317005d8 android-viewer translated using Weblate Asturian currently translated at 32.2% (38 of 118 strings) Change-Id: Ie470cf5f249a0e498413571cd0b56a5421f5710a android-viewer translated using Weblate Asturian currently translated at 32.2% (38 of 118 strings) Change-Id: I687ae9fe76f85a03f0876f4eda55d943f51b43fb android-viewer translated using Weblate Slovenian currently translated at 100.0% (118 of 118 strings) Change-Id: I0c0cc15c6d5f245311c12d05afd4742db649389d android-viewer translated using Weblate Chinese (Traditional) currently translated at 100.0% (118 of 118 strings) Change-Id: I2ddc5b6a36a512e6e4d1e52c96e282b0ff05f2ea android-viewer translated using Weblate Welsh currently translated at 100.0% (118 of 118 strings) Change-Id: I34dbcafeaf61e7400d07910976ff71fdbe8ae4b0 Added translation for android-viewer using Weblate (Greek) Change-Id: Idfc6ee0a0988f3c414e6e6beee58a96ab5fb9547 Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Andika Triwidada <andika@gmail.com> Co-authored-by: Cheng-Chia Tseng <pswo10680@gmail.com> Co-authored-by: Dimitris Spingos <dmtrs32@gmail.com> Co-authored-by: Elisabetta Manuele <calembour@hotmail.it> Co-authored-by: Martin Srebotnjak <miles@filmsi.net> Co-authored-by: Po-Yen Huang <jeff.huang@ossii.com.tw> Co-authored-by: Rhoslyn Prys <post@meddal.com> Co-authored-by: Saroj Dhakal <lotusnagarkot@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: Xandru Martino Ruz <xandrumartino@softastur.org> Co-authored-by: Євген Кондратюк <lachend@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/el/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ne/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/uk/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/zh_Hant/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160909 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-17android-viewer translated using WeblateWeblate12-11/+513
Lower Sorbian currently translated at 100.0% (118 of 118 strings) Change-Id: Ic20ccfbdde8de842548b79e3b5dfde85f300dc90 android-viewer translated using Weblate Upper Sorbian currently translated at 100.0% (118 of 118 strings) Change-Id: Iddaca4eedc9f022377c81929814856c31067f50d android-viewer translated using Weblate Italian currently translated at 5.9% (7 of 118 strings) Change-Id: I9e0f677f79c7496211959a3360eb166af6226aee Added translation for android-viewer using Weblate (Ukrainian) Change-Id: I130f051543b758544ac3b2a069899870ac16058d android-viewer translated using Weblate Upper Sorbian currently translated at 100.0% (118 of 118 strings) Change-Id: I8655aa3d29866b006f839c93d242332e1102fb4a android-viewer translated using Weblate Czech currently translated at 1.6% (2 of 118 strings) Change-Id: Ib3f028432a47679478f17cadcf031f425293e745 Added translation for android-viewer using Weblate (Lower Sorbian) Change-Id: I1978530538c3808b939729c15fd9a16ed2ab8b3d android-viewer translated using Weblate Icelandic currently translated at 100.0% (118 of 118 strings) Change-Id: Ib7f514c6082fe1b85f6c40f70024cefab8f4b103 android-viewer translated using Weblate Asturian currently translated at 19.4% (23 of 118 strings) Change-Id: I726ac83b54a25b2c12747992f425ac713e33825d android-viewer translated using Weblate Portuguese (Brazil) currently translated at 100.0% (118 of 118 strings) Change-Id: Ib03330ad83be7cd6bf01f99a51870b5eb5c0a316 android-viewer translated using Weblate Armenian currently translated at 100.0% (118 of 118 strings) Change-Id: Idbdaeed85c0cbcfb037de074d34558c10fd978bb Added translation for android-viewer using Weblate (Upper Sorbian) Change-Id: I2f5ca2465e7d788f290656f728da1a3ed001ba19 Added translation for android-viewer using Weblate (Dutch) Change-Id: I9cfed846807c16dd7c9c92d32ada641d89082579 Added translation for android-viewer using Weblate (Icelandic) Change-Id: I120a3e1603867ae60b25531686dbbac5a8086bf2 Added translation for android-viewer using Weblate (Italian) Change-Id: I16661f95066ee125409b7e939721b0070c59cf2d Added translation for android-viewer using Weblate (Asturian) Change-Id: I561826cd41e1de13f8c683a9ffe005cccb2e1246 android-viewer translated using Weblate Czech currently translated at 0.8% (1 of 118 strings) Change-Id: I1fbb418d0c82e587e56dca7b1e751f05fbe256e9 android-viewer translated using Weblate Polish currently translated at 100.0% (118 of 118 strings) Change-Id: I4d9f8bf30b3a084940356258ae929bf061dba129 android-viewer translated using Weblate French currently translated at 32.2% (38 of 118 strings) Change-Id: I327ef925fc254142b4668385a79f502ef0bb888d Added translation for android-viewer using Weblate (Czech) Change-Id: I1215d7ba1a3d4fac3ebf00de9d55ef31753a356e Co-authored-by: Adam Rak <kitynska@gmail.com> Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Elisabetta Manuele <calembour@hotmail.it> Co-authored-by: Michael Wolf <milupo@sorbzilla.de> Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org> Co-authored-by: Stanislav Horáček <stanislav.horacek@gmail.com> Co-authored-by: Sveinn í Felli <sv1@fellsnet.is> Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: raal <raal@post.cz> Co-authored-by: sophie <gautier.sophie@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ast/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cs/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/dsb/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hsb/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hy/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/is/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/it/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt_BR/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160842 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15Update translation files for android-viewerWeblate17-92/+598
Updated by "Cleanup translation files" hook in Weblate. Change-Id: Ie0d7d835fba42e9a8cfb73370a8b153168a9cf9e android-viewer translated using Weblate Slovenian currently translated at 100.0% (132 of 132 strings) Change-Id: Id07e5c018310b97460f7750c2db2f43127c483c5 Added translation for android-viewer using Weblate (Slovenian) Change-Id: Ie9008b437173feb5a871e119fd00e5f134dd0da9 android-viewer translated using Weblate Polish currently translated at 100.0% (132 of 132 strings) Change-Id: Iacacacd662c48986358e904598d458c44ca8805f Added translation for android-viewer using Weblate (Japanese) Change-Id: I3373654075eabc79c42cd2c67daf62f5f7111158 Added translation for android-viewer using Weblate (Chinese (Traditional)) Change-Id: I7af06e08b6567f990641ad532b8b94df2ec7d367 android-viewer translated using Weblate Basque currently translated at 100.0% (132 of 132 strings) Change-Id: I9b29af97d0642fa36c09ce38bf14290f60ccb8cd android-viewer translated using Weblate Polish currently translated at 100.0% (132 of 132 strings) Change-Id: Ie0b345d1dc63102120cb871f8066ed710917e72f android-viewer translated using Weblate Portuguese (Brazil) currently translated at 54.5% (72 of 132 strings) Change-Id: I652b6dde8cd02c9b4baff5ba5453f7471f8eb896 android-viewer translated using Weblate Catalan currently translated at 100.0% (132 of 132 strings) Change-Id: Ic7b42998072d6bb02937e88af76620564abc51b8 Added translation for android-viewer using Weblate (Finnish) Change-Id: Iae55f9b007d7d34162d77c8f62d025fa54ff8035 Added translation for android-viewer using Weblate (Basque) Change-Id: I88291444f52d5f4189c17330f855683268a2bffc android-viewer translated using Weblate Catalan currently translated at 62.1% (82 of 132 strings) Change-Id: I28ec1b2f54d39209f7d802ba9aa899d12b2a3b35 android-viewer translated using Weblate Persian currently translated at 2.2% (3 of 132 strings) Change-Id: I7ba58594540aff2ad592771e73efeeccdff027db android-viewer translated using Weblate Portuguese (Brazil) currently translated at 33.3% (44 of 132 strings) Change-Id: I092277ffea906ad3da9b73e7831536a482bb104f android-viewer translated using Weblate French currently translated at 1.5% (2 of 132 strings) Change-Id: Ia8553c387bec6c66c6def3de9b4b41016ead2bb1 Added translation for android-viewer using Weblate (Polish) Change-Id: Ibe83470b27b286030024f654df5cf30b2cb727ed Added translation for android-viewer using Weblate (Persian) Change-Id: I67bb9684aaa873ca4129139fb340b84634c9fe7e android-viewer translated using Weblate Portuguese (Brazil) currently translated at 20.4% (27 of 132 strings) Change-Id: I628da41052ac2957601226a5e03796bd67744863 Added translation for android-viewer using Weblate (Portuguese (Brazil)) Change-Id: I8ee44239235aaba0c44f805d93d2cb8db4383fab android-viewer translated using Weblate Punjabi currently translated at 87.8% (116 of 132 strings) Change-Id: Ic9ae2d4d5d007638ecf8d58c9069c103d30af7c1 android-viewer translated using Weblate Catalan currently translated at 59.0% (78 of 132 strings) Change-Id: Ib6d7f7e1adf85c57f6de66cf21795c27d6945a03 Added translation for android-viewer using Weblate (French) Change-Id: I936f355b82bf58baea5f1738227b7b1755b23193 Co-authored-by: A S Alam <amanpreet.alam@gmail.com> Co-authored-by: Adam Rak <kitynska@gmail.com> Co-authored-by: Aitor Salaberria <trslbrr@gmail.com> Co-authored-by: Hossein <hossein@libreoffice.org> Co-authored-by: Joan Montané <joan@montane.cat> Co-authored-by: Martin Srebotnjak <miles@filmsi.net> Co-authored-by: Naruhiko Ogasawara <naruoga@gmail.com> Co-authored-by: Olivier Hallot <olivier.hallot@libreoffice.org> Co-authored-by: Tuomas Hietala <tuomas.hietala@iki.fi> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Weblate <noreply@weblate.org> Co-authored-by: sophie <gautier.sophie@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/eu/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fa/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/fr/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pa/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/pt_BR/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/sl/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160824 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android: Set sample texts for design viewMichael Weghorn1-3/+6
As cloph suggested in [1], set sample texts for the version and vendor information in the About dialog, using the `tools:text` attribute as described at [2]. These are displayed when viewing the layout in Android Studio's layout preview. With these placeholder texts, this gives a better impression at design time what the actual result will look like at runtime. The actual texts for the view are set at runtime, s. `AboutDialogFragment#onCreateDialog`. [1] https://gerrit.libreoffice.org/c/core/+/160047/comments/52584e2e_50869bef [2] https://developer.android.com/studio/write/tool-attributes#design-time_view_attributes Change-Id: I92b1c3d9f947fd1aa68a3ef4f0eee9e5c742e0c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160826 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android: Update lint baselineMichael Weghorn1-272/+19
Update the list of known (tolerated for now) issues by deleting lint-baseline.xml and running `make` to regenerate the file, so recent translation-related (config) changes are reflected. Change-Id: If8a39d72ba83c2a2e0bab9830c69095445943b09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160818 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android lint: Drop unused string resourcesMichael Weghorn1-14/+0
This also avoids that these will show up in Weblate, causing unnecessary work for translators since they're unused anyway. IIUC, dropping the strings in already existing translations should be handled automatically by Weblate. (Leave them there to see whether this actually works as expected.) Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160821 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android lint: Ignore extra translationsMichael Weghorn2-2/+12
These should be managed automatically via weblate, s. [1], so there shouldn't be any need to manually remove stale strings for all translations. There are 2 lint checks for these, `ExtraTranslations` and `UnusedResources`. Disable `ExtraTranslations` altogether. The `UnusedResources` check seems useful in general, so only disable that for the translations by adding a lint config file `lint.xml` (s.a. [2]) using a wildcard for the path that matches the translation's string.xml files. This is in preparation for Change-Id: Icab66a1768f5c6250598fcf788377575d3f6f611 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Dec 15 10:28:21 2023 +0100 android lint: Drop unused string resources This also avoids that these will show up in Weblate, causing unnecessary work for translators since they're unused anyway. IIUC, dropping the strings in already existing translations should be handled automatically by Weblate. (Leave them there to see whether this actually works as expected.) [1] https://gerrit.libreoffice.org/c/impress_remote/+/155966/comments/769f76c5_c3c499ec [2] https://developer.android.com/studio/write/lint Change-Id: Ic7c7a1c4c5583bf1a42004480435aac70a88dee0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160822 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android lint: Replace "..." with ellipsis characterMichael Weghorn1-1/+1
Address this lint warning listed in the lint-baseline.xml: <issue id="TypographyEllipsis" message="Replace &quot;...&quot; with ellipsis character (…, &amp;#8230;) ?" errorLine1=" &lt;string name=&quot;action_save_as&quot;>Save As...&lt;/string>" errorLine2=" ~~~~~~~~~~"> <location file="res/values/strings.xml" line="53" column="35"/> </issue> This also helps to avoid introducing more issues of that kind in newly added translations, quoting from cloph's Gerrit comment [1]: > and FYI: if the source-string would end in an Ellipsis, then weblate could > enforce the translation ending in an ellipsis [...] > > ( https://docs.weblate.org/en/latest/user/checks.html#mismatched-ellipsis ) [1] https://gerrit.libreoffice.org/c/core/+/160614/comments/5ef2dc6d_75cde15f Change-Id: Ic056849dd56d7e6c50615ffd62d470df4ab337bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160817 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android lint: Ignore missing translationsMichael Weghorn1-3/+7
Translations are handled in Weblate now, so missing translations are tracked there. Therefore, ignore them in the lint check, since there's no added value in having them listed in the `android/source/lint-baseline.xml` file in addition any more. Change-Id: I82945c0eebe015ca9695813dd19613108884c648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160816 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-15android-viewer translated using WeblateWeblate2-0/+4
Catalan currently translated at 57.5% (76 of 132 strings) Change-Id: I477bd8cf847c12e62d00385460caf91f310fa531 Added translation for android-viewer using Weblate (Punjabi) Change-Id: Idad2440113f7f4cbdc0077ac101eb14b9f449f76 Co-authored-by: A S Alam <amanpreet.alam@gmail.com> Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Weblate <noreply@documentfoundation.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160789 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-14android-viewer translated using WeblateWeblate4-38/+19
Turkish currently translated at 93.9% (124 of 132 strings) Change-Id: I67905c448a119c99417a465ff90968dbf842c4d5 android-viewer translated using Weblate German currently translated at 97.7% (129 of 132 strings) Change-Id: I5b64bae8809d6a0c1366191c00b086ea003dd95a Added translation for android-viewer using Weblate (Kazakh) Change-Id: I3f0a39884167fce6e7bcfde22ee582cdc53115cb android-viewer translated using Weblate Turkish currently translated at 93.1% (123 of 132 strings) Change-Id: I4d5a8084d56fa5c3f803b26ccc31d905d477d504 android-viewer translated using Weblate Catalan currently translated at 56.0% (74 of 132 strings) Change-Id: I5296250e71d015b65f5704cc2ae088f157a5c888 android-viewer translated using Weblate Catalan currently translated at 49.2% (65 of 132 strings) Change-Id: Icfb62bf6f5d1e26efea090726f2379d72238fd6e Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Baurzhan Muftakhidinov <baurthefirst@gmail.com> Co-authored-by: Christian Lohmaier <cloph@documentfoundation.org> Co-authored-by: Michael Weghorn <m.weghorn@posteo.de> Co-authored-by: Weblate <noreply@documentfoundation.org> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/de/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/tr/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160770 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-14android lint: Dont' fail on TypographyEllipsis warningMichael Weghorn1-3/+3
After new translations got added in commit 40f850279d912786f7943d97ec6db73ee2bb874f Author: Weblate <noreply@documentfoundation.org> Date: Wed Dec 13 15:33:50 2023 +0100 android-viewer translated using Weblate (Welsh) , the android build started failing like this: > Task :lintReportStrippedUIEditingDebug Wrote HTML report to file:///home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/reports/lint-results-strippedUIEditingDebug.html > Task :lintStrippedUIEditingDebug FAILED Lint found 3 errors, 0 warnings (232 errors, 3 warnings filtered by baseline lint-baseline.xml). First failure: /home/michi/development/git/libreoffice-WORKTREE-android/android/source/res/values-hy/strings.xml:36: Error: Replace "..." with ellipsis character (…, &#8230;) ? [TypographyEllipsis] <string name="action_save_as">Պահել որպես...</string> ~~~~~~~~~~~~~~ The full lint text report is located at: /home/michi/development/git/libreoffice-WORKTREE-android/android/source/build/intermediates/lint_intermediate_text_report/strippedUIEditingDebug/lint-results-strippedUIEditingDebug.txt FAILURE: Build failed with an exception. Downgrade that type of lint check to severity informational to not cause the build to fail. (Changes to address these will need to be done in Weblate, which is now the source of truth for translations.) Change-Id: Ibc82f96d29c8ac76f98db0259e1ee3cae4a986f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160772 Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-14android-viewer translated using Weblate (Welsh)Weblate5-0/+607
Currently translated at 100.0% (132 of 132 strings) Change-Id: I84d27bd881bb9d9a28d4770aaff50cae81c217a2 android-viewer translated using Weblate (Catalan) Currently translated at 48.4% (64 of 132 strings) Change-Id: Iba9603def2e2ebd3beb993e7188f226a4b3fa260 Added translation for android-viewer using Weblate (Welsh) Change-Id: I2852724a5f0267a7108aca3b4fb887d15c8421bb android-viewer translated using Weblate (Catalan) Currently translated at 46.2% (61 of 132 strings) Change-Id: I148ee4d2ad33aa43dce5ce44ff5eff18df7239b9 Added translation for android-viewer using Weblate (Catalan) Change-Id: I808e3a956f5758959cf9e708e6a3047f779cc024 android-viewer translated using Weblate (Spanish) Currently translated at 100.0% (132 of 132 strings) Change-Id: Id83ee9b9d69499604e7bf3ac15a52e5e4264192e android-viewer translated using Weblate (Spanish) Currently translated at 98.4% (130 of 132 strings) Change-Id: I17e6b0385edb32a6da1871893c646488ec35419f Added translation for android-viewer using Weblate (Spanish) Change-Id: I572a602e665f896905d378294d5485b262b4b934 android-viewer translated using Weblate (Galician) Currently translated at 100.0% (132 of 132 strings) Change-Id: Ic3026fb57a2042e45506d7507223c0b007271fe6 Added translation for android-viewer using Weblate (Galician) Change-Id: I7af380682508b4a12c902c58002884750f4dc5d3 android-viewer translated using Weblate (Armenian) Currently translated at 100.0% (132 of 132 strings) Change-Id: Ia57e0477acc8f14ee597b0b6961e2a3067064a89 Added translation using Weblate (Armenian) Change-Id: Id0c85ec1236b4a9c8a0f95c0d9510db4639e777a Co-authored-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Co-authored-by: Rhoslyn Prys <post@meddal.com> Co-authored-by: Tigran Zargaryan <tigranflib@gmail.com> Co-authored-by: Weblate <noreply@documentfoundation.org> Co-authored-by: Xosé <xosecalvo@gmail.com> Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/ca/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/cy/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/es/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/gl/ Translate-URL: https://translations.documentfoundation.org/projects/android-viewer/android-strings/hy/ Translation: android-viewer/android-strings Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160614 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-13android: Make the build fail on new lint warningsMichael Weghorn3-4/+2660
In order to avoid introducing new lint errors, also run the `lint<buildVariant>` gradle target when building Android Viewer and set the `warningsAsErrors true` lint option. This makes the build fail on (new) lint errors. See [1] for more details. Downgrade missing translations and issues that can "suddenly" appear without any code changes to the app itself to informational, to prevent (CI) builds from suddenly starting to fail just because a new Android Gradle Plugin version or external library becomes available etc. To be able to avoid introducing new issues without having to address all existing ones right now, use a baseline file ("lint-baseline.xml") as described at [2] which lists all existing issues, so they don't result in a failing build. Those should still be looked into at some point. Updating the baseline file can be done by just removing the existing one and running the build again. (Build will create the new baseline file and fail on first run after deleting the file, then find the new file and succeed in subsequent builds.) [1] https://developer.android.com/studio/write/lint [2] https://developer.android.com/studio/write/lint#customize-the-baseline Change-Id: Iddbe432519ab3040c83c0e977a584b51d3ef1e5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160199 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-13android: Remove generated resources in "clean" make targetsMichael Weghorn1-1/+1
Since these are produced by the build, they should also be removed in the "clean" target. Without this, Jenkins CI builds for the upcoming Change-Id: Iddbe432519ab3040c83c0e977a584b51d3ef1e5b Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Dec 8 14:57:14 2023 +0100 android: Make the build fail on new lint warnings were seen failing, despite the example file no longer being part of the generated resources since commit 1d7b1e2d4099aac15e695696e6a0640d6e01e23f Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Nov 15 13:16:26 2023 +0100 android: Drop "More Info" item in "About" dialog , but apparently the file was still lingering around from previous builds. Build failure/Lint error from CI build [1]: > Task :lintReportStrippedUIEditingDebug Wrote HTML report to file:///home/tdf/lode/jenkins/workspace/android_arm/android/source/build/reports/lint-results-strippedUIEditingDebug.html > Task :lintStrippedUIEditingDebug FAILED /home/tdf/lode/jenkins/workspace/android_arm/android/source/lint-baseline.xml: Information: 237 errors and 11 warnings were filtered out because they are listed in the baseline file, lint-baseline.xml [LintBaseline] /home/tdf/lode/jenkins/workspace/android_arm/android/source/res_generated/raw/example.odt: Error: The resource R.raw.example appears to be unused [UnusedResources] Explanation for issues of type "UnusedResources": Unused resources make applications larger and slow down builds. The unused resource check can ignore tests. If you want to include resources that are only referenced from tests, consider packaging them in a test source set instead. You can include test sources in the unused resource check by setting the system property lint.unused-resources.include-tests =true, and to exclude them (usually for performance reasons), use lint.unused-resources.exclude-tests =true. , 1 errors, 0 warnings (237 errors, 11 warnings filtered by baseline lint-baseline.xml) FAILURE: Build failed with an exception. This could also be reproduced locally: After a $ touch android/source/res_generated/example.odt , the above error would on build, and neither `make clean` nor `make android.clean` would remove the file and thus fix the problem for subsequent builds. Add removing the directory to the top-level and Android-specific clean targets, so either of these commands now takes care of this. [1] https://ci.libreoffice.org/job/gerrit_android_arm/33845/console Change-Id: I91c83ce4ddb236d87d7c51f4dcce85e99aae0107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160612 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-12android lint: Drop unused image resourcesMichael Weghorn2-0/+0
Drop unused image resources that lint warns about, e.g.: <issue id="UnusedResources" message="The resource `R.drawable.action_search` appears to be unused"> <location file="res/drawable-hdpi/action_search.png"/> </issue> Change-Id: I69422d485fc324245fd562fd75b016862b29c2a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160490 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-12android lint: Drop extra closing XML tagMichael Weghorn1-1/+0
This was accidently added in commit a21e7a76d745750dcea14bc6311e4f1766c3fa45 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 9 10:24:13 2023 +0100 android a11y: Add content labels and now reported by lint: <issue id="ExtraText" message="Unexpected text found in layout file: &quot;/>&quot;" errorLine1=" />" errorLine2=" ~~"> <location file="res/layout/toolbar_bottom.xml" line="481" column="13"/> </issue> Change-Id: If4a17c4cd10450c2f5e13ead88a7511684ab9956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160469 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-11Move Android buildfeature config to build.gradleThorsten Behrens2-1/+3
Old gradle.properties entry was deprecated in 8.0: - https://cs.android.com/android-studio/platform/tools/base/+/0bc1c23297760643b03e8cfd8acc52c007a99cd6 Change-Id: Ia34379e8112cc2c316be229e7719c2ce1b695576 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160602 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-11android lint: Add API level check for EXTRA_INITIAL_URIMichael Weghorn1-2/+6
`DocumentsContract.EXTRA_INITIAL_URI` was added in API level 26, so only set it conditionally when that API level is avaible. Change-Id: I6783e89f50354c017968b74cc45fb1a3b6faab83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160468 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-12-08android: Bump minSdkVersion to 21 (Android 5.0)Michael Weghorn7-45/+7
NDK 26 dropped support for API levels < 21 [1] [2]. Do the same for our Android build, to ease the maintenance. Adapt configure.ac accordingly and drop the now obsolete code paths in Android Viewer Java code. This in also means that the same minSdkVersion will be used for all architectures now, while API level 21 was already used for the 64-bit variants (for which the minimum supported version was 21 anyway) and API level 19 was used for x86 and 32-bit ARM when building with NDK 24/25, API level 16 when building with NDK 23. According to [1] and [3], more than 99% of Android devices have at least Android version 5, i.e. support API level 21. [1] https://github.com/android/ndk/issues/1751 [2] https://developer.android.com/ndk/downloads/revision_history [3] https://apilevels.com/ Change-Id: I875e784dd4e62993f51059ae6a280d425cb49c0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160334 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-01android: Update Android Gradle Plugin to 8.2.0Michael Weghorn2-3/+3
... and gradle to 8.2, as suggested by Android Studio. Change-Id: I1a1df5f43b7a95d24308873b708d3d21b76aa7f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160200 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-01Fix typoAndrea Gelmini1-1/+1
Change-Id: Ia40016ad2696c8555163074c415ea0e8f9216f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160207 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2023-12-01android: Shown warnings about deprecated API usageMichael Weghorn1-0/+5
Configure the gradle build to show detailed warnings about the use of deprecated API, instead of just > Task :compileStrippedUIEditingDebugJavaWithJavac Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. With this in place, 78 specific warnings about the use of deprecated API are now shown in the build output, which can be addressed at some point. Change-Id: I9f3b484b6dfad1fc57895efa7d3426b625030ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160198 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Add make dep to update build ID more reliablyMichael Weghorn1-1/+3
So far, the build ID in liboSettings.gradle, and therefore in the about dialog in Android Viewer was not reliably updated in incremental builds. For example, after a full build, then git commit --allow-empty -m "Dummy" make , the build ID would still refer to the commit from the full build, not the new dummy commit. Since `instdir/program/versionrc` on Linux and `instdir/program/version.ini` on Windows gets updated properly, add an optional make dependency on these files, using a wildcard. Change-Id: If3b1d4d811a5e4316a26bb17f246b66858dcf80f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160157 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Separate build ID and vendor from versionNameMichael Weghorn2-16/+12
So far, the versionName for the LibreOffice APK/app bundle included the build ID and vendor, was e.g. "24.2.0.0.alpha1+/2972af9045a5/The Document Foundation". That versionName would be split again to extract the build ID and vendor to display them in the about dialog. No longer include build ID and vendor in the `versionName`, but use separate build config variables, similar to what is done for the privacy policy. This slightly simplifies the code for the about dialog. But more importantly, the previous `versionName` scheme would make it impossible to automate the F-Droid update of the app, because the scheme is not compatible with the expectations of F-Droid's update mechanism, see the F-Droid merge request to update LibreOffice Viewer to 7.6.3 [1] for more details, in particular the (eventually not merged) commit [2] mentioning what manual steps would still be needed when trying to semi-automate the update at least. [1] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14080 [2] https://gitlab.com/fdroid/fdroiddata/-/merge_requests/14080/diffs?commit_id=bfc062a358dc574326a29f08e01c0e80cadd80cb Change-Id: Ibede06d13095d8e83dcc88ee09a8a610d6a9de0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160150 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Drop trailing whitespace in MakefileMichael Weghorn1-1/+1
Change-Id: Ic68471bbbc18e5fa0a66dbf57e3e7156ef824e50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160149 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Simplify vendor info handling for about dialogMichael Weghorn2-6/+3
Similar to Change-Id: Iaa78f5a6020bea4ed80a1b41d3b23cc8d313813c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Thu Nov 30 12:00:52 2023 +0100 android: Simplify version info handling for about dialog , also simplify the handling of the vendor info text by retrieving the text from the string resource right away. Change-Id: I7d56b1814454be2bc8d13e01265f0a0db6d865be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160147 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Simplify version info handling for about dialogMichael Weghorn5-8/+5
* Don't set and retrieve the placeholder text in/from the TexView in the about dialog, but use the string resource directly. * Add the HTML code directly in the string resource, rather than having to fiddle with that in the Java code. With this in place, only the version name and the commit hash need to be replaced. Since there is no placeholder text in the text view, it's also no longer necessary to explicitly set an empty string in case of an exception. Change-Id: Iaa78f5a6020bea4ed80a1b41d3b23cc8d313813c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160146 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Remove 'build' dir in 'clean' make targetMichael Weghorn1-1/+1
Add the build dir (`android/source/build`) to the directories to be removed when cleaning. Previously, this was't cleaned, which could be seen e.g. by the fact that a fresh build would result in this warning being shown > Task :compileStrippedUIEditingDebugJavaWithJavac Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. while a make android.clean make android after a full build wouldn't. Change-Id: I00a4f8b1fda9fbefb3b8f806b1997eceded117fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160145 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Update com.google.android.material:material to 1.10.0Michael Weghorn1-1/+1
Depends on the previous commit Change-Id: I2778d8c181daa92530c769a168a9e186b6ea079c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Nov 29 13:33:33 2023 +0100 android: Update compileSdk/targetSdkVersion to 34 Change-Id: Ibdb7e002d599d42256290febc422cf86b2694d46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160087 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Update compileSdk/targetSdkVersion to 34Michael Weghorn1-2/+2
API version 33 refers to Android 14. I didn't notice anything requiring changes when going over the release notes for all apps running on Android 14 [1] and apps targeting Android 14 [2]. (Taking a look whether making use of the new possibility to request/grant partial access to photos and videos [3] for the "Insert" -> "Select Photo" feature and testing the app with the newly available 200% text scaling [4] might make sense at some point, but is unrelated to bumping the versions as done in this commit.) [1] https://developer.android.com/about/versions/14/behavior-changes-all [2] https://developer.android.com/about/versions/14/behavior-changes-14 [3] https://developer.android.com/about/versions/14/behavior-changes-all#partial-photo-video-access [4] https://developer.android.com/about/versions/14/behavior-changes-all#non-linear-font-scaling Change-Id: I2778d8c181daa92530c769a168a9e186b6ea079c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160086 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Update Android Gradle Plugin to 8.1.4Michael Weghorn1-1/+1
This is a prerequisite for updating the compile and target SDK versions to API level 34, which requires and AGP minimum version of 8.1.1. Change-Id: I27d12ec3c9bc3dac8a5df18459a57f1a1e990197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160085 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: Use 'compileSdk' instead of deprecated 'compileSdkVersion'Michael Weghorn1-1/+1
See [1] and [2]. From what I can see, they are equivalent for our use. This addresses a "'compileSdkVersion' is deprectaed." warning shown in Android Studio. [1] https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/CommonExtension#compilesdk [2] https://developer.android.com/reference/tools/gradle-api/7.0/com/android/build/api/dsl/CommonExtension#compilesdkversion Change-Id: I9a7416d8b3750a5f8f8281c6e226fc7bbe665776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160084 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30android: No longer extract native libsMichael Weghorn1-2/+0
As described in more detail in commit 45fbfbfeae1de12e87d0a3748e22553b69adbc4a Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Mar 27 17:04:37 2020 +0100 tdf#131622 android: Extract native libs again , extracting native libraries was necessary for the NSS library to be able to load modules like `libnssckbi.so` at runtime. Without this, opening password-protected files would fail. However, this has in the meanwhile been addressed differently in the following commit (probably in the context of the online-based/Collabora Online app), so extracting libs is no longer needed: commit 16a7f98f99d334ea865b800e0b32d6fed1483942 Author: Mert Tumer <mert.tumer@collabora.com> Date: Wed Sep 30 17:14:59 2020 +0300 Fix libnssckbi not found error on Android This error causes Android App to be unable to open Password-protected documents. Change-Id: Iacbacb1c780025752e2447db325b075c58947818 Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103658 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> Therefore, no longer extract the libraries, which also addresses addresses this warning shown during the build: > Task :processStrippedUIEditingDebugMainManifest .../android/source/AndroidManifest.xml:16:9-41 Warning: android:extractNativeLibs should not be specified in this source AndroidManifest.xml file. See https://d.android.com/guide/topics/manifest/application-element#extractNativeLibs for more information. The AGP Upgrade Assistant can remove the attribute from the AndroidManifest.xml file and update the build file accordingly. See https://d.android.com/studio/build/agp-upgrade-assistant for more information. Change-Id: I867beea0bce8398806375048e87a152e1348d016 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160079 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Set bg color for calc formula barMichael Weghorn1-1/+2
For the layout containing the Calc address/formula bar, explicitly set a background color that matches the theme. Otherwise, those text views would be using white font on white background when using dark theme, making the text unreadable. Change-Id: I5fdf9e04f8bb331ca6a57bf3046a7ebb9ccb0d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160078 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Avoid using color attr requiring API 23Michael Weghorn4-6/+13
Using "colorBackgroundFloating" requires API level 23 [1], but our current minimum API level is 16 (when building with NDK 23). Therefore, define an own color `background_floating` instead and use the correspodning color values from the material theme (`background_floating_material_{dark,light}` depending on whether dark/night mode is enabled or not. This makes the app work again in a quick test with an x86 AVD with API level 16 instead of crashing on startup. Change-Id: I7b8378b42e9fc7430ec4ed263d4cb8b42027a930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160077 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Use an actual button for "Select file to open"Michael Weghorn2-20/+9
Instead of using a TextView and setting `?attr/colorButtonNormal` for the background color, just use a button right away, which also makes sure that the proper button color is used and avoids using `colorButtonNormal` only available from API level 21 on. [1] Also drop the extra `LinearLayout` parent that was only containing this one TextView. While at it, drop an unused import. [1] https://developer.android.com/reference/android/R.attr#colorButtonNormal Change-Id: Ie2f7e2646d20f4051fb2513fb8fd72572ce19217 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160076 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Use themed color for icon on start activityMichael Weghorn2-2/+2
Similar to how Change-Id I2061878067d21dcd743ad6ca8d1018db323755d6 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Nov 28 14:22:54 2023 +0100 tdf#124480 android: Use themed color for more icons did for the icons in the toolbars, use the themed color for the directory icon in the start activity as well. While at it, switch to using the same shade of gray that the toolbar icons also use. And rename the icon to drop the "_grey" suffix, since this is now themed and no longer using a hard-coded color. Change-Id: I9fcf51b712a01aab3b9754bcfbd817c89171a64f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160075 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Rename icons no longer using hard-coded colorMichael Weghorn16-12/+12
As already mentioned in Change-Id I2061878067d21dcd743ad6ca8d1018db323755d6 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Nov 28 14:22:54 2023 +0100 tdf#124480 android: Use themed color for more icons , do this: > Given the icons are no longer hard-coded to be black, > the files with a "_black" suffix will be renamed in > a follow-up commit. (Separate commit to keep the > diff clearer.) Change-Id: Ie2d3433934569dc97530a35d88bda01802af96b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160074 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Use themed color for more iconsMichael Weghorn14-14/+14
These icons used in the toolbars were previously using a hard-coded fill color. Most of them were using black, but `ic_line` and `ic_rect` used in the "Insert" tab of the bottom toolbar, were previously using a lighter gray than the other items in there for no apparent reason. Switch all of them to use the themed `toolbar_foreground` color that other icons are also using. Together with Change-Id Ic699fd1cecc607bd5e748648113336fe045e72b1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Nov 28 13:13:12 2023 +0100 tdf#124480 android: Override icon color for dark theme , this makes these icons use a light color when using the dark system theme. Given the icons are no longer hard-coded to be black, the files with a "_black" suffix will be renamed in a follow-up commit. (Separate commit to keep the diff clearer.) Change-Id: I2061878067d21dcd743ad6ca8d1018db323755d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160073 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Drop unused iconsMichael Weghorn6-41/+0
Change-Id: I811d9190c0c163db93ec981855f735d47e071cbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160071 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Override icon color for dark themeMichael Weghorn1-0/+4
Add a `values-night/colors.xml` that can be used to override the colors specified in `values/colors.xml` specifically for the dark theme. Specify a light color for `toolbar_foreground`, which is the color used for (most) toolbar icons, both for the top-level as well as the bottom toolbar. This makes most icons show up in proper contrast when using dark mode. Others are not making use of the color defined here and will have to be looked into separately. Change-Id: Ic699fd1cecc607bd5e748648113336fe045e72b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160070 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Use theme bg color for bottom toolbarsMichael Weghorn4-6/+4
Instead of hard-coding the background color for the 2 toolbars shown at the bottom (`toolbar_bottom` and the color picker), use "colorPrimary" from the theme. Stop overriding "colorPrimary" in `LibreOfficeTheme.Toolbar`, which would otherwise result in a hard-coded white color being used again. This makes those toolbars show up in a darker color when dark theme is enabled. Stop hard-coding the font color of the items in the "Style" tab in the bottom toolbar to black, but use the primary font color instead, so a light color is automatically used when using the dark theme. Change-Id: Ib09ca47e8695903cdfa9f4eb100dc88ecae652a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160069 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Support dark themeMichael Weghorn2-3/+3
Support dark theme by inheriting from the corresponding "AppCompat.DayNight" themes rather than forcing the use of a light theme by using the "AppCompat.Light" variants, s.a. [1]. With this in place, the app will automatically use a dark theme for the Android UI controls when that's enabled in the Android system settings. Toolbars and menus mostly look as expected. The bottom toolbar will be handled separately. Icons will also have to be adapted in a follow-up step to provide for better contrast, since they're currently designed for light mode/white background. [1] https://developer.android.com/develop/ui/views/theming/darktheme#themes-styles Change-Id: Ia08edcc9d22b93caa67b146dcf90ee5fd02ee550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160068 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Replace hard-coded bg color with themeable oneMichael Weghorn4-9/+8
or drop explicitly setting background color where the one from the parent widget should be used. See also https://developer.android.com/develop/ui/views/theming/darktheme#themes-styles Change-Id: I21dc4b7c45e2cc5add96d603abe5e781d4e09992 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160067 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-30tdf#124480 android: Use MaterialToolbar and drop manual bg colorMichael Weghorn2-5/+3
This ensures these 2 toolbars will also use the correct color in dark mode once support for that is added in a subsequent commit. Change-Id: Idcea5096c4e4bdf8ddc6b28df0fc6df05074980b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160066 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-27tdf#158398 android: Draw light gray background for Calc headersMichael Weghorn1-7/+14
Similar to the desktop version, use a light gray background color for the Calc header cells. There was already code in place to draw darker gray background to highlight the header cell when a cell in that row/column is selected. (The actually highlighted header cell didn't wasn't always the correct one in a quick test, but that's independent of this change.) Adapt that to always fill the rectangle, but use a lighter gray (lower alpha value) when not selected. Use a separate `Paint` object for the frame (stroke). Set the frame color and text color to black instead of gray, for better contrast to the light gray fill/background. Change-Id: I0490811e928ebd1b3840242fc1aa4682b2786b00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159989 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-27tdf#158398 android: Center Calc header textMichael Weghorn1-1/+6
Center the header text in the Calc header cell, to make better use of the space. This is in line with what the desktop version also does. Setting the text alignment to `Paint.Align.CENTER` is sufficient for centering horizontally. There's no equivalent for centering vertically, so calculate the position based on the text bounds. Change-Id: Ia8d5d8434b703cb7daecd34ae70405883f22f0d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159988 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-22 01:25:11 +0000