summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2023-12-07sfx2: simplify SetCommonStorageEncryptionData() callsMichael Stahl2-54/+17
Some of these look redundant, as SfxMedium::GetStorage() already does this earlier. Change-Id: Iba178196898adfd4ee260da908c7298f3f2c1734 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160408 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-07tdf#105844 package,sfx2: wholesome ODF package wrapping encryptionMichael Stahl7-37/+347
Redo the ODF encryption by storing an ODF package and wrapping it as a stream "encrypted-package" in another ODF package, such that there is only one encrypted stream - this requires only one KDF computation. * This is only enabled in Experimental mode for now. * Avoid storing unencrypted data in the pTempFile of SfxMedium, as it is usually created in the same directory as the target file, which may be on a network share or similar less trusted location. * SfxMedium::SetEncryptionDataToStorage_Impl() should just set an error status if it fails (how can it fail anyway) * when loading a document, SfxDocPasswordVerifier extracts an encrypted inner package (by calling SfxMedium::TryEncryptedInnerPackage()) * SfxMedium::GetStorage() automatically decrypts an encrypted inner storage and sets it as the SfxMedium's xStorage * when storing a document, SfxObjectShell::SaveTo_Impl() creates the wrapped storages * One challenge is to keep the macro/scripting signature working; this can only be put in the inner storage, whereas the document signature should continue to be on the outer storage; also it must use a Zip storage, to see the "META-INF" directory. This needs a new SfxMedium::GetScriptingStorageToSign_Impl() and changes in SfxMedium::SignContents_Impl(). Change-Id: Ibfee36ce3a9cd030f2aa2ce1484b6d001cba2389 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160401 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-07some cosmetic improvements, better warningsMichael Stahl5-13/+16
Change-Id: I05a7eeb74088c278aab94519c7f53b0482e38058 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160400 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-12-07Adapt consteval failure check to recent GCC 14 trunkStephan Bergmann1-1/+4
...which happens to accept the original check from af34108d90bbbce90cf00c4b23961787599c7fa5 "Use C++20 consteval for the Color(sal_uInt32) ctor" now, but would still fail to compile the actual code at > In file included from xmloff/source/chart/ColorPropertySet.hxx:23, > from xmloff/source/chart/ColorPropertySet.cxx:20: > include/tools/color.hxx: In constructor ‘xmloff::chart::ColorPropertySet::ColorPropertySet(Color)’: > xmloff/source/chart/ColorPropertySet.cxx:81:9: in ‘constexpr’ expansion of ‘((xmloff::chart::ColorPropertySet*)this)->xmloff::chart::ColorPropertySet::m_nDefaultColor.Color::Color(10079487)’ > include/tools/color.hxx:82:11: error: modification of ‘*(xmloff::chart::ColorPropertySet*)this’ is not a constant expression > 82 | : mValue(nColor) > | ^~~~~~~~~~~~~~ (see the comment at <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=98752#c6> "wrong "error: ‘this’ is not a constant expression" with consteval constructor") Change-Id: I3b8b92cd7ba31724cf0c9fe38b6cf8aa2abd7c0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160405 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-07mkdir_p still needed by make create-partial-infoStephan Bergmann1-0/+9
157298bb808a943616991927f9370a86c1f2ca48 "android and bin/update: make pythonic" had removed it, so that `make create-partial-info` would now fail at least with > Traceback (most recent call last): > File "bin/update/create_partial_update.py", line 10, in <module> > from path import UpdaterPath, mkdir_p, convert_to_unix, convert_to_native > ImportError: cannot import name 'mkdir_p' from 'path' (bin/update/path.py) (and no idea if that make target would still do anything useful, beyond this initial hurdle) Change-Id: Ib1be3304e2b3468dc187c1b5e24041e68a3677fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160397 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-07tdf#158464 - UI: Part 47 - Unify lockdown behavior of Options dialogBalazs Varga3-61/+325
for Calc - General Page. Change-Id: I2ff8edd0fb10a3f388459d842c79b157bc3861f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160407 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-12-07tdf#157432 Expert config: Allow filtering by changed valuesSamuel Mehrbrodt16-83/+216
Change-Id: Ib8bbb7fc9e8014a9367278f3fa640f53af46dd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159986 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-07loplugin:ostr (macOS)Stephan Bergmann1-17/+19
Change-Id: I1b169e0c170c26a49941d22f0982a24ef547f941 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160391 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-07sw a11y: Only report "level", no more "heading-level" obj attrMichael Weghorn1-3/+4
Stop reporting the custom "heading-level" object attribute in addition to the "level" attribute. As described in the Core Accessibility API Mappings spec, the latter is specified in ARIA and maps to an attribute of the same name for all of AT-SPI2, IAccessible2 and UIA [1]. Get rid of the non-documented "heading-level" as part of the goal to align more closely to platform APIs/specifications. NVDA's LibreOffice-specific app module currently relies on the custom "heading-level" object attribute [2], but I've reported an issue and submitted a pull request for this: [3] [4] While neither the "level" nor the "heading-level" attribute are currently mentioned in the the IAccessible2 object attribute specification [5], the IAccessible2 doc for `IAccessible2::groupPosition` [6] explicitly mentions the "level" attribute for headings: > This method is meant to describe the nature of an object's containment > structure. It's exposed by trees, tree grids, nested lists, nested > menus, but not headings, which uses the level object attribute. [1] https://www.w3.org/TR/core-aam-1.2/#ariaLevelHeading [2] https://github.com/nvaccess/nvda/blob/9cf925195e0fc5ffc67dcfcc9e4d4a7d46ffb430/source/appModules/soffice.py#L225 [3] https://github.com/nvaccess/nvda/issues/15881 [4] https://github.com/nvaccess/nvda/pull/15882 [5] https://wiki.linuxfoundation.org/accessibility/iaccessible2/objectattributes [6] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible2.html#a94d4d84e000ef2fa3f2abf1148779941 Change-Id: I8e8994cc7565f9b0f40ca8bedff951512f56b59b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160347 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-07sw a11y: Only report heading level attr for headingMichael Weghorn1-13/+9
Only report the "heading-level" and "level" object attributes for a Writer paragraph when this paragraph has a heading level that can be reported as the value of the object attribute. No longer report the attribute without any value set otherwise, since the attribute doesn't provide any value then, but is rather confusing/misleading. Change-Id: I282345b00a32a74de229058ff368f3b169bf1c03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160346 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-12-06Related: tdf#155266 skip redisplay of the view when forcing flushPatrick Luby1-2/+10
It appears that calling -[NSView display] overwhelms some Intel Macs so only flush the graphics and skip immediate redisplay of the view. Change-Id: I7a94a1ada35526c5eda1b793f872e206b4c833ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160399 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-06update tsan suppressionsNoel Grandin1-0/+3
Change-Id: Ib91f900e93c10225769ba92f4d0819a4084f5847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-06tdf#157915 Error when running a Basic macro with instruction commitChangesNoel Grandin1-0/+2
regression from commit 1576ef8532cf2cea2da361db9c5707f1994e65e2 Author: Noel Grandin <noelgrandin@gmail.com> Date: Thu Dec 23 18:40:44 2021 +0200 osl::Mutex->std::mutex in SvtCommandOptions Note that this only fixes part of the issue - specifically the part that the original reporter described. There is a further issue, not fixed here, which only happens on Linux/GTK, where the messagebox dialog manages to end up behind the About dialog, and consequently cannot be closed, which freezes the program. Change-Id: Idbb7f51e494a69886c80eb92efaa7cf7c6911c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160393 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-06Fix apparent typo in make create-update-infoStephan Bergmann1-1/+1
157298bb808a943616991927f9370a86c1f2ca48 "android and bin/update: make pythonic" had introduced this apparent typo, so that `make create-update-info` would now fail (and no idea if that make target would still do anything useful, beyond this initial hurdle) Change-Id: I63c4e87e06370d99e5d036ce5c7f2a5bda3c1554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160398 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-06ScriptForge (SF_Root) Fix typosJean-Pierre Ledure3-12/+8
Suppression of linefeeds in excess inside english error messages. Change-Id: I38189e7dcf9d24055e477a5cb6cfeb42644ded39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160385 Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2023-12-06loplugin:ostr (macOS)Stephan Bergmann1-1/+1
Change-Id: I85ecdf188dc394d6175a2dd7338147a057fa7766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160392 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-06tdf#148986 Support XF86Forward / XF86Back key eventsGabor Kelemen9-2/+70
Multimedia keys found on certain presentation clicker devices. Not added to the Customize dialog, as that was not yet asked for. As I have no access to a MAC, did not add support for that in vcl. Inspiration for code taken from commit ca74511985981444dbd72ade7244484c131e36a7 Change-Id: I417e6ba7e79c5f6e774a56ba747803a156d5f50f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160255 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-06tdf#154369 don't apply default items to numbering symbolsOliver Specht1-1/+2
default attributes from the CharFmt should no be applied to the numbering symbol Change-Id: Ifa2d2ace575b888a43fa948f3b71605cfe20f129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159817 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-06Remove pyuno.xcd from build/packagingGabor Kelemen3-14/+1
cleanup after commit 80798b426bf7d5fa4616db1af608640cfbcd79fe Change-Id: I8d1712ac592a69ec0b9a5705d6a689e57062e347 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160300 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-06Drop use of Win98-era multimon.hGabor Kelemen1-5/+0
last mention of it was removed in 2014 by: commit cb40b7d2f9902b5fbe89333c4107d72c156b9a15 Change-Id: Ib60d84624b681d103bc654075a759fc92f8f3300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160289 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-06cid#1558795 Dereference after null checkCaolán McNamara1-1/+1
Change-Id: Iebdc89ee4512e2583a9e320ba65b3f40c3d5a33b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-06replace bInfo with direct pInfo checkCaolán McNamara1-9/+8
its a little less obscure Change-Id: I16f48e9cb55ea74a8d0e64ec7bc694890a0fcf88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160344 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-06make AlphaMask separate from BitmapNoel Grandin26-115/+168
Having it subclass Bitmap encourages confusion in passing it around, and I need the extra type-safety for my work on merged-alpha Change-Id: I35819f9b8ee609cbdaf865563c78531e397b529b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160235 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-06tdf#158488 Impress templates: restore style hierarchyLaurent Balland20-60/+60
Some templates were defining Title/Header/Text A0 styles with A4 as parent. Reset it to A0 Change-Id: Ide7b0e5287d38991ad5149eacb80f600467039f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160261 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-06tdf#126084 import svg image from ooxml document that use svgBlip elem.Tomaž Vajngerl8-70/+100
In an OOXML document the svg image is defined in an svgBlip, which is an OOXML extension. This change checks for the svgBlip element and imports that instead the normal "blip" element that is still provided as a fallback (PNG image). Add roundtrip SVG image test for ODF and OOXML, Impress and Writer. testGraphicBlipXLSX test failed after this change, because some component was missing. Changed to enable use_rdb for all chart2 export tests, so issues like this won't happen anymore. Change-Id: Idf0e754775254d7dcfd0321dfca2ed6d00c42c09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157238 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-06Remove now unused SwModelTestBase::preTest()Miklos Vajna2-12/+0
Which was a way to place test setup code far from the test itself, so good to get rid of it. Change-Id: I9f88ded958e7b546f0b1ecd7ce025e72a2a5e245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160373 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-12-06Remove the special-casing in Bitmap::Invert (and fix)Noel Grandin5-72/+140
and rather rely on the backends doing the right thing, which is considerably faster. Which uncovers a bug in the existing code - it is not legal to simply invert the value when dealing with palette-based images. Fix this by sharing some code with Bitmap::ReplaceMask. Change-Id: I2ef340a9f251c8c7e27b68ab451ce85df07c1035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-05Impress templates: restore font declarationsLaurent Balland11-123/+93
Some warnings appear when opening the template due to some missing font declarations Remove date declaration Fix some minor errors detected with ODFValidator Focus: remove DejaVu Sans2 font declaration (duplicate) Change-Id: I48a61d7df651d8113d5f15ba0c5877f6553e5003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160064 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-12-05Resolves: tdf#158223 Revert "fix" for tdf#156174 and follow-upEike Rathke1-7/+12
... introducing a real fix. commit 94ca402cd1fe2fd9776d08448f7216b7f638e69a CommitDate: Tue Jul 25 15:04:01 2023 +0200 tdf#156174 sc DBData: fix regression of database ranges just cured a symptom by removing a condition that shouldn't had been removed, instead of getting to the real cause of an odd reference update. Shrinking the end of a sheet reference range and thus moving it one before the previously referenced relative position is only possible if the deleted sheet actually touches the referenced range, which here the start value points to and thus checking ref>=start+delta is not necessary and subtracting 1 even harms. This is different from deleting columns or rows where the start value points behind the deleted area of moving the following area. Change-Id: If9ae5dd6f6ae5cd248ad5d999f1aa7577d4ec035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160374 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2023-12-05tdf#157729 SwNavigator: enhancement to group comments by threadsJim Raykowski2-2/+93
Change-Id: I64bc02e64d540a2bf602d2124deda1990dfb9f7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160011 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2023-12-05writerfilter: fix crash in DomainMapper_Impl::PushSdt()Miklos Vajna1-1/+12
Crashreport signature: Fatal signal received: SIGSEGV code: 1 for address: 0x0 program/libwriterfilterlo.so writerfilter::dmapper::DomainMapper_Impl::PushSdt() writerfilter/source/dmapper/DomainMapper_Impl.cxx:987 program/libwriterfilterlo.so writerfilter::dmapper::DomainMapper::lcl_attribute(unsigned int, writerfilter::Value&) include/tools/ref.hxx:56 program/libwriterfilterlo.so writerfilter::ooxml::OOXMLProperty::resolve(writerfilter::Properties&) include/tools/ref.hxx:56 program/libwriterfilterlo.so writerfilter::ooxml::OOXMLPropertySet::resolve(writerfilter::Properties&) include/tools/ref.hxx:157 Change-Id: I76416ca707a4ac40495e5c22f62fcd017bcb5e48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160336 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 728f6ec104b1a91c8c8ea0790bc7f56471c67737) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160351 Tested-by: Jenkins
2023-12-05Deduplicate execute_dialog_through_*Mike Kaganski1-29/+19
Use Python 3.3's 'yield from', which should be OK, because the baseline rhel8 has Python 3.6. If needed, older Python could use replacement like this: for dialog in self.wait_and_yield_dialog(event, xDialogParent, close_button): yield dialog Change-Id: Ic70bdf19fed730e41b7ce2868990ec88423eab33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160352 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-05Fix apparent copy/paste typoStephan Bergmann1-1/+1
...present ever since the code got introduced in 569269078576fa832143ec4f0bf03283ff358f48 "improve the update checker" Change-Id: I38d0efee3cb3f6954dd30690ba9afddf0b66c959 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160348 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-05Make --enable-online-update=mar at least compile again, on LinuxStephan Bergmann2-10/+11
Seen it build (but no idea yet whether it actually would work) with autogen.input including > --enable-online-update=mar > --with-update-config=/home/sberg/lo/update.ini and ~/lo/update.ini containing > [Updater] > ServerURL=TODO > base-url=TODO > certificate-der=/home/sberg/lo/certificate.der > certificate-name=TODO > certificate-path=TODO > channel=TODO > upload-url=TODO and ~/lo/certificate.der containing > TODO Change-Id: Ib40417c09c6454fe9cf678c029a06716415e5cb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-12-05Related: tdf#158534 set fallback help page for optional print contentCaolán McNamara1-0/+1
Change-Id: I79d843cbf2591ab5a8625087e2ec5897b26a8056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-05cid#1546503 Using invalid iteratorCaolán McNamara2-2/+8
and cid#1546284 Using invalid iterator Change-Id: I9ff3498b65ce392dbe859566b49e60a31e0779f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160370 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-05Vintage Impress template: remove unused stylesLaurent Balland1-54/+0
These old styles are used in the template and is no more in use in LO. So they remain untranslated when changing UI language. Change-Id: I130eb25df9b76783d498d6ab1e5191551b9a4d0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160269 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-05Resolves: tdf#158534 two help pages from print help buttonCaolán McNamara2-12/+0
its either use the default "help" response, or have an explicit handler for the help button. Its more consistent to just use the default "help" response for the print dialog as done everywhere else. Change-Id: I0bb173e67a3bea1c10cc315cfcf212376f2710c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-05Resolves: tdf#158441 we don't want to return early for all handled keysCaolán McNamara1-1/+5
a problem since: commit c39bd1f6690ade936d62a66265b9b277061024d8 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Feb 19 10:13:15 2020 +0000 weld CodeCompleteWindow Change-Id: I520a591bad89515c973098f4200f01ae0ddbdc34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160337 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-05vcl: add unit test for cached glyphs based on tdf#103492Chris Sherlock1-0/+2
Change-Id: Id66be996053435c92b667eb142ae1e271ff33b90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159386 Tested-by: Jenkins Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-05Fix typoAndrea Gelmini1-1/+1
Change-Id: Id5c6ac6c1358334dba4b96fcc6dee9e40859ec32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160341 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-05Fix typoAndrea Gelmini1-1/+1
Change-Id: I5f000f53f4dfec62a6d5a332361c380dc142d2bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160342 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-05sc: show a message dialog if insert cells failHenry Castro2-0/+6
Use case, go to the max row and insert a row. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I930d7724b9c94e10e9207ec749b7249d2fee0e39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160314 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit eccbe3bb4ed6f0bed4e7fbacfaf50762c93f9464) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160183 Tested-by: Jenkins
2023-12-05[API CHANGE] Drop unused XAxis/YAxis config groupsGabor Kelemen2-74/+4
from Calc grid options. Spotted while researching for tdf#158473 last mention of ther getters was commented out in 2001 by: commit a4e5d2cb47275e91834e41a9d51f1bf11ec409b1 Change-Id: Iffc7b5c4fb50352ad7063fc911039707a20dca4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160169 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
2023-12-05tdf#158022 Grey Elegant template: restore placeholdersLaurent Balland3-430/+490
- Restore preview of slide in notes (master notes and notes, same size and position than other templates) - Enable header/date-time/footer/page number in master notes - Uniformisation of font Noto Sans - Bring to front header and outlines - Add date/time, footer and slide number on all master pages (except Title) - Improve Header and Outline positions - Use placeholders for example texts - Move credits on master slide "Table of content" and slide 9 to meta.xml - Change name of Title master page due to tdf#158496 Change-Id: I29eec8ad61fdf35a53be15678fd09aefc2b11a60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158956 Tested-by: Jenkins Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
2023-12-05tdf#60558 sw floattable: allow wrap of table on the right of a floattableMiklos Vajna3-1/+51
The bugdoc shows that Word wraps inline tables around floating tables if they have enough space, but Writer didn't do this. Table frames may wrap fly frames by adding some top, left or right margin to the table at a layout level, this is calculated in SwTabFrame::CalcFlyOffsets(). There we currently decide the give a top margin to such tables, which fixes the overlap problem, but the bugdoc is now of 2 pages instead of 1 page, since we don't wrap. Fix the problem by improving the "shift down" case by checking if shifting to the right would also work (has enough space). If so, do that in case the fly frame is a split fly. Note that this could be done for all flys as well, but that would have to be conditional on some Word compat flag and that's not needed to fix the bugdoc, so leave that for later. Change-Id: Idb45413257758fd0334b17ef348ba28010a52316 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160331 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-12-05upload_symbols: give some feedbackXisco Fauli1-1/+5
Change-Id: I2a1faa91ec502cfe8b62324f8fa80264bdb9d31f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160197 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-05uitest: remove crash report handlerXisco Fauli1-16/+1
Unneded since a4a1f2ecee2e7b1d50e0065e25090e262863e1c4 "Disallow crash reporting in UITests" Change-Id: I661b6111bd5142e67ee73a82c0777771e7651300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160324 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-12-05tdf#148540 Revert "tdf#109790 RTF import: keep remembering...Justin Luth5-16/+3
... paragraph style between \cell and \row" This reverts 5.4.1 commit aaa6a5202a447fb4e86d5f016d8e79fbc34a3ed7, and rtfexport7's tdf109790.rtf unit test still passes. I also did a visual test, which looks good. After \cell, we normally get more \cells, so an impending \row is completely unexpected most of the time. I'm not really sure why that patch was ever thought to be good. The problem was that \pard was not removing the paragraph style that was assigned to an earlier column. The end result seemed innocent (no bad formatting noticed), but that is probably based on other work done in the meantime which allows the unit test to still pass even after all of "its code" has been reverted. [If this causes a regression, perhaps m_pLastCharacterContext could be of value?] Change-Id: Ide9b65f5e5fa39c21bac6d8ed354bb88e0bbefe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160233 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com>
2023-12-05tdf#108505 writerfilter: fix field direct char settingsJustin Luth3-18/+68
Instead of adding characters properties one at a time, lets take care of everything all at once. The results seem to be good so far. There is even some similarity between how MS Word has these properties on the "in-between" pseudo end character, where placing the cursor after the field gets these properties. I don't see it happening in MS Word at the pseudo start character, but it does in LO now... Hopefully that doesn't end up doing bad things. In the unit test, replacing the content ends up in red, italic. However, I see the same thing in MSO when testing with my second FORMTEXT example, so I think everything is "working as expected". I tried to see if I could limit doing this for only certain types of fields or conditions. However, pContext->GetResult() doesn't have a \fldrslt yet at the time this is happening. Also, TextField.is() happens less than I expected. I'm sure I could limit it to just certain pContext->GetFieldId(), but so far no problems are noticed for all field types. make CppunitTest_sw_rtfexport6 \ CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat make CppunitTest_sw_rtfexport6 \ CPPUNIT_TEST_NAME=testTdf108505_fieldCharFormat2 Change-Id: I3223437fd0d694f5e5733a9f7323f10f03d7802f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160232 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemeng@ubuntu.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 17:41:47 +0000