summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
11 daystdf#142741: Add unit test to set valid pages for footnote links PDF export.MelvinYG2-0/+32
Change-Id: I90abb354fb9c4c6319034d994165f2e5cd667d2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175945 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
11 daystdf#163251 Fix for missing flags in single click obj creationAshSinc3-3/+3
Change-Id: I0f6e65c4cf3ad9cac3096144d8a0efec29030739 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174420 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Jenkins
11 daysUpdate git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' to b3bc6425768d93d6b9bb7304ed3a0ead4b03e2a7 - Mute L10n of <embedvar> + typos Change-Id: I06d3cf6d3d56dc030d422228f1e37cd68a7bddb5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/176697 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Jenkins
11 daysloplugin:dllprivate: Extend for new qtbase macroMichael Weghorn1-7/+7
Qt's qtbase commit [1] commit cecca90ff23ff27b9396defc21abd472b3fe0003 Author: Thiago Macieira <thiago.macieira@intel.com> AuthorDate: Tue Oct 1 11:26:30 2024 -0700 Commit: Thiago Macieira <thiago.macieira@intel.com> CommitDate: Tue Nov 12 17:14:46 2024 -0800 moc: fix support for generating meta objects for nested private classes introduced a new QT_OBJECT_GADGET_COMMON macro, causing my `--enable-qt6` clang plugin build with current qtbase git dev (as of commit 957e2be00a5c45223a5ef842a5f9f2f7b7be882b) to fail as follows for classes using the Q_OBJECT macro: In file included from /home/michi/development/git/libreoffice/vcl/qt6/QtAccessibleRegistry.cxx:10: In file included from /home/michi/development/git/libreoffice/vcl/qt6/../qt5/QtAccessibleRegistry.cxx:11: In file included from /home/michi/development/git/libreoffice/vcl/inc/qt6/QtXAccessible.hxx:10: /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:27:5: error: declaration nested in DLLPRIVATE declaration redundantly marked as DLLPRIVATE [loplugin:dllprivate] 27 | Q_OBJECT | ^~~~~~~~ /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:145:5: note: expanded from macro 'Q_OBJECT' 145 | QT_OBJECT_GADGET_COMMON \ | ^~~~~~~~~~~~~~~~~~~~~~~ /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:132:5: note: expanded from macro 'QT_OBJECT_GADGET_COMMON' 132 | Q_DECL_HIDDEN_STATIC_METACALL static void qt_static_metacall(QObject *, QMetaObject::Call, int, void **); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/michi/development/git/qt5/qtbase/src/corelib/kernel/qtmetamacros.h:98:39: note: expanded from macro 'Q_DECL_HIDDEN_STATIC_METACALL' 98 | #define Q_DECL_HIDDEN_STATIC_METACALL Q_DECL_HIDDEN | ^ /home/michi/development/git/qt5/qtbase/src/corelib/global/qcompilerdetection.h:190:46: note: expanded from macro 'Q_DECL_HIDDEN' 190 | # define Q_DECL_HIDDEN __attribute__((visibility("hidden"))) | ^ /home/michi/development/git/libreoffice/vcl/inc/qt6/../qt5/QtXAccessible.hxx:25:7: note: parent declaration is here [loplugin:dllprivate] 25 | class QtXAccessible : public QObject | ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 26 | { | ~ 27 | Q_OBJECT | ~~~~~~~~ 28 | 29 | public: | ~~~~~~~ 30 | QtXAccessible(css::uno::Reference<css::accessibility::XAccessible> xAccessible); | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 31 | 32 | /** Reference to the XAccessible. | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 33 | * This is cleared once it has been passed to the QtAccessibleWidget, | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 34 | * which then keeps an own reference and takes care of all required | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 35 | * access to the XAccessible for the Qt a11y bridge. */ | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 36 | css::uno::Reference<css::accessibility::XAccessible> m_xAccessible; | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 37 | }; | ~ 1 error generated. make[1]: *** [/home/michi/development/git/libreoffice/solenv/gbuild/LinkTarget.mk:339: /home/michi/development/git/libreoffice/workdir/CxxObject/vcl/qt6/QtAccessibleRegistry.o] Error 1 Extend the plugin to also take the new macro into account in addition to Q_OBJECT. [1] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=cecca90ff23ff27b9396defc21abd472b3fe0003 Change-Id: I990f0b25010b3a0f0cc3902f732b93d13bb85d78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176702 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
11 daysdbaccess/qa - Seperate database connection so it can be reusedAdam Seskunas1-1/+8
Change-Id: I982cf589aff159149190c7f0f78dc8085a700240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174981 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
11 daysupdated vim footers in vcl/qt6/*.cxxlovatico2159-118/+118
Change-Id: I98f15800abf65bf3c69b473e8eb68b01838b2ed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176556 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
11 daystdf#81913 - Keep cell highlighting active during arrow key navigationAndreas Heinisch1-0/+3
Don't delete range finder during arrow key navigation since cursor keys don't count as modifications. Change-Id: I53566a4a84ff4dc81fdf0d8b8f6468f956958925 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176689 Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
12 dayscrashtesting: use after freeCaolán McNamara1-4/+2
commit 8393267c651d0a3071472a8d6ad9861ed75af38b CommitDate: Tue Nov 12 09:03:21 2024 +0100 clang-tidy: performance-unnecessary-copy-initialization in various Change-Id: I1033c33a6b4bf06e365ce183b1a73c98bea777ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176442 Change-Id: Id9e253b849c74a2828ef889f9a13854de0fe2f8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176693 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
12 daysUpdate git submodulesAlain Romedenne1-0/+0
* Update helpcontent2 from branch 'master' to c4bd6c98f97baeebb9ab087939cf6675ac27a2ce - Basic MiD() method has 2 different signatures - arguments syntax precisions - keyword names correction, the 4th argument keyword name is unknown Change-Id: I6d38dcf61286f88d28090d9e18fafde25bd89376 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/172821 Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org> Tested-by: Jenkins
12 dayscid#1607974 silence Overflowed return valueCaolán McNamara1-6/+5
Change-Id: I9663f3e0cb641bd4530e1aca06d4216de74e38cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176691 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
12 dayscid#1607833 Overflowed constantCaolán McNamara1-1/+1
Change-Id: Ie90b759b76fa587cddd3c160fe7845dec01652c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
12 dayscid#1607905 Data race conditionCaolán McNamara1-3/+2
Change-Id: Idb525a4e19cfbe0c4a493f511be7dadafac0cff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176465 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
12 dayscreate BaseContent with the state required and drop mutexCaolán McNamara4-18/+11
and ContentEventNotifier can be de-friended Holding this mutex to write to a just created local doesn't make sense to me. I can't see any where that there might be another thread that matters here. Change-Id: I803a45a0cf02ebc306767595555018ee97d96caf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176684 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
12 dayscid#1607919 Overflowed constantCaolán McNamara1-2/+5
Change-Id: I842357000f3282521aa927921a5598fddaef5dee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176686 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
12 dayspNew is only possible if there is a pRedLineCaolán McNamara1-6/+11
so we can move this inside the other conditional Change-Id: I63259598d5165e3aafbf0c1cfef70ccb1b16bb38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176685 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
12 daystdf#143148 Use pragma once instead of include guardsSloane Vaznova21-85/+21
Refactored include guards into pragma once for some files alphabetically c-d in sw/inc. Change-Id: I8cf8059851169472d7953f4e6f5408666d27c2c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176688 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
13 daysDrop DECL_LINK missed in commitJim Raykowski1-1/+0
60a77c7ef46f6fa82b016c7605ec3451de291344 Change-Id: I9141380327aa111bee02257ea2dda53a19bcb0d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176687 Reviewed-by: Jim Raykowski <raykowj@gmail.com> Tested-by: Jenkins
13 daysAvoid UBSan when negating the most negative sal_Int64 valueStephan Bergmann2-5/+8
...as exhibited by recently added 08e566f0c97fb6cc2ee17813e81c221a8d7154c0 "add a couple of tests for tools::BigInt" Change-Id: Icd1080f86ccd985868fce34d6f86e2706acd58df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176677 Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> Tested-by: Jenkins
13 dayscid#1606752 silence Overflowed return valueCaolán McNamara4-28/+18
and cid#1607158 Overflowed return value cid#1607271 Overflowed return value cid#1608107 Overflowed return value cid#1606975 Overflowed return value cid#1608009 Overflowed return value cid#1608353 Overflowed return value cid#1608486 Overflowed return value cid#1607009 Overflowed return value cid#1606780 Overflowed return value its totally unclear what the source of these warnings is Change-Id: If46cac6a329dec397bd784f57d9ffe5e53af9a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176683 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
13 dayscid#1371295 avoid Missing move assignment operatorCaolán McNamara1-2/+6
Change-Id: I27cca1b737c441a9f31ed6aa0fc462190ca818da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176682 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
13 dayscid#1557644 COPY_INSTEAD_OF_MOVECaolán McNamara1-1/+1
Change-Id: I63510464b74e72f8fc73899e963e20891cdf0f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176644 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins
13 daystdf#163486: PVS: Identical branchesBogdan Buzea1-3/+1
V1037 Two or more case-branches perform the same actions. Check lines: 146, 158. This will still be the case, the code being just at the moment similar. Change-Id: Iceca3c717ccc6ee3ea865d3a469418ff6e8accd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175146 Reviewed-by: David Gilbert <freedesktop@treblig.org> Tested-by: Jenkins
13 daysFix typoAndrea Gelmini1-1/+1
Change-Id: Iffd36495c9a1424ad02756dbc9bde6ae55df86c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176662 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
13 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I05757dccf4abc66f11454d2587902d25fca4312a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176660 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
13 daysFix typosAndrea Gelmini1-2/+2
Change-Id: Ibeadfb72c54887ac8a74dbb11958266fbbda46e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176659 Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net> Tested-by: Jenkins
13 daysFix typoAndrea Gelmini1-1/+1
Change-Id: I4ffd3af20662e92512119ddfa27ea255a114f910 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176661 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
13 daysRelated tdf#105112: FB fix request for getFunctionsJulien Nabet1-3/+3
add missing spaces + quote before and after function name searched Change-Id: I3b0bd3ca780c4de9d04fda7d2c80c29e60ddd1ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176669 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15tdf#151423 Only allow modifiers for mouse scrollwheel eventsPatrick Luby1-4/+26
The Command modifier converts scrollwheel events into magnification events and the Shift modifier converts vertical scrollwheel events into horizontal scrollwheel events. This behavior is reasonable for mouse scrollwheel events since many mice only have a single, vertical scrollwheel but trackpads already have specific gestures for magnification and horizontal scrolling. So, behave like most macOS applications and ignore all modifiers if this a trackpad scrollwheel event. Also, ignore all modifiers for swipe events since it appears that devices that generate swipe events can generate both vertical and horizontal swipe events. Change-Id: I3c0c726759ef010d528f221c63d1e7e401726db5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176410 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
2024-11-15tdf#163876 ignore marked text generated from Command-` eventsPatrick Luby1-0/+14
For some unknown reason, when using the standard macOS French layout, pressing Command-` causes -[NSView interpretKeyEvents:] to temporarily set and unset the marked text. Command-` should only cycle through the application's windows so ignore marked text changes from such key down events. Change-Id: Ifeb4ad637d572b339d7b389466815bb60a4b3120 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176652 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins
2024-11-15Related tdf#105112: use XDatabaseMetadata3 in Firebird + implement getFunctionsJulien Nabet2-2/+219
Firebird query for getFunctions comes from Jaybird (Firebird JDBC client). Change-Id: I427cc1a103ed6fe2b1ad3554bb7c3e2f7a903d87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176273 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15tdf#130564: getTableTypes retrieves only table types of the current databaseJulien Nabet1-0/+10
So indicate to LO that at least PostgreSQL and MySQL/MariaDB support views Change-Id: I241fa3cfc599e11c1f1523a78a1905beadc80307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176308 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2024-11-15tdf#163383 Skip adding a tooltip to internal links in all casesIlmari Lauhakangas1-1/+1
Change-Id: I1d4e46b6e886d45982f3e8145e0bc12ec12d9884 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176626 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins
2024-11-15render master and slide content separately (drawinglayer render)Miklos Vajna8-46/+216
This renders master and the main slide as 2 separate layers, which is useful because in a huge slideshow we can reuse the master slide and only render the rest of the slide, which should be more compact in size as the master slide is the one that usually contains the (complex) background. Change-Id: I5e86d718b7ab3b03bd0b6146ce4df218a4dd72d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176622 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-11-15Cleanup notebookbar.ui for drawHossein1-5/+5
Fix duplicate IDs found by glade-previewer Change-Id: I5331d5ebdc226bb370d2fd6d6f00c2315952f5ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176625 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-15tdf#163486: PVS: V614 Uninitialized variable usedBogdan Buzea1-2/+2
V614 Uninitialized variable 'aLStyle' used. V614 Uninitialized variable 'aFStyle' used. Change-Id: I2e545d7909818d8850728bea7cbb533d5ddd87e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175860 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#79450 - Other: Bubbles too near disappear in a Calc chartKurt Nordback1-0/+6
An existing optimization avoids rendering a bubble chart bubble if it is nearly the same size and position as the preceding bubble. This results in incorrect rendering in the case of transparent fill. Skip the optimization in this case. Change-Id: Ie21235a66c4d22ac2ce793264ef5bb7b6434117e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#163486: PVS: fix assertXisco Fauli1-1/+1
V547 Expression '!"unknown reference mark type"' is always false. Change-Id: I7f984c0e008924b23e3a2384c2e36390bf76cfec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#163486: PVS: Identical branchesBogdan Buzea1-23/+3
V1037 Two or more case-branches perform the same actions. Check lines: 830, 840, 850 V1037 Two or more case-branches perform the same actions. Check lines: 960, 1148 Change-Id: Ifff7612b44d2a3bc0ea573077104b460fed8cf76 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175222 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-15tdf#163486: PVS: Identical branchesBogdan Buzea1-7/+2
Change-Id: I71c6cd9b5dbcb3126da1919108be009f6512b0d0 V1037: Two or more case-branches perform the same actions. Check lines: 100, 122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/175054 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-15vcl: make Calendar constructor initializer functions more clearChris Sherlock1-9/+9
Change-Id: I670f219e98bb83f0e8efd0054a06aa869f8fc098 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174719 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#39468 vcl: translate German comments in control/calendar.cxxChris Sherlock1-2/+2
Change-Id: I6d741a7b1da28f0111df1b1947e510d595d282dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/174718 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15tdf#136003 Change labels in the protect sheet dialogSahil Gautam1-2/+2
previously a comment `(for unprotected cells)` was added to the `Delete Rows` and `Delete Columns` menu entries as a solution of tdf#136003. The change has been reverted https://gerrit.libreoffice.org/c/core/+/176614 As tdf#136003 says "Can't delete rows, despite of allow to deletes", the source of confusion is these labels `[ ] Delete Rows` and `[ ] Delete Columns` in the protect sheet dialog. Changed these to `Delete rows with unprotected cells` to make it more clear what they are about. Change-Id: I1009fca2a3cf56ffdc513fdb9b6192b3b965d050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176616 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil@libreoffice.org>
2024-11-15simplify GDIMetaFile::ReplaceActionNoel Grandin2-4/+1
now that we are using proper reference-counting template classes to control lifetime here, the code can be simplified and obsolete comments removed. Change-Id: I7693c684d4bed0e26016b5d6bbbf1c38fec62519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176624 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2024-11-15tdf#143148 Use #pragma once instead of include guardsMohamed Ali1-4/+1
Change-Id: If278386d2f6da2b841f57be0b57c189dcade3c3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176608 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2024-11-15cool#9992 lok doc sign: add initial serialization of external signaturesMiklos Vajna8-20/+102
Now that the hash extract part works, the other end of this external signature support is to be able to integrate an externally generated (e.g. qualified) signature into our PDF file. The problem is that we have SignDocumentContentUsingCertificate() for non-interactive signing and we have the interactive sign dialog, but we have no way to integrate an existing PKCS#7 blob. Fix the problem by extending vcl::filter::PDFDocument::Sign(): if a signature value is provided, then integrate that, instead of calling svl::crypto::Signing::Sign() to generate a new signature. Also extend the SigningContext documentation, since now it has 3 modes (normal sign, hash extract, sign serialize). Change-Id: I113fb536b1a83b8a4869a7064bb415bca6a91ae4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176623 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2024-11-15consistently return -1 in SvFileStream::PutDataNoel Grandin1-0/+3
for the error case Just for consistency with the other error cases in PutData/GetData Change-Id: Ib7fd27f9347021b3063e6eac88fd8038d5f218e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176621 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15add a couple of tests for tools::BigIntNoel Grandin1-0/+18
because I might touch this area and I want to be sure I don't mess it up Change-Id: I62c177031f690f4455a58f3280ed26186df94158 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-11-15Cleanup notebookbar.ui for scHossein1-5/+5
While trying to load notebookbar.ui for sc I found that there are issues with the .ui file itself: * Duplicate IDs, created in 608e1452c51efa4f9bbcea8ed9a538ff974eed28 * Typo in the attribute names, created with the manual edits in 04ed7cbe53243a042ceeecc62212e73a910d7aef This patch fixes above problems. Now, one can preview the notebookbar.ui for sc with: $ export GLADE_CATALOG_SEARCH_PATH=$PWD/instdir/share/glade $ glade-previewer -f sc/uiconfig/scalc/ui/notebookbar.ui Change-Id: I83be23f4a2a24a04f4fa8b627c138bc42bdf6916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176619 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2024-11-15Add minimal vcl weld example applicationHossein4-0/+138
The "minweld" is a minimal standalone vcl application that uses the LibreOffice vcl weld framework to display the "tip of the day" dialog on the screen. Upon clicking on the "Next Tip", a counter is incremented and the text label containing its value is displayed/updated in the center of the dialog box. One can run the application by invoking: ./bin/run minweld This example uses cui/ui/tipofthedaydialog.ui for the UI, but only uses a few elements of it. Change-Id: If304c60ddb262182cf23438ed1f83dba85e66391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176610 Reviewed-by: Hossein <hossein@libreoffice.org> Tested-by: Jenkins
2024-11-15Revert "tdf#136003 Make Delete Rows/Columns labels more descriptive"Sahil Gautam2-2/+2
This reverts commit 68d074fb910de7298cbefb6a3c3e192dae201837. Reason for revert: Changing labels in the menu doesn't help much, rather makes it confusing for new users; decided in the design meeting on 2024-Nov-14 Change-Id: Id8560cd32b233f6908e79beb3af3d774ccc06adc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176614 Tested-by: Jenkins Reviewed-by: Sahil Gautam <sahil@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-29 19:32:45 +0000