summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2022-11-16bump product version to 7.4.3.2.0+libreoffice-7-4-3Christian Lohmaier1-1/+1
Change-Id: Ibcf2e3c5b6c2758012ef893871f554f5af15a70d
2022-11-16TempFile: clear handle on closeDr. David Alan Gilbert1-0/+6
If we close the file on error, then clear the handle we returned to the caller so it doesn't try and close it again or do anything else with it. Change-Id: Idd054f92f4f3cbc3427896ec9795e588471292d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142344 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0d9613b77fc653c6144b5e4f0136c0536300c0db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142306 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 84d292960bee73f24450857ff141953be2570094) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142434 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-16TempFile: Initialise handleDr. David Alan Gilbert1-1/+1
If the tempfile creation fails, the handle is left uninitialised but we still try and close it, and we explode with various pthread locking corruptions. I think this could be the cause of a bunch of the: https://crashreport.libreoffice.org/stats/signature/osl_closeFile I can trigger it on Linux by setting TMPDIR to a bogus value, but I don't think that's all the cases that we see in the crash reports. Initialising it to null makes the close take a safe path. Change-Id: If66c5629b6bce62e6c4b18a97ecb901abedd4ea3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit fa40ea19dbea5f0618d86da8626c35e734bb5220) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142305 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit f7adc60d6a17f43c14496560e9fbfcc638ff4c41) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142435 Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-16update creditsChristian Lohmaier1-2213/+2433
Change-Id: I5fb81432975d0a0c83cfbed6f4335ca54d574c37 (cherry picked from commit cb2133e765ebd44fb005b9d1497de65ac28f1f1a) (cherry picked from commit 55192b9148aca779ab2c2f28fbe024e9c3d6d720)
2022-11-16Update git submodulesChristian Lohmaier1-0/+0
* Update translations from branch 'libreoffice-7-4-3' to a1e4202474a71d408dde3e9b4ab3156dace535a8 - update translations for 7.4.3 rc2 and force-fix errors using pocheck Change-Id: I899323d45f4b174db2c6b745d29f20b48b39bf30 (cherry picked from commit 866c614e3b6401538fc951583e8bbb11874da097)
2022-11-16Fix ARM64 build after postgres upgrade to 13.8Xisco Fauli1-1/+1
Partially revert 096e2ba8e4fce64c04a7d7e842dd1dbab8699801 "postgresql: upgrade to release 13.8" Change-Id: I3fa2a96f9765788ab6193133c4f420eed7eb99bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142255 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 2cfd5a875231cc9ae59cc495ba82efc54de2016d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142209 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit afe9de4d8c972293ba6e00444ebafbbd8472d33c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142210 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-16vcl: fix crash in Window::LeaveWait()Miklos Vajna1-0/+2
Crashreport signature: SIG Fatal signal received: SIGSEGV code: 128 for address: 0x0 program/libmergedlo.so vcl::Window::LeaveWait() vcl/source/window/mouse.cxx:640 program/../program/libsclo.so ScSpellingEngine::ShowTableWrapDialog() sc/source/ui/view/spelleng.cxx:315 program/libsclo.so ScConversionEngineBase::FindNextConversionCell() sc/source/ui/view/spelleng.cxx:168 program/../program/libsclo.so ScSpellDialogChildWindow::GetNextWrongSentence(bool) /opt/rh/devtoolset-10/root/usr/include/c++/10/bits/unique_ptr.h:173 Seeing that e.g. Window::GetDropTarget() also handles a disposed vcl::Window, let's do the same here. Change-Id: Ia4ad312ae91dfef24266c5bd45751778acbee367 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142473 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 3df3488014dc5f80756c24f584bb554845f4a2df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142439 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7a7c76bb1e135b6de242e9fbd4b3b34adf3fc0ad) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142440 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-16external/openssl: fix and remove some patchesTaichi Haradaguchi3-15/+3
* configurable-z-option.patch.0, openssl-no-multilib.patch.0: fix patch coverage * opensslios.patch: remove this patch as it is not used. Change-Id: Iaa23e5bb9ca9d63f5ca7451d02726ad24211f078 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 983f68e3f5e8bb5c1ac2618fc49f4b01b3de5c0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142678 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-16Resolves: tdf#151947 Merging separators must not scan for field endEike Rathke1-1/+1
Regression introduced with commit cf777cfcb22647b1f2d6ace307fbcc4f6d2cca30 CommitDate: Sun Oct 2 17:07:06 2022 +0200 Resolves: tdf#125110 tdf#151211 Disentangle the convoluted CSV/TSV-clip import a copy-paste replacement logic error. Change-Id: Ibd699a4edfa9f88da26d888afa8567ee34e78a5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142572 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 5db9d8356c8fdc732942357cd2171ba27eda8647) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142528 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-16upgrade Expat to 2.5.0Taichi Haradaguchi2-8/+9
Fixes CVE-2022-43680 Change-Id: I5bf8d1ab0ac352833c76a7edfc1d8eb78dd03e10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 74eea44c685e108fab44c85ce81609091c7be1ec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142211 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-16upgrade to openssl-1.1.1sXisco Fauli1-2/+2
Change-Id: Ic0f1fca7ef73b3a443c24d2bcc7f234be331a05b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142184 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 23e6227ab347a00b235fb00892b379ef4e3a0d35) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142200 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-11-15Resolves: tdf#152014 When reusing interpreter context slot clear lookup cacheEike Rathke1-1/+5
... if different doc As is, unthreaded the same slot gets reused for every calculation. That could benefit from keeping 2-3 documents cached to not throw away the lookup cache each time when alternating between documents. Change-Id: Id024333f72bcdcd6109042dec1104f3029955d3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142639 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f86a0666ac337363b470c9c67fa0970a330b26a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142631 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-11-02bump product version to 7.4.3.1.0+Xisco Fauli1-1/+1
Change-Id: I57a4bcf3420a0c63ebab28c055f6c5f07b8353d2
2022-11-02Branch libreoffice-7-4-3Xisco Fauli4-1/+1
This is 'libreoffice-7-4-3' - the stable branch for the 7.4.3 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.4.x release, please use the 'libreoffice-7-4' branch. If you want to build something cool, unstable, and risky, use master.
2022-11-02tdf#113187 exclude angle conversion from count of maGuideListRegina Henschel4-1/+24
The ooxml import uses the special viewBox value '0 0 0 0' to indicate that the point coordinates are relative to shape size and not to viewBox and need special treatment. To detect this case the number of guides in maGuideList was used. But that number might be larger than the guides in ooxml because each arcTo command introduces two additional guides for the conversion from 1/60000 degree in ooxml to degree in LibreOffice. The patch excludes these guides from count. Thus now a path which has no references in its points will get a viewBox with non-zero width and height in all cases and is rendered now. Change-Id: I410638a1fe02f692fd46313c88b5ea518f1d094f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142050 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142109
2022-11-02tdf#148926 tdf#151678 PPTX import: position of standard connector - part1Tibor Nagy5-0/+98
Connectors are typically connected to connection dots, which exist on shapes. If both or one of the two shapes are missing, it will be drawn the default type of a standard connector in LO. In this case, there is an adjustment point which is used to modify positions and shapes of the connectors. This patch fixes the position of the connector by calculating and setting the adjustment value. Change-Id: Iee384d2a92a22ff95d7b17ba0b4f09698176bc84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141723 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142159 Tested-by: Jenkins
2022-11-02vcl: re-exporting broken pdfs -> empty pagesDennis Francis7-102/+183
Certain pdf documents when loaded in LO_IMPORT_USE_PDFIUM=1 mode even if pdf-version < v1.6 sometimes has missing objects referred by other objects for determing its stream length for instance. As a result parsing fails and results in a pdf with empty pages. A round trip through pdfium and exporting to v1.6 seems to cure the issue. Possibly it does some repairing work to determine the length of the stream in a independent pass through the file. Conflicts: vcl/source/filter/ipdf/pdfread.cxx Change-Id: Id09f67eddab4163ed12a3a3f3a73baf92e2912aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141856 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com> (cherry picked from commit 3f9e8ac6172f5b1dfd2869ee1c6aea4f24d3f480) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142137 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-02update creditsXisco Fauli1-1979/+1755
Change-Id: I33892b5bee2d043704c69b088bcc84217ca28099 Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-02tdf#151621 sd UI: use correct zoom in embedded PPTXTünde Tóth1-3/+7
Embedded PPTX object opened at 3000% zoom in a new window. Change-Id: I7b353b607a1cef84eceaac5fbff96f2fbeb18500 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141528 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 6e378b5beee473edc54c50550eff9e7d9eec57b5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142143 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-02tdf#151462 - Search for outline node containing the current nodeAndreas Heinisch2-0/+35
Added unit test Change-Id: I9fcc26527ec2f7e036ee32a709f023fcc50d9e6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141892 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142157
2022-11-02Update git submodulesXisco Fauli1-0/+0
* Update translations from branch 'libreoffice-7-4' to 9268c1f70168e99e847ccf554edb2f897c2684c2 - update translations for 7-4 and force-fix errors using pocheck Change-Id: I906b6346540ef3316f9564cbfbcecb659d038920
2022-11-02Resolves: tdf#147141 style:header-first/footer-first only ODF 1.3|1.2-extendedEike Rathke1-1/+12
For ODF 1.2-extended write with loext namespace, for ODF 1.2 and earlier do not write them at all. LO versions <7.2.5 not having the fix for tdf#144940 need ODF 1.2 written (without header-first and footer-first) to not lose the header/footer. Change-Id: Id856459eac487ddd8ba0c6963db5d4e227d82093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142127 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 71081a2a79a7b5a1eefec60fc687c533a95d190d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142140 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-02tdf#151384 DOCX export: lost hyperlink format in localized UITünde Tóth1-3/+7
Fix losing color and underline of hyperlinks in localized builds, at least with Russian UI. Regression from commit d57b4480903f700ad7c95e885b9dd0ace5883cfc "tdf#127579 DOCX export: fix losing color and underline of ODT hyperlinks". Change-Id: I1eebcf58a7071226e80df3f84ed1264c5a8baf31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141761 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 2dfd9e3e00f6e57ab1b307cf57c01a0830da4b17) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142134 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-11-01tdf#151462 - Search for outline node containing the current nodeAndreas Heinisch1-0/+2
If the index lies within a special section, the position of the anchor of the corresponding section will used to search the node of the paragraph. This patch searches for the outline node of the found paragraph in order to find all the corresponding sub indexes. Change-Id: I9be4bdc0768d5d0d5987d47d37e41acc5009cca8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141344 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit ba58fc11723b7c9d370d6407385ea0e8829db099) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142136 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151492 PPTX export: fix connection points regressionTibor Nagy3-2/+17
caused by commit 4d153517183193f468dee9148c94fe9d874bacb3 (tdf#149697 PPTX export: fix changing place of connection points). Change-Id: I6134f18f3c32182a2f5d7295e2511da192dd20c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141427 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 097a2de6428f834d28fa78af203d3c0b6577656e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142135 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01Python3: update to 3.8.15Taichi Haradaguchi13-84/+25
* Fixes CVE-2022-40674 * Removed 0001-3.6-bpo-17239-Disable-external-entities-in-SAX-parse.patch.1 as fixed upstream Change-Id: I8e71f9a6b013ca4c45bf8774b284be98eee71bab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ea5843b67f1c2006aa1f68f2d00a991e1d463262) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141738 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#124603 sw: pressing Up/Down triggers pending spell checkingLászló Németh3-1/+81
Modified text wasn't checked until the next edit operation, so spelling mistake of the last edited word could go unnoticed. Leaving the edited line by pressing Up/Down triggers pending spell checking to fix the problem in most cases. Regression from commit 4c91e94e892943ef5e031d65f6f42864233cb4cd "tdf#92036: sw: fix idle spelling loop", Note: add unit test to tdf#92036, too. Change-Id: I865eb7b5d8f872421230d457989e24c3b489690d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141728 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e3ae86a38d6282db0f54d3545015ed22ee868ae5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141852 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151654 related: dereference after nullptr checkMike Kaganski1-1/+1
pPV nullptr has appeared in commit 6fcee31ed5e1dadcbf9614967592ff188a250007 Date Thu Jul 02 14:28:15 2009 +0000 CWS-TOOLING: integrate CWS aw065 but it was still dereferenced unconditionally after that. Change-Id: I4a9ec2345e4093673eed092f6ddb16ee21b9d00f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/142054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 7fc2aefc09956bee0353575d2bacca2d5b556b04) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141929 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151736 writer direct formatting crashNoel Grandin1-5/+14
regression from commit 9a44807ff3a11afa8f7ce9857ae6a6144a61d481 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Mar 2 17:58:31 2022 +0200 use SfxItemSet::GetItemIfSet in sw/source/core/txt Change-Id: I9db016d608300c603d0b1386962b188dddc85125 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141943 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 7d63176bcfbc80fc4045a0f0580c5bf9ccea7a89) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141928 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151546: RTL text is reversed (Writer pdfimport)Kevin Suo3-10/+70
This is a followup to commit 69e9925ded584113e52f84ef0ed7c224079fa061 for the fix of tdf#104597. The Writer pdf import filter code is similar than the Draw part. However, many fixes to the Draw part was not done in the Writer part historically. This patch ports the fix of text run in the Draw part to the Writer part. There is a todo related to continuous spaces issue which should be fixed separately. Also use CPPUNIT_ASSERT_EQUAL_MESSAGE for the output of xml content instread of using std::cout, in case of unit test failure. Change-Id: Id013700524750e6e5283d85eeab72d8075f16f1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141420 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit f6004e1c457ddab5e0c91e6159875d25130b108a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141927 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01error when copying table and the copy table wizard creates the primary keyNoel Grandin1-1/+3
then the primary key will not be IDENTITY column, and the ALTER TABLE...RESTART WITH will product an error Change-Id: If17bd0cbfe3519f9074aebb819b7d85ccea63e1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 85a5233275ab83fe0d6b943b298695387d97accd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141932 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01sdext.pdfimport: resolves tdf#104597: RTL script text runs are reversedKevin Suo4-31/+48
For the simple Arabic string: ٱلسَّلَامُ عَلَيْك, the xpdfimport binary generates the follwing (drawchar) sequences: كَ يْ لَ عَ مُ ا لَ سَّ ل ٱ (i.e., in reversed order, one character by one character). Before this patch, after pdfimport the text shows up as لَسَّلٱ كَيْلَعَ مُا, which is reversed. It was surposed to combine these characters into text frames in DrawXmlOptimizer::optimizeTextElements(Element& rParent) (sdext/source/pdfimport/\ tree/drawtreevisiting.cxx:677), but actually it was not combined successfully there. The single characters were then passed to sdext/source/pdfimport/tree/drawtreevisiting\ .cxx:105, one by one, in the hope that the strings could be mirrored. The mirroring failed, because one single character, even after mirroring, always equals itself. The DrawXmlOptimizer::optimizeTextElements failed to combine the characters into one text frame, because the condition: (rCurGC.Transformation == rNextGC.Transformation || notTransformed(rNextGC)) would never be true, as at least its horizontal position is different. A further analysis indicates that we do not need to check the transformation here at all, as this is an optimizer for a TextElement and in case a character is transformed then it would already be in a different draw element (thus will never be combined with this TextElement). After the fix of DrawXmlOptimizer::optimizeTextElements which now successfully combines the characters, there is another issue in the old PDFIProcessor::mirrorString function. It seems to mirror the characters within a word, but if a string contains two words, then the two words are not successfully switched (e.g. for string "abc def" it produces "cba fed" rather than "fed cba"), which is not suitable for the case of RTL which requires all the characters been reversed. Fix this by using comphelper::string::reverseString. Change-Id: Ifa210836f1d6666dd56205ff0d243adfb4114794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141231 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 69e9925ded584113e52f84ef0ed7c224079fa061) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141319 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01build appstore packages with symbols/add targets to merge into universal buildChristian Lohmaier1-5/+45
while there is no builtin support to create a fat binary during the actual build phase, we have a post-processing script that can merge two separately built architectures into an universal binary one. Thus enhance the makefile to support a more convenient way to build the two archs without the need to manually move the package out of the way to build the other arch. 1) assemble one architecture's package via "make mac-app-store-package.prepare" 2) make clean and change targets in autogen.input to build for the other architecture 3) build the other architecture and combine into universal binary and also package into the final deliverable via make mac-app-store-package.universal (of course you can also use the .prepare target separately also in the second build, and just mac-app-store-package will build the deliverable for the current architecture like it did before) Change-Id: I02c14e9b8c4f6e39d0d50cd3b4ffdd060b2d69bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141557 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit d5c11ddae9e54668f5d8997f4c37dd542e656d4f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141703 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01macOS sandbox: only use com.apple.application-identifier for main packageChristian Lohmaier1-7/+9
when multiple files are signed with that entitlement, the build will just be listed with "Not Available for Testing" via Testflight Change-Id: I92957f24513ab419ddbc4289b53175932111c198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141497 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 6e6c6f697b019348161648d9d26398bf64de83ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141701 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151073 - enable firebird for appstore build w/o experimental modeChristian Lohmaier2-1/+5
also don't default to hsqldb as embedded database when a build is done without java support. Mainly to hide an UI bug - apparently the dialog should show a non-supported message for known embedded drivers at least that is what 04d1e80ac7091ec2bf31c8617e832d5fe15350be suggests " // this indicates it's really a type which is known in general, but not supported on the current platform // show a message saying so // eSpecialMessage = smUnsupportedType; insertDatasourceTypeEntryData( m_eCurrentSelection, sDisplayName ); // remember this type so we can show the special message again if the user selects this // type again (without changing the data source) m_eNotSupportedKnownType = m_pCollection->determineType( m_eCurrentSelection ); " but that doesn't work, at least not anymore. m_eNotSupportedKnownType was since removed, no attempts are made in showing an error/warning message returning the hsqldb driver results in an empty (no display string) entry as the default element in the dropdown in the dialog, that still allows to create a database file (but of course one that you cannot add any actual database tables to) without any error message. At the very least it is inconsistent with the rest of the dialog's code that clears the input name for stuff that shouldn't be shown. Change-Id: I8419888018be2a556c49d32e40f02c0ac1801930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141631 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit d0a20b67ae7ee1691409b4a1665853a182c46b7b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141705 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#151484 Data Validity list looses separation when saving as XLSNoel Grandin2-2/+4
regression from commit fbb41798b86c5ed35eb80aa07a5ee7c9866ac4e8 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Mar 18 09:46:52 2022 +0200 tdf#133603 remove some string copying Change-Id: Ie241a7d5e54673b35c643c7c20dc100ba7925647 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9ff56812741029ad17204cff53357751687d9b6c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141834 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#148934 PDF/UA export: add Contents entry to Link annotationsMichael Stahl15-56/+92
* Specification: ISO 14289-1:2014, Clause: 7.18.5, Test number: 2 Links shall contain an alternate description via their Contents key as described in ISO 32000-1:2008, 14.9.3. These links are created all over the code, in some cases it's a bit dubious what the content/alt-text should be, but let's try to use the most suitable looking bit of text in whatever the context is. * Specification: ISO 14289-1:2014, Clause: 7.18.3, Test number: 1 Every page on which there is an annotation shall contain in its page dictionary the key Tabs, and its value shall be S. Change-Id: I7b63feb759f0c75047f854ed9997918f829a537e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141826 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit fa3f04bdd4f73a1b3be70dfb709c44638ef7e3d9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141873 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#150888 Scale down PPI if it would result in a tiny imageParis Oplopoios4-4/+45
The reason for the blurry document in tdf#150888 is that the image is tiny. PPI is 2540 in that image but when using the window bounding box (96, 81) this results in a very small image that the .odt then scales up which makes it blurry. Apart from that, when opening the extracted .wmf in Draw it's also very small, around 0.04" squared. Because MM_ANISOTROPICs definition allows for arbritrary scaling, when an image would be smaller than an inch squared the PPI is scaled down to either the images width or height. This makes the extracted WMF match the size of competitor office suites and fix the blur bug without breaking past tests. Change-Id: I11eab879848d9308f818708a91fd9eb91fc65200 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141533 Tested-by: Jenkins Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit a03a47bb0791d88fedb2650bca412c28469b0b27) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141745 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-11-01tdf#124333 PPTX import: fix Z-order of embedded OLE objectsTünde Tóth5-11/+45
Choose mc:Choice in a:graphicData element if the selected p:oleObj element has a shape id to avoid of shape duplication which created also bad layout/overlapping because of the different Z-order of the duplicated shape. Change-Id: Idecff4903c2d637bc82353f13352cac72413cec1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140041 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141938 Tested-by: Jenkins
2022-11-01Fix bug in copying table where we need to create a primary keyNoel Grandin1-0/+14
The problem seems to be that commit fa177231cd20bf3c3f4bb9b50f6646da139c6766 Author: Tamas Bunth <tamas.bunth@collabora.co.uk> Date: Fri Aug 30 14:57:31 2019 +0200 tdf#127093, tdf#127092 Fix pasting autoincremented was reverted in commit d783017c1ccb4e62e99f26b42250ac4e15780cff. But the follow-on commit commit 376cc3ea0fc2e0f209763a2a27c5852136332c86 Author: Tamas Bunth <tamas.bunth@collabora.co.uk> Date: Sat Aug 31 18:27:44 2019 +0200 dbaccess: delete old paste autoincrement logic was not reverted. This is not a straight revert of the second commit, because autoincrement has since been improved with commit 2a8e120db1c3175ff937cdbe6d0ade23dc380c01 Author: Oleksii Makhotin <alex@bitprox.com> Date: Tue Apr 6 16:03:41 2021 +0300 tdf#119962 Fix autoincrement for copied table Change-Id: Ia9657d88b3e77ba72399ad9afeece3bda3f57038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141967 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0325be6f3de622be6af9b2f686e3c7afae0405b1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141918 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-28related tdf#149961 pptx export: scale indents for autofitted textboxesSarper Akdemir4-5/+45
For autofitted textboxes, Impress scales the indents with the text size while PowerPoint doesn't. Try to compensate for this by scaling exported indents proportionally to the font scale on autofitted textboxes. Change-Id: Ib0f967e923d23553b4cdbd1bbe2e137d97b1b2e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141758 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141940 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-10-28try to fix some shutdown crashesNoel Grandin1-1/+5
seen in 7.4 crash reports Change-Id: I4c88d485e2e1925895f23861232823ebe97c0c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141936 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b4b63d0c46979ad6b6aae5d6a4ea6672ea248e10) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141915
2022-10-28tdf#149961 pptx import: fix indents for autofitted texboxesSarper Akdemir7-6/+58
For autofitted textboxes, Impress scales the indents with the text size while PowerPoint doesn't. Scale the indents inversely propotional to autofit font scale so that the visual appearance on import is similar to PowerPoint. Change-Id: I7876b35a1f4221789564fcf23ccbe3fe21db3d48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141717 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141939 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-10-27tdf#151608: Fix crash in disposing remotecontrol listenerdldld1-1/+0
Clearing the listener twice seems to be the problem here, because the WeakComponentImplHelperBase::dispose() tries to access the cleared listener when it was already cleared, causing the crash. The problem which is fixed by this commit appears when the Impress Remote App is closed, which is connected to a running presentation. So closing the app "kills" the presentation. I think I have seen this also happening, when the connection was closed due to bad wifi. Which also makes sense as the communication thread is getting stopped and the listener will be destroyed. Change-Id: I3c8fa535cfd4d82c846494f76ffb9ce43ebd606a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141468 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit e5aa82b259e35e3976734af38fff643ea28767df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141851 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-10-27update creditsChristian Lohmaier1-1722/+1862
Change-Id: I4862f568d9025e321a14291aae5617ab2a474862 (cherry picked from commit d5f25f2f78d3852967a6919e215308d129880cf1)
2022-10-27curl: upgrade to release 7.86.0Michael Stahl3-4/+9
Fixes CVE-2022-32221 which could affect libcmis, CVE-2022-42915, and 2 more CVEs that probably don't affect LO. * remove --without-ssl: On the one hand, on GNU/Linux this now results in: configure: error: --without-ssl has been set together with an explicit option to use an ssl library On the other hand, using the more obvious --without-openssl yields a link failure on Android on the nss check in configure: configure:28220: checking for SSL_VersionRangeSet in -lnss /home/cl/Android/Sdk/ndk/20.1.5948944/toolchains/llvm/prebuilt/linux-x86_64/bin/../lib/gcc/aarch64-linux-android/4.9.x/../../../../aarch64-linux-android/bin/ld: warning: liblog.so, needed by /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnss3.so, not found (try using -rpath or -rpath-link) /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnspr4.so: undefined reference to `__android_log_write' /home/cl/rpmbuild/BUILD/lo-android2/workdir/UnpackedTarball/nss/dist/out/lib/libnspr4.so: undefined reference to `__android_log_assert' ... so add the -llog for android in curl-nss.patch.1 Change-Id: I3931a1eec2d681c2ce0e5695039492772e9fcc81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141866 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit a76a88203d8508f38b10d9bbb94c3bba2485fcaf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141846 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-27ucb: FTP UCP: report CURLE_URL_MALFORMAT as IllegalIdentifierExceptionMichael Stahl1-0/+15
With curl 7.86, the test JunitTest_ucb_complex starts to fail: .ftp://noname:nopasswd@*nohost.invalid now executing open com.sun.star.ucb.InteractiveAugmentedIOException: at com.sun.proxy.$Proxy15.execute(Unknown Source) at complex.ucb.UCB.executeCommand(UCB.java:63) at complex.ucb.UCB.checkWrongFtpConnection(UCB.java:119) because curl_easy_perform() now returns CURLE_URL_MALFORMAT where previously it was CURLE_COULDNT_RESOLVE_HOST. Map this to an exception the test expects. Change-Id: Ifdb672946726ddb4cb4d9426b7e70eefac63f040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141877 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 022e476af44c0dfc97403dc0f3a3b63e731903e6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141844 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-27crashreporting: crash in thesaurus dialog PostUserEventCaolán McNamara2-3/+14
not reproducible, but a common error to post an event that outlives the owner Change-Id: Ic2633c504d853116d03e3322f552ae66e7e7e14e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141840 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-10-26crashreporting: crash in area tab page with insert, envelopeCaolán McNamara1-0/+10
insert, envelope, format, addressee: format: edit: paragraph, area, click on gradient, bitmap, etc. Change-Id: I121674776662b31dc4e3cf96fbeb2c1d234ae00e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141839 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-10-26sw html import: fix handling of CDATAMiklos Vajna6-0/+70
In case the HTML contained markup like <![CDATA[...]]>, we simply ignored it during import, even if e.g. the ODT import handles that correctly. The reason for this is that the svtools/ HTMLParser had code to parse <!-- ... ---> style comments, but not for CDATA. Fix the problem by introducing a new HtmlTokenId::CDATA, producing a matching token content in HTMLParser::GetNextToken_(), and finally map it to normal text on the Writer side. Note that HtmlTokenId doesn't allow non-on-off tokens past ONOFF_START, neither allows inserting a single token before ONOFF_START (it breaks getOnToken()), so for now just add a second, dummy token to avoid breakage. Change-Id: I605c3c21dc11986fda5d93d36148788a638e97b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141813 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit b38730ae0ae92ca49b84a45853c2ed098ee9064f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141838 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-22 00:23:57 +0000