summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-11-23lok: Chart context menu: Disable menu items which are not available.feature/spellig_popup_SIDTamás Zolnai3-1/+17
Change-Id: Id7487c581759389e66ca513381d6706f3ae49980
2019-11-23lok: Chart context menu: Replace tunneled context menu with JS context menu.Tamás Zolnai2-19/+31
Change-Id: I36db90887bff86036093ce0732db6fc6c76e79f6
2019-11-23SpellingPopup: Create separate SID for Ignore / IgnoreAll / suggestion.Tamás Zolnai6-127/+193
Change-Id: I20f41f511ea38f960f081f92bc36e095f7752d28
2019-11-23SpellingPopup: lok: Replace the tunneled context menu.Tamás Zolnai4-12/+121
Send the menu structure instead using LOK_CALLBACK_CONTEXT_MENU. We need to set commands for menu items to make fillPopupMenu() method work. We also need to check whether there is any selection during execution of menu items. In case of LO core execution the suspicious text is selected, however in case of LO online, there is no selection. Change-Id: Id696ee9976d11f6b57e23a3bcc5b483a1d486639
2019-11-23Dispatch: Make fillPopupMenu() method accessible from other modules.Tamás Zolnai2-97/+96
No functional change. Change-Id: Ifaa6ff038277ef5702ac38d90c7461d664b0aee4
2019-11-23SpellingPopup: lok: Hide unusable items for onlineTamás Zolnai1-0/+7
MN_EXPLANATION_LINK is some link, but it's exectued internally, which means the the link would be executed on the serves side and not on the client's browser. m_nCorrectMenuId is a sub menu which allows to specify new autocorrect rules. Since m_nAddId is also disabled, I expect that extending the dictionaries / autocorrect rule might be a problem for online. Change-Id: Id6e8ed078f90a4f25a335a3ab5ec0e3056db648d
2019-11-23SpellingPopup: Convert suggestion menu items to use slot ID.Tamás Zolnai2-20/+106
Change-Id: Icf1f50d04ab5e7ba467d68613f4101a3fe48589b
2019-11-23SpellingPopup: Remove m_aSuggestions member variableTamás Zolnai2-15/+20
We don't need it after the construction. The text is stored by the menu item. Change-Id: I54b0392b4564e76d405824bb297e6f993a24a5fb
2019-11-23SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (spelling).Tamás Zolnai3-17/+22
When the popup is in spelling mode. "IgnoreAll_Spelling" rule triggers this method. Change-Id: Ia1e1877f8501beff29f09bc33621c8f03008b7e8
2019-11-23SpellingPopup: Convert "IgnoreAll" menu item to use a slot ID (grammar).Tamás Zolnai3-21/+43
When the popup is in grammar mode. "IgnoreAll_Grammar" rule triggers this method. When openning the spelling popup we have the suspicious text selected, so we don't need the mouse position to apply the changes. I updated GetGrammarCorrection() method accordingly. Change-Id: Iaf86544ea5f7dbc4afa2889772a5a38c5fd5707e
2019-11-23SpellingPopup: Convert "Ignore" menu item to use a slot ID.Tamás Zolnai6-3/+54
Introduced a new slot id SID_APPLY_SPELLING, which can be used to apply any spelling / grammar related changes (e.g. ignore, ignore all, replace with suggestion, add to dictionary). In this commit, only the simple ignore is implemented. Change-Id: I06ab84efeb955cc02ce3ff531bd8b5c20ddced9e
2019-11-23SpellingPopup: Move setting UPN_IS_GRAMMAR_INTERACTIVE to the constructor.Tamás Zolnai1-4/+2
Change-Id: Ief5470e0a61f0ca40549ab6d3768c795c3f04510
2019-11-23SpellingPopup: lok: Also hide the add menuTamás Zolnai1-0/+1
Change-Id: Ic6b10d579fe1fb0afe5e80244e84ed456dc6cc87
2019-11-23SpellingPopup: Remove unused variablesTamás Zolnai1-2/+0
Change-Id: I3cb3b128ec54f82381bf6f0c17401a5d5fb58a96
2019-11-23SpellingPopup: Convert selection language items to use slot idTamás Zolnai1-15/+6
Change-Id: I10a89d7efa957e6b94e793158983c5acf623e511
2019-11-23SpellingPopup: Convert paragraph language items to use slot idTamás Zolnai1-16/+6
Change-Id: I36df4777b408f9defd883d49413847152f6b496f
2019-11-23SpellingPopup: Convert char dialog related items to use slot idTamás Zolnai3-11/+5
After this change we can make sw_CharDialog() a local function. Change-Id: I34b15fccaed07b5d89f63a69da8c870fff0e9b14
2019-11-23cppcheck: performing initialization in initialization list (sfx2/doctempl)Julien Nabet1-2/+1
Change-Id: I91f077fc6c3e74ea1c0470a562e3d762ab3b1439 Reviewed-on: https://gerrit.libreoffice.org/83550 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-23uitest for bug tdf#91217Zdeněk Crhonek2-0/+43
Change-Id: I0322a3bc821850d5f15aeb690ba80ff7b8129140 Reviewed-on: https://gerrit.libreoffice.org/83546 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-23OfaTreeOptionsDialog::LoadModule: Use range-based forMichael Weghorn1-10/+9
Change-Id: I2b191dd55dcd9e085b2cde6bacd1e2e3c963fafa Reviewed-on: https://gerrit.libreoffice.org/83489 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23tdf#97926: Update @since tagsXisco Fauli2-2/+2
Since it was backported to libreoffice-6-4 Change-Id: I832c252678b132c743f868688abbe702eb1293b2 Reviewed-on: https://gerrit.libreoffice.org/83512 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2019-11-23treeopt.cxx: Simplify 'ModuleMap' handlingMichael Weghorn1-28/+13
Use 'OUString' instead of 'const char*' for 'ModuleToGroupNameMap_Impl.m_pModule', and simplify the iteration using range-based for. Change-Id: I1756bc6ac8b163a68b79d6900738362db010d8a9 Reviewed-on: https://gerrit.libreoffice.org/83488 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23Use const OUString instead of const char[]Michael Weghorn1-1/+1
'SvtViewOptions::GetUserItem' and 'SvtViewOptions::SetUserItem' take a 'const OUString&' param anyway. Change-Id: Icdc4c578516c9fe1307b64eecdf3270142b4e823 Reviewed-on: https://gerrit.libreoffice.org/83487 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-23Update git submodulesOlivier Hallot1-0/+0
* Update helpcontent2 from branch 'master' - Fix div position for Online Help The condition was masking the div. Now the condition mask the contents Change-Id: I270e20f3ae17a16d4425698f24e674763320fade Reviewed-on: https://gerrit.libreoffice.org/83540 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-23Update git submodulesIlmari Lauhakangas1-0/+0
* Update helpcontent2 from branch 'master' - Improve the help for old Fontwork The old Fontwork functionality continues to be very useful. Some see it as even more useful than the new Fontwork. I changed the text to make it more understandable what it is all about. Change-Id: I05f073a7cdb23d5aa1470fd7a19386f444010d7e Reviewed-on: https://gerrit.libreoffice.org/81961 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-22GCC trunk towards GCC 9 still emits a bogus -Wstringop-truncationJulien Nabet1-0/+7
Change-Id: I14ff82099107302f5e99f22735c37901f68934e9 Reviewed-on: https://gerrit.libreoffice.org/83537 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22Fix typoAndrea Gelmini1-5/+5
Change-Id: Ibf2e90ff53f201d7b1f279c11eb8238eb403c05e Reviewed-on: https://gerrit.libreoffice.org/83533 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-22wrong delete signal idCaolán McNamara1-1/+1
Change-Id: I4aecd3c8f5d40c3256d2d2816a79f8809db6cedb Reviewed-on: https://gerrit.libreoffice.org/83518 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22tdf#128952 Set the position of shape for 180 deg.Gülşah Köse3-1/+18
If the rotation value is 180, 540, 900... degree with mirror pShape->GetRotateAngle() returns 0. In that control 0 means no rotation but that is not true. For that cases (180, 540, 900) after the angle conversition GetRotateAngle() returns 0. We should recalculate the position for 0 too. Change-Id: I14e981235b2d6cd8382d4c9e151bccd2e73a3fd9 Reviewed-on: https://gerrit.libreoffice.org/83468 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-11-22tdf#121740 cache font data to speed up PPT loadNoel Grandin3-5/+50
takes the load time from 24s to 21s for me. The cache was determined experimentally for this document. Change-Id: I34c78d1ff99cb8e72b274a201ded61d23e66941a Reviewed-on: https://gerrit.libreoffice.org/83470 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22make some classes module-privateNoel Grandin64-123/+121
Change-Id: If7303a082e06f6937fca911c578a40475546cda2 Reviewed-on: https://gerrit.libreoffice.org/83442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-22uitest for bug tdf#126168Zdeněk Crhonek1-0/+52
Change-Id: I35b7235b7f53789d781a567efe15f13be16f7193 Reviewed-on: https://gerrit.libreoffice.org/83530 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-22Adapt solenv/flatpak-manifest.in to 28e52c49452320ac76489d0f93ca5692456e5331Stephan Bergmann1-3/+3
..."poppler: upgrade to release 0.82.0" Change-Id: Ic333e22856e8ace114776b93b339e7c4e8de01ff Reviewed-on: https://gerrit.libreoffice.org/83521 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-22vcl: add brief doc on SolarMutexGuardMiklos Vajna1-0/+39
Muhammet points out this is not really written down anywhere. Change-Id: Ied122d9e252e3eff7b088abe95a563dff89e8fff Reviewed-on: https://gerrit.libreoffice.org/83490 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-22cui: add UI for semi-transparent shape textMiklos Vajna6-1/+124
- Make font color only work with the RGB color, otherwise the preview would be white for e.g. half-transparent red. - Add label and widget to see already set transparency. - Add a flag to show these only for Draw/Impress and leave Writer/Calc unchanged. - Update returned item set to contain transparency in case the widget changes. Change-Id: If77771076ff4b10a4a5d468a6583809a94deb57e Reviewed-on: https://gerrit.libreoffice.org/83520 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-22use prime symbol for footCaolán McNamara3-3/+23
Change-Id: Ieb1743b89a3c069d7b24cab0869294522ae2a6d7 Reviewed-on: https://gerrit.libreoffice.org/83503 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22Resolves: tdf#128948 double prime symbol not parsed as inch indicatorCaolán McNamara2-1/+3
Change-Id: I9d3e606b5158b4594f94e0f13bdf2f635bc77357 Reviewed-on: https://gerrit.libreoffice.org/83447 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22tdf#128951: restore passing nullptr to ScTableSheetObj when not inserted yetMike Kaganski3-2/+38
This partially reverts 009e7a54f40ebacd9dd4a394504c277789699801 Change-Id: I5a9605ff9d0ff1cd825968fb247b2a3bf4b2902a Reviewed-on: https://gerrit.libreoffice.org/83464 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-22tdf#128892 Give menu "Rename Sheet" an alternative mnemonic HTakeshi Abe1-1/+1
... to avoid the duplicate R for "Insert Rows". Change-Id: Ie2e0faf566ba5f85e4b2a72c289a4320e580f7f9 Reviewed-on: https://gerrit.libreoffice.org/83368 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-11-22crashtesting: failure on import of tdf10306-1.docxCaolán McNamara1-2/+1
downgrade to warning instead of assert as per https://lists.freedesktop.org/archives/libreoffice/2019-November/083836.html Change-Id: If561930ca9733899cf0f4e3a6d8bb6609c94fc1d Reviewed-on: https://gerrit.libreoffice.org/83485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22cid#1448239 unsafe_xml_parse_configCaolán McNamara1-3/+0
This branch is only in use for the build-tool mode, so doesn't affect extension help. I can find no difference in our output help dir with these removed vs in place so lets remove it. Change-Id: If8511b6cb74f1af136a71ab39a7a5759d50c43eb Reviewed-on: https://gerrit.libreoffice.org/83480 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22cid#1448239 unsafe_xml_parse_configCaolán McNamara1-0/+1
Change-Id: I85e471943338baca756707e8e40f46ff69d96a36 Reviewed-on: https://gerrit.libreoffice.org/83479 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22document HelpCompiler::getSourceDocument behaviourCaolán McNamara1-4/+6
Change-Id: I03348fc3bce4c879644c6b8d12444c8ec58c0c5e Reviewed-on: https://gerrit.libreoffice.org/83469 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22mark with overrideCaolán McNamara1-1/+1
Change-Id: Ia7e8093106136b54ea3908ebc355e01ade37ad36 Reviewed-on: https://gerrit.libreoffice.org/83482 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22tdf#128499 DOC export: fix lost ToC formatting regressionLászló Németh1-1/+2
caused by commit 7376a47680b65cbdfd747a736f288e06f51f7f2d (tdf#92335 DOCX: fix multiplying of "ListLabel" styles). Change-Id: I7d6fc2be3ad7556b988cb00936b9b49deae23f19 Reviewed-on: https://gerrit.libreoffice.org/83443 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-22Warn user when output format does not support used encryptionSerge Krot1-0/+34
Change-Id: Id5614cb7647b465c3edb2485fcd4f621cfee42b2 Reviewed-on: https://gerrit.libreoffice.org/82816 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> Reviewed-on: https://gerrit.libreoffice.org/82817 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-11-22Resolves: rhbz#1775544 crash in navigatorCaolán McNamara1-6/+2
see demo reproducer in rhbz#1775544 nChildCount is a count of all descendants not just direct children. Just looping while FirstChild returns something is sufficient. Change-Id: If7b16032731d694bfffaae22faad5fe194d1822f Reviewed-on: https://gerrit.libreoffice.org/83454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22fs::getThreadTextEncoding->osl_getThreadTextEncodingCaolán McNamara3-23/+16
Change-Id: I803f21dba239073cf07dc853f400adeac3256856 Reviewed-on: https://gerrit.libreoffice.org/83467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22drop impl_sleep hackCaolán McNamara1-21/+3
doesn't seem to make any sense, maybe it did in some dmake-era dependency problem when building our help content ? Change-Id: Id964ad73249ef33ba0102fb7d2d853b2719e3814 Reviewed-on: https://gerrit.libreoffice.org/83466 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-22Add command .uno:EditChartMuhammet Kara1-0/+11
This is an alias uno command which let's users switch to edit mode for the selected object. It is equivalent to the Edit > Object > Edit menu item, which is a parameterized variation of the .uno:ObjectMenue command, and is created dynamically each time user opens the Edit menu. Change-Id: I131fab1758d2689cecfa3adc79b7868abf67b5e0 Reviewed-on: https://gerrit.libreoffice.org/83463 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>