diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2017-12-14 08:45:02 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2017-12-14 13:03:06 +0100 |
| commit | 6f4f5677acff2711b4cfdae6ba1a0892e62b179a (patch) | |
| tree | ba97fc99b67b9b139bdf6807ceedcb168fa68fd2 /xmlhelp | |
| parent | 581640ac53f8568157ffc3b5c82b2ae7da576e3b (diff) | |
No need to keep these whitelisted functions decorated with SAL_CALL
The only effect SAL_CALL effectively has on LO-internal code is to change non-
static member functions from __thiscall to __cdecl in MSVC (where all other
functions are __cdecl by default, anyway). (For 3rd-party code, it could be
argued that SAL_CALL is useful on function declarations in the URE stable
interface other than non-static member functions, too, in case 3rd-party code
uses a compiler switch to change the default calling convention to something
other than __cdecl. But loplugin:salcall exempts the URE stable interface,
anyway.)
One could argue that SAL_CALL, even if today it effectively only affects non-
static member functions in MSVC, could be extended in the future to affect more
functions on more platforms. However, the current code would already not
support that. For example, 3af500580b1c82eabd60335c9ebc458a3f68850c
"loplugin:salcall fix functions" changed FrameControl_createInstance in
UnoControls/source/base/registercontrols.cxx to no longer be SAL_CALL, even
though its address (in ctl_component_getFacrory, in the same file) is passed to
cppuhelper::createSingleFactory as an argument of type
cppu::ComponentInstantiation, which is a pointer to SAL_CALL function.
Change-Id: I3acbf7314a3d7868ed70e35bb5c47bc11a0b7ff6
Reviewed-on: https://gerrit.libreoffice.org/46436
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'xmlhelp')
| -rw-r--r-- | xmlhelp/source/cxxhelp/inc/tvfactory.hxx | 4 | ||||
| -rw-r--r-- | xmlhelp/source/treeview/tvfactory.cxx | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/xmlhelp/source/cxxhelp/inc/tvfactory.hxx b/xmlhelp/source/cxxhelp/inc/tvfactory.hxx index 86dc3a8cf6b6..0f34599542a4 100644 --- a/xmlhelp/source/cxxhelp/inc/tvfactory.hxx +++ b/xmlhelp/source/cxxhelp/inc/tvfactory.hxx @@ -69,9 +69,9 @@ class TVFactory: public cppu::WeakImplHelper < // Other - static OUString SAL_CALL getImplementationName_static(); + static OUString getImplementationName_static(); - static css::uno::Sequence< OUString > SAL_CALL getSupportedServiceNames_static(); + static css::uno::Sequence< OUString > getSupportedServiceNames_static(); static css::uno::Reference< css::lang::XSingleServiceFactory > createServiceFactory( diff --git a/xmlhelp/source/treeview/tvfactory.cxx b/xmlhelp/source/treeview/tvfactory.cxx index 6bb587703cfd..9edb304cd791 100644 --- a/xmlhelp/source/treeview/tvfactory.cxx +++ b/xmlhelp/source/treeview/tvfactory.cxx @@ -123,13 +123,13 @@ TVFactory::getAvailableServiceNames( ) // static -OUString SAL_CALL +OUString TVFactory::getImplementationName_static() { return OUString( "com.sun.star.help.TreeViewImpl" ); } -Sequence< OUString > SAL_CALL +Sequence< OUString > TVFactory::getSupportedServiceNames_static() { Sequence< OUString > seq( 2 ); |