summaryrefslogtreecommitdiff
path: root/xmerge
diff options
context:
space:
mode:
authorNoel Grandin <noel@peralex.com>2014-12-10 15:36:24 +0200
committerNoel Grandin <noelgrandin@gmail.com>2014-12-11 06:09:03 +0000
commit7557f23b31dcfb4d86c122bb34d9675c0db9a694 (patch)
tree5feb7be2b0841d8ee60d935cf2e29e9a01a31a27 /xmerge
parent808fd5fbd8868dfd95c8a38676815798fa2b79c4 (diff)
java: reduce visibility of fields and methods
found by PMD Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6 Reviewed-on: https://gerrit.libreoffice.org/13409 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'xmerge')
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/OfficeDocument.java2
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/ColumnStyle.java2
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/Format.java8
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/NameDefinition.java10
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/RowStyle.java2
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SheetSettings.java2
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/xslt/PluginFactoryImpl.java2
-rw-r--r--xmerge/source/xmerge/java/org/openoffice/xmerge/util/TwipsConverter.java4
8 files changed, 16 insertions, 16 deletions
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/OfficeDocument.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/OfficeDocument.java
index 6d0135aaf468..839b43100938 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/OfficeDocument.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/OfficeDocument.java
@@ -266,7 +266,7 @@ public abstract class OfficeDocument
*
* @return An {@code Iterator} of {@code EmbeddedObject} objects.
*/
- public Iterator<EmbeddedObject> getEmbeddedObjects() {
+ private Iterator<EmbeddedObject> getEmbeddedObjects() {
if (embeddedObjects == null && manifestDoc != null) {
embeddedObjects = new HashMap<String, EmbeddedObject>();
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/ColumnStyle.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/ColumnStyle.java
index 3b880083f7d5..c9ff20591314 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/ColumnStyle.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/ColumnStyle.java
@@ -112,7 +112,7 @@ public class ColumnStyle extends Style implements Cloneable {
*
* @param colWidth The width of this column.
*/
- public void setColWidth(int colWidth) {
+ private void setColWidth(int colWidth) {
this.colWidth = colWidth;
}
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/Format.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/Format.java
index 84514bedd2d1..68a62b620fd5 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/Format.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/Format.java
@@ -188,7 +188,7 @@ public class Format implements Cloneable {
*
* @return The formatting category of the object.
*/
- public String getCategory() {
+ private String getCategory() {
return category;
}
@@ -197,7 +197,7 @@ public class Format implements Cloneable {
*
* @return The value of the formula.
*/
- public String getValue() {
+ private String getValue() {
return value;
}
@@ -225,7 +225,7 @@ public class Format implements Cloneable {
*
* @return {@code Format} specifier for this category.
*/
- public String getFormatSpecifier() {
+ private String getFormatSpecifier() {
return formatSpecifier;
}
@@ -243,7 +243,7 @@ public class Format implements Cloneable {
*
* @return Number of decimal places.
*/
- public int getDecimalPlaces() {
+ private int getDecimalPlaces() {
return decimalPlaces;
}
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/NameDefinition.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/NameDefinition.java
index 051236d4fe4d..b243794b3c5e 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/NameDefinition.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/NameDefinition.java
@@ -78,7 +78,7 @@ public class NameDefinition implements OfficeConstants {
*
* @return the name which identifies the definition.
*/
- public String getName() {
+ private String getName() {
return name;
}
@@ -96,7 +96,7 @@ public class NameDefinition implements OfficeConstants {
*
* @return the definition.
*/
- public String getDefinition() {
+ private String getDefinition() {
return definition;
}
@@ -105,7 +105,7 @@ public class NameDefinition implements OfficeConstants {
*
* @return the base cell address.
*/
- public String getBaseCellAddress() {
+ private String getBaseCellAddress() {
return baseCellAddress;
}
@@ -114,7 +114,7 @@ public class NameDefinition implements OfficeConstants {
*
* @return whether or not this name definition is of type expression.
*/
- public boolean isExpressionType() {
+ private boolean isExpressionType() {
return expressionType;
}
@@ -123,7 +123,7 @@ public class NameDefinition implements OfficeConstants {
*
* @return whether or not this name definition is of type range.
*/
- public boolean isRangeType() {
+ private boolean isRangeType() {
return rangeType;
}
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/RowStyle.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/RowStyle.java
index 97bf0c9a0884..5b0446a61ac7 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/RowStyle.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/RowStyle.java
@@ -113,7 +113,7 @@ public class RowStyle extends Style implements Cloneable {
*
* @param RowHeight The height of this row.
*/
- public void setRowHeight(int RowHeight) {
+ private void setRowHeight(int RowHeight) {
this.rowHeight = RowHeight;
}
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SheetSettings.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SheetSettings.java
index d3ce082bc925..8f6603a458ac 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SheetSettings.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/sxc/SheetSettings.java
@@ -205,7 +205,7 @@ public class SheetSettings implements OfficeConstants {
*
* @return the name of the worksheet.
*/
- public String getSheetName() {
+ private String getSheetName() {
return sheetName;
}
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/xslt/PluginFactoryImpl.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/xslt/PluginFactoryImpl.java
index cae4e7667f53..0352ee714a6a 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/xslt/PluginFactoryImpl.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/converter/xml/xslt/PluginFactoryImpl.java
@@ -126,7 +126,7 @@ public final class PluginFactoryImpl extends PluginFactory
*
* @return The file extension of a {@code Document}.
*/
- public String getDeviceFileExtension() {
+ private String getDeviceFileExtension() {
Class<? extends PluginFactoryImpl> c = this.getClass();
InputStream is = c.getResourceAsStream("XsltPlugin.properties");
Properties props = new Properties();
diff --git a/xmerge/source/xmerge/java/org/openoffice/xmerge/util/TwipsConverter.java b/xmerge/source/xmerge/java/org/openoffice/xmerge/util/TwipsConverter.java
index 8ab83be1c4ae..a8501f8b9fa9 100644
--- a/xmerge/source/xmerge/java/org/openoffice/xmerge/util/TwipsConverter.java
+++ b/xmerge/source/xmerge/java/org/openoffice/xmerge/util/TwipsConverter.java
@@ -43,7 +43,7 @@ public class TwipsConverter {
*
* @return {@code int} containing the converted value.
*/
- public static int cm2twips(float value) {
+ private static int cm2twips(float value) {
int twips = (int) ((value/2.54)*1440);
return twips;
}
@@ -55,7 +55,7 @@ public class TwipsConverter {
*
* @return {@code int} containing the converted value.
*/
- public static int inches2twips(float value) {
+ private static int inches2twips(float value) {
return (int) (value*1440);
}