diff options
author | Stephan Bergmann <sbergman@redhat.com> | 2022-01-15 13:50:26 +0100 |
---|---|---|
committer | Stephan Bergmann <sbergman@redhat.com> | 2022-01-15 15:58:07 +0100 |
commit | 29bc12777ceffd00ed0ae103b8f2affa26897b4e (patch) | |
tree | 137886309baa148e3e84646f89600c00dd37d0fe /stoc | |
parent | fe37aa64ff79abcd3aeedeb03d8d74798225a367 (diff) |
Let loplugin:nullptr look into template instantiations
It missed some occurrences of 0 when only looking into uninstantiated template
code, as Clang doesn't model them with an ImplicitCastExpr, even if the target
is known to be a (dependent) pointer type.
Looking into all template instantiations of course carries the risk that a given
use of 0 is meant to be interpreted as a pointer in some and as an integer in
other instantiations. But the only case where that happened in the current code
base is RegistryValueList::getElement (include/registry/registry.hxx), where {}
is arguably a better choice anyway. (And which would presumably also hold for
any future such cases.)
Change-Id: I708bcfc8bedc0a49c9282d7814eb325afa29905c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128462
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'stoc')
-rw-r--r-- | stoc/source/security/lru_cache.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/stoc/source/security/lru_cache.h b/stoc/source/security/lru_cache.h index bbde657de4dc..402b41d58745 100644 --- a/stoc/source/security/lru_cache.h +++ b/stoc/source/security/lru_cache.h @@ -156,7 +156,7 @@ inline t_val const * lru_cache< t_key, t_val, t_hashKey, t_equalKey >::lookup( return &entry->m_val; } } - return 0; + return nullptr; } template< typename t_key, typename t_val, typename t_hashKey, typename t_equalKey > |