diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2022-06-14 08:43:54 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2022-06-14 11:37:16 +0200 |
| commit | 8b6c8e624b1257a2221e8f98ba71112eae86c795 (patch) | |
| tree | 49b62809a3dc68307cc4ee16dfe497754bf93158 /sot | |
| parent | 6de844c5da695bf4605bef5510d33e74a7ff04ee (diff) | |
cid#1504592 Big parameter passed by value
and
cid#1504665 Big parameter passed by value
cid#1505368 Big parameter passed by value
revert the clang-tidy modernize-pass-by-value changes that coverity
warns about
Change-Id: Id92fdc8d1caeed9eaf7ff1e9e745938e5a971a34
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135803
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sot')
| -rw-r--r-- | sot/source/sdstor/stgdir.cxx | 3 | ||||
| -rw-r--r-- | sot/source/sdstor/stgdir.hxx | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/sot/source/sdstor/stgdir.cxx b/sot/source/sdstor/stgdir.cxx index ee70d390542e..69ca094f370f 100644 --- a/sot/source/sdstor/stgdir.cxx +++ b/sot/source/sdstor/stgdir.cxx @@ -28,7 +28,6 @@ #include <sal/log.hxx> #include <memory> -#include <utility> //////////////////////////// class StgDirEntry @@ -53,7 +52,7 @@ StgDirEntry::StgDirEntry( const void* pBuffer, sal_uInt32 nBufferLen, sal_uInt64 InitMembers(); } -StgDirEntry::StgDirEntry( StgEntry r ) : m_aEntry(std::move( r )) +StgDirEntry::StgDirEntry( const StgEntry& r ) : m_aEntry( r ) { InitMembers(); } diff --git a/sot/source/sdstor/stgdir.hxx b/sot/source/sdstor/stgdir.hxx index 5044dc48f313..3605c27ac03d 100644 --- a/sot/source/sdstor/stgdir.hxx +++ b/sot/source/sdstor/stgdir.hxx @@ -59,7 +59,7 @@ public: bool m_bInvalid; // true: invalid entry StgDirEntry(const void* pBuffer, sal_uInt32 nBufferLen, sal_uInt64 nUnderlyingStreamSize, bool * pbOk); - explicit StgDirEntry( StgEntry ); + explicit StgDirEntry( const StgEntry& ); virtual ~StgDirEntry() override; void Invalidate( bool ); // invalidate all open entries |