diff options
| author | Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> | 2019-12-11 13:23:43 +0100 |
|---|---|---|
| committer | Stephan Bergmann <sbergman@redhat.com> | 2020-02-04 22:03:54 +0100 |
| commit | ae855bf48163ff64d94cfc34aff8e37abdb5518d (patch) | |
| tree | cdfc726f47cc69c265288936157295c94d9ec949 /smoketest | |
| parent | 494092dc0c2f6fd04dbd973d6f76f1df720dbcf7 (diff) | |
tdf#117331 Merge jurt and unoil into ridl
jurt.jar and unoil.jar are kept as effectively empty jars, each with a
Class-Path: ridl.jar
in their meta-inf/manifest.mf, so that 3rd-party code loading them (with or
without also loading ridl.jar) will still have access to their content.
Conceptually, the UNOIDL entities in unoil.jar (corresponding to module offapi)
are not part of the URE, but are now made available by URE's ridl.jar. This
should probably not cause problems in practice.
At least for now, we seal exactly those packages in ridl.jar that were
originally sealed in jurt.jar. Ideally, all of ridl.jar could be sealed now,
but that would be mildly incompatible, as it would prevent 3rd-party code from
introducing additional UNOIDL entities in the relevant namespaces (even if that
is something we do not want 3rd-party code to do anyway).
However, some JunitTest_jurt_* define classes in those sealed packages. In the
past they got away with that by using gb_JunitTest_use_jar_classset,*,jurt.
Instead they now need to gb_JunitTest_use_jar_classset,*,ridl and drop the
gb_JunitTest_use_jar,*,ridl. But the former only makes available the classes
that are specified in ridljar/Jar_ridl.mk with gb_Jar_add_sourcefiles, not the
UNOIDL entities specified via gb_Jar_add_packagedirs. But the tests need the
udkapi UNOIDL entities, so introduce gb_JunitTest_add_classpath to let the tests
get them explicitly. (Curiously, JunitTest_jurt_uno and JnitTest_jurt_util use
gb_JunitTest_use_jar_classset,*,jurt but don't seem to acutally need it; lets
leave that for a follow-up clean up.)
As a follow-up clean up, relevant files could be moved from jurt/ to ridljar/.
Change-Id: I836f4e7bb47fb41f1306e3f223da90dba988eb9a
Co-authored-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/84946
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Diffstat (limited to 'smoketest')
| -rw-r--r-- | smoketest/Jar_TestExtension.mk | 4 | ||||
| -rw-r--r-- | smoketest/Jar_smoketest.mk | 1 |
2 files changed, 0 insertions, 5 deletions
diff --git a/smoketest/Jar_TestExtension.mk b/smoketest/Jar_TestExtension.mk index 00b9ab5a5bd0..22a3a5cdb5fd 100644 --- a/smoketest/Jar_TestExtension.mk +++ b/smoketest/Jar_TestExtension.mk @@ -14,16 +14,12 @@ $(eval $(call gb_Jar_set_manifest,TestExtension,$(SRCDIR)/smoketest/com/sun/star $(eval $(call gb_Jar_add_manifest_classpath,TestExtension,\ juh.jar \ - jurt.jar \ ridl.jar \ - unoil.jar \ )) $(eval $(call gb_Jar_use_jars,TestExtension,\ juh \ - jurt \ ridl \ - unoil \ )) $(eval $(call gb_Jar_set_packageroot,TestExtension,com)) diff --git a/smoketest/Jar_smoketest.mk b/smoketest/Jar_smoketest.mk index 2f0bca193901..86210c8eba70 100644 --- a/smoketest/Jar_smoketest.mk +++ b/smoketest/Jar_smoketest.mk @@ -23,7 +23,6 @@ $(eval $(call gb_Jar_set_packageroot,smoketest,org)) $(eval $(call gb_Jar_use_jars,smoketest, \ juh \ ridl \ - unoil \ )) # vim: set noet sw=4 ts=4: |