shell: MSVC: pragma warning: make more specific, remove obsolete

Change-Id: Ie2391b1feed31fe9cee7dc097c57ebebab698705
Reviewed-on: https://gerrit.libreoffice.org/49049
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

30 files changed, 6 insertions, 183 deletions

diff --git a/shell/inc/columninfo.hxx b/shell/inc/columninfo.hxx
index 4950ad969b71..105ba7566de5 100644
--- a/shell/inc/columninfo.hxx
+++ b/shell/inc/columninfo.hxx
@@ -20,14 +20,7 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_COLUMNINFO_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_COLUMNINFO_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#pragma warning(disable:4917)
-#endif
 #include <shlobj.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 
 class CColumnInfo : public IColumnProvider
diff --git a/shell/inc/config.hxx b/shell/inc/config.hxx
index a888745ba5cd..58b5dd4bfc3c 100644
--- a/shell/inc/config.hxx
+++ b/shell/inc/config.hxx
@@ -20,10 +20,6 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_CONFIG_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_CONFIG_HXX
 
-#ifdef _MSC_VER
-#pragma warning (disable : 4786 4503 4917)
-#endif
-
 #ifdef _AMD64_
 #define MODULE_NAME L"shlxthdl_x64.dll"
 #else
diff --git a/shell/inc/global.hxx b/shell/inc/global.hxx
index 24dd2e0d664c..07b7d5f79e7d 100644
--- a/shell/inc/global.hxx
+++ b/shell/inc/global.hxx
@@ -20,16 +20,10 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_GLOBAL_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_GLOBAL_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 #  define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 extern long g_DllRefCnt;
 
diff --git a/shell/inc/infotips.hxx b/shell/inc/infotips.hxx
index 270250d27f04..a50276b04351 100644
--- a/shell/inc/infotips.hxx
+++ b/shell/inc/infotips.hxx
@@ -20,15 +20,8 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_INFOTIPS_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_INFOTIPS_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#pragma warning(disable:4917)
-#endif
 #include <objidl.h>
 #include <shlobj.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 #include <string>
 #include "filepath.hxx"
 
diff --git a/shell/inc/propertyhdl.hxx b/shell/inc/propertyhdl.hxx
index 457a896eca18..725885525de6 100644
--- a/shell/inc/propertyhdl.hxx
+++ b/shell/inc/propertyhdl.hxx
@@ -20,14 +20,7 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_PROPERTYHDL_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_PROPERTYHDL_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#pragma warning(disable:4917)
-#endif
 #include <shlobj.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 // {AE424E85-F6DF-4910-A6A9-438797986431}
 const CLSID CLSID_PROPERTY_HANDLER =
diff --git a/shell/inc/propsheets.hxx b/shell/inc/propsheets.hxx
index 920ede7ccff3..20aa1e9e37a4 100644
--- a/shell/inc/propsheets.hxx
+++ b/shell/inc/propsheets.hxx
@@ -22,13 +22,7 @@
 
 #include "metainforeader.hxx"
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <shlobj.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 #include <string>
 #include <memory>
 #include "filepath.hxx"
diff --git a/shell/inc/registry.hxx b/shell/inc/registry.hxx
index 3da9eccd40c6..3ea0d85f74b8 100644
--- a/shell/inc/registry.hxx
+++ b/shell/inc/registry.hxx
@@ -24,13 +24,7 @@
 // registry helper functions
 
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <objbase.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 #include <string>
 #include "filepath.hxx"
 
diff --git a/shell/inc/shlxthdl.hxx b/shell/inc/shlxthdl.hxx
index 3591ca9cc0cf..2f1c1b1e8146 100644
--- a/shell/inc/shlxthdl.hxx
+++ b/shell/inc/shlxthdl.hxx
@@ -20,13 +20,7 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_SHLXTHDL_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_SHLXTHDL_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <objbase.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 // {087B3AE3-E237-4467-B8DB-5A38AB959AC9}
 const CLSID CLSID_INFOTIP_HANDLER =
diff --git a/shell/inc/thumbviewer.hxx b/shell/inc/thumbviewer.hxx
index 81698f084871..37e348118b5d 100644
--- a/shell/inc/thumbviewer.hxx
+++ b/shell/inc/thumbviewer.hxx
@@ -20,18 +20,11 @@
 #ifndef INCLUDED_SHELL_INC_INTERNAL_THUMBVIEWER_HXX
 #define INCLUDED_SHELL_INC_INTERNAL_THUMBVIEWER_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#pragma warning(disable:4917)
-#endif
 #include <objidl.h>
 #include <shlobj.h>
 #ifndef DONT_HAVE_GDIPLUS
 #include <gdiplus.h>
 #endif
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 #include <string>
 
 class CThumbviewer : public IPersistFile, public IExtractImage
diff --git a/shell/inc/utilities.hxx b/shell/inc/utilities.hxx
index 22f785d3ce62..a199c83db5e9 100644
--- a/shell/inc/utilities.hxx
+++ b/shell/inc/utilities.hxx
@@ -21,16 +21,12 @@
 #define INCLUDED_SHELL_INC_INTERNAL_UTILITIES_HXX
 
 #include <malloc.h>
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
+
 #if !defined WIN32_LEAN_AND_MEAN
   #define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
+
 #include <stdio.h>
 #include <fcntl.h>
 #include <io.h>
diff --git a/shell/qa/zip/ziptest.cxx b/shell/qa/zip/ziptest.cxx
index 2f09c9abcd50..9cab98a1c5ef 100644
--- a/shell/qa/zip/ziptest.cxx
+++ b/shell/qa/zip/ziptest.cxx
@@ -17,16 +17,10 @@
  *   the License at http://www.apache.org/licenses/LICENSE-2.0 .
  */
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 #include <ole2.h>
 #include <stdio.h>
 
diff --git a/shell/source/backends/localebe/localebackend.cxx b/shell/source/backends/localebe/localebackend.cxx
index 056d8a48bb32..218b17212451 100644
--- a/shell/source/backends/localebe/localebackend.cxx
+++ b/shell/source/backends/localebe/localebackend.cxx
@@ -34,16 +34,10 @@
 #include <stdio.h>
 
 #ifdef _WIN32
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 css::beans::Optional<css::uno::Any> ImplGetLocale(LCID lcid)
 {
diff --git a/shell/source/backends/wininetbe/wininetbackend.cxx b/shell/source/backends/wininetbe/wininetbackend.cxx
index bed1e270cf6d..1cfdd63cf114 100644
--- a/shell/source/backends/wininetbe/wininetbackend.cxx
+++ b/shell/source/backends/wininetbe/wininetbackend.cxx
@@ -22,18 +22,12 @@
 
 #include "wininetbackend.hxx"
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
 #include <wininet.h>
 #include <sal/alloca.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #define WININET_DLL_NAME L"wininet.dll"
 #define EQUAL_SIGN '='
diff --git a/shell/source/tools/regsvrex/regsvrex.cxx b/shell/source/tools/regsvrex/regsvrex.cxx
index 032267f4dcfc..7fe5a0d95c3b 100644
--- a/shell/source/tools/regsvrex/regsvrex.cxx
+++ b/shell/source/tools/regsvrex/regsvrex.cxx
@@ -18,14 +18,8 @@
  */
 
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #define WIN32_LEAN_AND_MEAN
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 typedef HRESULT (__stdcall *lpfnDllRegisterServer)();
 typedef HRESULT (__stdcall *lpfnDllUnregisterServer)();
diff --git a/shell/source/win32/SysShExec.cxx b/shell/source/win32/SysShExec.cxx
index 644aa40c687c..44cfed4876f0 100644
--- a/shell/source/win32/SysShExec.cxx
+++ b/shell/source/win32/SysShExec.cxx
@@ -31,15 +31,9 @@
 #include <o3tl/char16_t2wchar_t.hxx>
 
 #define WIN32_LEAN_AND_MEAN
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <windows.h>
 #include <shellapi.h>
 #include <objbase.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 using com::sun::star::uno::Reference;
 using com::sun::star::uno::RuntimeException;
diff --git a/shell/source/win32/shlxthandler/classfactory.hxx b/shell/source/win32/shlxthandler/classfactory.hxx
index 69a0841b62f5..2b6ab987f279 100644
--- a/shell/source/win32/shlxthandler/classfactory.hxx
+++ b/shell/source/win32/shlxthandler/classfactory.hxx
@@ -20,13 +20,7 @@
 #ifndef INCLUDED_SHELL_SOURCE_WIN32_SHLXTHANDLER_CLASSFACTORY_HXX
 #define INCLUDED_SHELL_SOURCE_WIN32_SHLXTHANDLER_CLASSFACTORY_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <objidl.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 class CClassFactory : public IClassFactory
 {
diff --git a/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx b/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
index 318b048c7335..8782704180ad 100644
--- a/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
+++ b/shell/source/win32/shlxthandler/ooofilt/ooofilt.cxx
@@ -45,16 +45,11 @@
 //  propspec.hxx    PROPSPEC
 
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
+
 #include <string.h>
 #include <filter.h>
 #include <filterr.h>
diff --git a/shell/source/win32/shlxthandler/ooofilt/propspec.cxx b/shell/source/win32/shlxthandler/ooofilt/propspec.cxx
index 222c9342d9ea..ed44bb8b22b9 100644
--- a/shell/source/win32/shlxthandler/ooofilt/propspec.cxx
+++ b/shell/source/win32/shlxthandler/ooofilt/propspec.cxx
@@ -26,17 +26,11 @@
 
 #include <new>
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
 #include <filter.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include "propspec.hxx"
 
diff --git a/shell/source/win32/shlxthandler/ooofilt/propspec.hxx b/shell/source/win32/shlxthandler/ooofilt/propspec.hxx
index bd771407fedf..7004c9c871f5 100644
--- a/shell/source/win32/shlxthandler/ooofilt/propspec.hxx
+++ b/shell/source/win32/shlxthandler/ooofilt/propspec.hxx
@@ -24,18 +24,12 @@
 //  File:       propspec.hxx
 //  Contents:   C++ wrapper(s) for FULLPROPSPEC
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
 #include <ole2.h>
 #include <ntquery.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 //+-------------------------------------------------------------------------
 //  Declare:    CLSID_SummaryInforation, GUID
 //              CLSID_Storage, GUID
diff --git a/shell/source/win32/shlxthandler/ooofilt/stream_helper.cxx b/shell/source/win32/shlxthandler/ooofilt/stream_helper.cxx
index 0d0e475ef678..2e4bff29995f 100644
--- a/shell/source/win32/shlxthandler/ooofilt/stream_helper.cxx
+++ b/shell/source/win32/shlxthandler/ooofilt/stream_helper.cxx
@@ -18,16 +18,10 @@
  */
 
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <stdio.h>
 #include <objidl.h>
diff --git a/shell/source/win32/shlxthandler/propsheets/document_statistic.cxx b/shell/source/win32/shlxthandler/propsheets/document_statistic.cxx
index a158366f7a46..6a27e1ab1bd0 100644
--- a/shell/source/win32/shlxthandler/propsheets/document_statistic.cxx
+++ b/shell/source/win32/shlxthandler/propsheets/document_statistic.cxx
@@ -18,9 +18,6 @@
  */
 
 
-#ifdef _MSC_VER
-#pragma warning (disable : 4786 4503)
-#endif
 #include "document_statistic.hxx"
 #include <utilities.hxx>
 #include <metainforeader.hxx>
diff --git a/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx b/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx
index 87a8f591f393..4b5342441cfe 100644
--- a/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx
+++ b/shell/source/win32/shlxthandler/propsheets/listviewbuilder.cxx
@@ -18,10 +18,6 @@
  */
 
 
-#ifdef _MSC_VER
-#pragma warning (disable : 4786 4503)
-#endif
-
 #include "listviewbuilder.hxx"
 #include "document_statistic.hxx"
 #include <utilities.hxx>
diff --git a/shell/source/win32/shlxthandler/propsheets/listviewbuilder.hxx b/shell/source/win32/shlxthandler/propsheets/listviewbuilder.hxx
index 7c8b86104bb8..689da439dd15 100644
--- a/shell/source/win32/shlxthandler/propsheets/listviewbuilder.hxx
+++ b/shell/source/win32/shlxthandler/propsheets/listviewbuilder.hxx
@@ -20,16 +20,10 @@
 #ifndef INCLUDED_SHELL_SOURCE_WIN32_SHLXTHANDLER_PROPSHEETS_LISTVIEWBUILDER_HXX
 #define INCLUDED_SHELL_SOURCE_WIN32_SHLXTHANDLER_PROPSHEETS_LISTVIEWBUILDER_HXX
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <string>
 #include <memory>
diff --git a/shell/source/win32/shlxthandler/propsheets/propsheets.cxx b/shell/source/win32/shlxthandler/propsheets/propsheets.cxx
index 4f9d7203a6c2..627452ea7da5 100644
--- a/shell/source/win32/shlxthandler/propsheets/propsheets.cxx
+++ b/shell/source/win32/shlxthandler/propsheets/propsheets.cxx
@@ -25,13 +25,7 @@
 #include <resource.h>
 #include "listviewbuilder.hxx"
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <shellapi.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <memory>
 #include <string>
diff --git a/shell/source/win32/shlxthandler/thumbviewer/thumbviewer.cxx b/shell/source/win32/shlxthandler/thumbviewer/thumbviewer.cxx
index 87a125a21b1a..cdc5d97622ec 100644
--- a/shell/source/win32/shlxthandler/thumbviewer/thumbviewer.cxx
+++ b/shell/source/win32/shlxthandler/thumbviewer/thumbviewer.cxx
@@ -36,13 +36,8 @@
 #include <utility>
 #include <stdlib.h>
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <shellapi.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
+
 #include <memory>
 
 namespace internal
diff --git a/shell/source/win32/shlxthandler/util/registry.cxx b/shell/source/win32/shlxthandler/util/registry.cxx
index d853ea54b53c..928fb4643f3a 100644
--- a/shell/source/win32/shlxthandler/util/registry.cxx
+++ b/shell/source/win32/shlxthandler/util/registry.cxx
@@ -18,26 +18,15 @@
  */
 
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #if !defined WIN32_LEAN_AND_MEAN
 # define WIN32_LEAN_AND_MEAN
 #endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
+
 #include <malloc.h>
 #include <registry.hxx>
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <objbase.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 bool SetRegistryKey(HKEY RootKey, const wchar_t* KeyName, const wchar_t* ValueName, const wchar_t* Value)
 {
diff --git a/shell/source/win32/simplemail/simplemapi.hxx b/shell/source/win32/simplemail/simplemapi.hxx
index e1de5e5c3cab..a9bf054557c3 100644
--- a/shell/source/win32/simplemail/simplemapi.hxx
+++ b/shell/source/win32/simplemail/simplemapi.hxx
@@ -21,14 +21,8 @@
 #define INCLUDED_SHELL_SOURCE_WIN32_SIMPLEMAIL_SIMPLEMAPI_HXX
 
 #define WIN32_LEAN_AND_MEAN
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <windows.h>
 #include <mapi.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 class CSimpleMapi
 {
diff --git a/shell/source/win32/simplemail/smplmailclient.cxx b/shell/source/win32/simplemail/smplmailclient.cxx
index 75cdf75eda11..f83932902e7b 100644
--- a/shell/source/win32/simplemail/smplmailclient.cxx
+++ b/shell/source/win32/simplemail/smplmailclient.cxx
@@ -30,14 +30,8 @@
 #include <o3tl/char16_t2wchar_t.hxx>
 
 #define WIN32_LEAN_AND_MEAN
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <windows.h>
 #include <mapi.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <process.h>
 #include <vector>
diff --git a/shell/source/win32/workbench/TestSmplMail.cxx b/shell/source/win32/workbench/TestSmplMail.cxx
index 74db0a71a695..b333d80e15bb 100644
--- a/shell/source/win32/workbench/TestSmplMail.cxx
+++ b/shell/source/win32/workbench/TestSmplMail.cxx
@@ -26,13 +26,8 @@
 #include <osl/diagnose.h>
 
 #include <stdio.h>
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
+
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 #include <osl/file.hxx>
 
diff --git a/shell/source/win32/workbench/TestSysShExec.cxx b/shell/source/win32/workbench/TestSysShExec.cxx
index 8d09a1c29eb7..607e0998a5bc 100644
--- a/shell/source/win32/workbench/TestSysShExec.cxx
+++ b/shell/source/win32/workbench/TestSysShExec.cxx
@@ -30,13 +30,7 @@
 
 #include <stdio.h>
 
-#if defined _MSC_VER
-#pragma warning(push, 1)
-#endif
 #include <windows.h>
-#if defined _MSC_VER
-#pragma warning(pop)
-#endif
 
 
 //  namespaces