Remove non-const Sequence::begin()/end() in internal code

... to avoid hidden cost of multiple COW checks, because they
call getArray() internally.
This obsoletes [loplugin:sequenceloop].

Also rename toNonConstRange to asNonConstRange, to reflect that
the result is a view of the sequence, not an independent object.

TODO: also drop non-const operator[], but introduce operator[]
in SequenceRange.

Change-Id: Idd5fd7a3400fe65274d2a6343025e2ef8911635d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123518
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>

1 files changed, 3 insertions, 3 deletions

diff --git a/package/source/zipapi/ThreadedDeflater.cxx b/package/source/zipapi/ThreadedDeflater.cxx
index 73725c580c02..f574105ad4ef 100644
--- a/package/source/zipapi/ThreadedDeflater.cxx
+++ b/package/source/zipapi/ThreadedDeflater.cxx
@@ -114,8 +114,8 @@ void ThreadedDeflater::deflateWrite(
         if (!lastBatch)
         {
             assert(inputBytes == batchSize);
-            std::copy_n(inBuffer.begin() + (batchSize - MaxBlockSize), MaxBlockSize,
-                        prevDataBlock.begin());
+            std::copy_n(std::cbegin(inBuffer) + (batchSize - MaxBlockSize), MaxBlockSize,
+                        prevDataBlock.getArray());
         }
 
         processDeflatedBuffers();
@@ -130,7 +130,7 @@ void ThreadedDeflater::processDeflatedBuffers()
 
     css::uno::Sequence<sal_Int8> outBuffer(batchOutputSize);
 
-    auto pos = outBuffer.begin();
+    auto pos = outBuffer.getArray();
     for (auto& buffer : outBuffers)
     {
         pos = std::copy(buffer.begin(), buffer.end(), pos);