diff options
| author | Xisco Fauli <xiscofauli@libreoffice.org> | 2024-11-13 16:02:35 +0100 |
|---|---|---|
| committer | Xisco Fauli <xiscofauli@libreoffice.org> | 2024-11-13 20:11:37 +0100 |
| commit | 6923fa7a92bd8f33b46be5e5ef6ff44362de435a (patch) | |
| tree | 1ac22c6e46f288656d86b1ac7e62b0cbf0f2ed9d /oox | |
| parent | 83763a3ae15ac8bd2faaf9b194d95ff077f6da4b (diff) | |
tdf#163486: PVS: identical conditional expressions
Since
commit 63cd67e5e18f01aca303131e148c80398a181a41
Author: Attila Bakos (NISZ) <bakos.attilakaroly@nisz.hu>
Date: Fri May 14 13:53:32 2021 +0200
tdf#92525 tdf#142398: fix export of simple custom shapes
V649 There are two 'if' statements with identical conditional expressions. The first 'if' statement contains function return. This means that the second 'if' statement is senseless. Check lines: 733, 738.
Change-Id: I92bff7ef8472c1774e6def78c5f1a165ea6a0153
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176550
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Diffstat (limited to 'oox')
| -rw-r--r-- | oox/source/export/DMLPresetShapeExport.cxx | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/oox/source/export/DMLPresetShapeExport.cxx b/oox/source/export/DMLPresetShapeExport.cxx index c77cbd3fcd5b..3e383ac13d8b 100644 --- a/oox/source/export/DMLPresetShapeExport.cxx +++ b/oox/source/export/DMLPresetShapeExport.cxx @@ -735,11 +735,6 @@ bool DMLPresetShapeExporter::WriteShapeWithAVlist() // Does not have handle points, so preset enough. return false; } - if (sShapeType == "flowChartDecision") - { - // Does not have handle points, so preset enough. - return false; - } if (sShapeType == "flowChartDelay") { // Does not have handle points, so preset enough. @@ -825,11 +820,6 @@ bool DMLPresetShapeExporter::WriteShapeWithAVlist() // Does not have handle points, so preset enough. return false; } - if (sShapeType == "flowChartDecision") - { - // Does not have handle points, so preset enough. - return false; - } if (sShapeType == "flowChartPredefinedProcess") { // Does not have handle points, so preset enough. |