summaryrefslogtreecommitdiff
path: root/logerrit
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@suse.cz>2012-08-22 14:14:46 +0200
committerMiklos Vajna <vmiklos@suse.cz>2012-08-22 14:15:14 +0200
commitf9fa180e42453b95b75d97dc8e50eab7e38c7464 (patch)
treeffc32c8a3f520878ef88a96e2774aaa4192eb1d9 /logerrit
parent28f04b0aa2239d2e1a38f5923b941ce6b0c3270f (diff)
logerrit: --code-review=2 in review implies --submit
Change-Id: Ibd21dfdb76536ea0e0a71791a91ec87e31d49960
Diffstat (limited to 'logerrit')
-rwxr-xr-xlogerrit4
1 files changed, 3 insertions, 1 deletions
diff --git a/logerrit b/logerrit
index c936653b0001..bb604734a253 100755
--- a/logerrit
+++ b/logerrit
@@ -146,6 +146,7 @@ case "$1" in
esac
read -p 'is the code looking good (+), bad (-) or none of that ()? ' CODEREVIEW
ask_tristate $CODEREVIEW
+ SUBMITFLAG=""
case "$ANSWER" in
"y")
read -p 'do you approve the change (+) too, or prefer someone else to do that ()? ' CODEREVIEW
@@ -153,6 +154,7 @@ case "$1" in
case "$ANSWER" in
"y")
CODEREVIEWFLAG="--code-review=2"
+ SUBMITFLAG="--submit"
;;
"n")
CODEREVIEWFLAG="--code-review=1"
@@ -185,7 +187,7 @@ case "$1" in
esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
get_REVISION_for_change $CHANGEID
- ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $REVISION
+ ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $SUBMITFLAG $REVISION
;;
checkout)
get_SHA_for_change $2