summaryrefslogtreecommitdiff
path: root/logerrit
diff options
context:
space:
mode:
authorMiklos Vajna <vmiklos@suse.cz>2012-06-29 09:59:14 +0200
committerMiklos Vajna <vmiklos@suse.cz>2012-06-29 10:00:47 +0200
commit616ad0b94ca3f200809999d19595b6a69a2a6969 (patch)
treec88321c0b4a78ee5f3d28b228ff749e3f5e5e3ee /logerrit
parentd817891d69602d9877ac46131c6e123b99376802 (diff)
logerrit review: fix missing escaping, codereview -> code-review
Change-Id: Icf5facbb59cba2116ae3fc6bdfc035673cf47985
Diffstat (limited to 'logerrit')
-rwxr-xr-xlogerrit14
1 files changed, 7 insertions, 7 deletions
diff --git a/logerrit b/logerrit
index 52be19335974..851af7de1f32 100755
--- a/logerrit
+++ b/logerrit
@@ -127,13 +127,13 @@ case "$1" in
ask_tristate $CODEREVIEW
case "$ANSWER" in
"y")
- CODEREVIEWFLAG="--codereview=2"
+ CODEREVIEWFLAG="--code-review=2"
;;
"n")
- CODEREVIEWFLAG="--codereview=1"
+ CODEREVIEWFLAG="--code-review=1"
;;
*)
- CODEREVIEWFLAG="--codereview=1"
+ CODEREVIEWFLAG="--code-review=1"
;;
esac
;;
@@ -142,15 +142,15 @@ case "$1" in
ask_tristate $CODEREVIEW
case "$ANSWER" in
"y")
- CODEREVIEWFLAG="--codereview=-1"
+ CODEREVIEWFLAG="--code-review=-1"
MESSAGEREQ="$MESSAGEREQ and explain why you have reservations about the code"
;;
"n")
- CODEREVIEWFLAG="--codereview=-2"
+ CODEREVIEWFLAG="--code-review=-2"
MESSAGEREQ="$MESSAGEREQ and explain why you want to block this"
;;
*)
- CODEREVIEWFLAG="--codereview=-1"
+ CODEREVIEWFLAG="--code-review=-1"
MESSAGEREQ="$MESSAGEREQ and explain why you have reservations about the code"
;;
esac
@@ -159,7 +159,7 @@ case "$1" in
;;
esac
read -p "please type a friendly comment$MESSAGEREQ: " MESSAGE
- echo ssh ${GERRITHOST?} gerrit review -m \"$MESSAGE\" $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
+ echo ssh ${GERRITHOST?} gerrit review -m '\"'$MESSAGE'\"' $VERIFIEDFLAG $CODEREVIEWFLAG $CHANGEID
;;
checkout)
get_SHA_for_change $2