diff options
author | Caolán McNamara <caolanm@redhat.com> | 2018-07-15 21:14:32 +0100 |
---|---|---|
committer | Jan Holesovsky <kendy@collabora.com> | 2018-07-18 10:58:13 +0200 |
commit | 1c8264b4a3305c3f4fcde726a3516bb58fff326a (patch) | |
tree | 3e872d2621399943ee32672fa2a41f9368da27b7 /libreofficekit | |
parent | b61b61f02fb5897a3ecd2aac89cb4ef45d7a139a (diff) |
coverity#1437959 Copy into fixed size buffer
Change-Id: I5578e195c834b2a3ceacd5c528f58d1d03502c2e
Reviewed-on: https://gerrit.libreoffice.org/57461
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'libreofficekit')
-rw-r--r-- | libreofficekit/qa/tilebench/tilebench.cxx | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/libreofficekit/qa/tilebench/tilebench.cxx b/libreofficekit/qa/tilebench/tilebench.cxx index 16fc047ce655..4cb76dd1366e 100644 --- a/libreofficekit/qa/tilebench/tilebench.cxx +++ b/libreofficekit/qa/tilebench/tilebench.cxx @@ -313,23 +313,22 @@ int main( int argc, char* argv[] ) mode = argv[arg++]; } - char user_url[8046];; - strcpy(user_url, "file:///"); - strcat(user_url, argv[1]); - strcat(user_url, "../user"); + std::string user_url("file:///"); + user_url.append(argv[1]); + user_url.append("../user"); if (pre_init) { aTimes.emplace_back("pre-initialization"); setenv("LOK_WHITELIST_LANGUAGES", "en_US", 0); // coverity[tainted_string] - build time test tool - lok_preinit(argv[1], user_url); + lok_preinit(argv[1], user_url.c_str()); aTimes.emplace_back(); } aTimes.emplace_back("initialization"); // coverity[tainted_string] - build time test tool - Office *pOffice = lok_cpp_init(argv[1], user_url); + Office *pOffice = lok_cpp_init(argv[1], user_url.c_str()); if (pOffice == nullptr) { fprintf(stderr, "Failed to initialize Office from %s\n", argv[1]); |