diff options
| author | Mike Kaganski <mike.kaganski@collabora.com> | 2021-01-14 17:30:17 +0100 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-01-15 07:26:48 +0100 |
| commit | f582670131dc211e472960ecff1826f7b133b083 (patch) | |
| tree | 014a0e74ecaace01a2d9e7efbee119781ebb0a22 /include | |
| parent | 9598018e67dfc10c35022cbec4844363b7dd98ab (diff) | |
Use value comparison here
This was always comparing pointers, ever since commit
cb07ed8c74d71de9ef512c7a3568c7ee85585cef. They could only
happen to be not different if they are both nullptr. But
the uses of the function seem to expect value comparison
(see SdrObjEditView::ImpChainingEventHdl,
SdrObjEditView::SdrEndTextEdit).
Change-Id: I2265dc8f0f7e4441940f8e19ec0b016b5f78e812
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109284
Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'include')
| -rw-r--r-- | include/svx/svdundo.hxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx index d1aac69b1d65..e56b6d52f9a7 100644 --- a/include/svx/svdundo.hxx +++ b/include/svx/svdundo.hxx @@ -407,7 +407,7 @@ public: SdrUndoObjSetText(SdrObject& rNewObj, sal_Int32 nText ); virtual ~SdrUndoObjSetText() override; - bool IsDifferent() const { return pOldText!=pNewText; } + bool IsDifferent() const; void AfterSetText(); virtual void Undo() override; |