diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-09-05 11:53:35 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-10 17:11:00 +0100 |
| commit | 242320d303d43a34ce2255a07783fbd51e253cd0 (patch) | |
| tree | 14bd7757a57784a18d1aa2b731eb71999d14bf94 /idlc | |
| parent | 8523fb2b37a2cdd2c3743795bb33cf30a57c5385 (diff) | |
new loplugin:reducevarscope
Change-Id: Iefe922c2e0d605114d54673d63eccc5e4abd545d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102143
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'idlc')
| -rw-r--r-- | idlc/source/idlc.cxx | 2 | ||||
| -rw-r--r-- | idlc/source/options.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/idlc/source/idlc.cxx b/idlc/source/idlc.cxx index 5984ca759448..c1d09b4c1b2e 100644 --- a/idlc/source/idlc.cxx +++ b/idlc/source/idlc.cxx @@ -273,8 +273,8 @@ OUString Idlc::processDocumentation() static void lcl_writeString(::osl::File & rFile, ::osl::FileBase::RC & o_rRC, OString const& rString) { - sal_uInt64 nWritten(0); if (::osl::FileBase::E_None == o_rRC) { + sal_uInt64 nWritten(0); o_rRC = rFile.write(rString.getStr(), rString.getLength(), nWritten); if (static_cast<sal_uInt64>(rString.getLength()) != nWritten) { o_rRC = ::osl::FileBase::E_INVAL; //? diff --git a/idlc/source/options.cxx b/idlc/source/options.cxx index 0ab0a9cc32d2..1b74a2367578 100644 --- a/idlc/source/options.cxx +++ b/idlc/source/options.cxx @@ -168,9 +168,9 @@ bool Options::checkCommandFile (std::vector< std::string > & rArgs, char const * bool Options::badOption(char const * reason, std::string const & rArg) { - OStringBuffer message; if (reason != nullptr) { + OStringBuffer message; message.append(reason); message.append(" option '"); message.append(rArg.c_str()); message.append("'"); throw IllegalArgument(message.makeStringAndClear()); } |