diff options
| author | Noel Grandin <noel@peralex.com> | 2016-04-12 16:39:03 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2016-04-18 07:37:31 +0000 |
| commit | 789055bc2acb4c71483fd60ea258d158bd5aec10 (patch) | |
| tree | 7849de841a71f667a30b2a971ad0c3d406110396 /desktop | |
| parent | 150ac9cf05ed9da6a2af5bc3f820280fd853e519 (diff) | |
clang-tidy performance-unnecessary-copy-initialization
probably not much performance benefit, but it sure is good at
identifying leftover intermediate variables from previous
refactorings.
Change-Id: I3ce16fe496ac2733c1cb0a35f74c0fc9193cc657
Reviewed-on: https://gerrit.libreoffice.org/24026
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
Tested-by: Noel Grandin <noelgrandin@gmail.com>
Diffstat (limited to 'desktop')
| -rw-r--r-- | desktop/source/app/sofficemain.cxx | 2 | ||||
| -rw-r--r-- | desktop/source/deployment/misc/dp_misc.cxx | 3 | ||||
| -rw-r--r-- | desktop/source/lib/init.cxx | 2 |
3 files changed, 3 insertions, 4 deletions
diff --git a/desktop/source/app/sofficemain.cxx b/desktop/source/app/sofficemain.cxx index e86d901df603..4a7ddfc13355 100644 --- a/desktop/source/app/sofficemain.cxx +++ b/desktop/source/app/sofficemain.cxx @@ -112,7 +112,7 @@ extern "C" int DESKTOP_DLLPUBLIC soffice_main() // handle --version and --help already here, otherwise they would be handled // after VCL initialization that might fail if $DISPLAY is not set const desktop::CommandLineArgs& rCmdLineArgs = desktop::Desktop::GetCommandLineArgs(); - OUString aUnknown( rCmdLineArgs.GetUnknown() ); + const OUString& aUnknown( rCmdLineArgs.GetUnknown() ); if ( !aUnknown.isEmpty() ) { desktop::Desktop::InitApplicationServiceManager(); diff --git a/desktop/source/deployment/misc/dp_misc.cxx b/desktop/source/deployment/misc/dp_misc.cxx index 28cf3d17b3c2..e02b84d87bd7 100644 --- a/desktop/source/deployment/misc/dp_misc.cxx +++ b/desktop/source/deployment/misc/dp_misc.cxx @@ -294,9 +294,8 @@ OUString makeURL( OUString const & baseURL, OUString const & relPath_ ) return buf.makeStringAndClear(); } -OUString makeURLAppendSysPathSegment( OUString const & baseURL, OUString const & relPath_ ) +OUString makeURLAppendSysPathSegment( OUString const & baseURL, OUString const & segment ) { - OUString segment = relPath_; OSL_ASSERT(segment.indexOf(static_cast<sal_Unicode>('/')) == -1); ::rtl::Uri::encode( diff --git a/desktop/source/lib/init.cxx b/desktop/source/lib/init.cxx index 12d0555f66ab..b58f23e14691 100644 --- a/desktop/source/lib/init.cxx +++ b/desktop/source/lib/init.cxx @@ -1623,7 +1623,7 @@ unsigned char* doc_renderFont(LibreOfficeKitDocument* /*pThis*/, for (sal_uInt16 i = 0; i < nFontCount; ++i) { const FontMetric& rFontMetric = pList->GetFontName(i); - OUString aFontName = rFontMetric.GetFamilyName(); + const OUString& aFontName = rFontMetric.GetFamilyName(); if (!aSearchedFontName.equals(aFontName.toUtf8().getStr())) continue; |