loplugin:constantparam in cui

Change-Id: Iccba51d7b1d11ae5b309e380fd396be796992d7e

10 files changed, 23 insertions, 28 deletions

diff --git a/cui/source/customize/cfg.cxx b/cui/source/customize/cfg.cxx
index 6aa6838a9967..c8e5ba3476d2 100644
--- a/cui/source/customize/cfg.cxx
+++ b/cui/source/customize/cfg.cxx
@@ -4698,10 +4698,10 @@ IMPL_LINK_NOARG_TYPED( SvxToolbarConfigPage, AddFunctionHdl, SvxScriptSelectorDi
 }
 
 void SvxToolbarConfigPage::AddFunction(
-    SvTreeListEntry* pTarget, bool bFront, bool bAllowDuplicates )
+    SvTreeListEntry* pTarget, bool bFront )
 {
     SvTreeListEntry* pNewLBEntry =
-        SvxConfigPage::AddFunction( pTarget, bFront, bAllowDuplicates );
+        SvxConfigPage::AddFunction( pTarget, bFront, true/*bAllowDuplicates*/ );
 
     SvxConfigEntry* pEntry = static_cast<SvxConfigEntry*>(pNewLBEntry->GetUserData());
 
diff --git a/cui/source/dialogs/cuicharmap.cxx b/cui/source/dialogs/cuicharmap.cxx
index ded95884f4eb..dc582d6bf214 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -173,10 +173,10 @@ short SvxCharacterMap::Execute()
 
 // class SvxShowText =====================================================
 
-SvxShowText::SvxShowText(vcl::Window* pParent, bool bCenter)
+SvxShowText::SvxShowText(vcl::Window* pParent)
     : Control(pParent)
     , mnY(0)
-    , mbCenter(bCenter)
+    , mbCenter(false)
 {}
 
 VCL_BUILDER_FACTORY(SvxShowText)
diff --git a/cui/source/dialogs/iconcdlg.cxx b/cui/source/dialogs/iconcdlg.cxx
index 859dc9a43e27..66d042d274f0 100644
--- a/cui/source/dialogs/iconcdlg.cxx
+++ b/cui/source/dialogs/iconcdlg.cxx
@@ -281,8 +281,7 @@ SvxIconChoiceCtrlEntry* IconChoiceDialog::AddTabPage(
 )
 {
     IconChoicePageData* pData = new IconChoicePageData ( nId, pCreateFunc,
-                                                         nullptr,
-                                                         false/*bItemsOnDemand*/ );
+                                                         nullptr );
     maPageList.push_back( pData );
 
     pData->fnGetRanges = nullptr;
diff --git a/cui/source/inc/cfg.hxx b/cui/source/inc/cfg.hxx
index abc928061ef8..104f2e5af3ab 100644
--- a/cui/source/inc/cfg.hxx
+++ b/cui/source/inc/cfg.hxx
@@ -581,8 +581,7 @@ public:
     virtual void dispose() override;
 
     void            AddFunction( SvTreeListEntry* pTarget = nullptr,
-                                             bool bFront = false,
-                                             bool bAllowDuplicates = true );
+                                             bool bFront = false );
 
     void            MoveEntry( bool bMoveUp ) override;
 
diff --git a/cui/source/inc/cuicharmap.hxx b/cui/source/inc/cuicharmap.hxx
index 9e1efa9ff1a2..a59a209478fb 100644
--- a/cui/source/inc/cuicharmap.hxx
+++ b/cui/source/inc/cuicharmap.hxx
@@ -39,7 +39,7 @@ namespace svx
 class SvxShowText : public Control
 {
 public:
-    SvxShowText(vcl::Window* pParent, bool bCenter = false);
+    SvxShowText(vcl::Window* pParent);
 
     void            SetFont( const vcl::Font& rFont );
     void            SetText( const OUString& rText ) override;
diff --git a/cui/source/inc/iconcdlg.hxx b/cui/source/inc/iconcdlg.hxx
index b343adbd61ee..d97b03bc7e5b 100644
--- a/cui/source/inc/iconcdlg.hxx
+++ b/cui/source/inc/iconcdlg.hxx
@@ -51,12 +51,12 @@ struct IconChoicePageData
     bool bRefresh;          ///< Flag: page has to be newly initialized
 
     // constructor
-    IconChoicePageData( sal_uInt16 Id, CreatePage fnPage, GetPageRanges fnRanges, bool bDemand )
+    IconChoicePageData( sal_uInt16 Id, CreatePage fnPage, GetPageRanges fnRanges )
         : nId           ( Id ),
           fnCreatePage  ( fnPage ),
           fnGetRanges   ( fnRanges ),
           pPage         ( nullptr ),
-          bOnDemand     ( bDemand ),
+          bOnDemand     ( false ),
           bRefresh      ( false )
     {}
 };
diff --git a/cui/source/options/connpoolconfig.cxx b/cui/source/options/connpoolconfig.cxx
index 56ff7d3b88a9..31423f5431a8 100644
--- a/cui/source/options/connpoolconfig.cxx
+++ b/cui/source/options/connpoolconfig.cxx
@@ -93,7 +93,7 @@ namespace offapp
                 ++aLoopDrivers
             )
         {
-            aSettings.push_back(DriverPooling(*aLoopDrivers, false, 120));
+            aSettings.push_back(DriverPooling(*aLoopDrivers, 120));
         }
 
         // then look for which of them settings are stored in the configuration
@@ -121,7 +121,7 @@ namespace offapp
 
             if (aLookup == aSettings.end())
             {   // do not know the driver - add it
-                aSettings.push_back(DriverPooling(sThisDriverName, false, 120));
+                aSettings.push_back(DriverPooling(sThisDriverName, 120));
 
                 // and the position of the new entry
                 aLookup = aSettings.end();
diff --git a/cui/source/options/connpoolsettings.cxx b/cui/source/options/connpoolsettings.cxx
index de64d355aac6..7eb2d8e82929 100644
--- a/cui/source/options/connpoolsettings.cxx
+++ b/cui/source/options/connpoolsettings.cxx
@@ -23,9 +23,9 @@
 namespace offapp
 {
 
-    DriverPooling::DriverPooling( const OUString& _rName, bool _bEnabled, const sal_Int32 _nTimeout )
+    DriverPooling::DriverPooling( const OUString& _rName, const sal_Int32 _nTimeout )
         :sName(_rName)
-        ,bEnabled(_bEnabled)
+        ,bEnabled(false)
         ,nTimeoutSeconds(_nTimeout)
     {
     }
diff --git a/cui/source/options/connpoolsettings.hxx b/cui/source/options/connpoolsettings.hxx
index 8353f45585d0..6cb1b0de3a33 100644
--- a/cui/source/options/connpoolsettings.hxx
+++ b/cui/source/options/connpoolsettings.hxx
@@ -34,10 +34,10 @@ namespace offapp
     struct DriverPooling
     {
         OUString            sName;
-        bool            bEnabled;
+        bool                bEnabled;
         sal_Int32           nTimeoutSeconds;
 
-        DriverPooling( const OUString& _rName, bool _bEnabled, const sal_Int32 _nTimeout );
+        DriverPooling( const OUString& _rName, const sal_Int32 _nTimeout );
 
         bool operator == (const DriverPooling& _rR) const;
         bool operator != (const DriverPooling& _rR) const { return !operator ==(_rR); }
diff --git a/cui/source/tabpages/borderconn.cxx b/cui/source/tabpages/borderconn.cxx
index ce94e50ca3ff..3f5019a50b98 100644
--- a/cui/source/tabpages/borderconn.cxx
+++ b/cui/source/tabpages/borderconn.cxx
@@ -165,14 +165,12 @@ class MarginConnection : public sfx::ItemControlConnection< MarginItemWrapper, M
 public:
     explicit            MarginConnection( const SfxItemSet& rItemSet,
                             MetricField& rMfLeft, MetricField& rMfRight,
-                            MetricField& rMfTop, MetricField& rMfBottom,
-                            sfx::ItemConnFlags nFlags = sfx::ITEMCONN_DEFAULT );
+                            MetricField& rMfTop, MetricField& rMfBottom );
 };
 
 MarginConnection::MarginConnection( const SfxItemSet& rItemSet,
-        MetricField& rMfLeft, MetricField& rMfRight, MetricField& rMfTop, MetricField& rMfBottom,
-        sfx::ItemConnFlags nFlags ) :
-    ItemControlConnectionType( SID_ATTR_ALIGN_MARGIN, new MarginControlsWrapper( rMfLeft, rMfRight, rMfTop, rMfBottom ), nFlags )
+        MetricField& rMfLeft, MetricField& rMfRight, MetricField& rMfTop, MetricField& rMfBottom ) :
+    ItemControlConnectionType( SID_ATTR_ALIGN_MARGIN, new MarginControlsWrapper( rMfLeft, rMfRight, rMfTop, rMfBottom ), sfx::ITEMCONN_DEFAULT )
 {
     mxCtrlWrp->SetDefaultValue( maItemWrp.GetDefaultItem( rItemSet ) );
 }
@@ -252,13 +250,12 @@ class ShadowConnection : public sfx::ItemControlConnection< ShadowItemWrapper, S
 {
 public:
     explicit            ShadowConnection( const SfxItemSet& rItemSet,
-                                ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor,
-                                sfx::ItemConnFlags nFlags = sfx::ITEMCONN_DEFAULT );
+                                ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor );
 };
 
 ShadowConnection::ShadowConnection( const SfxItemSet& rItemSet,
-        ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor, sfx::ItemConnFlags nFlags ) :
-    ItemControlConnectionType( SID_ATTR_BORDER_SHADOW, new ShadowControlsWrapper( rVsPos, rMfSize, rLbColor ), nFlags )
+        ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor ) :
+    ItemControlConnectionType( SID_ATTR_BORDER_SHADOW, new ShadowControlsWrapper( rVsPos, rMfSize, rLbColor ), sfx::ITEMCONN_DEFAULT )
 {
     mxCtrlWrp->SetDefaultValue( maItemWrp.GetDefaultItem( rItemSet ) );
 }
@@ -274,13 +271,13 @@ sfx::ItemConnectionBase* CreateMarginConnection( const SfxItemSet& rItemSet,
         MetricField& rMfLeft, MetricField& rMfRight,
         MetricField& rMfTop, MetricField& rMfBottom )
 {
-    return new MarginConnection( rItemSet, rMfLeft, rMfRight, rMfTop, rMfBottom, sfx::ITEMCONN_DEFAULT );
+    return new MarginConnection( rItemSet, rMfLeft, rMfRight, rMfTop, rMfBottom );
 }
 
 sfx::ItemConnectionBase* CreateShadowConnection( const SfxItemSet& rItemSet,
         ValueSet& rVsPos, MetricField& rMfSize, ColorListBox& rLbColor )
 {
-    return new ShadowConnection( rItemSet, rVsPos, rMfSize, rLbColor, sfx::ITEMCONN_DEFAULT );
+    return new ShadowConnection( rItemSet, rVsPos, rMfSize, rLbColor );
 }