cid#706201: No need to call access prior to realpath here

...and thus silence a TOCTOU warning

Change-Id: I17f36181946616747d84aca6d43e44d180dc8741

1 files changed, 12 insertions, 17 deletions

diff --git a/cppuhelper/source/findsofficepath.c b/cppuhelper/source/findsofficepath.c
index f062d8f30e78..37c8bdfc5e07 100644
--- a/cppuhelper/source/findsofficepath.c
+++ b/cppuhelper/source/findsofficepath.c
@@ -156,26 +156,21 @@ static char* platformSpecific(void)
         strcpy( file, dir );
         strcat( file, APPENDIX );
 
-        /* check existence of soffice file */
-        if ( !access( file, F_OK ) )
+        /* resolve symbolic link */
+        resolved = realpath( file, buffer );
+        if ( resolved != NULL )
         {
-            /* resolve symbolic link */
-            resolved = realpath( file, buffer );
+            /* get path to program directory */
+            sep = strrchr( resolved, SEPARATOR );
 
-            if ( resolved != NULL )
+            if ( sep != NULL )
             {
-                /* get path to program directory */
-                sep = strrchr( resolved, SEPARATOR );
-
-                if ( sep != NULL )
-                {
-                    pos = sep - resolved;
-                    path = (char*) malloc( pos + 1 );
-                    strncpy( path, resolved, pos );
-                    path[ pos ] = '\0';
-                    free( file );
-                    break;
-                }
+                pos = sep - resolved;
+                path = (char*) malloc( pos + 1 );
+                strncpy( path, resolved, pos );
+                path[ pos ] = '\0';
+                free( file );
+                break;
             }
         }