diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 10:35:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-28 12:07:54 +0100 |
| commit | bc539bd3c04964471af6b5ca54264215c8995696 (patch) | |
| tree | c37af5b9fb3dc0b8677fc8dd535fb8e93ad6039d /codemaker | |
| parent | 9f78a4174e5099ad3af65a23e158a51c1afca54d (diff) | |
loplugin:stringadd improve detection
if one side of the expression is a compile-time-constant, we don't need
to worry about side-effects on the other side
Change-Id: Iee71ea51b327ef244bf39f128f921ac325d74e2b
Reviewed-on: https://gerrit.libreoffice.org/81589
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'codemaker')
| -rw-r--r-- | codemaker/source/cppumaker/cppuoptions.cxx | 4 | ||||
| -rw-r--r-- | codemaker/source/javamaker/javaoptions.cxx | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/codemaker/source/cppumaker/cppuoptions.cxx b/codemaker/source/cppumaker/cppuoptions.cxx index 05c941b2c68a..90f16fdd3332 100644 --- a/codemaker/source/cppumaker/cppuoptions.cxx +++ b/codemaker/source/cppumaker/cppuoptions.cxx @@ -311,8 +311,8 @@ OString CppuOptions::prepareHelp() " -nD = no dependent types are generated.\n" " -G = generate only target files which does not exists.\n" " -Gc = generate only target files which content will be changed.\n" - " -X<file> = extra types which will not be taken into account for generation.\n\n"; - help += prepareVersion(); + " -X<file> = extra types which will not be taken into account for generation.\n\n" + + prepareVersion(); return help; } diff --git a/codemaker/source/javamaker/javaoptions.cxx b/codemaker/source/javamaker/javaoptions.cxx index 795d1bbf8955..31e43414c68c 100644 --- a/codemaker/source/javamaker/javaoptions.cxx +++ b/codemaker/source/javamaker/javaoptions.cxx @@ -234,8 +234,8 @@ OString JavaOptions::prepareHelp() " -nD = no dependent types are generated.\n" " -G = generate only target files which does not exists.\n" " -Gc = generate only target files which content will be changed.\n" - " -X<file> = extra types which will not be taken into account for generation.\n\n"; - help += prepareVersion(); + " -X<file> = extra types which will not be taken into account for generation.\n\n" + + prepareVersion(); return help; } |