diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2019-10-05 13:32:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-10-06 11:58:50 +0200 |
| commit | 6a789e617ed07bfddc516c8fc0cf94cd6dfe7250 (patch) | |
| tree | 11d6097893a301ae65cf4668077134ac7510091a /avmedia | |
| parent | 070b3a848d6824ea154ae2d68fc7571feed60a5f (diff) | |
improve SfxPoolItem operator== implementations
(*) make them all call the superclass operator==
(*) make the base class check which and typeid to ensure
we are only comparing the safe subclasses together
(*) remove a couple of operator== that were not doing
anything useful
Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316
Reviewed-on: https://gerrit.libreoffice.org/80308
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'avmedia')
| -rw-r--r-- | avmedia/source/avmediadummy.cxx | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/avmedia/source/avmediadummy.cxx b/avmedia/source/avmediadummy.cxx index 74ac0ecf3a1d..2c642541bfb8 100644 --- a/avmedia/source/avmediadummy.cxx +++ b/avmedia/source/avmediadummy.cxx @@ -87,9 +87,10 @@ SfxPoolItem* MediaItem::Clone( SfxItemPool*) const return nullptr; } -bool MediaItem::operator==( const SfxPoolItem& ) const +bool MediaItem::operator==( const SfxPoolItem& rItem ) const { - return false; + assert(SfxPoolItem::operator==(rItem)); (void)rItem; + return false; } } // namespace avmedia |