diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2015-11-15 07:42:02 +0200 |
|---|---|---|
| committer | Noel Grandin <noelgrandin@gmail.com> | 2015-11-15 06:46:07 +0000 |
| commit | 3bdd176731c351638f541a37b94094124f3c9f52 (patch) | |
| tree | ccae69c3871620923bea1c5a048f44ad428853c0 | |
| parent | 7272e8df62a12d6172b297d7a82a0265cd1bc44a (diff) | |
cppcheck:stlIfStrFind
"Inefficient usage of string::find() in condition; string::compare() would be faster."
Change-Id: I90403b1d05eff6499c10be33068e5fd4fed30b62
Reviewed-on: https://gerrit.libreoffice.org/19966
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
| -rw-r--r-- | compilerplugins/clang/passstuffbyref.cxx | 2 | ||||
| -rw-r--r-- | helpcompiler/source/HelpCompiler.cxx | 4 | ||||
| -rw-r--r-- | helpcompiler/source/HelpLinker.cxx | 2 |
3 files changed, 4 insertions, 4 deletions
diff --git a/compilerplugins/clang/passstuffbyref.cxx b/compilerplugins/clang/passstuffbyref.cxx index 6d98dbf90341..673b72b32f8e 100644 --- a/compilerplugins/clang/passstuffbyref.cxx +++ b/compilerplugins/clang/passstuffbyref.cxx @@ -103,7 +103,7 @@ bool PassStuffByRef::isFat(QualType type, std::string * name) { } *name = type.getUnqualifiedType().getCanonicalType().getAsString(); if (*name == "class rtl::OUString" || *name == "class rtl::OString" - || name->find("class com::sun::star::uno::Sequence") == 0) + || name->compare("class com::sun::star::uno::Sequence") == 0) { return true; } diff --git a/helpcompiler/source/HelpCompiler.cxx b/helpcompiler/source/HelpCompiler.cxx index af8154749795..5d3709105287 100644 --- a/helpcompiler/source/HelpCompiler.cxx +++ b/helpcompiler/source/HelpCompiler.cxx @@ -335,7 +335,7 @@ void myparser::traverse( xmlNodePtr parentNode ) std::string hid; - if (branch.find("hid") == 0) + if (branch.compare("hid") == 0) { size_t index = branch.find('/'); if (index != std::string::npos) @@ -493,7 +493,7 @@ bool HelpCompiler::compile() if ( !bExtensionMode && !fileName.empty()) { - if (fileName.find("/text/") == 0) + if (fileName.compare("/text/") == 0) { int len = strlen("/text/"); actMod = fileName.substr(len); diff --git a/helpcompiler/source/HelpLinker.cxx b/helpcompiler/source/HelpLinker.cxx index 8b8f89563f27..33e684a88ecc 100644 --- a/helpcompiler/source/HelpLinker.cxx +++ b/helpcompiler/source/HelpLinker.cxx @@ -400,7 +400,7 @@ void HelpLinker::link() throw(HelpProcessingException, BasicCodeTagger::TaggerEx continue; std::string documentPath = streamTable.document_path; - if (documentPath.find("/") == 0) + if (documentPath.compare("/") == 0) documentPath = documentPath.substr(1); std::string documentJarfile = streamTable.document_module + ".jar"; |