diff options
author | Herbert Dürr <hdu@apache.org> | 2014-02-10 09:36:08 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2014-02-10 11:57:56 +0000 |
commit | 87f52352614aed918501e8a7df8e8a61499efc5b (patch) | |
tree | 261c3890b0cdd8d1e3ec6c088de153cc7fb09243 | |
parent | c7e0bfd18eaba685d9f8ef8fdeb9fa45ae2e132d (diff) |
Resolves: #i124201# rename apple_remote's MainController...
to AppleRemoteController
having a MainController class in the global namespace of an application with
gazillions of MVC patterns is not a good idea. Renaming it to better match
its scope (i.e. the Apple Remote) cleans this up.
(cherry picked from commit 8ef3836059ca613d125f66e6bad21c83200dadad)
Conflicts:
apple_remote/source/RemoteMainController.m
include/apple_remote/RemoteMainController.h
vcl/inc/osx/saldata.hxx
vcl/osx/saldata.cxx
vcl/osx/salinst.cxx
vcl/osx/vclnsapp.mm
Change-Id: I1f252ac51ef65966a48ee03b2cd3519f98d57383
-rw-r--r-- | apple_remote/source/RemoteMainController.m | 6 | ||||
-rw-r--r-- | include/apple_remote/RemoteMainController.h | 2 | ||||
-rw-r--r-- | vcl/inc/osx/saldata.hxx | 2 | ||||
-rw-r--r-- | vcl/osx/saldata.cxx | 6 | ||||
-rw-r--r-- | vcl/osx/salinst.cxx | 2 | ||||
-rw-r--r-- | vcl/osx/vclnsapp.mm | 14 |
6 files changed, 17 insertions, 15 deletions
diff --git a/apple_remote/source/RemoteMainController.m b/apple_remote/source/RemoteMainController.m index 790c52052fda..caf145ec7252 100644 --- a/apple_remote/source/RemoteMainController.m +++ b/apple_remote/source/RemoteMainController.m @@ -39,7 +39,7 @@ // Sample Code 3: Multi Click Behavior and Hold Event Simulation // ------------------------------------------------------------------------------------------- -@implementation MainController +@implementation AppleRemoteMainController - (id) init { self = [super init]; // because we redefined our own init instead of use the fu..nny awakeFromNib @@ -75,11 +75,11 @@ // to give the binding mechanism a chance to see the change of the attribute [self setValue: container forKey: @"remoteControl"]; #ifdef DEBUG - NSLog(@"MainController init done"); + NSLog(@"AppleRemoteMainController init done"); #endif } else - NSLog(@"MainController init failed"); + NSLog(@"AppleRemoteMainController init failed"); return self; } diff --git a/include/apple_remote/RemoteMainController.h b/include/apple_remote/RemoteMainController.h index 60cd4fbcec8e..c4ee0ac6ed74 100644 --- a/include/apple_remote/RemoteMainController.h +++ b/include/apple_remote/RemoteMainController.h @@ -42,7 +42,7 @@ //static void sendTheEvent( unichar, int ); -SAL_DLLPUBLIC_EXPORT @interface MainController : NSObject { +SAL_DLLPUBLIC_EXPORT @interface AppleRemoteMainController : NSObject { @public // else remoteControl is not reachable from GetSalData()->mpMainController RemoteControl* remoteControl; @private diff --git a/vcl/inc/osx/saldata.hxx b/vcl/inc/osx/saldata.hxx index b125caad8156..8ee0b41799b8 100644 --- a/vcl/inc/osx/saldata.hxx +++ b/vcl/inc/osx/saldata.hxx @@ -89,7 +89,7 @@ public: bool mbIsScrollbarDoubleMax; // TODO: support DoubleMin and DoubleBoth too #if !HAVE_FEATURE_MACOSX_SANDBOX - MainController* mpMainController; // Apple Remote + AppleRemoteMainController* mpAppleRemoteMainController; #endif NSObject* mpDockIconClickHandler; long mnDPIX; // #i100617# read DPI only once per office life diff --git a/vcl/osx/saldata.cxx b/vcl/osx/saldata.cxx index 2bf2d8cf3581..f4dc179fe4f1 100644 --- a/vcl/osx/saldata.cxx +++ b/vcl/osx/saldata.cxx @@ -47,7 +47,7 @@ SalData::SalData() maCursors( POINTER_COUNT, INVALID_CURSOR_PTR ), mbIsScrollbarDoubleMax( false ), #if !HAVE_FEATURE_MACOSX_SANDBOX - mpMainController( NULL ), + mpAppleRemoteMainController( NULL ), #endif mpDockIconClickHandler( nil ), mnDPIX( 0 ), @@ -82,8 +82,8 @@ SalData::~SalData() s_aAutoReleaseKey = 0; } #if !HAVE_FEATURE_MACOSX_SANDBOX - if ( mpMainController ) - [mpMainController release]; + if ( mpAppleRemoteMainController ) + [mpAppleRemoteMainController release]; #endif } diff --git a/vcl/osx/salinst.cxx b/vcl/osx/salinst.cxx index 723ad00b4c20..3d169989d791 100644 --- a/vcl/osx/salinst.cxx +++ b/vcl/osx/salinst.cxx @@ -170,7 +170,7 @@ static void initNSApp() object: nil ]; #if !HAVE_FEATURE_MACOSX_SANDBOX // Initialize Apple Remote - GetSalData()->mpMainController = [[MainController alloc] init]; + GetSalData()->mpAppleRemoteMainController = [[AppleRemoteMainController alloc] init]; [[NSDistributedNotificationCenter defaultCenter] addObserver: NSApp selector: @selector(applicationWillBecomeActive:) diff --git a/vcl/osx/vclnsapp.mm b/vcl/osx/vclnsapp.mm index 0c0fe698a3cc..bd85aa760e00 100644 --- a/vcl/osx/vclnsapp.mm +++ b/vcl/osx/vclnsapp.mm @@ -434,15 +434,16 @@ { (void)pNotification; SalData* pSalData = GetSalData(); - if( pSalData->mpMainController && pSalData->mpMainController->remoteControl) + AppleRemoteMainController* pAppleRemoteCtrl = pSalData->mpAppleRemoteMainController; + if( pAppleRemoteCtrl && pAppleRemoteCtrl->remoteControl) { // [remoteControl startListening: self]; // does crash because the right thing to do is - // [GetSalData()->mpMainController->remoteControl startListening: self]; + // [pAppleRemoteCtrl->remoteControl startListening: self]; // but the instance variable 'remoteControl' is declared protected // workaround : declare remoteControl instance variable as public in RemoteMainController.m - [pSalData->mpMainController->remoteControl startListening: self]; + [pAppleRemoteCtrl->remoteControl startListening: self]; #ifdef DEBUG NSLog(@"Apple Remote will become active - Using remote controls"); #endif @@ -461,15 +462,16 @@ { (void)pNotification; SalData* pSalData = GetSalData(); - if( pSalData->mpMainController && pSalData->mpMainController->remoteControl) + AppleRemoteMainController* pAppleRemoteCtrl = pSalData->mpAppleRemoteMainController; + if( pAppleRemoteCtrl && pAppleRemoteCtrl->remoteControl) { // [remoteControl stopListening: self]; // does crash because the right thing to do is - // [GetSalData()->mpMainController->remoteControl stopListening: self]; + // [pAppleRemoteCtrl->remoteControl stopListening: self]; // but the instance variable 'remoteControl' is declared protected // workaround : declare remoteControl instance variable as public in RemoteMainController.m - [pSalData->mpMainController->remoteControl stopListening: self]; + [pAppleRemoteCtrl->remoteControl stopListening: self]; #ifdef DEBUG NSLog(@"Apple Remote will resign active - Releasing remote controls"); #endif |