summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2012-02-10fdo#36109 in INDIRECT() make a non-existing sheet produce an error againlibreoffice-3-4Eike Rathke2-2/+4
* In lcl_ScAddress_Parse_OOo() don't assume non-existing sheets would be external documents if there was no sheet separator. This lead to an external reference being created that is only an error if dereferenced, not if fed to ISERROR() and the like. * In ScInterpreter::ScIndirect() push errNoRef instead of errInvalidArgument to produce a #REF! error. Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2012-02-08fix fdo#40590 stop abusing regular string token for XML importEike Rathke4-13/+8
During XML import formulas of defined names and conditional formatting were remembered as regular svString tokens that then later were retrieved without quotes for compilation. This didn't go along with the new ScRangeData::CompileUnresolvedXML() that recreates the formula string from an already tokenized form of the formula. Introduced FormulaToken::AddStringXML() with ocStringXML to sort those out and removed the IsImportingXML() hack from FormulaCompiler::AppendString(), the ocStringXML case is handled in FormulaCompiler::CreateStringFromToken(). Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2012-02-08fdo#40378 compile defined names that had unresolveds during loadEike Rathke7-57/+129
Dependencies of defined names must not depend on the order in which they are inserted during file load. In a second step compile defined names that had unresolved names during load, and only those. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2012-02-08resolved fdo#38595 border width lost in ODF importEike Rathke1-2/+3
backported 34315e7ec4062f9521cd19951b5f7f6ad9ce0d2e Signed-off-by: Michael Stahl <mstahl@redhat.com>
2012-02-07fdo#45115: sc: fix setting bordersMichael Stahl1-2/+1
Same problem in ScHelperFunctions::GetBorderLine. Signed-off-by: Eike Rathke <erack@redhat.com>
2012-02-07fdo#45450: sc: ODF export: cell styles:Michael Stahl1-2/+2
Only write "style:vertical-justify" and "css3t:text-justify" in ODF extended mode. (regression from 7da57d17b6179e71c8b6d7549ad89eaf3a4a28c6) Signed-off-by: Noel Power <noel.power@novell.com>
2012-02-07fix getCellRangeByName failure for named rangeNoel Power21-53/+29
2012-02-03cast from BorderLine to BorderLine2 is not validEike Rathke1-2/+2
Don't access a css::table::BorderLine struct as if it was a css::table::BorderLine2 struct, which it isn't. A proper implementation would need to pass BorderLine2 structs around for which it would need a css::table::TableBorder2 struct that holds BorderLine2 instead of BorderLine, and adapt various places for API compatibility to support both. For now use the default table::BorderLineStyle::SOLID to set the line style at ::editeng::SvxBorderLine This also fixes fdo#39117. (cherry picked from commit 97c66b3b13528cc50f271217663718b3d6681bd9) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2012-01-31clone token in ScFormulaResult copy-ctor instead of referringEike Rathke1-3/+20
Replaces commit e2b11f4fd79dce4116badb0ecf6477546ca5d0d4 Prevent excessive references to single token instance during fill. Because if not, we may run out of the 16-bit integer space to store reference count. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2012-01-23resolved rhbz#783556 crash in ScMatrix::GetDimensons() from ScInterpreterEike Rathke1-1/+10
* Interpreter tried to access a nonexistent matrix for external reference. * In ScInterpreter::PopExternalDoubleRef(ScMatrixRef& rMat) set error for unexpected conditions. In caller or descendants check for error or presence of ScMatrix.
2012-01-23resolved fdo#45032 Calc export to HTML with graphics failedEike Rathke1-3/+6
Fixed a misconception in transition from List to to ptr_vector of commit db599f64e63a3141159b7f0e59783197c39b3e02, List::Next() returned NULL when at end of list, mimic that. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2012-01-20Resolves fdo#43725 crash on saving a fileEike Rathke1-13/+74
+ Checks out-of-bounds accesses in ScFormatRangeStyles::GetStyleNameIndex() and ScRowFormatRanges::AddRange() and prevents crashes. - The real cause seems to be some style row/repeat miscalculation elsewhere, further investigation would be necessary. Signed-off-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-01-16fdo#39118: Fixed chart listener registration during ODS import.Kohei Yoshida2-3/+3
The breakage was due to the drawing layer re-work. We do need to store charts (or all OLE shapes with associated listening ranges) for later registration regardless of anchor types. Signed-off-by: Eike Rathke <erack@redhat.com>
2012-01-08return early on error in ScInterpreter::GetDBParam, fdo#44442Markus Mohrhard1-0/+3
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-12-12fixed rhbz#754051 Libreoffice calc crashes when re-opening a xlxs fileEike Rathke1-0/+1
ScMatrixImpl lacked initialization of pErrorInterpreter=NULL. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-12-09fdo#43308: Set the logic straight for "center across selection" setting.Kohei Yoshida1-9/+3
Another unfortunate logic change introduced via DECLARE_LIST removal. Reverting the logic to the original one. Signed-off-by: Eike Rathke <erack@redhat.com>
2011-11-24fdo#39589: Avoid using ulimit_cast between signed and unsigned.Kohei Yoshida1-2/+2
If you do, things go very very wrong. These *limit_cast try to be clever and check ranges of various types before casting, but they fail to do the right thing when casting a signed integer into unsigned. Signed-off-by: Lionel Elie Mamane <lionel@mamane.lu>
2011-11-11Fixed the wrong keyboard selection behavior in reference mode.Kohei Yoshida1-0/+2
This one is pretty bad, especially for those who like to select ranges using keyboard. Signed-off-by: Eike Rathke <erack@redhat.com>
2011-11-07fdo#42169: Display caption strings without format detection.Kohei Yoshida1-2/+13
We don't need to auto-detect the formats of caption values; they are already formatted by the time they arrive in to ScDPOutput. Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2011-11-02we need to use ValidColRowOrRepeated, silly mistake by me.Markus Mohrhard1-1/+1
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-11-01prevent access to non existing mdds elements (fdo#41807)Markus Mohrhard1-2/+4
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-11-01boolean values are valid for matrix evaluation (fdo#49967)Markus Mohrhard1-1/+1
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-11-01fdo#40110: Correctly map external ranges into matrix instances.Kohei Yoshida1-40/+39
This is a simple silly mistake; the matrix representation of the external range should've preserved the original range; not the data range which can be smaller than the originally requested range. Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2011-10-25Version 3.4.4.1, tag libreoffice-3.4.4.1 (3.4.4-rc1)libreoffice-3.4.4.1Petr Mladek0-0/+0
2011-09-14fda#35965: Mark all formula cells dirty when appending a new sheetKohei Yoshida1-1/+4
Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2011-09-13fix fdo#39485 recalculate matrix formula dimension correctlyEike Rathke2-3/+11
ScFormulaCell::GetMatrixEdge() when recalculating its dimension obtained the matrix origin of itself instead of a neighboring matrix formula if encountered such, effectively adding that other matrix to its own cells occupying dimension. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-09-08Adjust the dialog size to make sure the bottom text is visible.Kohei Yoshida3-0/+69
This ensures that the bottom text "Drag the fields from ..." is visible on all platforms. Previously this text overlapped with the data and row field windows on Windows XP. Signed-off-by: Tor Lillqvist <tlillqvist@suse.com>
2011-09-07don't extend the merged area by one for shadowsMarkus Mohrhard14-40/+27
Signed-off-by: Eike Rathke <erack@erack.de>
2011-09-06crash when modifing a named rangeEike Rathke10-25/+28
Signed-off-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2011-09-06fixed various crashes due to newly introducedEike Rathke1-3/+20
ScRangeName::maIndexToData * The newly introduced ScRangeName::maIndexToData needs to take into account that boost::ptr_set clones and deletes elements, hence each collection needs its own maIndexToData setup in copy-ctor. * Also fixed ScRangeName::erase() where a wrong index element was set to NULL. Signed-off-by: Eike Rathke <erack@erack.de>
2011-09-06Speed up range name lookup by index.Kohei Yoshida2-13/+41
This should speed up formula calculations considerably during xls import since shared formulas are also stored in ScRangeName and they are looked up by index. (bnc#715104) Signed-off-by: Eike Rathke <erack@erack.de>
2011-09-05"thereof" should be translated to modern EnglishLior Kaplan1-1/+1
Signed-off-by: Caolán McNamara <caolanm@redhat.com>
2011-08-30use boost::intrusive_ptr::get() instead of operator->()Eike Rathke3-3/+3
Old intrusive pointer in operator->() simply returned a NULL pointer if so, boost::intrusive_ptr asserts on that. If explicitly used to obtain the pointer use get() instead. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-25avoid maTables.back() calls by store and reuse when neededLaurent Godard2-47/+55
better performance on loadin calc files (esp. big ones)
2011-08-16Version 3.4.3.1, tag libreoffice-3.4.3.1 (3.4.3-rc1)libreoffice-3.4.3.1Petr Mladek0-0/+0
2011-08-10Prevent crash at column row boundaries.Eike Rathke1-30/+16
Modified from the original patch submitted by Olivier Hallot. Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-10Correctly import from Excel charts with multiple ranges.Kohei Yoshida4-16/+33
This was "fixed" in i#107275, but the fix only worked in locales where the range/argument separator was ';' (e.g. German locale). This is the correct fix that works in all locales regardless of the separator. Signed-off-by: Noel Power <noel.power@novell.com>
2011-08-08use delete[] for arrays allocated with new[]Markus Mohrhard1-2/+2
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-08[PATCH] fix for fdo#39915: defining named ranges should be case insensitivMarkus Mohrhard1-1/+3
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-08fix for fdo#39678: don't write password algorithm in odf 1.0 and 1.1Markus Mohrhard1-16/+22
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-06fix for fdo#39792: changes to range names invalidate stream tooMarkus Mohrhard1-0/+4
If we don't invalidate the table stream when we change the local range name, the new range name will only be written if something else has been changed in the sheet Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com> Signed-off-by: Eike Rathke <ooo@erack.de>
2011-08-02fix for fdo#39773: crash with hidden column in Data->FormMarkus Mohrhard1-1/+2
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-02fix for fdo#39151: set correct table number in local db dataMarkus Mohrhard1-1/+9
Signed-off-by: Kohei Yoshida <kohei.yoshida@suse.com>
2011-08-02fix for fdo#39728: check for empty local range namesMarkus Mohrhard1-1/+3
Signed-off-by: Kohei Yoshida <kyoshida@novell.com>
2011-08-02bnc#707486: The previous commit is for bnc#707486, not for fdo#.Kohei Yoshida0-0/+0
2011-08-02fdo#707486: Use the correct clip doc instance to copy to.Noel Power1-1/+1
Signed-off-by: Kohei Yoshida <kyoshida@novell.com>
2011-07-29bnc#707486: Allow multi-range copy from VBA.Noel Power5-15/+158
Signed-off-by: Kohei Yoshida <kyoshida@novell.com>
2011-07-27Resolves: fdo#38955 set selection request as done for macro recorderCaolán McNamara1-0/+1
Signed-off-by: Kohei Yoshida <kyoshida@novell.com>
2011-07-27dr78: #i116250# set app flag in ScGlobal::SetSearchItem, fdo#33379, fdo#33593Niklas Nebel1-0/+1
And also fdo#37499. It seems that this commit somehow disappeared during merge. Signed-off-by: Noel Power <noel.power@novell.com>
2011-07-26make strings localizable - fdo#36706Andras Timar1-2/+2
Signed-off-by: Michael Meeks <michael.meeks@novell.com>
generated by cgit v1.2.3 (git 2.39.1) at 2024-10-16 11:26:28 +0000