diff options
| author | Behdad Esfahbod <behdad@behdad.org> | 2018-11-15 02:48:50 -0500 |
|---|---|---|
| committer | Behdad Esfahbod <behdad@behdad.org> | 2018-11-15 02:48:50 -0500 |
| commit | cabe433fbb81d314ad9e3cbed768dd13983a4477 (patch) | |
| tree | 3ab2704ba801b16efa79b8e306442e5539ff02a4 | |
| parent | 3bf1ce748fa89316dd32de28bfdc636495e657fb (diff) | |
[base] Add TODO items
| -rw-r--r-- | src/hb-ot-layout-base-table.hh | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/src/hb-ot-layout-base-table.hh b/src/hb-ot-layout-base-table.hh index 582e6015..fb57e762 100644 --- a/src/hb-ot-layout-base-table.hh +++ b/src/hb-ot-layout-base-table.hh @@ -198,6 +198,7 @@ struct MinMax const BaseCoord **min, const BaseCoord **max) const { + /* TODO Replace hb_bsearch() with .bsearch(). */ const FeatMinMaxRecord *minMaxCoord = (const FeatMinMaxRecord *) hb_bsearch (&feature_tag, featMinMaxRecords.arrayZ, featMinMaxRecords.len, @@ -230,7 +231,7 @@ struct MinMax maxCoord; /* Offset to BaseCoord table that defines * maximum extent value, from the beginning * of MinMax table (may be NULL) */ - ArrayOf<FeatMinMaxRecord> + SortedArrayOf<FeatMinMaxRecord> featMinMaxRecords; /* Array of FeatMinMaxRecords, in alphabetical * order by featureTableTag */ @@ -302,6 +303,7 @@ struct BaseScript { inline const MinMax &get_min_max (hb_tag_t language_tag) const { + /* TODO Replace hb_bsearch() with .bsearch(). */ const BaseLangSysRecord* record = (const BaseLangSysRecord *) hb_bsearch (&language_tag, baseLangSysRecords.arrayZ, baseLangSysRecords.len, @@ -332,7 +334,7 @@ struct BaseScript OffsetTo<MinMax> defaultMinMax; /* Offset to MinMax table, from beginning of * BaseScript table (may be NULL) */ - ArrayOf<BaseLangSysRecord> + SortedArrayOf<BaseLangSysRecord> baseLangSysRecords; /* Number of BaseLangSysRecords * defined — may be zero (0) */ @@ -377,6 +379,7 @@ struct BaseScriptList { inline const BaseScriptRecord *find_record (hb_tag_t script) const { + /* TODO Replace hb_bsearch() with .bsearch(). */ return (const BaseScriptRecord *) hb_bsearch (&script, baseScriptRecords.arrayZ, baseScriptRecords.len, BaseScriptRecord::static_size, @@ -400,7 +403,7 @@ struct BaseScriptList } protected: - ArrayOf<BaseScriptRecord> + SortedArrayOf<BaseScriptRecord> baseScriptRecords; public: |