diff options
| author | David Zeuthen <david@fubar.dk> | 2005-03-07 19:38:09 +0000 |
|---|---|---|
| committer | David Zeuthen <david@fubar.dk> | 2005-03-07 19:38:09 +0000 |
| commit | cad155514e53f1ea1b6f1f7a9d4171dee0acf979 (patch) | |
| tree | f6e677026ea910825dcb960e5fcba1aab54182d7 | |
| parent | 63e8b2e3a641e476a02bbf4ec16793a3a91e6bdd (diff) | |
Back out libhal testing code for now. (check_properties): We've changed the
semantics of hal_device_ property_strlist_add so change test suite
accordingly
Add note about extending test suite coverage
| -rw-r--r-- | ChangeLog | 8 | ||||
| -rw-r--r-- | doc/TODO | 6 | ||||
| -rw-r--r-- | hald/hald_test.c | 7 |
3 files changed, 16 insertions, 5 deletions
@@ -1,5 +1,13 @@ 2005-03-07 David Zeuthen <davidz@redhat.com> + * hald/hald_test.c (main): Back out libhal testing code for now. + (check_properties): We've changed the semantics of hal_device_ + property_strlist_add so change test suite accordingly + + * doc/TODO: Add note about extending test suite coverage + +2005-03-07 David Zeuthen <davidz@redhat.com> + * doc/TODO: Forgot one important TODO about finishing the volume_id library (pretty please Kay :-) @@ -6,12 +6,14 @@ add/remove entries if you get an idea or implement one of these. If you want to work on one of these you might want to send a patch that updates this file to reflect it. -Ongoing items -------------- +Ongoing items that always need work +----------------------------------- - valgrind once in a while to fix memory leaks / memory corruption - keeping the spec in sync with the code + - Extend test suite coverage + Small items ----------- diff --git a/hald/hald_test.c b/hald/hald_test.c index 4d85cd52..24b45f78 100644 --- a/hald/hald_test.c +++ b/hald/hald_test.c @@ -256,8 +256,8 @@ check_properties (void) goto out; } - /* this add will succeed but it shouldn't change the list */ - if (!hal_device_property_strlist_add (d, "test.strlist", "foostrlist2")) { + /* this add should fail because it shouldn't change the list */ + if (hal_device_property_strlist_add (d, "test.strlist", "foostrlist2")) { printf ("FAILED40\n"); goto out; } @@ -548,11 +548,12 @@ main (int argc, char *argv[]) num_tests_failed++; /* tests of libhal against /org/freedesktop/Hal/devices/testobj1 for getting */ +/* if (!check_libhal (dbus_server_get_address (server))) num_tests_failed++; if (!wait_for_external_test ()) num_tests_failed++; - +*/ printf ("=============================\n"); |