diff options
author | Seungha Yang <seungha@centricular.com> | 2022-07-06 02:14:55 +0900 |
---|---|---|
committer | GStreamer Marge Bot <gitlab-merge-bot@gstreamer-foundation.org> | 2022-07-07 19:59:34 +0000 |
commit | 718e3768c568ffa8c49475bde931478d65e61655 (patch) | |
tree | 927fd161a7d44077b59e8f286ffe9ec073841bb6 /data | |
parent | d6a55824c3d78e370a4dfa3fe5258a30d1cc90a3 (diff) |
msvc: Remove msvcrt.props
Almost everything in the Visual Studio property file is wrong
or unnecessary.
* WIN32_LEAN_AND_MEAN: Should not be defined globally, but per
source file defined when needed.
* Don't force ancient target
* Global CRT attributes set by us is not a desired configuration,
but application should consider it by itself
* DO NOT FORCE MSVCRT: We moved to UCRT a couple of years ago.
So it will cause linking problem when application calls CRT functions
Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/888>
Diffstat (limited to 'data')
-rw-r--r-- | data/vs-1.0/msvc/msvcrt.props | 35 | ||||
-rw-r--r-- | data/vs-1.0/msvc/x86.props | 1 | ||||
-rw-r--r-- | data/vs-1.0/msvc/x86_64.props | 1 |
3 files changed, 0 insertions, 37 deletions
diff --git a/data/vs-1.0/msvc/msvcrt.props b/data/vs-1.0/msvc/msvcrt.props deleted file mode 100644 index 984b32f9..00000000 --- a/data/vs-1.0/msvc/msvcrt.props +++ /dev/null @@ -1,35 +0,0 @@ -<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
- <ImportGroup Label="PropertySheets" />
- <PropertyGroup Label="UserMacros" />
- <PropertyGroup />
- <ItemDefinitionGroup>
- <ClCompile>
- <AdditionalIncludeDirectories>%(AdditionalIncludeDirectories);$(WINDOWS_DRIVER_KIT)\inc\crt\;$(WINDOWS_DRIVER_KIT)\inc\atl71\</AdditionalIncludeDirectories>
- <PreprocessorDefinitions>WIN32_LEAN_AND_MEAN=1;_MBCS=1;WHISTLER_DDK=1;_DLL=1;_MT=1;__NO_MINGW_LFS;__MSVCRT_VERSION__=0x0601;__MSVCRT__;_CRT_NONSTDC_FORCE_DEPRECATE;_CRT_SECURE_FORCE_DEPRECATE; _CRT_SECURE_NO_WARNINGS;_CRT_SECURE_NO_DEPRECATE;_CRT_NONSTDC_NO_DEPRECATE;%(PreprocessorDefinitions)</PreprocessorDefinitions>
- </ClCompile>
- <Link>
- <IgnoreAllDefaultLibraries>true</IgnoreAllDefaultLibraries>
- <OptimizeReferences>false</OptimizeReferences>
- </Link>
- </ItemDefinitionGroup>
- <ItemDefinitionGroup Condition=" '$(PlatformName)' == 'Win32' ">
- <Link>
- <AdditionalLibraryDirectories>$(WINDOWS_DRIVER_KIT)\lib\crt\i386;$(WINDOWS_DRIVER_KIT)\lib\win7\i386;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
- <AdditionalDependencies>libmoldname.a;msvcrt.lib;msvcrt_winxp.obj;%(AdditionalDependencies)</AdditionalDependencies>
- </Link>
- <ClCompile>
- <BasicRuntimeChecks>Default</BasicRuntimeChecks>
- </ClCompile>
- </ItemDefinitionGroup>
- <ItemDefinitionGroup Condition=" '$(PlatformName)' == 'x64' ">
- <Link>
- <AdditionalLibraryDirectories>$(WINDOWS_DRIVER_KIT)\lib\crt\amd64;$(WINDOWS_DRIVER_KIT)\lib\win7\amd64;%(AdditionalLibraryDirectories)</AdditionalLibraryDirectories>
- <AdditionalDependencies>oldnames.lib;msvcrt.lib;%(AdditionalDependencies)</AdditionalDependencies>
- </Link>
- <ClCompile>
- <BasicRuntimeChecks>Default</BasicRuntimeChecks>
- </ClCompile>
- </ItemDefinitionGroup>
- <ItemGroup />
-</Project>
diff --git a/data/vs-1.0/msvc/x86.props b/data/vs-1.0/msvc/x86.props index dd7361ad..46d9b2d9 100644 --- a/data/vs-1.0/msvc/x86.props +++ b/data/vs-1.0/msvc/x86.props @@ -2,7 +2,6 @@ <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <ImportGroup Label="PropertySheets"> <Import Project="common.props" /> - <Import Project="msvcrt.props" /> </ImportGroup> <PropertyGroup Label="UserMacros" /> <PropertyGroup /> diff --git a/data/vs-1.0/msvc/x86_64.props b/data/vs-1.0/msvc/x86_64.props index dd7361ad..46d9b2d9 100644 --- a/data/vs-1.0/msvc/x86_64.props +++ b/data/vs-1.0/msvc/x86_64.props @@ -2,7 +2,6 @@ <Project ToolsVersion="4.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> <ImportGroup Label="PropertySheets"> <Import Project="common.props" /> - <Import Project="msvcrt.props" /> </ImportGroup> <PropertyGroup Label="UserMacros" /> <PropertyGroup /> |