summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNirbheek Chauhan <nirbheek@centricular.com>2023-02-25 05:07:31 +0530
committerNirbheek Chauhan <nirbheek@centricular.com>2023-02-25 05:08:45 +0530
commit44cc3dac3a0ca185d17c65535e8ecba806e9cfd5 (patch)
treea8ae449e4352686f8c16d1c1126f8f501dced678
parent63ea9aa2a4b52284c6ebb682d6fdf1f07167528f (diff)
cerbero: Don't use VS 2022 when building UWP1.20.6
Fails with: ``` LINK : fatal error LNK1104: cannot open file 'MSVCRT.lib' ``` Part-of: <https://gitlab.freedesktop.org/gstreamer/cerbero/-/merge_requests/1119>
-rw-r--r--cerbero/ide/vs/env.py6
1 files changed, 4 insertions, 2 deletions
diff --git a/cerbero/ide/vs/env.py b/cerbero/ide/vs/env.py
index f22e99ca..9e7928bc 100644
--- a/cerbero/ide/vs/env.py
+++ b/cerbero/ide/vs/env.py
@@ -125,8 +125,10 @@ def _get_vswhere_vs_install(vswhere, vs_versions):
'back to manual searching...' .format(', '.join(vs_versions)))
return None
-def get_vcvarsall(vs_version, vs_install_path):
+def get_vcvarsall(vs_version, vs_install_path, uwp):
known_vs_versions = sorted(VCVARSALLS.keys(), reverse=True)
+ if uwp:
+ known_vs_versions.remove('vs17')
if vs_version:
if vs_version not in VCVARSALLS:
raise FatalError('Requested Visual Studio version {} is not one of: '
@@ -224,7 +226,7 @@ def get_envvar_msvc_values(msvc, nomsvc, sep=';'):
@lru_cache()
def get_msvc_env(arch, target_arch, uwp, version=None, vs_install_path=None):
ret_env = {}
- vcvarsall, vsver = get_vcvarsall(version, vs_install_path)
+ vcvarsall, vsver = get_vcvarsall(version, vs_install_path, uwp)
without_msvc = run_and_get_env('set')
arg = get_vcvarsall_arg(arch, target_arch)