summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNirbheek Chauhan <nirbheek@centricular.com>2020-01-12 20:06:25 +0530
committerNirbheek Chauhan <nirbheek.chauhan@gmail.com>2020-01-15 05:59:20 +0000
commit20ea134be4cfa84be825791c234135aebcc7afaa (patch)
treeba285a246dc0353272eeccea0d839d556db16736
parentf458fbe87b5ae363ec761475a8c5154c66ffc997 (diff)
meson.recipe: Write out DLL/EXE checksums with MSVC
Discovered in https://gitlab.freedesktop.org/gstreamer/cerbero/issues/221 Not essential, but it's good hygiene, helps detect data corruption, and also reduces the chances that our binaries will be detected as malware.
-rw-r--r--recipes/build-tools/meson.recipe2
-rw-r--r--recipes/build-tools/meson/0001-vs-Write-out-checksums-but-not-timestamps.patch30
2 files changed, 32 insertions, 0 deletions
diff --git a/recipes/build-tools/meson.recipe b/recipes/build-tools/meson.recipe
index 7fb4da69..10488716 100644
--- a/recipes/build-tools/meson.recipe
+++ b/recipes/build-tools/meson.recipe
@@ -27,6 +27,8 @@ class Recipe(recipe.Recipe):
'meson/0001-environment-better-xcode-11-clang-detection.patch',
# https://github.com/mesonbuild/meson/pull/5872
'meson/0001-flatten-list-to-subprocess.Popen-necessary-for-Pytho.patch',
+ # https://github.com/mesonbuild/meson/pull/6451, in 0.54.*
+ 'meson/0001-vs-Write-out-checksums-but-not-timestamps.patch',
]
deps = ['ninja']
diff --git a/recipes/build-tools/meson/0001-vs-Write-out-checksums-but-not-timestamps.patch b/recipes/build-tools/meson/0001-vs-Write-out-checksums-but-not-timestamps.patch
new file mode 100644
index 00000000..9d454580
--- /dev/null
+++ b/recipes/build-tools/meson/0001-vs-Write-out-checksums-but-not-timestamps.patch
@@ -0,0 +1,30 @@
+From cba72ac0d542ec5ece716d945b9072dc0a80a9ca Mon Sep 17 00:00:00 2001
+From: Nirbheek Chauhan <nirbheek@centricular.com>
+Date: Sun, 12 Jan 2020 19:45:16 +0530
+Subject: [PATCH] vs: Write out checksums but not timestamps
+
+This is upstream in 0.54.x:
+https://github.com/mesonbuild/meson/pull/6451
+
+Checksums issue was discovered in:
+https://gitlab.freedesktop.org/gstreamer/cerbero/issues/221
+---
+ mesonbuild/compilers/c.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/mesonbuild/compilers/c.py b/mesonbuild/compilers/c.py
+index d47694e..ea9b728 100644
+--- a/mesonbuild/compilers/c.py
++++ b/mesonbuild/compilers/c.py
+@@ -1389,7 +1389,7 @@ class VisualStudioCCompiler(CCompiler):
+ return ['link']
+
+ def get_linker_always_args(self):
+- return ['/nologo']
++ return ['/nologo', '/release', '/Brepro']
+
+ def get_linker_output_args(self, outputname):
+ return ['/OUT:' + outputname]
+--
+2.24.1.windows.2
+