Age | Commit message (Collapse) | Author | Files | Lines |
|
https://bugzilla.gnome.org/show_bug.cgi?id=690364
|
|
Signed-off-by: Ross Burton <ross.burton@intel.com>
https://bugzilla.gnome.org/show_bug.cgi?id=690364
|
|
Signed-off-by: Ross Burton <ross.burton@intel.com>
https://bugzilla.gnome.org/show_bug.cgi?id=690364
|
|
https://bugzilla.gnome.org/show_bug.cgi?id=677764
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Including config.h does not work as expected and the EXPERIMENTAL define
is not taken into account when generating gstomx.conf otherwise.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Defining it to nothing gives problems in some scenarios if only #if is
used instead of #ifdef.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
The bellagio volume component only supports 44.1kHz and 2 channels.
It doesn't even handle setting of the OMX_IndexParamAudioPcm parameter
correctly.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Otherwise -DHAVE_CONFIG_H is not passed.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
On some systems the defines from config.h are passed via CFLAGS instead
of a config.h file.
This also makes the generated gstomx.conf file easier to read because
the indention is not destroyed anymore and no additional newlines are
inserted.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
These files are automatically generated and should be regenerated
after "make clean".
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Let's make sure gstomx.conf is cleanly regenerated.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Apparently gst_structure_from_string() doesn't like the multiple lines
in omx_mpeg4dec caps.
It's easily fixable by passing the -P option to the preprocessor, which
also gets rid of the comments.
If this breaks with somebody's pre-processor, speak now :)
Reported-by: Sebastian Dröge <slomo@circular-chaos.org>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
Fixes compilation with gcc 4.6.
gstomx.c:241:35: error: variable 'component_role' set but not used [-Werror=unused-but-set-variable]
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
To properly negotiate with other GStreamer elements which are now using
these.
Hopefully at some point OpenMAX IL would have appropriate fields to set
this information.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Some people use OMX_COLOR_FormatYUV420Planar, some
OMX_COLOR_FormatYUV420PackedPlanar. Strictly speaking the format needed
in GStreamer is the packed one, but since there's no notion of planes in
GStreamer, considering them the same cannot hurt.
Would be better if the implementations are fixed, specially if we
implement stride/plane support in GStreamer/gst-openmax.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
aacparse or qtdemux will parse out aac channels and sample rate and
stream type, but gstomx_aacdec don't set them to omx aacdec commponent,
which will cause some implementation(like bellagio) fault.
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
|
|
|
|
Signed-off-by: Rob Clark <rob@ti.com>
|
|
A few tweaks to the sed rules to make more friendly for using macros (for
example, "foo" "bar" becomes "foobar", which is normally done by the C
compiler and not the pre-processor). Also, the result of the preprocessor,
before generating gstomx_conf.c, is now also a generated file, to ease
debugging and to use as a starting point for a customized config file.
Signed-off-by: Rob Clark <rob@ti.com>
|
|
Signed-off-by: Rob Clark <rob@ti.com>
|
|
Align autogen.sh with other gst trees, including use of the commit-hook.
Also, shave no longer seemed to be working AM_SILENT_RULES (as used by
other gst trees) does.
Signed-off-by: Rob Clark <rob@ti.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Patches are welcome, but I'm not going to fix anyone's buggy omx
implementation.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Ew.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Awful c89.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Tested-by: Mickey Kim <jihun.kim@samsung.com>
Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
|
|
gst_element_class_set_details() is now deprecated. Replace with gst_element_class_set_details_simple() instead.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Refactor some common functionality, in particular the settings_changed_cb,
into an abstract base class.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
This removes some common code from all base classes, and makes it easier
to add new common properties.
For now (and the foreseeable future) all common properties are
read-only, but a gstomx_set_property_helper() could be added later if
needed.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
This way omx_handle is always valid, and can be used in get/set_property
methods.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
This improves readability by keeping knowledge of numeric port-index
value in only one place (in the element constructor), and makes it
easier to later add derived classes with different port indexes (for
example GstOmxCamera subclassing GstOmxBaseSrc, but having GstOmxBaseSrc
handling a port whose index != 0 while derived class handles port index
0 and others).
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Do OMX_GetParameter(PortDefinition) inside g_omx_port_setup(), rather
than duplicating same code in each caller.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
The port objects are constructed up in element constructor (so they are
valid at any point in the element's lifecycle), and bound to a
port_index at construction time, rather than getting constructed in
setup_ports.
This will be useful later to enable properties that directly set port
params.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Reading and writing an int is not sufficient synchronization without
barrier instructions. Using g_once_init_enter() (which uses
g_atomic_pointer_get()) provides SMP safety.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
These work like the GST_BOILERPLATE macros, but following the naming
conventions for init functions used in the gst-openmax code, to remove a
lot of gobject related boilerplate code.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
omx/gstomx_base_filter.c:763: warning: format not a string literal and no format arguments
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Probably more efficient.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
So that the cache is reloaded when needed.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
Will be useful in next patches, but it's good in itself. Also, no need
to inialize to zero global variables.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|
|
plugin_init() is *always* called, so we can assume element_table will
always be initialize once.
Signed-off-by: Felipe Contreras <felipe.contreras@nokia.com>
|