diff options
| author | Daniel Vetter <daniel.vetter@ffwll.ch> | 2018-04-26 17:43:33 +0200 |
|---|---|---|
| committer | Daniel Vetter <daniel.vetter@ffwll.ch> | 2018-04-30 08:32:33 +0200 |
| commit | bf64169637ee9a0086ace5de562412ac8b83bd67 (patch) | |
| tree | 9d26383897e90a4b531449e8ee2577f67d1c2ff8 | |
| parent | 540371e7dec9836b7443444c81992fb7d9a1e9d7 (diff) | |
Makefile: shut up about SC1117 and SC2207 in shellcheck
Not sure how this happened, but we gained a lot of errors. I think we should
exclude these two since we have lots of them:
SC1117: Backslash is literal in "\n". Prefer explicit escaping: "\\n".
These happen in lots of our strings (especially anything we feed to grep).
SC2207: Prefer mapfile or read -a to split command output (or quote to avoid splitting).
Our bash_completion scripts are full of these - everywhere we call compgen.
Acked-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
| -rw-r--r-- | Makefile | 4 |
1 files changed, 3 insertions, 1 deletions
@@ -37,8 +37,10 @@ SC_EXCLUDE := \ -e SC2046 \ -e SC2086 \ -e SC2115 \ + -e SC1117 \ -e SC2119 \ - -e SC2120 + -e SC2120 \ + -e SC2207 shellcheck: shellcheck $(SC_EXCLUDE) dim bash_completion qf |