From 82096ecf589d8224447213c4592e54598fea0b9d Mon Sep 17 00:00:00 2001 From: Tian Tao Date: Wed, 23 Dec 2020 09:26:33 +0800 Subject: thunderbolt: Use kmemdup instead of kzalloc and memcpy Fixes coccicheck warning: drivers/thunderbolt/dma_test.c:302:13-20: WARNING opportunity for kmemdup. Signed-off-by: Tian Tao Signed-off-by: Mika Westerberg --- drivers/thunderbolt/dma_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'drivers/thunderbolt') diff --git a/drivers/thunderbolt/dma_test.c b/drivers/thunderbolt/dma_test.c index f924423fa180..955f980986ca 100644 --- a/drivers/thunderbolt/dma_test.c +++ b/drivers/thunderbolt/dma_test.c @@ -299,14 +299,12 @@ static int dma_test_submit_tx(struct dma_test *dt, size_t npackets) tf->frame.size = 0; /* means 4096 */ tf->dma_test = dt; - tf->data = kzalloc(DMA_TEST_FRAME_SIZE, GFP_KERNEL); + tf->data = kmemdup(dma_test_pattern, DMA_TEST_FRAME_SIZE, GFP_KERNEL); if (!tf->data) { kfree(tf); return -ENOMEM; } - memcpy(tf->data, dma_test_pattern, DMA_TEST_FRAME_SIZE); - dma_addr = dma_map_single(dma_dev, tf->data, DMA_TEST_FRAME_SIZE, DMA_TO_DEVICE); if (dma_mapping_error(dma_dev, dma_addr)) { -- cgit v1.2.3