diff options
author | Jiri Bohac <jbohac@suse.cz> | 2016-10-20 12:29:26 +0200 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2016-10-20 14:29:11 -0400 |
commit | 7aa8e63f0d0f2e0ae353632bca1ce75a258696c6 (patch) | |
tree | 296d579460ec8de98617fd4c63945f4cf4db2aae /net/ipv6/ip6_offload.c | |
parent | 8be0328e52dc2c8c6f61563c9ccc95ae4d63e9ce (diff) |
ipv6: properly prevent temp_prefered_lft sysctl race
The check for an underflow of tmp_prefered_lft is always false
because tmp_prefered_lft is unsigned. The intention of the check
was to guard against racing with an update of the
temp_prefered_lft sysctl, potentially resulting in an underflow.
As suggested by David Miller, the best way to prevent the race is
by reading the sysctl variable using READ_ONCE.
Signed-off-by: Jiri Bohac <jbohac@suse.cz>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Fixes: 76506a986dc3 ("IPv6: fix DESYNC_FACTOR")
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ipv6/ip6_offload.c')
0 files changed, 0 insertions, 0 deletions